From: Paolo Bonzini <pbonzini@redhat.com> To: Emil Condrea <emilcondrea@gmail.com>, qemu-devel@nongnu.org Cc: xuquan8@huawei.com, sstabellini@kernel.org, wei.liu2@citrix.com, stefanb@linux.vnet.ibm.com, xen-devel@lists.xen.org, anthony.perard@citrix.com, dgdegra@tycho.nsa.gov Subject: Re: [Qemu-devel] [PATCH 15/15] xen: Rename xen_be_frontend_changed Date: Tue, 4 Oct 2016 10:06:45 +0200 [thread overview] Message-ID: <0145ab9f-f2f5-8550-d593-b0f3b269cfe9@redhat.com> (raw) In-Reply-To: <1475563424-6604-16-git-send-email-emilcondrea@gmail.com> On 04/10/2016 08:43, Emil Condrea wrote: > xen_be_frontend_changed -> xen_fe_frontend_changed This is not correct. The front-end is implemented in the guest domain, while the back-end is implemented in the dom0 or stubdom. This function processes *in the backed* a notification that the frontend state changed, hence the name should be xen_be_frontend_changed. Paolo > Signed-off-by: Emil Condrea <emilcondrea@gmail.com> > --- > hw/xen/xen_backend.c | 2 +- > hw/xen/xen_frontend.c | 4 ++-- > include/hw/xen/xen_frontend.h | 2 +- > 3 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/hw/xen/xen_backend.c b/hw/xen/xen_backend.c > index 30d3aaa..b79e83e 100644 > --- a/hw/xen/xen_backend.c > +++ b/hw/xen/xen_backend.c > @@ -213,7 +213,7 @@ static int xen_be_try_setup(struct XenDevice *xendev) > xen_be_set_state(xendev, XenbusStateInitialising); > > xen_be_backend_changed(xendev, NULL); > - xen_be_frontend_changed(xendev, NULL); > + xen_fe_frontend_changed(xendev, NULL); > return 0; > } > > diff --git a/hw/xen/xen_frontend.c b/hw/xen/xen_frontend.c > index 1407f5f..761688b 100644 > --- a/hw/xen/xen_frontend.c > +++ b/hw/xen/xen_frontend.c > @@ -39,7 +39,7 @@ int xenstore_read_fe_uint64(struct XenDevice *xendev, const char *node, > return xenstore_read_uint64(xendev->fe, node, uval); > } > > -void xen_be_frontend_changed(struct XenDevice *xendev, const char *node) > +void xen_fe_frontend_changed(struct XenDevice *xendev, const char *node) > { > int fe_state; > > @@ -85,6 +85,6 @@ void xenstore_update_fe(char *watch, struct XenDevice *xendev) > } > node = watch + len + 1; > > - xen_be_frontend_changed(xendev, node); > + xen_fe_frontend_changed(xendev, node); > xen_be_check_state(xendev); > } > diff --git a/include/hw/xen/xen_frontend.h b/include/hw/xen/xen_frontend.h > index bb0bc23..2a5f03f 100644 > --- a/include/hw/xen/xen_frontend.h > +++ b/include/hw/xen/xen_frontend.h > @@ -9,6 +9,6 @@ int xenstore_read_fe_uint64(struct XenDevice *xendev, const char *node, > uint64_t *uval); > void xenstore_update_fe(char *watch, struct XenDevice *xendev); > > -void xen_be_frontend_changed(struct XenDevice *xendev, const char *node); > +void xen_fe_frontend_changed(struct XenDevice *xendev, const char *node); > > #endif /* QEMU_HW_XEN_FRONTEND_H */ >
WARNING: multiple messages have this Message-ID (diff)
From: Paolo Bonzini <pbonzini@redhat.com> To: Emil Condrea <emilcondrea@gmail.com>, qemu-devel@nongnu.org Cc: xuquan8@huawei.com, sstabellini@kernel.org, wei.liu2@citrix.com, stefanb@linux.vnet.ibm.com, xen-devel@lists.xen.org, anthony.perard@citrix.com, dgdegra@tycho.nsa.gov Subject: Re: [PATCH 15/15] xen: Rename xen_be_frontend_changed Date: Tue, 4 Oct 2016 10:06:45 +0200 [thread overview] Message-ID: <0145ab9f-f2f5-8550-d593-b0f3b269cfe9@redhat.com> (raw) In-Reply-To: <1475563424-6604-16-git-send-email-emilcondrea@gmail.com> On 04/10/2016 08:43, Emil Condrea wrote: > xen_be_frontend_changed -> xen_fe_frontend_changed This is not correct. The front-end is implemented in the guest domain, while the back-end is implemented in the dom0 or stubdom. This function processes *in the backed* a notification that the frontend state changed, hence the name should be xen_be_frontend_changed. Paolo > Signed-off-by: Emil Condrea <emilcondrea@gmail.com> > --- > hw/xen/xen_backend.c | 2 +- > hw/xen/xen_frontend.c | 4 ++-- > include/hw/xen/xen_frontend.h | 2 +- > 3 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/hw/xen/xen_backend.c b/hw/xen/xen_backend.c > index 30d3aaa..b79e83e 100644 > --- a/hw/xen/xen_backend.c > +++ b/hw/xen/xen_backend.c > @@ -213,7 +213,7 @@ static int xen_be_try_setup(struct XenDevice *xendev) > xen_be_set_state(xendev, XenbusStateInitialising); > > xen_be_backend_changed(xendev, NULL); > - xen_be_frontend_changed(xendev, NULL); > + xen_fe_frontend_changed(xendev, NULL); > return 0; > } > > diff --git a/hw/xen/xen_frontend.c b/hw/xen/xen_frontend.c > index 1407f5f..761688b 100644 > --- a/hw/xen/xen_frontend.c > +++ b/hw/xen/xen_frontend.c > @@ -39,7 +39,7 @@ int xenstore_read_fe_uint64(struct XenDevice *xendev, const char *node, > return xenstore_read_uint64(xendev->fe, node, uval); > } > > -void xen_be_frontend_changed(struct XenDevice *xendev, const char *node) > +void xen_fe_frontend_changed(struct XenDevice *xendev, const char *node) > { > int fe_state; > > @@ -85,6 +85,6 @@ void xenstore_update_fe(char *watch, struct XenDevice *xendev) > } > node = watch + len + 1; > > - xen_be_frontend_changed(xendev, node); > + xen_fe_frontend_changed(xendev, node); > xen_be_check_state(xendev); > } > diff --git a/include/hw/xen/xen_frontend.h b/include/hw/xen/xen_frontend.h > index bb0bc23..2a5f03f 100644 > --- a/include/hw/xen/xen_frontend.h > +++ b/include/hw/xen/xen_frontend.h > @@ -9,6 +9,6 @@ int xenstore_read_fe_uint64(struct XenDevice *xendev, const char *node, > uint64_t *uval); > void xenstore_update_fe(char *watch, struct XenDevice *xendev); > > -void xen_be_frontend_changed(struct XenDevice *xendev, const char *node); > +void xen_fe_frontend_changed(struct XenDevice *xendev, const char *node); > > #endif /* QEMU_HW_XEN_FRONTEND_H */ > _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-10-04 8:06 UTC|newest] Thread overview: 85+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-10-04 6:43 [Qemu-devel] [PATCH 00/15] Refactor common part of xen backend and frontend Emil Condrea 2016-10-04 6:43 ` [Qemu-devel] [PATCH 01/15] xen: Fix coding style errors Emil Condrea 2016-10-04 6:43 ` Emil Condrea 2016-10-11 13:56 ` [Qemu-devel] " Anthony PERARD 2016-10-13 3:48 ` Emil Condrea 2016-10-13 3:48 ` Emil Condrea 2016-10-11 13:56 ` Anthony PERARD 2016-10-04 6:43 ` [Qemu-devel] [PATCH 02/15] xen: Fix coding style warnings Emil Condrea 2016-10-11 14:20 ` Anthony PERARD 2016-10-11 14:20 ` Anthony PERARD 2016-10-13 4:04 ` Emil Condrea 2016-10-13 4:04 ` [Qemu-devel] " Emil Condrea 2016-10-13 11:35 ` Anthony PERARD 2016-10-13 11:35 ` Anthony PERARD 2016-10-13 15:59 ` [Qemu-devel] " Emil Condrea 2016-10-13 15:59 ` Emil Condrea 2016-10-04 6:43 ` Emil Condrea 2016-10-04 6:43 ` [Qemu-devel] [PATCH 03/15] xen: Create a new file xen_pvdev.c Emil Condrea 2016-10-04 6:43 ` Emil Condrea 2016-10-11 14:38 ` [Qemu-devel] " Anthony PERARD 2016-10-11 14:38 ` Anthony PERARD 2016-10-04 6:43 ` [Qemu-devel] [PATCH 04/15] xen: Create a new file xen_frontend.c Emil Condrea 2016-10-04 6:43 ` Emil Condrea 2016-10-12 13:30 ` Anthony PERARD 2016-10-12 13:30 ` [Qemu-devel] " Anthony PERARD 2016-10-04 6:43 ` [Qemu-devel] [PATCH 05/15] xen: Move xenstore_update to xen_pvdev.c Emil Condrea 2016-10-04 6:43 ` Emil Condrea 2016-10-04 6:43 ` [Qemu-devel] [PATCH 06/15] xen: Move evtchn functions " Emil Condrea 2016-10-04 6:43 ` Emil Condrea 2016-10-04 6:43 ` [Qemu-devel] [PATCH 07/15] xen: Prepare xendev qtail to be shared with frontends Emil Condrea 2016-10-04 6:43 ` Emil Condrea 2016-10-04 6:43 ` [Qemu-devel] [PATCH 08/15] xen: Move xenstore cleanup and mkdir functions Emil Condrea 2016-10-04 6:43 ` Emil Condrea 2016-10-12 13:30 ` [Qemu-devel] " Anthony PERARD 2016-10-12 13:30 ` Anthony PERARD 2016-10-04 6:43 ` [Qemu-devel] [PATCH 09/15] xen: Rename xen_be_printf to xen_pv_printf Emil Condrea 2016-10-04 6:43 ` Emil Condrea 2016-10-12 13:31 ` [Qemu-devel] " Anthony PERARD 2016-10-12 13:31 ` Anthony PERARD 2016-10-04 6:43 ` [Qemu-devel] [PATCH 10/15] xen: Rename xen_be_unbind_evtchn Emil Condrea 2016-10-04 6:43 ` Emil Condrea 2016-10-12 13:37 ` Anthony PERARD 2016-10-12 13:37 ` [Qemu-devel] " Anthony PERARD 2016-10-13 1:44 ` Xuquan (Quan Xu) 2016-10-13 1:44 ` Xuquan (Quan Xu) 2016-10-04 6:43 ` [Qemu-devel] [PATCH 11/15] xen: Rename xen_be_send_notify Emil Condrea 2016-10-04 6:43 ` Emil Condrea 2016-10-12 13:40 ` Anthony PERARD 2016-10-12 13:40 ` [Qemu-devel] " Anthony PERARD 2016-10-13 1:45 ` Xuquan (Quan Xu) 2016-10-13 1:45 ` Xuquan (Quan Xu) 2016-10-04 6:43 ` [Qemu-devel] [PATCH 12/15] xen: Rename xen_be_evtchn_event Emil Condrea 2016-10-04 6:43 ` Emil Condrea 2016-10-12 13:41 ` [Qemu-devel] " Anthony PERARD 2016-10-12 13:41 ` Anthony PERARD 2016-10-13 1:46 ` [Qemu-devel] " Xuquan (Quan Xu) 2016-10-13 1:46 ` Xuquan (Quan Xu) 2016-10-04 6:43 ` [Qemu-devel] [PATCH 13/15] xen: Rename xen_be_find_xendev Emil Condrea 2016-10-04 6:43 ` Emil Condrea 2016-10-12 13:42 ` [Qemu-devel] " Anthony PERARD 2016-10-12 13:42 ` Anthony PERARD 2016-10-13 1:46 ` [Qemu-devel] " Xuquan (Quan Xu) 2016-10-13 1:46 ` Xuquan (Quan Xu) 2016-10-04 6:43 ` [Qemu-devel] [PATCH 14/15] xen: Rename xen_be_del_xendev Emil Condrea 2016-10-04 6:43 ` Emil Condrea 2016-10-12 13:46 ` [Qemu-devel] " Anthony PERARD 2016-10-12 13:46 ` Anthony PERARD 2016-10-13 1:47 ` [Qemu-devel] " Xuquan (Quan Xu) 2016-10-13 1:47 ` Xuquan (Quan Xu) 2016-10-04 6:43 ` [Qemu-devel] [PATCH 15/15] xen: Rename xen_be_frontend_changed Emil Condrea 2016-10-04 8:06 ` Paolo Bonzini [this message] 2016-10-04 8:06 ` Paolo Bonzini 2016-10-04 8:08 ` [Qemu-devel] " Paolo Bonzini 2016-10-04 8:08 ` Paolo Bonzini 2016-10-09 19:50 ` Emil Condrea 2016-10-09 19:50 ` [Qemu-devel] " Emil Condrea 2016-10-12 11:00 ` Paolo Bonzini 2016-10-12 11:00 ` [Qemu-devel] " Paolo Bonzini 2016-10-13 6:08 ` Emil Condrea 2016-10-13 6:08 ` Emil Condrea 2016-10-13 6:32 ` [Qemu-devel] " Xuquan (Quan Xu) 2016-10-13 6:32 ` Xuquan (Quan Xu) 2016-10-13 8:27 ` [Qemu-devel] " Paolo Bonzini 2016-10-13 8:27 ` Paolo Bonzini 2016-10-04 6:43 ` Emil Condrea
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=0145ab9f-f2f5-8550-d593-b0f3b269cfe9@redhat.com \ --to=pbonzini@redhat.com \ --cc=anthony.perard@citrix.com \ --cc=dgdegra@tycho.nsa.gov \ --cc=emilcondrea@gmail.com \ --cc=qemu-devel@nongnu.org \ --cc=sstabellini@kernel.org \ --cc=stefanb@linux.vnet.ibm.com \ --cc=wei.liu2@citrix.com \ --cc=xen-devel@lists.xen.org \ --cc=xuquan8@huawei.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.