* [PATCH] [SCSI] pm80xx : no need for tag allocation when issuing the command of unregistering device
@ 2014-02-13 3:59 XinHong Zhu
2014-02-13 4:41 ` lindar_liu
0 siblings, 1 reply; 2+ messages in thread
From: XinHong Zhu @ 2014-02-13 3:59 UTC (permalink / raw)
To: linux-scsi; +Cc: lindar_liu, XinHong Zhu
In function pm8001_dev_gone_notify require a tag from bitmap resource and later don't free tag resource .So tag resource will be consume fully and following request can not be execed because of lack of tags . But in the function don't need use any tag to issue command of unregistering device .
Signed-off-by: XinHong Zhu <zxh3737@163.com>
---
drivers/scsi/pm8001/pm8001_sas.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/pm8001/pm8001_sas.c b/drivers/scsi/pm8001/pm8001_sas.c
index f50ac44..ba3088c 100644
--- a/drivers/scsi/pm8001/pm8001_sas.c
+++ b/drivers/scsi/pm8001/pm8001_sas.c
@@ -865,13 +865,11 @@ ex_err:
static void pm8001_dev_gone_notify(struct domain_device *dev)
{
unsigned long flags = 0;
- u32 tag;
struct pm8001_hba_info *pm8001_ha;
struct pm8001_device *pm8001_dev = dev->lldd_dev;
pm8001_ha = pm8001_find_ha_by_dev(dev);
spin_lock_irqsave(&pm8001_ha->lock, flags);
- pm8001_tag_alloc(pm8001_ha, &tag);
if (pm8001_dev) {
u32 device_id = pm8001_dev->device_id;
--
1.7.9
^ permalink raw reply related [flat|nested] 2+ messages in thread
* RE: [PATCH] [SCSI] pm80xx : no need for tag allocation when issuing the command of unregistering device
2014-02-13 3:59 [PATCH] [SCSI] pm80xx : no need for tag allocation when issuing the command of unregistering device XinHong Zhu
@ 2014-02-13 4:41 ` lindar_liu
0 siblings, 0 replies; 2+ messages in thread
From: lindar_liu @ 2014-02-13 4:41 UTC (permalink / raw)
To: 'XinHong Zhu', linux-scsi
On Thu, 2014-02-13 at 12:00 PM, XinHong Zhu wrote:
> In function pm8001_dev_gone_notify require a tag from bitmap resource and
> later don't free tag resource .So tag resource will be consume fully and
> following request can not be execed because of lack of tags . But in the
> function don't need use any tag to issue command of unregistering device .
>
> Signed-off-by: XinHong Zhu <zxh3737@163.com>
> ---
> drivers/scsi/pm8001/pm8001_sas.c | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/pm8001/pm8001_sas.c
> b/drivers/scsi/pm8001/pm8001_sas.c
> index f50ac44..ba3088c 100644
> --- a/drivers/scsi/pm8001/pm8001_sas.c
> +++ b/drivers/scsi/pm8001/pm8001_sas.c
> @@ -865,13 +865,11 @@ ex_err:
> static void pm8001_dev_gone_notify(struct domain_device *dev) {
> unsigned long flags = 0;
> - u32 tag;
> struct pm8001_hba_info *pm8001_ha;
> struct pm8001_device *pm8001_dev = dev->lldd_dev;
>
> pm8001_ha = pm8001_find_ha_by_dev(dev);
> spin_lock_irqsave(&pm8001_ha->lock, flags);
> - pm8001_tag_alloc(pm8001_ha, &tag);
> if (pm8001_dev) {
> u32 device_id = pm8001_dev->device_id;
>
Thanks for fix.
Acked-by: Lindar Liu <lindar_liu@usish.com>
> --
> 1.7.9
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-02-13 4:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-02-13 3:59 [PATCH] [SCSI] pm80xx : no need for tag allocation when issuing the command of unregistering device XinHong Zhu
2014-02-13 4:41 ` lindar_liu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.