* [PATCH] net: stmmac: fixed enh_desc set always zero
@ 2013-06-28 7:35 Byungho An
2013-06-28 12:57 ` Giuseppe CAVALLARO
0 siblings, 1 reply; 3+ messages in thread
From: Byungho An @ 2013-06-28 7:35 UTC (permalink / raw)
To: netdev
Cc: 'Giuseppe CAVALLARO', '김국진',
davem, cpgs
This patch fixed that enh_desc value is always zero.
Due to calling order of stmmac_selec_desc_mode(), enh_desc value is always zero.
Even though mac is set to use enhanced dma descriptor, if enh_desc is zero,
functions related dma descriptor are not working correctly.
Signed-off-by: Byungho An <bh74.an@samsung.com>
---
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
index e5e221e..40efd55 100644
--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
@@ -2567,9 +2567,6 @@ static int stmmac_hw_init(struct stmmac_priv *priv)
/* Get and dump the chip ID */
priv->synopsys_id = stmmac_get_synopsys_id(priv);
- /* To use alternate (extended) or normal descriptor structures */
- stmmac_selec_desc_mode(priv);
-
/* To use the chained or ring mode */
if (chain_mode) {
priv->hw->chain = &chain_mode_ops;
@@ -2604,6 +2601,9 @@ static int stmmac_hw_init(struct stmmac_priv *priv)
} else
pr_info(" No HW DMA feature register supported");
+ /* To use alternate (extended) or normal descriptor structures */
+ stmmac_selec_desc_mode(priv);
+
ret = priv->hw->mac->rx_ipc(priv->ioaddr);
if (!ret) {
pr_warn(" RX IPC Checksum Offload not configured.\n");
--
1.7.10.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] net: stmmac: fixed enh_desc set always zero
2013-06-28 7:35 [PATCH] net: stmmac: fixed enh_desc set always zero Byungho An
@ 2013-06-28 12:57 ` Giuseppe CAVALLARO
2013-07-01 20:33 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Giuseppe CAVALLARO @ 2013-06-28 12:57 UTC (permalink / raw)
To: Byungho An; +Cc: netdev, '김국진', davem, cpgs
On 6/28/2013 9:35 AM, Byungho An wrote:
>
> This patch fixed that enh_desc value is always zero.
> Due to calling order of stmmac_selec_desc_mode(), enh_desc value is always zero.
> Even though mac is set to use enhanced dma descriptor, if enh_desc is zero,
> functions related dma descriptor are not working correctly.
> Signed-off-by: Byungho An <bh74.an@samsung.com>
Acked-by: Giuseppe Cavallaro <peppe.cavallaro@st.com>
> ---
> drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> index e5e221e..40efd55 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> @@ -2567,9 +2567,6 @@ static int stmmac_hw_init(struct stmmac_priv *priv)
> /* Get and dump the chip ID */
> priv->synopsys_id = stmmac_get_synopsys_id(priv);
>
> - /* To use alternate (extended) or normal descriptor structures */
> - stmmac_selec_desc_mode(priv);
> -
> /* To use the chained or ring mode */
> if (chain_mode) {
> priv->hw->chain = &chain_mode_ops;
> @@ -2604,6 +2601,9 @@ static int stmmac_hw_init(struct stmmac_priv *priv)
> } else
> pr_info(" No HW DMA feature register supported");
>
> + /* To use alternate (extended) or normal descriptor structures */
> + stmmac_selec_desc_mode(priv);
> +
> ret = priv->hw->mac->rx_ipc(priv->ioaddr);
> if (!ret) {
> pr_warn(" RX IPC Checksum Offload not configured.\n");
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] net: stmmac: fixed enh_desc set always zero
2013-06-28 12:57 ` Giuseppe CAVALLARO
@ 2013-07-01 20:33 ` David Miller
0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2013-07-01 20:33 UTC (permalink / raw)
To: peppe.cavallaro; +Cc: bh74.an, netdev, kgene.kim, cpgs
From: Giuseppe CAVALLARO <peppe.cavallaro@st.com>
Date: Fri, 28 Jun 2013 14:57:46 +0200
> On 6/28/2013 9:35 AM, Byungho An wrote:
>>
>> This patch fixed that enh_desc value is always zero.
>> Due to calling order of stmmac_selec_desc_mode(), enh_desc value is always zero.
>> Even though mac is set to use enhanced dma descriptor, if enh_desc is zero,
>> functions related dma descriptor are not working correctly.
>> Signed-off-by: Byungho An <bh74.an@samsung.com>
>
> Acked-by: Giuseppe Cavallaro <peppe.cavallaro@st.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-07-01 20:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-06-28 7:35 [PATCH] net: stmmac: fixed enh_desc set always zero Byungho An
2013-06-28 12:57 ` Giuseppe CAVALLARO
2013-07-01 20:33 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.