[PATCH 1/4] u-boot: Update to 2016.09.01 release

[PATCH 1/4] u-boot: Update to 2016.09.01 release

[Marek Vasut]

Upgrade U-Boot to the latest version.

Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Richard Purdie <richard.purdie@linuxfoundation.org>
Cc: Denys Dmytriyenko <denis@denix.org>
---
 .../{u-boot-common_2016.03.inc => u-boot-common_2016.09.01.inc}   | 8 ++++----
 .../{u-boot-fw-utils_2016.03.bb => u-boot-fw-utils_2016.09.01.bb} | 0
 .../{u-boot-mkimage_2016.03.bb => u-boot-mkimage_2016.09.01.bb}   | 0
 .../u-boot/{u-boot_2016.03.bb => u-boot_2016.09.01.bb}            | 0
 4 files changed, 4 insertions(+), 4 deletions(-)
 rename meta/recipes-bsp/u-boot/{u-boot-common_2016.03.inc => u-boot-common_2016.09.01.inc} (59%)
 rename meta/recipes-bsp/u-boot/{u-boot-fw-utils_2016.03.bb => u-boot-fw-utils_2016.09.01.bb} (100%)
 rename meta/recipes-bsp/u-boot/{u-boot-mkimage_2016.03.bb => u-boot-mkimage_2016.09.01.bb} (100%)
 rename meta/recipes-bsp/u-boot/{u-boot_2016.03.bb => u-boot_2016.09.01.bb} (100%)

diff --git a/meta/recipes-bsp/u-boot/u-boot-common_2016.03.inc b/meta/recipes-bsp/u-boot/u-boot-common_2016.09.01.inc
similarity index 59%
rename from meta/recipes-bsp/u-boot/u-boot-common_2016.03.inc
rename to meta/recipes-bsp/u-boot/u-boot-common_2016.09.01.inc
index 403e316..ead5077 100644
--- a/meta/recipes-bsp/u-boot/u-boot-common_2016.03.inc
+++ b/meta/recipes-bsp/u-boot/u-boot-common_2016.09.01.inc
@@ -4,13 +4,13 @@ SECTION = "bootloaders"
 LICENSE = "GPLv2+"
 LIC_FILES_CHKSUM = "file://Licenses/README;md5=a2c678cfd4a4d97135585cad908541c6"
 
-# This revision corresponds to the tag "v2016.03"
+# This revision corresponds to the tag "v2016.09.01"
 # We use the revision in order to avoid having to fetch it from the
 # repo during parse
-SRCREV = "df61a74e6845ec9bdcdd48d2aff5e9c2c6debeaa"
+SRCREV = "f3363c060497515ca8b71451cb56f3ec0abacaa9"
 
-PV = "v2016.03+git${SRCPV}"
+PV = "v2016.09.01+git${SRCPV}"
 
-SRC_URI = "git://git.denx.de/u-boot.git;branch=master"
+SRC_URI = "git://git.denx.de/u-boot.git;branch=u-boot-2016.09.y"
 
 S = "${WORKDIR}/git"
diff --git a/meta/recipes-bsp/u-boot/u-boot-fw-utils_2016.03.bb b/meta/recipes-bsp/u-boot/u-boot-fw-utils_2016.09.01.bb
similarity index 100%
rename from meta/recipes-bsp/u-boot/u-boot-fw-utils_2016.03.bb
rename to meta/recipes-bsp/u-boot/u-boot-fw-utils_2016.09.01.bb
diff --git a/meta/recipes-bsp/u-boot/u-boot-mkimage_2016.03.bb b/meta/recipes-bsp/u-boot/u-boot-mkimage_2016.09.01.bb
similarity index 100%
rename from meta/recipes-bsp/u-boot/u-boot-mkimage_2016.03.bb
rename to meta/recipes-bsp/u-boot/u-boot-mkimage_2016.09.01.bb
diff --git a/meta/recipes-bsp/u-boot/u-boot_2016.03.bb b/meta/recipes-bsp/u-boot/u-boot_2016.09.01.bb
similarity index 100%
rename from meta/recipes-bsp/u-boot/u-boot_2016.03.bb
rename to meta/recipes-bsp/u-boot/u-boot_2016.09.01.bb
-- 
2.9.3

[PATCH 2/4] u-boot: Drop the +git part from PV

[Marek Vasut]

The U-Boot package is using release versions of U-Boot,
so drop the extra +git part from PV.

Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Richard Purdie <richard.purdie@linuxfoundation.org>
Cc: Denys Dmytriyenko <denis@denix.org>
---
 meta/recipes-bsp/u-boot/u-boot-common_2016.09.01.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-bsp/u-boot/u-boot-common_2016.09.01.inc b/meta/recipes-bsp/u-boot/u-boot-common_2016.09.01.inc
index ead5077..0a90621 100644
--- a/meta/recipes-bsp/u-boot/u-boot-common_2016.09.01.inc
+++ b/meta/recipes-bsp/u-boot/u-boot-common_2016.09.01.inc
@@ -9,7 +9,7 @@ LIC_FILES_CHKSUM = "file://Licenses/README;md5=a2c678cfd4a4d97135585cad908541c6"
 # repo during parse
 SRCREV = "f3363c060497515ca8b71451cb56f3ec0abacaa9"
 
-PV = "v2016.09.01+git${SRCPV}"
+PV = "v2016.09.01"
 
 SRC_URI = "git://git.denx.de/u-boot.git;branch=u-boot-2016.09.y"
 
-- 
2.9.3

[PATCH V2 3/4] u-boot: Drop PV altogether

[Marek Vasut]

Drop the explicit setting of PV altogether. This changes the U-Boot
version string from "v20yy.mm" to "20yy.mm" , so layer setting the
PREFERRED_VERSION_u-boot must be updated by removing the leading 'v'.

Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Richard Purdie <richard.purdie@linuxfoundation.org>
Cc: Denys Dmytriyenko <denis@denix.org>
---
V2: - Add PE=1 to increment the epoch of the package, as the version
      numbering changes in non-backward-compatible way.
---
 meta/recipes-bsp/u-boot/u-boot-common_2016.09.01.inc | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/meta/recipes-bsp/u-boot/u-boot-common_2016.09.01.inc b/meta/recipes-bsp/u-boot/u-boot-common_2016.09.01.inc
index 0a90621..e7f6364 100644
--- a/meta/recipes-bsp/u-boot/u-boot-common_2016.09.01.inc
+++ b/meta/recipes-bsp/u-boot/u-boot-common_2016.09.01.inc
@@ -3,14 +3,13 @@ SECTION = "bootloaders"
 
 LICENSE = "GPLv2+"
 LIC_FILES_CHKSUM = "file://Licenses/README;md5=a2c678cfd4a4d97135585cad908541c6"
+PE="1"
 
 # This revision corresponds to the tag "v2016.09.01"
 # We use the revision in order to avoid having to fetch it from the
 # repo during parse
 SRCREV = "f3363c060497515ca8b71451cb56f3ec0abacaa9"
 
-PV = "v2016.09.01"
-
 SRC_URI = "git://git.denx.de/u-boot.git;branch=u-boot-2016.09.y"
 
 S = "${WORKDIR}/git"
-- 
2.9.3

[PATCH 4/4] u-boot: Drop redundant comment

[Marek Vasut]

Drop comment stating that the SRCREV corresponds to particular U-Boot
version. This comment is redundant, since the U-Boot version is part
of the recipe filename.

Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Richard Purdie <richard.purdie@linuxfoundation.org>
Cc: Denys Dmytriyenko <denis@denix.org>
---
 meta/recipes-bsp/u-boot/u-boot-common_2016.09.01.inc | 1 -
 1 file changed, 1 deletion(-)

diff --git a/meta/recipes-bsp/u-boot/u-boot-common_2016.09.01.inc b/meta/recipes-bsp/u-boot/u-boot-common_2016.09.01.inc
index e7f6364..8922947 100644
--- a/meta/recipes-bsp/u-boot/u-boot-common_2016.09.01.inc
+++ b/meta/recipes-bsp/u-boot/u-boot-common_2016.09.01.inc
@@ -5,7 +5,6 @@ LICENSE = "GPLv2+"
 LIC_FILES_CHKSUM = "file://Licenses/README;md5=a2c678cfd4a4d97135585cad908541c6"
 PE="1"
 
-# This revision corresponds to the tag "v2016.09.01"
 # We use the revision in order to avoid having to fetch it from the
 # repo during parse
 SRCREV = "f3363c060497515ca8b71451cb56f3ec0abacaa9"
-- 
2.9.3

Re: [PATCH V2 3/4] u-boot: Drop PV altogether

[Denys Dmytriyenko]

On Thu, Oct 20, 2016 at 03:35:13PM +0200, Marek Vasut wrote:
> Drop the explicit setting of PV altogether. This changes the U-Boot
> version string from "v20yy.mm" to "20yy.mm" , so layer setting the
> PREFERRED_VERSION_u-boot must be updated by removing the leading 'v'.
> 
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Richard Purdie <richard.purdie@linuxfoundation.org>
> Cc: Denys Dmytriyenko <denis@denix.org>

Acked-by: Denys Dmytriyenko <denys@ti.com>


> ---
> V2: - Add PE=1 to increment the epoch of the package, as the version
>       numbering changes in non-backward-compatible way.
> ---
>  meta/recipes-bsp/u-boot/u-boot-common_2016.09.01.inc | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/meta/recipes-bsp/u-boot/u-boot-common_2016.09.01.inc b/meta/recipes-bsp/u-boot/u-boot-common_2016.09.01.inc
> index 0a90621..e7f6364 100644
> --- a/meta/recipes-bsp/u-boot/u-boot-common_2016.09.01.inc
> +++ b/meta/recipes-bsp/u-boot/u-boot-common_2016.09.01.inc
> @@ -3,14 +3,13 @@ SECTION = "bootloaders"
>  
>  LICENSE = "GPLv2+"
>  LIC_FILES_CHKSUM = "file://Licenses/README;md5=a2c678cfd4a4d97135585cad908541c6"
> +PE="1"

^^^^^^^^
Formatting! My OCD is going to kill me... :)



>  # This revision corresponds to the tag "v2016.09.01"
>  # We use the revision in order to avoid having to fetch it from the
>  # repo during parse
>  SRCREV = "f3363c060497515ca8b71451cb56f3ec0abacaa9"
>  
> -PV = "v2016.09.01"
> -
>  SRC_URI = "git://git.denx.de/u-boot.git;branch=u-boot-2016.09.y"
>  
>  S = "${WORKDIR}/git"
> -- 
> 2.9.3
> 

Re: [PATCH 1/4] u-boot: Update to 2016.09.01 release

[Denys Dmytriyenko]

On Thu, Oct 20, 2016 at 03:35:11PM +0200, Marek Vasut wrote:
> Upgrade U-Boot to the latest version.
> 
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Richard Purdie <richard.purdie@linuxfoundation.org>
> Cc: Denys Dmytriyenko <denis@denix.org>

Acked-by: Denys Dmytriyenko <denys@ti.com>


> ---
>  .../{u-boot-common_2016.03.inc => u-boot-common_2016.09.01.inc}   | 8 ++++----
>  .../{u-boot-fw-utils_2016.03.bb => u-boot-fw-utils_2016.09.01.bb} | 0
>  .../{u-boot-mkimage_2016.03.bb => u-boot-mkimage_2016.09.01.bb}   | 0
>  .../u-boot/{u-boot_2016.03.bb => u-boot_2016.09.01.bb}            | 0
>  4 files changed, 4 insertions(+), 4 deletions(-)
>  rename meta/recipes-bsp/u-boot/{u-boot-common_2016.03.inc => u-boot-common_2016.09.01.inc} (59%)
>  rename meta/recipes-bsp/u-boot/{u-boot-fw-utils_2016.03.bb => u-boot-fw-utils_2016.09.01.bb} (100%)
>  rename meta/recipes-bsp/u-boot/{u-boot-mkimage_2016.03.bb => u-boot-mkimage_2016.09.01.bb} (100%)
>  rename meta/recipes-bsp/u-boot/{u-boot_2016.03.bb => u-boot_2016.09.01.bb} (100%)
> 
> diff --git a/meta/recipes-bsp/u-boot/u-boot-common_2016.03.inc b/meta/recipes-bsp/u-boot/u-boot-common_2016.09.01.inc
> similarity index 59%
> rename from meta/recipes-bsp/u-boot/u-boot-common_2016.03.inc
> rename to meta/recipes-bsp/u-boot/u-boot-common_2016.09.01.inc
> index 403e316..ead5077 100644
> --- a/meta/recipes-bsp/u-boot/u-boot-common_2016.03.inc
> +++ b/meta/recipes-bsp/u-boot/u-boot-common_2016.09.01.inc
> @@ -4,13 +4,13 @@ SECTION = "bootloaders"
>  LICENSE = "GPLv2+"
>  LIC_FILES_CHKSUM = "file://Licenses/README;md5=a2c678cfd4a4d97135585cad908541c6"
>  
> -# This revision corresponds to the tag "v2016.03"
> +# This revision corresponds to the tag "v2016.09.01"
>  # We use the revision in order to avoid having to fetch it from the
>  # repo during parse
> -SRCREV = "df61a74e6845ec9bdcdd48d2aff5e9c2c6debeaa"
> +SRCREV = "f3363c060497515ca8b71451cb56f3ec0abacaa9"
>  
> -PV = "v2016.03+git${SRCPV}"
> +PV = "v2016.09.01+git${SRCPV}"
>  
> -SRC_URI = "git://git.denx.de/u-boot.git;branch=master"
> +SRC_URI = "git://git.denx.de/u-boot.git;branch=u-boot-2016.09.y"
>  
>  S = "${WORKDIR}/git"
> diff --git a/meta/recipes-bsp/u-boot/u-boot-fw-utils_2016.03.bb b/meta/recipes-bsp/u-boot/u-boot-fw-utils_2016.09.01.bb
> similarity index 100%
> rename from meta/recipes-bsp/u-boot/u-boot-fw-utils_2016.03.bb
> rename to meta/recipes-bsp/u-boot/u-boot-fw-utils_2016.09.01.bb
> diff --git a/meta/recipes-bsp/u-boot/u-boot-mkimage_2016.03.bb b/meta/recipes-bsp/u-boot/u-boot-mkimage_2016.09.01.bb
> similarity index 100%
> rename from meta/recipes-bsp/u-boot/u-boot-mkimage_2016.03.bb
> rename to meta/recipes-bsp/u-boot/u-boot-mkimage_2016.09.01.bb
> diff --git a/meta/recipes-bsp/u-boot/u-boot_2016.03.bb b/meta/recipes-bsp/u-boot/u-boot_2016.09.01.bb
> similarity index 100%
> rename from meta/recipes-bsp/u-boot/u-boot_2016.03.bb
> rename to meta/recipes-bsp/u-boot/u-boot_2016.09.01.bb
> -- 
> 2.9.3
> 

Re: [PATCH 2/4] u-boot: Drop the +git part from PV

[Denys Dmytriyenko]

On Thu, Oct 20, 2016 at 03:35:12PM +0200, Marek Vasut wrote:
> The U-Boot package is using release versions of U-Boot,
> so drop the extra +git part from PV.
> 
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Richard Purdie <richard.purdie@linuxfoundation.org>
> Cc: Denys Dmytriyenko <denis@denix.org>

Acked-by: Denys Dmytriyenko <denys@ti.com>


> ---
>  meta/recipes-bsp/u-boot/u-boot-common_2016.09.01.inc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/recipes-bsp/u-boot/u-boot-common_2016.09.01.inc b/meta/recipes-bsp/u-boot/u-boot-common_2016.09.01.inc
> index ead5077..0a90621 100644
> --- a/meta/recipes-bsp/u-boot/u-boot-common_2016.09.01.inc
> +++ b/meta/recipes-bsp/u-boot/u-boot-common_2016.09.01.inc
> @@ -9,7 +9,7 @@ LIC_FILES_CHKSUM = "file://Licenses/README;md5=a2c678cfd4a4d97135585cad908541c6"
>  # repo during parse
>  SRCREV = "f3363c060497515ca8b71451cb56f3ec0abacaa9"
>  
> -PV = "v2016.09.01+git${SRCPV}"
> +PV = "v2016.09.01"
>  
>  SRC_URI = "git://git.denx.de/u-boot.git;branch=u-boot-2016.09.y"
>  
> -- 
> 2.9.3
> 

Re: [PATCH 4/4] u-boot: Drop redundant comment

[Denys Dmytriyenko]

On Thu, Oct 20, 2016 at 03:35:14PM +0200, Marek Vasut wrote:
> Drop comment stating that the SRCREV corresponds to particular U-Boot
> version. This comment is redundant, since the U-Boot version is part
> of the recipe filename.
> 
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Richard Purdie <richard.purdie@linuxfoundation.org>
> Cc: Denys Dmytriyenko <denis@denix.org>

Acked-by: Denys Dmytriyenko <denys@ti.com>


> ---
>  meta/recipes-bsp/u-boot/u-boot-common_2016.09.01.inc | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/meta/recipes-bsp/u-boot/u-boot-common_2016.09.01.inc b/meta/recipes-bsp/u-boot/u-boot-common_2016.09.01.inc
> index e7f6364..8922947 100644
> --- a/meta/recipes-bsp/u-boot/u-boot-common_2016.09.01.inc
> +++ b/meta/recipes-bsp/u-boot/u-boot-common_2016.09.01.inc
> @@ -5,7 +5,6 @@ LICENSE = "GPLv2+"
>  LIC_FILES_CHKSUM = "file://Licenses/README;md5=a2c678cfd4a4d97135585cad908541c6"
>  PE="1"
>  
> -# This revision corresponds to the tag "v2016.09.01"
>  # We use the revision in order to avoid having to fetch it from the
>  # repo during parse
>  SRCREV = "f3363c060497515ca8b71451cb56f3ec0abacaa9"
> -- 
> 2.9.3
> 

[PATCH V3 3/4] u-boot: Drop PV altogether

[Marek Vasut]

Drop the explicit setting of PV altogether. This changes the U-Boot
version string from "v20yy.mm" to "20yy.mm" , so layer setting the
PREFERRED_VERSION_u-boot must be updated by removing the leading 'v'.

Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Richard Purdie <richard.purdie@linuxfoundation.org>
Cc: Denys Dmytriyenko <denis@denix.org>
---
V2: - Add PE=1 to increment the epoch of the package, as the version
      numbering changes in non-backward-compatible way.
V3: - Formatting fix of the PE line
---
 meta/recipes-bsp/u-boot/u-boot-common_2016.09.01.inc | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/meta/recipes-bsp/u-boot/u-boot-common_2016.09.01.inc b/meta/recipes-bsp/u-boot/u-boot-common_2016.09.01.inc
index 0a90621..183e222 100644
--- a/meta/recipes-bsp/u-boot/u-boot-common_2016.09.01.inc
+++ b/meta/recipes-bsp/u-boot/u-boot-common_2016.09.01.inc
@@ -3,14 +3,13 @@ SECTION = "bootloaders"
 
 LICENSE = "GPLv2+"
 LIC_FILES_CHKSUM = "file://Licenses/README;md5=a2c678cfd4a4d97135585cad908541c6"
+PE = "1"
 
 # This revision corresponds to the tag "v2016.09.01"
 # We use the revision in order to avoid having to fetch it from the
 # repo during parse
 SRCREV = "f3363c060497515ca8b71451cb56f3ec0abacaa9"
 
-PV = "v2016.09.01"
-
 SRC_URI = "git://git.denx.de/u-boot.git;branch=u-boot-2016.09.y"
 
 S = "${WORKDIR}/git"
-- 
2.9.3

Re: [PATCH V3 3/4] u-boot: Drop PV altogether

[Denys Dmytriyenko]

On Thu, Oct 20, 2016 at 03:48:27PM +0200, Marek Vasut wrote:
> Drop the explicit setting of PV altogether. This changes the U-Boot
> version string from "v20yy.mm" to "20yy.mm" , so layer setting the
> PREFERRED_VERSION_u-boot must be updated by removing the leading 'v'.
> 
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Richard Purdie <richard.purdie@linuxfoundation.org>
> Cc: Denys Dmytriyenko <denis@denix.org>

Acked-by: Denys Dmytriyenko <denys@ti.com>


> ---
> V2: - Add PE=1 to increment the epoch of the package, as the version
>       numbering changes in non-backward-compatible way.
> V3: - Formatting fix of the PE line

Thanks!


> ---
>  meta/recipes-bsp/u-boot/u-boot-common_2016.09.01.inc | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/meta/recipes-bsp/u-boot/u-boot-common_2016.09.01.inc b/meta/recipes-bsp/u-boot/u-boot-common_2016.09.01.inc
> index 0a90621..183e222 100644
> --- a/meta/recipes-bsp/u-boot/u-boot-common_2016.09.01.inc
> +++ b/meta/recipes-bsp/u-boot/u-boot-common_2016.09.01.inc
> @@ -3,14 +3,13 @@ SECTION = "bootloaders"
>  
>  LICENSE = "GPLv2+"
>  LIC_FILES_CHKSUM = "file://Licenses/README;md5=a2c678cfd4a4d97135585cad908541c6"
> +PE = "1"
>  
>  # This revision corresponds to the tag "v2016.09.01"
>  # We use the revision in order to avoid having to fetch it from the
>  # repo during parse
>  SRCREV = "f3363c060497515ca8b71451cb56f3ec0abacaa9"
>  
> -PV = "v2016.09.01"
> -
>  SRC_URI = "git://git.denx.de/u-boot.git;branch=u-boot-2016.09.y"
>  
>  S = "${WORKDIR}/git"
> -- 
> 2.9.3
> 

Re: [PATCH 1/4] u-boot: Update to 2016.09.01 release

[Burton, Ross]

[-- Attachment #1: Type: text/plain, Size: 178 bytes --]

On 20 October 2016 at 14:35, Marek Vasut <marex@denx.de> wrote:

> Upgrade U-Boot to the latest version.
>

I hope nobody objects but I squashed these for clarity.

Ross

[-- Attachment #2: Type: text/html, Size: 578 bytes --]

Re: [PATCH 1/4] u-boot: Update to 2016.09.01 release

[Marek Vasut]

On 10/20/2016 05:16 PM, Burton, Ross wrote:
> 
> On 20 October 2016 at 14:35, Marek Vasut <marex@denx.de
> <mailto:marex@denx.de>> wrote:
> 
>     Upgrade U-Boot to the latest version.
> 
> 
> I hope nobody objects but I squashed these for clarity.

All right ;-)

-- 
Best regards,
Marek Vasut

Re: [PATCH 1/4] u-boot: Update to 2016.09.01 release

[Burton, Ross]

[-- Attachment #1: Type: text/plain, Size: 2975 bytes --]

On 20 October 2016 at 14:35, Marek Vasut <marex@denx.de> wrote:

> Upgrade U-Boot to the latest version.
>

As usual, u-boot-mkimage broke again:

| DEBUG: Executing shell function do_compile
|   x86_64-poky-linux-gcc  -m64 -march=core2 -mtune=core2 -msse3
-mfpmath=sse
--sysroot=/home/pokybuild/yocto-autobuilder/yocto-worker/nightly-no-x11/build/build/tmp/sysroots/qemux86-64
 -O2 -pipe -g -feliminate-unused-debug-types
-fdebug-prefix-map=/home/pokybuild/yocto-autobuilder/yocto-worker/nightly-no-x11/build/build/tmp/work/core2-64-poky-linux/u-boot-mkimage/1_2016.09.01-r0=/usr/src/debug/u-boot-mkimage/1_2016.09.01-r0
-fdebug-prefix-map=/home/pokybuild/yocto-autobuilder/yocto-worker/nightly-no-x11/build/build/tmp/sysroots/x86_64-linux=
-fdebug-prefix-map=/home/pokybuild/yocto-autobuilder/yocto-worker/nightly-no-x11/build/build/tmp/sysroots/qemux86-64=
 -Wl,-O1 -Wl,--hash-style=gnu -Wl,--as-needed -Wp,-MD,tools/.bin2header.d
-Wall -Wstrict-prototypes -O2 -fomit-frame-pointer
 -DCONFIG_FIT_SIGNATURE -include ./include/libfdt_env.h -idirafterinclude
-idirafter./arch/sandbox/include -I./lib/libfdt -I./tools
-DCONFIG_SYS_TEXT_BASE=0 -DUSE_HOSTCC -D__KERNEL_STRICT_NAMES -D_GNU_SOURCE
 -o tools/bin2header tools/bin2header.c
| cat ./Licenses/gpl-2.0.txt | gzip -9 -c | \
| tools/bin2header license_gzip > ./include/license.h
|   x86_64-poky-linux-gcc  -m64 -march=core2 -mtune=core2 -msse3
-mfpmath=sse
--sysroot=/home/pokybuild/yocto-autobuilder/yocto-worker/nightly-no-x11/build/build/tmp/sysroots/qemux86-64
 -O2 -pipe -g -feliminate-unused-debug-types
-fdebug-prefix-map=/home/pokybuild/yocto-autobuilder/yocto-worker/nightly-no-x11/build/build/tmp/work/core2-64-poky-linux/u-boot-mkimage/1_2016.09.01-r0=/usr/src/debug/u-boot-mkimage/1_2016.09.01-r0
-fdebug-prefix-map=/home/pokybuild/yocto-autobuilder/yocto-worker/nightly-no-x11/build/build/tmp/sysroots/x86_64-linux=
-fdebug-prefix-map=/home/pokybuild/yocto-autobuilder/yocto-worker/nightly-no-x11/build/build/tmp/sysroots/qemux86-64=
 -Wl,-O1 -Wl,--hash-style=gnu -Wl,--as-needed -Wp,-MD,tools/lib/.crc32.o.d
-Wall -Wstrict-prototypes -O2 -fomit-frame-pointer
 -DCONFIG_FIT_SIGNATURE -include ./include/libfdt_env.h -idirafterinclude
-idirafter./arch/sandbox/include -I./lib/libfdt -I./tools
-DCONFIG_SYS_TEXT_BASE=0 -DUSE_HOSTCC -D__KERNEL_STRICT_NAMES -D_GNU_SOURCE
-pedantic -c -o tools/lib/crc32.o tools/lib/crc32.c
| /bin/sh: tools/bin2header: /lib/ld-linux-x86-64.so.2: bad ELF
interpreter: No such file or directory
| ERROR: oe_runmake failed
| make[1]: *** [include/license.h] Error 126
NOTE: recipe u-boot-mkimage-1_2016.09.01-r0: task do_compile: Failed
ERROR: Task
(/home/pokybuild/yocto-autobuilder/yocto-worker/nightly-no-x11/build/meta/recipes-bsp/u-boot/u-boot-mkimage_2016.09.01.bb:do_compile)
failed with exit code '1'

It's using the target compiler/sysroot/options to build a runtime tool (so
should use BUILD_CC instead of CC, etc).

Ross

[-- Attachment #2: Type: text/html, Size: 3586 bytes --]

Re: [PATCH 1/4] u-boot: Update to 2016.09.01 release

[Marek Vasut]

On 10/21/2016 09:47 AM, Burton, Ross wrote:

Hi!

> On 20 October 2016 at 14:35, Marek Vasut <marex@denx.de
> <mailto:marex@denx.de>> wrote:
> 
>     Upgrade U-Boot to the latest version.
> 
> 
> As usual, u-boot-mkimage broke again:

That's weird, I successfully built it for nios2 during my tests.
Can you tell me how I can replicate the issue , so I can test for it to
prevent regression and roll out a patch ?

> | DEBUG: Executing shell function do_compile
> |   x86_64-poky-linux-gcc  -m64 -march=core2 -mtune=core2 -msse3
> -mfpmath=sse
> --sysroot=/home/pokybuild/yocto-autobuilder/yocto-worker/nightly-no-x11/build/build/tmp/sysroots/qemux86-64
>  -O2 -pipe -g -feliminate-unused-debug-types
> -fdebug-prefix-map=/home/pokybuild/yocto-autobuilder/yocto-worker/nightly-no-x11/build/build/tmp/work/core2-64-poky-linux/u-boot-mkimage/1_2016.09.01-r0=/usr/src/debug/u-boot-mkimage/1_2016.09.01-r0
> -fdebug-prefix-map=/home/pokybuild/yocto-autobuilder/yocto-worker/nightly-no-x11/build/build/tmp/sysroots/x86_64-linux=
> -fdebug-prefix-map=/home/pokybuild/yocto-autobuilder/yocto-worker/nightly-no-x11/build/build/tmp/sysroots/qemux86-64=
>  -Wl,-O1 -Wl,--hash-style=gnu -Wl,--as-needed
> -Wp,-MD,tools/.bin2header.d -Wall -Wstrict-prototypes -O2
> -fomit-frame-pointer    -DCONFIG_FIT_SIGNATURE -include
> ./include/libfdt_env.h -idirafterinclude
> -idirafter./arch/sandbox/include -I./lib/libfdt -I./tools
> -DCONFIG_SYS_TEXT_BASE=0 -DUSE_HOSTCC -D__KERNEL_STRICT_NAMES
> -D_GNU_SOURCE  -o tools/bin2header tools/bin2header.c
> | cat ./Licenses/gpl-2.0.txt | gzip -9 -c | \
> | tools/bin2header license_gzip > ./include/license.h
> |   x86_64-poky-linux-gcc  -m64 -march=core2 -mtune=core2 -msse3
> -mfpmath=sse
> --sysroot=/home/pokybuild/yocto-autobuilder/yocto-worker/nightly-no-x11/build/build/tmp/sysroots/qemux86-64
>  -O2 -pipe -g -feliminate-unused-debug-types
> -fdebug-prefix-map=/home/pokybuild/yocto-autobuilder/yocto-worker/nightly-no-x11/build/build/tmp/work/core2-64-poky-linux/u-boot-mkimage/1_2016.09.01-r0=/usr/src/debug/u-boot-mkimage/1_2016.09.01-r0
> -fdebug-prefix-map=/home/pokybuild/yocto-autobuilder/yocto-worker/nightly-no-x11/build/build/tmp/sysroots/x86_64-linux=
> -fdebug-prefix-map=/home/pokybuild/yocto-autobuilder/yocto-worker/nightly-no-x11/build/build/tmp/sysroots/qemux86-64=
>  -Wl,-O1 -Wl,--hash-style=gnu -Wl,--as-needed
> -Wp,-MD,tools/lib/.crc32.o.d -Wall -Wstrict-prototypes -O2
> -fomit-frame-pointer    -DCONFIG_FIT_SIGNATURE -include
> ./include/libfdt_env.h -idirafterinclude
> -idirafter./arch/sandbox/include -I./lib/libfdt -I./tools
> -DCONFIG_SYS_TEXT_BASE=0 -DUSE_HOSTCC -D__KERNEL_STRICT_NAMES
> -D_GNU_SOURCE -pedantic -c -o tools/lib/crc32.o tools/lib/crc32.c
> | /bin/sh: tools/bin2header: /lib/ld-linux-x86-64.so.2: bad ELF
> interpreter: No such file or directory
> | ERROR: oe_runmake failed
> | make[1]: *** [include/license.h] Error 126
> NOTE: recipe u-boot-mkimage-1_2016.09.01-r0: task do_compile: Failed
> ERROR: Task
> (/home/pokybuild/yocto-autobuilder/yocto-worker/nightly-no-x11/build/meta/recipes-bsp/u-boot/u-boot-mkimage_2016.09.01.bb:do_compile)
> failed with exit code '1'
> 
> It's using the target compiler/sysroot/options to build a runtime tool
> (so should use BUILD_CC instead of CC, etc).
> 
> Ross


-- 
Best regards,
Marek Vasut

Re: [PATCH 1/4] u-boot: Update to 2016.09.01 release

[Denys Dmytriyenko]

On Sat, Oct 22, 2016 at 10:32:12PM +0200, Marek Vasut wrote:
> On 10/21/2016 09:47 AM, Burton, Ross wrote:
> 
> Hi!
> 
> > On 20 October 2016 at 14:35, Marek Vasut <marex@denx.de
> > <mailto:marex@denx.de>> wrote:
> > 
> >     Upgrade U-Boot to the latest version.
> > 
> > 
> > As usual, u-boot-mkimage broke again:
> 
> That's weird, I successfully built it for nios2 during my tests.
> Can you tell me how I can replicate the issue , so I can test for it to
> prevent regression and roll out a patch ?

Marek, Ross,

Any progress on this? Need any help testing?

-- 
Denys


> > | DEBUG: Executing shell function do_compile
> > |   x86_64-poky-linux-gcc  -m64 -march=core2 -mtune=core2 -msse3
> > -mfpmath=sse
> > --sysroot=/home/pokybuild/yocto-autobuilder/yocto-worker/nightly-no-x11/build/build/tmp/sysroots/qemux86-64
> >  -O2 -pipe -g -feliminate-unused-debug-types
> > -fdebug-prefix-map=/home/pokybuild/yocto-autobuilder/yocto-worker/nightly-no-x11/build/build/tmp/work/core2-64-poky-linux/u-boot-mkimage/1_2016.09.01-r0=/usr/src/debug/u-boot-mkimage/1_2016.09.01-r0
> > -fdebug-prefix-map=/home/pokybuild/yocto-autobuilder/yocto-worker/nightly-no-x11/build/build/tmp/sysroots/x86_64-linux=
> > -fdebug-prefix-map=/home/pokybuild/yocto-autobuilder/yocto-worker/nightly-no-x11/build/build/tmp/sysroots/qemux86-64=
> >  -Wl,-O1 -Wl,--hash-style=gnu -Wl,--as-needed
> > -Wp,-MD,tools/.bin2header.d -Wall -Wstrict-prototypes -O2
> > -fomit-frame-pointer    -DCONFIG_FIT_SIGNATURE -include
> > ./include/libfdt_env.h -idirafterinclude
> > -idirafter./arch/sandbox/include -I./lib/libfdt -I./tools
> > -DCONFIG_SYS_TEXT_BASE=0 -DUSE_HOSTCC -D__KERNEL_STRICT_NAMES
> > -D_GNU_SOURCE  -o tools/bin2header tools/bin2header.c
> > | cat ./Licenses/gpl-2.0.txt | gzip -9 -c | \
> > | tools/bin2header license_gzip > ./include/license.h
> > |   x86_64-poky-linux-gcc  -m64 -march=core2 -mtune=core2 -msse3
> > -mfpmath=sse
> > --sysroot=/home/pokybuild/yocto-autobuilder/yocto-worker/nightly-no-x11/build/build/tmp/sysroots/qemux86-64
> >  -O2 -pipe -g -feliminate-unused-debug-types
> > -fdebug-prefix-map=/home/pokybuild/yocto-autobuilder/yocto-worker/nightly-no-x11/build/build/tmp/work/core2-64-poky-linux/u-boot-mkimage/1_2016.09.01-r0=/usr/src/debug/u-boot-mkimage/1_2016.09.01-r0
> > -fdebug-prefix-map=/home/pokybuild/yocto-autobuilder/yocto-worker/nightly-no-x11/build/build/tmp/sysroots/x86_64-linux=
> > -fdebug-prefix-map=/home/pokybuild/yocto-autobuilder/yocto-worker/nightly-no-x11/build/build/tmp/sysroots/qemux86-64=
> >  -Wl,-O1 -Wl,--hash-style=gnu -Wl,--as-needed
> > -Wp,-MD,tools/lib/.crc32.o.d -Wall -Wstrict-prototypes -O2
> > -fomit-frame-pointer    -DCONFIG_FIT_SIGNATURE -include
> > ./include/libfdt_env.h -idirafterinclude
> > -idirafter./arch/sandbox/include -I./lib/libfdt -I./tools
> > -DCONFIG_SYS_TEXT_BASE=0 -DUSE_HOSTCC -D__KERNEL_STRICT_NAMES
> > -D_GNU_SOURCE -pedantic -c -o tools/lib/crc32.o tools/lib/crc32.c
> > | /bin/sh: tools/bin2header: /lib/ld-linux-x86-64.so.2: bad ELF
> > interpreter: No such file or directory
> > | ERROR: oe_runmake failed
> > | make[1]: *** [include/license.h] Error 126
> > NOTE: recipe u-boot-mkimage-1_2016.09.01-r0: task do_compile: Failed
> > ERROR: Task
> > (/home/pokybuild/yocto-autobuilder/yocto-worker/nightly-no-x11/build/meta/recipes-bsp/u-boot/u-boot-mkimage_2016.09.01.bb:do_compile)
> > failed with exit code '1'
> > 
> > It's using the target compiler/sysroot/options to build a runtime tool
> > (so should use BUILD_CC instead of CC, etc).
> > 
> > Ross
> 
> 
> -- 
> Best regards,
> Marek Vasut
> -- 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [PATCH 1/4] u-boot: Update to 2016.09.01 release

[Marek Vasut]

On 10/25/2016 08:32 PM, Denys Dmytriyenko wrote:
> On Sat, Oct 22, 2016 at 10:32:12PM +0200, Marek Vasut wrote:
>> On 10/21/2016 09:47 AM, Burton, Ross wrote:
>>
>> Hi!
>>
>>> On 20 October 2016 at 14:35, Marek Vasut <marex@denx.de
>>> <mailto:marex@denx.de>> wrote:
>>>
>>>     Upgrade U-Boot to the latest version.
>>>
>>>
>>> As usual, u-boot-mkimage broke again:
>>
>> That's weird, I successfully built it for nios2 during my tests.
>> Can you tell me how I can replicate the issue , so I can test for it to
>> prevent regression and roll out a patch ?
> 
> Marek, Ross,
> 
> Any progress on this? Need any help testing?
> 
Yeah, how do you replicate this issue ?

-- 
Best regards,
Marek Vasut

Re: [PATCH 1/4] u-boot: Update to 2016.09.01 release

[Stefan Müller-Klieser]

On 25.10.2016 21:24, Marek Vasut wrote:
> On 10/25/2016 08:32 PM, Denys Dmytriyenko wrote:
>> On Sat, Oct 22, 2016 at 10:32:12PM +0200, Marek Vasut wrote:
>>> On 10/21/2016 09:47 AM, Burton, Ross wrote:
>>>
>>> Hi!
>>>
>>>> On 20 October 2016 at 14:35, Marek Vasut <marex@denx.de
>>>> <mailto:marex@denx.de>> wrote:
>>>>
>>>>     Upgrade U-Boot to the latest version.
>>>>
>>>>
>>>> As usual, u-boot-mkimage broke again:
>>>
>>> That's weird, I successfully built it for nios2 during my tests.
>>> Can you tell me how I can replicate the issue , so I can test for it to
>>> prevent regression and roll out a patch ?
>>
>> Marek, Ross,
>>
>> Any progress on this? Need any help testing?
>>
> Yeah, how do you replicate this issue ?
> 
Hi!
I am just looking at a similar problem and want to jump into the discussion.
As Ross said, the problem is to not respect host/target -- cc/cflags/ldflags.
So to replicate the issue, you can use a bare minimum build host with no
cross toolchain installed, and I guess all targets will fail to build.
As this has been broken so many times, I want to discuss some possible fixes:
In the top level Makefile we have:
HOSTCC = cc
HOSTCFLAGS = ...
The problem is, you cannot properly override those variables, as they get used
a lot to do different things, e.g. in tools/Makefile we have (for cross tools
target) HOSTCC = $(CC) and for HOSTCFLAGS we have appends for configuration. 
Thats why we have the current workaround with a squashed override. I see many
possible solutions and would like to hear your opinion:
1. Make top level Makefile HOST assignments conditional "?="
   - easy
   - will probably not be accepted upstream
2. add "override" to appends in sublevel Makefiles
   - adds complexity/one level of override hierarchy
3. Don't use appends for those variables (like in the kernel Makefile), overrides
   in the recipe
   - clean
   - quite some rework in uboot
4. Hack around in the recipe with class overrides and exports
   - quickfix, no patch required
   - fails easily in the future

Any thoughts?
Stefan

Re: [PATCH 1/4] u-boot: Update to 2016.09.01 release

[Marek Vasut]

On 10/27/2016 01:44 PM, Stefan Müller-Klieser wrote:
> On 25.10.2016 21:24, Marek Vasut wrote:
>> On 10/25/2016 08:32 PM, Denys Dmytriyenko wrote:
>>> On Sat, Oct 22, 2016 at 10:32:12PM +0200, Marek Vasut wrote:
>>>> On 10/21/2016 09:47 AM, Burton, Ross wrote:
>>>>
>>>> Hi!
>>>>
>>>>> On 20 October 2016 at 14:35, Marek Vasut <marex@denx.de
>>>>> <mailto:marex@denx.de>> wrote:
>>>>>
>>>>>     Upgrade U-Boot to the latest version.
>>>>>
>>>>>
>>>>> As usual, u-boot-mkimage broke again:
>>>>
>>>> That's weird, I successfully built it for nios2 during my tests.
>>>> Can you tell me how I can replicate the issue , so I can test for it to
>>>> prevent regression and roll out a patch ?
>>>
>>> Marek, Ross,
>>>
>>> Any progress on this? Need any help testing?
>>>
>> Yeah, how do you replicate this issue ?
>>
> Hi!

Hi!

> I am just looking at a similar problem and want to jump into the discussion.
> As Ross said, the problem is to not respect host/target -- cc/cflags/ldflags.
> So to replicate the issue, you can use a bare minimum build host with no
> cross toolchain installed, and I guess all targets will fail to build.

Well both ARM and nios2 builds for me, so I wonder what sort of stupid
thing am I doing.

> As this has been broken so many times, I want to discuss some possible fixes:
> In the top level Makefile we have:
> HOSTCC = cc
> HOSTCFLAGS = ...
> The problem is, you cannot properly override those variables, as they get used
> a lot to do different things, e.g. in tools/Makefile we have (for cross tools
> target) HOSTCC = $(CC) and for HOSTCFLAGS we have appends for configuration. 
> Thats why we have the current workaround with a squashed override. I see many
> possible solutions and would like to hear your opinion:
> 1. Make top level Makefile HOST assignments conditional "?="
>    - easy
>    - will probably not be accepted upstream

Why ?

> 2. add "override" to appends in sublevel Makefiles
>    - adds complexity/one level of override hierarchy
> 3. Don't use appends for those variables (like in the kernel Makefile), overrides
>    in the recipe
>    - clean
>    - quite some rework in uboot

Can you provide details ?

> 4. Hack around in the recipe with class overrides and exports
>    - quickfix, no patch required
>    - fails easily in the future
> 
> Any thoughts?
> Stefan
> 


-- 
Best regards,
Marek Vasut

Re: [PATCH 1/4] u-boot: Update to 2016.09.01 release

[Denys Dmytriyenko]

On Fri, Oct 28, 2016 at 02:18:59AM +0200, Marek Vasut wrote:
> On 10/27/2016 01:44 PM, Stefan Müller-Klieser wrote:
> > On 25.10.2016 21:24, Marek Vasut wrote:
> >> On 10/25/2016 08:32 PM, Denys Dmytriyenko wrote:
> >>> On Sat, Oct 22, 2016 at 10:32:12PM +0200, Marek Vasut wrote:
> >>>> On 10/21/2016 09:47 AM, Burton, Ross wrote:
> >>>>
> >>>> Hi!
> >>>>
> >>>>> On 20 October 2016 at 14:35, Marek Vasut <marex@denx.de
> >>>>> <mailto:marex@denx.de>> wrote:
> >>>>>
> >>>>>     Upgrade U-Boot to the latest version.
> >>>>>
> >>>>>
> >>>>> As usual, u-boot-mkimage broke again:
> >>>>
> >>>> That's weird, I successfully built it for nios2 during my tests.
> >>>> Can you tell me how I can replicate the issue , so I can test for it to
> >>>> prevent regression and roll out a patch ?
> >>>
> >>> Marek, Ross,
> >>>
> >>> Any progress on this? Need any help testing?
> >>>
> >> Yeah, how do you replicate this issue ?
> >>
> > Hi!
> 
> Hi!
> 
> > I am just looking at a similar problem and want to jump into the discussion.
> > As Ross said, the problem is to not respect host/target -- cc/cflags/ldflags.
> > So to replicate the issue, you can use a bare minimum build host with no
> > cross toolchain installed, and I guess all targets will fail to build.
> 
> Well both ARM and nios2 builds for me, so I wonder what sort of stupid
> thing am I doing.

Well, that's the thing - your patches didn't change anything around toolchain, 
so it shouldn't break what used to be working before, right? Unless it was 
already broken...

Ross,

Care to elaborate on what is breaking for you and what setup you are using?


> > As this has been broken so many times, I want to discuss some possible fixes:
> > In the top level Makefile we have:
> > HOSTCC = cc
> > HOSTCFLAGS = ...
> > The problem is, you cannot properly override those variables, as they get used
> > a lot to do different things, e.g. in tools/Makefile we have (for cross tools
> > target) HOSTCC = $(CC) and for HOSTCFLAGS we have appends for configuration. 
> > Thats why we have the current workaround with a squashed override. I see many
> > possible solutions and would like to hear your opinion:
> > 1. Make top level Makefile HOST assignments conditional "?="
> >    - easy
> >    - will probably not be accepted upstream
> 
> Why ?

Heh, good one! :)


> > 2. add "override" to appends in sublevel Makefiles
> >    - adds complexity/one level of override hierarchy
> > 3. Don't use appends for those variables (like in the kernel Makefile), overrides
> >    in the recipe
> >    - clean
> >    - quite some rework in uboot
> 
> Can you provide details ?
> 
> > 4. Hack around in the recipe with class overrides and exports
> >    - quickfix, no patch required
> >    - fails easily in the future
> > 
> > Any thoughts?
> > Stefan
> > 
> 
> 
> -- 
> Best regards,
> Marek Vasut
> 

Re: [PATCH 1/4] u-boot: Update to 2016.09.01 release

[Marek Vasut]

On 10/28/2016 04:11 AM, Denys Dmytriyenko wrote:
> On Fri, Oct 28, 2016 at 02:18:59AM +0200, Marek Vasut wrote:
>> On 10/27/2016 01:44 PM, Stefan Müller-Klieser wrote:
>>> On 25.10.2016 21:24, Marek Vasut wrote:
>>>> On 10/25/2016 08:32 PM, Denys Dmytriyenko wrote:
>>>>> On Sat, Oct 22, 2016 at 10:32:12PM +0200, Marek Vasut wrote:
>>>>>> On 10/21/2016 09:47 AM, Burton, Ross wrote:
>>>>>>
>>>>>> Hi!
>>>>>>
>>>>>>> On 20 October 2016 at 14:35, Marek Vasut <marex@denx.de
>>>>>>> <mailto:marex@denx.de>> wrote:
>>>>>>>
>>>>>>>     Upgrade U-Boot to the latest version.
>>>>>>>
>>>>>>>
>>>>>>> As usual, u-boot-mkimage broke again:
>>>>>>
>>>>>> That's weird, I successfully built it for nios2 during my tests.
>>>>>> Can you tell me how I can replicate the issue , so I can test for it to
>>>>>> prevent regression and roll out a patch ?
>>>>>
>>>>> Marek, Ross,
>>>>>
>>>>> Any progress on this? Need any help testing?
>>>>>
>>>> Yeah, how do you replicate this issue ?
>>>>
>>> Hi!
>>
>> Hi!
>>
>>> I am just looking at a similar problem and want to jump into the discussion.
>>> As Ross said, the problem is to not respect host/target -- cc/cflags/ldflags.
>>> So to replicate the issue, you can use a bare minimum build host with no
>>> cross toolchain installed, and I guess all targets will fail to build.
>>
>> Well both ARM and nios2 builds for me, so I wonder what sort of stupid
>> thing am I doing.
> 
> Well, that's the thing - your patches didn't change anything around toolchain, 
> so it shouldn't break what used to be working before, right? Unless it was 
> already broken...

That's correct ... unless it got broken between 2016.03 and 2016.09 in
U-Boot upstream.

> Ross,
> 
> Care to elaborate on what is breaking for you and what setup you are using?

Please do, indeed.

>>> As this has been broken so many times, I want to discuss some possible fixes:
>>> In the top level Makefile we have:
>>> HOSTCC = cc
>>> HOSTCFLAGS = ...
>>> The problem is, you cannot properly override those variables, as they get used
>>> a lot to do different things, e.g. in tools/Makefile we have (for cross tools
>>> target) HOSTCC = $(CC) and for HOSTCFLAGS we have appends for configuration. 
>>> Thats why we have the current workaround with a squashed override. I see many
>>> possible solutions and would like to hear your opinion:
>>> 1. Make top level Makefile HOST assignments conditional "?="
>>>    - easy
>>>    - will probably not be accepted upstream
>>
>> Why ?
> 
> Heh, good one! :)
> 
> 
>>> 2. add "override" to appends in sublevel Makefiles
>>>    - adds complexity/one level of override hierarchy
>>> 3. Don't use appends for those variables (like in the kernel Makefile), overrides
>>>    in the recipe
>>>    - clean
>>>    - quite some rework in uboot
>>
>> Can you provide details ?
>>
>>> 4. Hack around in the recipe with class overrides and exports
>>>    - quickfix, no patch required
>>>    - fails easily in the future
>>>
>>> Any thoughts?
>>> Stefan
>>>
>>
>>
>> -- 
>> Best regards,
>> Marek Vasut
>>


-- 
Best regards,
Marek Vasut

Re: [PATCH 1/4] u-boot: Update to 2016.09.01 release

[Khem Raj]

[-- Attachment #1: Type: text/plain, Size: 3560 bytes --]


> On Oct 27, 2016, at 5:18 PM, Marek Vasut <marex@denx.de> wrote:
> 
> On 10/27/2016 01:44 PM, Stefan Müller-Klieser wrote:
>> On 25.10.2016 21:24, Marek Vasut wrote:
>>> On 10/25/2016 08:32 PM, Denys Dmytriyenko wrote:
>>>> On Sat, Oct 22, 2016 at 10:32:12PM +0200, Marek Vasut wrote:
>>>>> On 10/21/2016 09:47 AM, Burton, Ross wrote:
>>>>> 
>>>>> Hi!
>>>>> 
>>>>>> On 20 October 2016 at 14:35, Marek Vasut <marex@denx.de
>>>>>> <mailto:marex@denx.de>> wrote:
>>>>>> 
>>>>>>    Upgrade U-Boot to the latest version.
>>>>>> 
>>>>>> 
>>>>>> As usual, u-boot-mkimage broke again:
>>>>> 
>>>>> That's weird, I successfully built it for nios2 during my tests.
>>>>> Can you tell me how I can replicate the issue , so I can test for it to
>>>>> prevent regression and roll out a patch ?
>>>> 
>>>> Marek, Ross,
>>>> 
>>>> Any progress on this? Need any help testing?
>>>> 
>>> Yeah, how do you replicate this issue ?
>>> 
>> Hi!
> 
> Hi!
> 
>> I am just looking at a similar problem and want to jump into the discussion.
>> As Ross said, the problem is to not respect host/target -- cc/cflags/ldflags.
>> So to replicate the issue, you can use a bare minimum build host with no
>> cross toolchain installed, and I guess all targets will fail to build.
> 
> Well both ARM and nios2 builds for me, so I wonder what sort of stupid
> thing am I doing.


perhaps, its manifesting when toolchain is used from sstate, moreover the sstate
comes from a mirror which is populated from a workspace which has different
build time paths, which means its encoding a different default sysroot into
toolchain. So unless you add TOOLCHAIN_OPTIONS to the CC and its ilk
you will have issues.

May be you can reproduce it by

1. build first time ./oe-init-build-env /path/to/build1
2. Now set another builddir may be using ./oe-init-build-env /path/to/build2
3. Add a SSTATE_MIRROR pointing to sstate from first builddir add below to local.conf

SSTATE_MIRRORS ?= "\
file://.* file:///path/to/build1/sstate-cache/PATH”

4. bitbake <package>
5. bitbake -ccleansstate <package>
6. bitbake package



> 
>> As this has been broken so many times, I want to discuss some possible fixes:
>> In the top level Makefile we have:
>> HOSTCC = cc
>> HOSTCFLAGS = ...
>> The problem is, you cannot properly override those variables, as they get used
>> a lot to do different things, e.g. in tools/Makefile we have (for cross tools
>> target) HOSTCC = $(CC) and for HOSTCFLAGS we have appends for configuration.
>> Thats why we have the current workaround with a squashed override. I see many
>> possible solutions and would like to hear your opinion:
>> 1. Make top level Makefile HOST assignments conditional "?="
>>   - easy
>>   - will probably not be accepted upstream
> 
> Why ?
> 
>> 2. add "override" to appends in sublevel Makefiles
>>   - adds complexity/one level of override hierarchy
>> 3. Don't use appends for those variables (like in the kernel Makefile), overrides
>>   in the recipe
>>   - clean
>>   - quite some rework in uboot
> 
> Can you provide details ?
> 
>> 4. Hack around in the recipe with class overrides and exports
>>   - quickfix, no patch required
>>   - fails easily in the future
>> 
>> Any thoughts?
>> Stefan
>> 
> 
> 
> --
> Best regards,
> Marek Vasut
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core


[-- Attachment #2: Message signed with OpenPGP using GPGMail --]
[-- Type: application/pgp-signature, Size: 211 bytes --]

Re: [PATCH 1/4] u-boot: Update to 2016.09.01 release

[Burton, Ross]

[-- Attachment #1: Type: text/plain, Size: 605 bytes --]

On 28 October 2016 at 03:14, Marek Vasut <marex@denx.de> wrote:

> > Ross,
> >
> > Care to elaborate on what is breaking for you and what setup you are
> using?
>
> Please do, indeed.


Sorry, I was away for a week and my out-of-office only fires for @intel.com
senders to avoid spamming the mailing list. :)

This was doing a build of *target* u-boot-mkimage for qemux86-64.  I
suspect that this autobuilder was running on Debian as Debian doesn't have
a /lib/lib-linux-x86-64 but oe-core does, so a binary built for x86-64
oe-core may work on some distributions but not others.

Ross

[-- Attachment #2: Type: text/html, Size: 1143 bytes --]

Re: [PATCH 1/4] u-boot: Update to 2016.09.01 release

[Marek Vasut]

On 10/28/2016 05:16 PM, Burton, Ross wrote:
> 
> On 28 October 2016 at 03:14, Marek Vasut <marex@denx.de
> <mailto:marex@denx.de>> wrote:
> 
>     > Ross,
>     >
>     > Care to elaborate on what is breaking for you and what setup you are using?
> 
>     Please do, indeed.
> 
> 
> Sorry, I was away for a week and my out-of-office only fires for
> @intel.com <http://intel.com> senders to avoid spamming the mailing list. :)
> 
> This was doing a build of *target* u-boot-mkimage for qemux86-64.  I
> suspect that this autobuilder was running on Debian as Debian doesn't
> have a /lib/lib-linux-x86-64 but oe-core does, so a binary built for
> x86-64 oe-core may work on some distributions but not others.

So the simplest test would be to do the build of native u-boot-mkimage
on, say, centos/fedora ?

-- 
Best regards,
Marek Vasut

Re: [PATCH 1/4] u-boot: Update to 2016.09.01 release

[Marek Vasut]

On 10/28/2016 06:23 AM, Khem Raj wrote:
> 
>> On Oct 27, 2016, at 5:18 PM, Marek Vasut <marex@denx.de> wrote:
>>
>> On 10/27/2016 01:44 PM, Stefan Müller-Klieser wrote:
>>> On 25.10.2016 21:24, Marek Vasut wrote:
>>>> On 10/25/2016 08:32 PM, Denys Dmytriyenko wrote:
>>>>> On Sat, Oct 22, 2016 at 10:32:12PM +0200, Marek Vasut wrote:
>>>>>> On 10/21/2016 09:47 AM, Burton, Ross wrote:
>>>>>>
>>>>>> Hi!
>>>>>>
>>>>>>> On 20 October 2016 at 14:35, Marek Vasut <marex@denx.de
>>>>>>> <mailto:marex@denx.de>> wrote:
>>>>>>>
>>>>>>>    Upgrade U-Boot to the latest version.
>>>>>>>
>>>>>>>
>>>>>>> As usual, u-boot-mkimage broke again:
>>>>>>
>>>>>> That's weird, I successfully built it for nios2 during my tests.
>>>>>> Can you tell me how I can replicate the issue , so I can test for it to
>>>>>> prevent regression and roll out a patch ?
>>>>>
>>>>> Marek, Ross,
>>>>>
>>>>> Any progress on this? Need any help testing?
>>>>>
>>>> Yeah, how do you replicate this issue ?
>>>>
>>> Hi!
>>
>> Hi!
>>
>>> I am just looking at a similar problem and want to jump into the discussion.
>>> As Ross said, the problem is to not respect host/target -- cc/cflags/ldflags.
>>> So to replicate the issue, you can use a bare minimum build host with no
>>> cross toolchain installed, and I guess all targets will fail to build.
>>
>> Well both ARM and nios2 builds for me, so I wonder what sort of stupid
>> thing am I doing.
> 
> 
> perhaps, its manifesting when toolchain is used from sstate, moreover the sstate
> comes from a mirror which is populated from a workspace which has different
> build time paths, which means its encoding a different default sysroot into
> toolchain. So unless you add TOOLCHAIN_OPTIONS to the CC and its ilk
> you will have issues.
> 
> May be you can reproduce it by
> 
> 1. build first time ./oe-init-build-env /path/to/build1
> 2. Now set another builddir may be using ./oe-init-build-env /path/to/build2
> 3. Add a SSTATE_MIRROR pointing to sstate from first builddir add below to local.conf
> 
> SSTATE_MIRRORS ?= "\
> file://.* file:///path/to/build1/sstate-cache/PATH”
> 
> 4. bitbake <package>
> 5. bitbake -ccleansstate <package>
> 6. bitbake package

This seems pretty convoluted. If I understand Ross correctly, it might
be easier to just try the build on centos?

-- 
Best regards,
Marek Vasut

Re: [PATCH 1/4] u-boot: Update to 2016.09.01 release

[Burton, Ross]

[-- Attachment #1: Type: text/plain, Size: 323 bytes --]

On 30 October 2016 at 18:18, Marek Vasut <marex@denx.de> wrote:

> So the simplest test would be to do the build of native u-boot-mkimage
> on, say, centos/fedora ?
>

No, a build on Debian (I've just replicated this on my own debian build
machine).  Literally just "bitbake u-boot-mkimage" fails to build.

Ross

[-- Attachment #2: Type: text/html, Size: 735 bytes --]

Re: [PATCH 1/4] u-boot: Update to 2016.09.01 release

[Marek Vasut]

On 10/31/2016 03:59 PM, Burton, Ross wrote:
> 
> On 30 October 2016 at 18:18, Marek Vasut <marex@denx.de
> <mailto:marex@denx.de>> wrote:
> 
>     So the simplest test would be to do the build of native u-boot-mkimage
>     on, say, centos/fedora ?
> 
> 
> No, a build on Debian (I've just replicated this on my own debian build
> machine).  Literally just "bitbake u-boot-mkimage" fails to build.

Got it, replicated, thanks.

I sent a patch, see if that works for you.

-- 
Best regards,
Marek Vasut