From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: "allen-kh.cheng" <allen-kh.cheng@mediatek.com>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Cc: Lala Lin <lala.lin@mediatek.com>,
Project_Global_Chrome_Upstream_Group@mediatek.com,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
Chen-Yu Tsai <wenst@chromium.org>,
Ryder Lee <ryder.lee@kernel.org>
Subject: Re: [PATCH v2 1/1] dt-bindings: nvmem: mediatek: Convert mtk-efuse binding to YAML
Date: Tue, 26 Apr 2022 08:31:13 +0200 [thread overview]
Message-ID: <0169c4ac-fdce-29b7-553a-14dc7df532d1@linaro.org> (raw)
In-Reply-To: <9d65b713e3ffdd34dcca532c4c97fa98b124bde4.camel@mediatek.com>
On 26/04/2022 08:23, allen-kh.cheng wrote:
>>> +properties:
>>> + compatible:
>>> + oneOf:
>>> + - enum:
>>> + - mediatek,mt8173-efuse
>>> + - mediatek,efuse
>>
>> Still no changes...
>>
>
> I just want to confirm again.
>
> "Generic compatibles should not be used standalone"
>
> It seems we should remove mediatek,efuse and keep "mediatek,mt8173-
> efuse"in binding. have I got that right?
You should comment for which chipsets this compatible is and add a
deprecated:true. In such case it cannot be part of enum but separate
item in this oneOf.
Best regards,
Krzysztof
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: "allen-kh.cheng" <allen-kh.cheng@mediatek.com>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Cc: Lala Lin <lala.lin@mediatek.com>,
Project_Global_Chrome_Upstream_Group@mediatek.com,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
Chen-Yu Tsai <wenst@chromium.org>,
Ryder Lee <ryder.lee@kernel.org>
Subject: Re: [PATCH v2 1/1] dt-bindings: nvmem: mediatek: Convert mtk-efuse binding to YAML
Date: Tue, 26 Apr 2022 08:31:13 +0200 [thread overview]
Message-ID: <0169c4ac-fdce-29b7-553a-14dc7df532d1@linaro.org> (raw)
In-Reply-To: <9d65b713e3ffdd34dcca532c4c97fa98b124bde4.camel@mediatek.com>
On 26/04/2022 08:23, allen-kh.cheng wrote:
>>> +properties:
>>> + compatible:
>>> + oneOf:
>>> + - enum:
>>> + - mediatek,mt8173-efuse
>>> + - mediatek,efuse
>>
>> Still no changes...
>>
>
> I just want to confirm again.
>
> "Generic compatibles should not be used standalone"
>
> It seems we should remove mediatek,efuse and keep "mediatek,mt8173-
> efuse"in binding. have I got that right?
You should comment for which chipsets this compatible is and add a
deprecated:true. In such case it cannot be part of enum but separate
item in this oneOf.
Best regards,
Krzysztof
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: "allen-kh.cheng" <allen-kh.cheng@mediatek.com>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Cc: Lala Lin <lala.lin@mediatek.com>,
Project_Global_Chrome_Upstream_Group@mediatek.com,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
Chen-Yu Tsai <wenst@chromium.org>,
Ryder Lee <ryder.lee@kernel.org>
Subject: Re: [PATCH v2 1/1] dt-bindings: nvmem: mediatek: Convert mtk-efuse binding to YAML
Date: Tue, 26 Apr 2022 08:31:13 +0200 [thread overview]
Message-ID: <0169c4ac-fdce-29b7-553a-14dc7df532d1@linaro.org> (raw)
In-Reply-To: <9d65b713e3ffdd34dcca532c4c97fa98b124bde4.camel@mediatek.com>
On 26/04/2022 08:23, allen-kh.cheng wrote:
>>> +properties:
>>> + compatible:
>>> + oneOf:
>>> + - enum:
>>> + - mediatek,mt8173-efuse
>>> + - mediatek,efuse
>>
>> Still no changes...
>>
>
> I just want to confirm again.
>
> "Generic compatibles should not be used standalone"
>
> It seems we should remove mediatek,efuse and keep "mediatek,mt8173-
> efuse"in binding. have I got that right?
You should comment for which chipsets this compatible is and add a
deprecated:true. In such case it cannot be part of enum but separate
item in this oneOf.
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-04-26 6:31 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-25 8:47 [PATCH v2 0/1] dt-bindings: nvmem: mediatek: Convert mtk-efuse binding to YAML Allen-KH Cheng
2022-04-25 8:47 ` Allen-KH Cheng
2022-04-25 8:47 ` Allen-KH Cheng
2022-04-25 8:48 ` [PATCH v2 1/1] " Allen-KH Cheng
2022-04-25 8:48 ` Allen-KH Cheng
2022-04-25 8:48 ` Allen-KH Cheng
2022-04-25 16:38 ` Krzysztof Kozlowski
2022-04-25 16:38 ` Krzysztof Kozlowski
2022-04-25 16:38 ` Krzysztof Kozlowski
2022-04-26 6:23 ` allen-kh.cheng
2022-04-26 6:23 ` allen-kh.cheng
2022-04-26 6:31 ` Krzysztof Kozlowski [this message]
2022-04-26 6:31 ` Krzysztof Kozlowski
2022-04-26 6:31 ` Krzysztof Kozlowski
2022-04-26 10:02 ` allen-kh.cheng
2022-04-26 10:02 ` allen-kh.cheng
2022-04-26 10:14 ` Krzysztof Kozlowski
2022-04-26 10:14 ` Krzysztof Kozlowski
2022-04-26 10:14 ` Krzysztof Kozlowski
2022-04-27 9:28 ` allen-kh.cheng
2022-04-27 9:28 ` allen-kh.cheng
2022-04-27 9:39 ` Krzysztof Kozlowski
2022-04-27 9:39 ` Krzysztof Kozlowski
2022-04-27 9:39 ` Krzysztof Kozlowski
2022-04-27 10:00 ` allen-kh.cheng
2022-04-27 10:00 ` allen-kh.cheng
2022-04-27 13:53 ` Krzysztof Kozlowski
2022-04-27 13:53 ` Krzysztof Kozlowski
2022-04-27 13:53 ` Krzysztof Kozlowski
2022-04-27 14:00 ` allen-kh.cheng
2022-04-27 14:00 ` allen-kh.cheng
2022-04-26 10:03 ` allen-kh.cheng
2022-04-26 10:03 ` allen-kh.cheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0169c4ac-fdce-29b7-553a-14dc7df532d1@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=allen-kh.cheng@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski@canonical.com \
--cc=lala.lin@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=ryder.lee@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=wenst@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.