From: Nicolas Saenz Julienne <nsaenzjulienne@suse.de> To: Amit Pundir <amit.pundir@linaro.org> Cc: Christoph Hellwig <hch@lst.de>, Marek Szyprowski <m.szyprowski@samsung.com>, Robin Murphy <robin.murphy@arm.com>, David Rientjes <rientjes@google.com>, linux-rpi-kernel@lists.infradead.org, jeremy.linton@arm.com, iommu@lists.linux-foundation.org, lkml <linux-kernel@vger.kernel.org>, John Stultz <john.stultz@linaro.org>, Sumit Semwal <sumit.semwal@linaro.org> Subject: Re: [PATCH] dma-pool: Do not allocate pool memory from CMA Date: Tue, 21 Jul 2020 14:45:07 +0200 [thread overview] Message-ID: <01831596e4a2a6c9c066138b23bd30435f8e5569.camel@suse.de> (raw) In-Reply-To: <CAMi1Hd0=ZsGhTkSy221EP9Vb3GMOcS0UMczX2u5X9qK37_ea1A@mail.gmail.com> On Tue, 2020-07-21 at 17:45 +0530, Amit Pundir wrote: > On Tue, 21 Jul 2020 at 16:45, Nicolas Saenz Julienne > <nsaenzjulienne@suse.de> wrote: > > On Tue, 2020-07-21 at 14:24 +0530, Amit Pundir wrote: > > > On Tue, 21 Jul 2020 at 14:09, Nicolas Saenz Julienne > > > <nsaenzjulienne@suse.de> wrote: > > > > Hi Amit, > > > > > Hi Nicolas, > > > > > > > > > > I see a boot regression with this commit d9765e41d8e9 "dma- > > > > > pool: > > > > > Do not allocate pool memory from CMA" on my Xiaomi Poco F1 > > > > > (Qcom sdm845) phone running v5.8-rc6. I can't boot past the > > > > > bootloader splash screen with this patch. > > > > > > > > > > Phone boots fine if I revert this patch. I carry only one out > > > > > of > > > > > tree > > > > > dts patch https://lkml.org/lkml/2020/6/25/52. And since this > > > > > is a > > > > > stock > > > > > phone, I don't have access to serial/dmesg logs until I boot > > > > > to > > > > > AOSP > > > > > (adb) shell. > > > > > > > > > > Any thoughts as to what might be going wrong here? I'd be > > > > > happy > > > > > to > > > > > help debug things. For what it's worth, I don't see this > > > > > regression > > > > > on > > > > > other two sdm845 devices (db845c and Pixel 3) I tested on. > > > > > > > > Can you provide a boot log (even if without my patch) and the > > > > device- > > > > tree files? It'd help a lot figuring things out. > > > > > > Thank you for the prompt reply Nicolas. > > > > > > Here is the boot log with the reverted patch > > > https://pastebin.ubuntu.com/p/BrhPf83nKF/ > > > > > > Here is my phone's dts > > > https://github.com/pundiramit/linux/commit/2a394c199deeaf4c91e0e008e8fba2a72f494d8c > > > > I'm at loss at what could be failing here. Your device should be > > able > > to address the whole 8GB memory space, which AFAIK is the max > > available > > on that smartphone family. But maybe the device-tree is lying, who > > knows... > > If it helps, my phone has 6GB memory space. > > > Can you try booting *without* my patch and this in the kernel > > command > > line: "cma=16M@0x100000000-0x200000000". > > It doesn't boot with this added kernel command line. For the record, this placed the CMA in the [4GB, 8GB] address space instead of you setup's default: [3GB, 4GB]. All atomic pools fall in that memory area without my patch, which makes me think some of the devices on your board might not like higher addresses. What happens if you boot with my troublesome patch with this in your device tree? (insert it at the bottom of sdm845-beryllium.dts) &soc { dma-ranges = <0 0 0 0 0x1 0>; }; Regards, Nicolas > Regards, > Amit Pundir > > > Regards, > > Nicolas > > > > And here is my kernel tree just in case > > > https://github.com/pundiramit/linux/commits/beryllium-mainline > > > > > > Regards, > > > Amit Pundir > > > > > > > > > > Regards, > > > > Nicolas > > > > > > > > > Regards, > > > > > Amit Pundir > > > > > > > > > > > Reported-by: Jeremy Linton <jeremy.linton@arm.com> > > > > > > Signed-off-by: Nicolas Saenz Julienne < > > > > > > nsaenzjulienne@suse.de> > > > > > > --- > > > > > > > > > > > > An more costly alternative would be adding an option to > > > > > > dma_alloc_from_contiguous() so it fails when the allocation > > > > > > doesn't > > > > > > fall > > > > > > in a specific zone. > > > > > > > > > > > > kernel/dma/pool.c | 11 ++---------
WARNING: multiple messages have this Message-ID (diff)
From: Nicolas Saenz Julienne <nsaenzjulienne@suse.de> To: Amit Pundir <amit.pundir@linaro.org> Cc: lkml <linux-kernel@vger.kernel.org>, jeremy.linton@arm.com, Sumit Semwal <sumit.semwal@linaro.org>, iommu@lists.linux-foundation.org, John Stultz <john.stultz@linaro.org>, linux-rpi-kernel@lists.infradead.org, David Rientjes <rientjes@google.com>, Robin Murphy <robin.murphy@arm.com>, Christoph Hellwig <hch@lst.de> Subject: Re: [PATCH] dma-pool: Do not allocate pool memory from CMA Date: Tue, 21 Jul 2020 14:45:07 +0200 [thread overview] Message-ID: <01831596e4a2a6c9c066138b23bd30435f8e5569.camel@suse.de> (raw) In-Reply-To: <CAMi1Hd0=ZsGhTkSy221EP9Vb3GMOcS0UMczX2u5X9qK37_ea1A@mail.gmail.com> On Tue, 2020-07-21 at 17:45 +0530, Amit Pundir wrote: > On Tue, 21 Jul 2020 at 16:45, Nicolas Saenz Julienne > <nsaenzjulienne@suse.de> wrote: > > On Tue, 2020-07-21 at 14:24 +0530, Amit Pundir wrote: > > > On Tue, 21 Jul 2020 at 14:09, Nicolas Saenz Julienne > > > <nsaenzjulienne@suse.de> wrote: > > > > Hi Amit, > > > > > Hi Nicolas, > > > > > > > > > > I see a boot regression with this commit d9765e41d8e9 "dma- > > > > > pool: > > > > > Do not allocate pool memory from CMA" on my Xiaomi Poco F1 > > > > > (Qcom sdm845) phone running v5.8-rc6. I can't boot past the > > > > > bootloader splash screen with this patch. > > > > > > > > > > Phone boots fine if I revert this patch. I carry only one out > > > > > of > > > > > tree > > > > > dts patch https://lkml.org/lkml/2020/6/25/52. And since this > > > > > is a > > > > > stock > > > > > phone, I don't have access to serial/dmesg logs until I boot > > > > > to > > > > > AOSP > > > > > (adb) shell. > > > > > > > > > > Any thoughts as to what might be going wrong here? I'd be > > > > > happy > > > > > to > > > > > help debug things. For what it's worth, I don't see this > > > > > regression > > > > > on > > > > > other two sdm845 devices (db845c and Pixel 3) I tested on. > > > > > > > > Can you provide a boot log (even if without my patch) and the > > > > device- > > > > tree files? It'd help a lot figuring things out. > > > > > > Thank you for the prompt reply Nicolas. > > > > > > Here is the boot log with the reverted patch > > > https://pastebin.ubuntu.com/p/BrhPf83nKF/ > > > > > > Here is my phone's dts > > > https://github.com/pundiramit/linux/commit/2a394c199deeaf4c91e0e008e8fba2a72f494d8c > > > > I'm at loss at what could be failing here. Your device should be > > able > > to address the whole 8GB memory space, which AFAIK is the max > > available > > on that smartphone family. But maybe the device-tree is lying, who > > knows... > > If it helps, my phone has 6GB memory space. > > > Can you try booting *without* my patch and this in the kernel > > command > > line: "cma=16M@0x100000000-0x200000000". > > It doesn't boot with this added kernel command line. For the record, this placed the CMA in the [4GB, 8GB] address space instead of you setup's default: [3GB, 4GB]. All atomic pools fall in that memory area without my patch, which makes me think some of the devices on your board might not like higher addresses. What happens if you boot with my troublesome patch with this in your device tree? (insert it at the bottom of sdm845-beryllium.dts) &soc { dma-ranges = <0 0 0 0 0x1 0>; }; Regards, Nicolas > Regards, > Amit Pundir > > > Regards, > > Nicolas > > > > And here is my kernel tree just in case > > > https://github.com/pundiramit/linux/commits/beryllium-mainline > > > > > > Regards, > > > Amit Pundir > > > > > > > > > > Regards, > > > > Nicolas > > > > > > > > > Regards, > > > > > Amit Pundir > > > > > > > > > > > Reported-by: Jeremy Linton <jeremy.linton@arm.com> > > > > > > Signed-off-by: Nicolas Saenz Julienne < > > > > > > nsaenzjulienne@suse.de> > > > > > > --- > > > > > > > > > > > > An more costly alternative would be adding an option to > > > > > > dma_alloc_from_contiguous() so it fails when the allocation > > > > > > doesn't > > > > > > fall > > > > > > in a specific zone. > > > > > > > > > > > > kernel/dma/pool.c | 11 ++--------- _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2020-07-21 12:45 UTC|newest] Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-07-08 16:49 [PATCH] dma-pool: Do not allocate pool memory from CMA Nicolas Saenz Julienne 2020-07-08 16:49 ` Nicolas Saenz Julienne 2020-07-08 16:58 ` Christoph Hellwig 2020-07-08 16:58 ` Christoph Hellwig 2020-07-08 23:14 ` Jeremy Linton 2020-07-08 23:14 ` Jeremy Linton 2020-07-09 21:47 ` David Rientjes 2020-07-09 21:47 ` David Rientjes via iommu 2020-07-21 7:21 ` Amit Pundir 2020-07-21 7:21 ` Amit Pundir 2020-07-21 8:39 ` Nicolas Saenz Julienne 2020-07-21 8:39 ` Nicolas Saenz Julienne 2020-07-21 8:54 ` Amit Pundir 2020-07-21 8:54 ` Amit Pundir 2020-07-21 11:15 ` Nicolas Saenz Julienne 2020-07-21 11:15 ` Nicolas Saenz Julienne 2020-07-21 11:28 ` Christoph Hellwig 2020-07-21 11:28 ` Christoph Hellwig 2020-07-21 11:37 ` Nicolas Saenz Julienne 2020-07-21 11:37 ` Nicolas Saenz Julienne 2020-07-21 12:16 ` Amit Pundir 2020-07-21 12:16 ` Amit Pundir 2020-07-21 12:15 ` Amit Pundir 2020-07-21 12:15 ` Amit Pundir 2020-07-21 12:45 ` Nicolas Saenz Julienne [this message] 2020-07-21 12:45 ` Nicolas Saenz Julienne 2020-07-21 15:22 ` Amit Pundir 2020-07-21 15:22 ` Amit Pundir 2020-07-21 16:27 ` Nicolas Saenz Julienne 2020-07-21 16:27 ` Nicolas Saenz Julienne 2020-07-23 5:14 ` Amit Pundir 2020-07-23 5:14 ` Amit Pundir 2020-07-24 9:36 ` Nicolas Saenz Julienne 2020-07-24 9:36 ` Nicolas Saenz Julienne 2020-07-24 11:06 ` Amit Pundir 2020-07-24 11:06 ` Amit Pundir 2020-07-24 13:41 ` Christoph Hellwig 2020-07-24 13:41 ` Christoph Hellwig 2020-07-24 16:19 ` Amit Pundir 2020-07-24 16:19 ` Amit Pundir 2020-07-24 16:27 ` Christoph Hellwig 2020-07-24 16:27 ` Christoph Hellwig 2020-07-27 17:56 ` Nicolas Saenz Julienne 2020-07-27 17:56 ` Nicolas Saenz Julienne 2020-07-28 9:13 ` Christoph Hellwig 2020-07-28 9:13 ` Christoph Hellwig 2020-07-28 9:30 ` Nicolas Saenz Julienne 2020-07-28 9:30 ` Nicolas Saenz Julienne 2020-07-28 10:09 ` Christoph Hellwig 2020-07-28 10:09 ` Christoph Hellwig 2020-07-31 1:10 ` Nathan Chancellor 2020-07-31 1:10 ` Nathan Chancellor 2020-07-31 7:19 ` Amit Pundir 2020-07-31 7:19 ` Amit Pundir 2020-07-31 10:09 ` Nicolas Saenz Julienne 2020-07-31 10:09 ` Nicolas Saenz Julienne
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=01831596e4a2a6c9c066138b23bd30435f8e5569.camel@suse.de \ --to=nsaenzjulienne@suse.de \ --cc=amit.pundir@linaro.org \ --cc=hch@lst.de \ --cc=iommu@lists.linux-foundation.org \ --cc=jeremy.linton@arm.com \ --cc=john.stultz@linaro.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-rpi-kernel@lists.infradead.org \ --cc=m.szyprowski@samsung.com \ --cc=rientjes@google.com \ --cc=robin.murphy@arm.com \ --cc=sumit.semwal@linaro.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.