From: Shannon Nelson <snelson@pensando.io>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Luis Chamberlain <mcgrof@kernel.org>,
jeyu@kernel.org, akpm@linux-foundation.org, arnd@arndb.de,
rostedt@goodmis.org, mingo@redhat.com, aquini@redhat.com,
cai@lca.pw, dyoung@redhat.com, bhe@redhat.com,
peterz@infradead.org, tglx@linutronix.de, gpiccoli@canonical.com,
pmladek@suse.com, tiwai@suse.de, schlad@suse.de,
andriy.shevchenko@linux.intel.com, keescook@chromium.org,
daniel.vetter@ffwll.ch, will@kernel.org,
mchehab+samsung@kernel.org, kvalo@codeaurora.org,
davem@davemloft.net, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 00/15] net: taint when the device driver firmware crashes
Date: Sat, 9 May 2020 19:15:23 -0700 [thread overview]
Message-ID: <01831b19-5890-e7e0-3801-068dfab5c92a@pensando.io> (raw)
In-Reply-To: <20200510015814.GE362499@lunn.ch>
On 5/9/20 6:58 PM, Andrew Lunn wrote:
> On Sat, May 09, 2020 at 06:01:51PM -0700, Shannon Nelson wrote:
>> On 5/8/20 9:35 PM, Luis Chamberlain wrote:
>>> Device driver firmware can crash, and sometimes, this can leave your
>>> system in a state which makes the device or subsystem completely
>>> useless. Detecting this by inspecting /proc/sys/kernel/tainted instead
>>> of scraping some magical words from the kernel log, which is driver
>>> specific, is much easier. So instead this series provides a helper which
>>> lets drivers annotate this and shows how to use this on networking
>>> drivers.
>>>
>> If the driver is able to detect that the device firmware has come back
>> alive, through user intervention or whatever, should there be a way to
>> "untaint" the kernel? Or would you expect it to remain tainted?
> Hi Shannon
>
> In general, you don't want to be able to untained. Say a non-GPL
> licenced module is loaded, which taints the kernel. It might then try
> to untaint the kernel to hide its.
Yeah, obviously we don't want this to be abuseable. I was just
wondering about reversing this particular status if the broken device
could get itself fixed.
>
> As for firmware, how much damage can the firmware do as it crashed? If
> it is a DMA master, it could of splattered stuff through
> memory. Restarting the firmware is not going to reverse the damage it
> has done.
>
True, and tho' the driver might get the thing restarted, it wouldn't
necessarily know what kind of damage had ensued.
Carry on,
sln
next prev parent reply other threads:[~2020-05-10 2:20 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-09 4:35 [PATCH 00/15] net: taint when the device driver firmware crashes Luis Chamberlain
2020-05-09 4:35 ` [PATCH 01/15] taint: add module firmware crash taint support Luis Chamberlain
2020-05-09 15:18 ` Rafael Aquini
2020-05-09 16:46 ` Luis Chamberlain
2020-05-10 2:19 ` Randy Dunlap
2020-05-09 4:35 ` [PATCH 02/15] ethernet/839: use new module_firmware_crashed() Luis Chamberlain
2020-05-09 4:35 ` [PATCH 03/15] bnx2x: " Luis Chamberlain
2020-05-09 4:35 ` [PATCH 04/15] bnxt: " Luis Chamberlain
2020-05-09 4:35 ` [PATCH 05/15] bna: " Luis Chamberlain
2020-05-09 4:35 ` [PATCH 06/15] liquidio: " Luis Chamberlain
2020-05-09 4:35 ` [PATCH 07/15] cxgb4: " Luis Chamberlain
2020-05-09 4:35 ` [PATCH 08/15] ehea: " Luis Chamberlain
2020-05-09 4:35 ` [PATCH 09/15] qed: " Luis Chamberlain
2020-05-09 6:32 ` [EXT] " Igor Russkikh
2020-05-09 16:42 ` Luis Chamberlain
2020-05-12 16:23 ` Igor Russkikh
2020-05-12 17:34 ` Luis Chamberlain
2020-05-14 14:53 ` Igor Russkikh
2020-05-15 20:32 ` Luis Chamberlain
2020-05-15 20:37 ` Igor Russkikh
2020-05-09 4:35 ` [PATCH 10/15] soc: qcom: ipa: " Luis Chamberlain
2020-05-09 4:35 ` [PATCH 11/15] wimax/i2400m: " Luis Chamberlain
2020-05-09 4:35 ` [PATCH 12/15] ath10k: " Luis Chamberlain
2020-05-09 4:35 ` Luis Chamberlain
2020-05-09 4:35 ` [PATCH 13/15] ath6kl: " Luis Chamberlain
2020-05-09 4:35 ` Luis Chamberlain
2020-05-09 4:35 ` [PATCH 14/15] brcm80211: " Luis Chamberlain
2020-05-09 4:35 ` [PATCH 15/15] mwl8k: " Luis Chamberlain
2020-05-09 18:35 ` [PATCH 00/15] net: taint when the device driver firmware crashes Jakub Kicinski
2020-05-11 14:11 ` Luis Chamberlain
2020-05-10 1:01 ` Shannon Nelson
2020-05-10 1:58 ` Andrew Lunn
2020-05-10 2:15 ` Shannon Nelson [this message]
2020-05-11 14:13 ` Luis Chamberlain
2020-05-11 19:21 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=01831b19-5890-e7e0-3801-068dfab5c92a@pensando.io \
--to=snelson@pensando.io \
--cc=akpm@linux-foundation.org \
--cc=andrew@lunn.ch \
--cc=andriy.shevchenko@linux.intel.com \
--cc=aquini@redhat.com \
--cc=arnd@arndb.de \
--cc=bhe@redhat.com \
--cc=cai@lca.pw \
--cc=daniel.vetter@ffwll.ch \
--cc=davem@davemloft.net \
--cc=dyoung@redhat.com \
--cc=gpiccoli@canonical.com \
--cc=jeyu@kernel.org \
--cc=keescook@chromium.org \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=mchehab+samsung@kernel.org \
--cc=mingo@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=schlad@suse.de \
--cc=tglx@linutronix.de \
--cc=tiwai@suse.de \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.