From: gengdongjiu <gengdongjiu@huawei.com>
To: James Morse <james.morse@arm.com>
Cc: "christoffer.dall@arm.com" <christoffer.dall@arm.com>,
"marc.zyngier@arm.com" <marc.zyngier@arm.com>,
"suzuki.poulose@arm.com" <suzuki.poulose@arm.com>,
"peter.maydell@linaro.org" <peter.maydell@linaro.org>,
"drjones@redhat.com" <drjones@redhat.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"kvmarm@lists.cs.columbia.edu" <kvmarm@lists.cs.columbia.edu>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>
Subject: Re: [PATCH v3 2/2] arm/arm64: KVM: enable 32 bits kvm vcpu events support
Date: Fri, 12 Oct 2018 15:36:14 +0000 [thread overview]
Message-ID: <0184EA26B2509940AA629AE1405DD7F201ECC805@dggema523-mbx.china.huawei.com> (raw)
Hi James,
> Hi Dongjiu Geng,
>
> On 11/10/2018 20:07, Dongjiu Geng wrote:
> > The commit 539aee0edb9f ("KVM: arm64: Share the parts of get/set
> > events useful to 32bit") shares the get/set events helper for arm64
> > and arm32,
>
> Oops. I evidently didn't test this bit. Looks like I just depended on the symbol to be defined, I didn't check the CAP was exposed.
Yes, you do not check the CAP when you test it.
>
>
> > it is better also share the check
> > for vcpu events capability to enable 32 bit kvm vcpu events support.
>
> not just better, necessary for correctly-written user-space to know the feature is supported. This last bit would be clearer as: "but forgot to
> share the cap extension code."
Ok, will update it.
>
>
> Thanks for catching this!
You are welcome
>
> Acked-by: James Morse <james.morse@arm.com>
>
>
> Thanks,
>
> James
next reply other threads:[~2018-10-12 15:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-12 15:36 gengdongjiu [this message]
2018-10-12 15:36 ` [PATCH v3 2/2] arm/arm64: KVM: enable 32 bits kvm vcpu events support gengdongjiu
-- strict thread matches above, loose matches on Subject: below --
2018-10-11 19:07 [PATCH v3 0/2] rename function name and enable 32bit vcpu events Dongjiu Geng
2018-10-11 19:07 ` [PATCH v3 2/2] arm/arm64: KVM: enable 32 bits kvm vcpu events support Dongjiu Geng
2018-10-11 19:07 ` Dongjiu Geng
2018-10-11 19:07 ` Dongjiu Geng
2018-10-12 11:35 ` James Morse
2018-10-12 11:35 ` James Morse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0184EA26B2509940AA629AE1405DD7F201ECC805@dggema523-mbx.china.huawei.com \
--to=gengdongjiu@huawei.com \
--cc=christoffer.dall@arm.com \
--cc=drjones@redhat.com \
--cc=james.morse@arm.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=peter.maydell@linaro.org \
--cc=suzuki.poulose@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.