* [PATCH v2 1/2] ath10k: Introduce download cal from mtd
@ 2020-09-18 18:11 ` Ansuel Smith
0 siblings, 0 replies; 8+ messages in thread
From: Ansuel Smith @ 2020-09-18 18:11 UTC (permalink / raw)
To: Kalle Valo
Cc: Ansuel Smith, David S. Miller, Jakub Kicinski, Rob Herring,
linux-wireless, netdev, devicetree, linux-kernel, ath10k
Most of routers that have the ath10k wifi chip integrated in the Soc
have the pre-cal data stored in the art (or equivalent) mtd partition.
Introduce a new function to directly extract and use it based on what is
set in the dt if the system have mtd support.
Pre-cal file have still priority to everything else.
Tested-on: QCA9984 hw1.0 PCI 10.4
Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
---
v2:
* Fix missing condition for cal_mode in transposing source to ath repo
drivers/net/wireless/ath/ath10k/core.c | 80 +++++++++++++++++++++++++-
drivers/net/wireless/ath/ath10k/core.h | 3 +
2 files changed, 81 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/ath/ath10k/core.c b/drivers/net/wireless/ath/ath10k/core.c
index 5f4e12196..d35abd16a 100644
--- a/drivers/net/wireless/ath/ath10k/core.c
+++ b/drivers/net/wireless/ath/ath10k/core.c
@@ -13,6 +13,7 @@
#include <linux/ctype.h>
#include <linux/pm_qos.h>
#include <asm/byteorder.h>
+#include <linux/mtd/mtd.h>
#include "core.h"
#include "mac.h"
@@ -918,7 +919,8 @@ static int ath10k_core_get_board_id_from_otp(struct ath10k *ar)
}
if (ar->cal_mode == ATH10K_PRE_CAL_MODE_DT ||
- ar->cal_mode == ATH10K_PRE_CAL_MODE_FILE)
+ ar->cal_mode == ATH10K_PRE_CAL_MODE_FILE ||
+ ar->cal_mode == ATH10K_PRE_CAL_MODE_MTD)
bmi_board_id_param = BMI_PARAM_GET_FLASH_BOARD_ID;
else
bmi_board_id_param = BMI_PARAM_GET_EEPROM_BOARD_ID;
@@ -1680,7 +1682,8 @@ static int ath10k_download_and_run_otp(struct ath10k *ar)
/* As of now pre-cal is valid for 10_4 variants */
if (ar->cal_mode == ATH10K_PRE_CAL_MODE_DT ||
- ar->cal_mode == ATH10K_PRE_CAL_MODE_FILE)
+ ar->cal_mode == ATH10K_PRE_CAL_MODE_FILE ||
+ ar->cal_mode == ATH10K_PRE_CAL_MODE_MTD)
bmi_otp_exe_param = BMI_PARAM_FLASH_SECTION_ALL;
ret = ath10k_bmi_execute(ar, address, bmi_otp_exe_param, &result);
@@ -1701,6 +1704,69 @@ static int ath10k_download_and_run_otp(struct ath10k *ar)
return 0;
}
+static int ath10k_download_cal_mtd(struct ath10k *ar)
+{
+#ifdef CONFIG_MTD
+ struct device_node *node, *mtd_node = NULL;
+ struct mtd_info *mtd;
+ const __be32 *list;
+ u32 offset, size;
+ const char *part;
+ phandle phandle;
+ size_t retlen;
+ char *file;
+ int ret;
+
+ node = ar->dev->of_node;
+ if (!node)
+ return -ENOENT;
+
+ list = of_get_property(node, "qcom,ath10k-pre-calibration-data-mtd", &size);
+ if (!list || (size != (3 * sizeof(*list))))
+ return -EINVAL;
+
+ phandle = be32_to_cpup(list++);
+ if (phandle)
+ mtd_node = of_find_node_by_phandle(phandle);
+
+ if (!mtd_node)
+ return -ENODEV;
+
+ part = of_get_property(mtd_node, "label", NULL);
+ if (!part)
+ part = mtd_node->name;
+
+ mtd = get_mtd_device_nm(part);
+ if (IS_ERR(mtd))
+ return -ENODEV;
+
+ offset = be32_to_cpup(list++);
+ size = be32_to_cpup(list);
+
+ file = kzalloc(size, GFP_KERNEL);
+ if (!file)
+ return -ENOMEM;
+
+ ret = mtd_read(mtd, offset, size, &retlen, file);
+ put_mtd_device(mtd);
+
+ ret = ath10k_download_board_data(ar, file, size);
+ if (ret) {
+ ath10k_err(ar, "failed to download cal_file data: %d\n", ret);
+ goto err;
+ }
+
+ ath10k_dbg(ar, ATH10K_DBG_BOOT, "boot cal file downloaded\n");
+
+ return 0;
+
+err:
+ kfree(file);
+ return ret;
+#endif
+ return -EOPNOTSUPP;
+}
+
static int ath10k_download_cal_file(struct ath10k *ar,
const struct firmware *file)
{
@@ -2047,6 +2113,16 @@ static int ath10k_core_pre_cal_download(struct ath10k *ar)
goto success;
}
+ ath10k_dbg(ar, ATH10K_DBG_BOOT,
+ "boot did not find a pre calibration file, try MTD next: %d\n",
+ ret);
+
+ ret = ath10k_download_cal_mtd(ar);
+ if (ret == 0) {
+ ar->cal_mode = ATH10K_PRE_CAL_MODE_MTD;
+ goto success;
+ }
+
ath10k_dbg(ar, ATH10K_DBG_BOOT,
"boot did not find a pre calibration file, try DT next: %d\n",
ret);
diff --git a/drivers/net/wireless/ath/ath10k/core.h b/drivers/net/wireless/ath/ath10k/core.h
index 4cf5bd489..3ca158605 100644
--- a/drivers/net/wireless/ath/ath10k/core.h
+++ b/drivers/net/wireless/ath/ath10k/core.h
@@ -864,6 +864,7 @@ enum ath10k_cal_mode {
ATH10K_CAL_MODE_OTP,
ATH10K_CAL_MODE_DT,
ATH10K_PRE_CAL_MODE_FILE,
+ ATH10K_PRE_CAL_MODE_MTD,
ATH10K_PRE_CAL_MODE_DT,
ATH10K_CAL_MODE_EEPROM,
};
@@ -886,6 +887,8 @@ static inline const char *ath10k_cal_mode_str(enum ath10k_cal_mode mode)
return "dt";
case ATH10K_PRE_CAL_MODE_FILE:
return "pre-cal-file";
+ case ATH10K_PRE_CAL_MODE_MTD:
+ return "pre-cal-mtd";
case ATH10K_PRE_CAL_MODE_DT:
return "pre-cal-dt";
case ATH10K_CAL_MODE_EEPROM:
--
2.27.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH v2 1/2] ath10k: Introduce download cal from mtd
@ 2020-09-18 18:11 ` Ansuel Smith
0 siblings, 0 replies; 8+ messages in thread
From: Ansuel Smith @ 2020-09-18 18:11 UTC (permalink / raw)
To: Kalle Valo
Cc: devicetree, netdev, linux-wireless, linux-kernel, ath10k,
David S. Miller, Rob Herring, Jakub Kicinski, Ansuel Smith
Most of routers that have the ath10k wifi chip integrated in the Soc
have the pre-cal data stored in the art (or equivalent) mtd partition.
Introduce a new function to directly extract and use it based on what is
set in the dt if the system have mtd support.
Pre-cal file have still priority to everything else.
Tested-on: QCA9984 hw1.0 PCI 10.4
Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
---
v2:
* Fix missing condition for cal_mode in transposing source to ath repo
drivers/net/wireless/ath/ath10k/core.c | 80 +++++++++++++++++++++++++-
drivers/net/wireless/ath/ath10k/core.h | 3 +
2 files changed, 81 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/ath/ath10k/core.c b/drivers/net/wireless/ath/ath10k/core.c
index 5f4e12196..d35abd16a 100644
--- a/drivers/net/wireless/ath/ath10k/core.c
+++ b/drivers/net/wireless/ath/ath10k/core.c
@@ -13,6 +13,7 @@
#include <linux/ctype.h>
#include <linux/pm_qos.h>
#include <asm/byteorder.h>
+#include <linux/mtd/mtd.h>
#include "core.h"
#include "mac.h"
@@ -918,7 +919,8 @@ static int ath10k_core_get_board_id_from_otp(struct ath10k *ar)
}
if (ar->cal_mode == ATH10K_PRE_CAL_MODE_DT ||
- ar->cal_mode == ATH10K_PRE_CAL_MODE_FILE)
+ ar->cal_mode == ATH10K_PRE_CAL_MODE_FILE ||
+ ar->cal_mode == ATH10K_PRE_CAL_MODE_MTD)
bmi_board_id_param = BMI_PARAM_GET_FLASH_BOARD_ID;
else
bmi_board_id_param = BMI_PARAM_GET_EEPROM_BOARD_ID;
@@ -1680,7 +1682,8 @@ static int ath10k_download_and_run_otp(struct ath10k *ar)
/* As of now pre-cal is valid for 10_4 variants */
if (ar->cal_mode == ATH10K_PRE_CAL_MODE_DT ||
- ar->cal_mode == ATH10K_PRE_CAL_MODE_FILE)
+ ar->cal_mode == ATH10K_PRE_CAL_MODE_FILE ||
+ ar->cal_mode == ATH10K_PRE_CAL_MODE_MTD)
bmi_otp_exe_param = BMI_PARAM_FLASH_SECTION_ALL;
ret = ath10k_bmi_execute(ar, address, bmi_otp_exe_param, &result);
@@ -1701,6 +1704,69 @@ static int ath10k_download_and_run_otp(struct ath10k *ar)
return 0;
}
+static int ath10k_download_cal_mtd(struct ath10k *ar)
+{
+#ifdef CONFIG_MTD
+ struct device_node *node, *mtd_node = NULL;
+ struct mtd_info *mtd;
+ const __be32 *list;
+ u32 offset, size;
+ const char *part;
+ phandle phandle;
+ size_t retlen;
+ char *file;
+ int ret;
+
+ node = ar->dev->of_node;
+ if (!node)
+ return -ENOENT;
+
+ list = of_get_property(node, "qcom,ath10k-pre-calibration-data-mtd", &size);
+ if (!list || (size != (3 * sizeof(*list))))
+ return -EINVAL;
+
+ phandle = be32_to_cpup(list++);
+ if (phandle)
+ mtd_node = of_find_node_by_phandle(phandle);
+
+ if (!mtd_node)
+ return -ENODEV;
+
+ part = of_get_property(mtd_node, "label", NULL);
+ if (!part)
+ part = mtd_node->name;
+
+ mtd = get_mtd_device_nm(part);
+ if (IS_ERR(mtd))
+ return -ENODEV;
+
+ offset = be32_to_cpup(list++);
+ size = be32_to_cpup(list);
+
+ file = kzalloc(size, GFP_KERNEL);
+ if (!file)
+ return -ENOMEM;
+
+ ret = mtd_read(mtd, offset, size, &retlen, file);
+ put_mtd_device(mtd);
+
+ ret = ath10k_download_board_data(ar, file, size);
+ if (ret) {
+ ath10k_err(ar, "failed to download cal_file data: %d\n", ret);
+ goto err;
+ }
+
+ ath10k_dbg(ar, ATH10K_DBG_BOOT, "boot cal file downloaded\n");
+
+ return 0;
+
+err:
+ kfree(file);
+ return ret;
+#endif
+ return -EOPNOTSUPP;
+}
+
static int ath10k_download_cal_file(struct ath10k *ar,
const struct firmware *file)
{
@@ -2047,6 +2113,16 @@ static int ath10k_core_pre_cal_download(struct ath10k *ar)
goto success;
}
+ ath10k_dbg(ar, ATH10K_DBG_BOOT,
+ "boot did not find a pre calibration file, try MTD next: %d\n",
+ ret);
+
+ ret = ath10k_download_cal_mtd(ar);
+ if (ret == 0) {
+ ar->cal_mode = ATH10K_PRE_CAL_MODE_MTD;
+ goto success;
+ }
+
ath10k_dbg(ar, ATH10K_DBG_BOOT,
"boot did not find a pre calibration file, try DT next: %d\n",
ret);
diff --git a/drivers/net/wireless/ath/ath10k/core.h b/drivers/net/wireless/ath/ath10k/core.h
index 4cf5bd489..3ca158605 100644
--- a/drivers/net/wireless/ath/ath10k/core.h
+++ b/drivers/net/wireless/ath/ath10k/core.h
@@ -864,6 +864,7 @@ enum ath10k_cal_mode {
ATH10K_CAL_MODE_OTP,
ATH10K_CAL_MODE_DT,
ATH10K_PRE_CAL_MODE_FILE,
+ ATH10K_PRE_CAL_MODE_MTD,
ATH10K_PRE_CAL_MODE_DT,
ATH10K_CAL_MODE_EEPROM,
};
@@ -886,6 +887,8 @@ static inline const char *ath10k_cal_mode_str(enum ath10k_cal_mode mode)
return "dt";
case ATH10K_PRE_CAL_MODE_FILE:
return "pre-cal-file";
+ case ATH10K_PRE_CAL_MODE_MTD:
+ return "pre-cal-mtd";
case ATH10K_PRE_CAL_MODE_DT:
return "pre-cal-dt";
case ATH10K_CAL_MODE_EEPROM:
--
2.27.0
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH v2 2/2] dt: bindings: ath10k: Document qcom,ath10k-pre-calibration-data-mtd
2020-09-18 18:11 ` Ansuel Smith
@ 2020-09-18 18:11 ` Ansuel Smith
-1 siblings, 0 replies; 8+ messages in thread
From: Ansuel Smith @ 2020-09-18 18:11 UTC (permalink / raw)
To: Kalle Valo
Cc: Ansuel Smith, David S. Miller, Jakub Kicinski, Rob Herring,
linux-wireless, netdev, devicetree, linux-kernel, ath10k
Document use of qcom,ath10k-pre-calibration-data-mtd bindings used to
define from where the driver will load the pre-cal data in the defined
mtd partition.
Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
---
.../devicetree/bindings/net/wireless/qcom,ath10k.txt | 12 +++++++++---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt
index b61c2d5a0..568364243 100644
--- a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt
+++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt
@@ -15,9 +15,9 @@ and also uses most of the properties defined in this doc (except
"qcom,ath10k-calibration-data"). It uses "qcom,ath10k-pre-calibration-data"
to carry pre calibration data.
-In general, entry "qcom,ath10k-pre-calibration-data" and
-"qcom,ath10k-calibration-data" conflict with each other and only one
-can be provided per device.
+In general, entry "qcom,ath10k-pre-calibration-data",
+"qcom,ath10k-calibration-data-mtd" and "qcom,ath10k-calibration-data" conflict with
+each other and only one can be provided per device.
SNOC based devices (i.e. wcn3990) uses compatible string "qcom,wcn3990-wifi".
@@ -63,6 +63,12 @@ Optional properties:
hw versions.
- qcom,ath10k-pre-calibration-data : pre calibration data as an array,
the length can vary between hw versions.
+- qcom,ath10k-pre-calibration-data-mtd :
+ Usage: optional
+ Value type: <phandle offset size>
+ Definition: pre calibration data read from mtd partition. Take 3 value, the
+ mtd to read data from, the offset in the mtd partition and the
+ size of data to read.
- <supply-name>-supply: handle to the regulator device tree node
optional "supply-name" are "vdd-0.8-cx-mx",
"vdd-1.8-xo", "vdd-1.3-rfa", "vdd-3.3-ch0",
--
2.27.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH v2 2/2] dt: bindings: ath10k: Document qcom, ath10k-pre-calibration-data-mtd
@ 2020-09-18 18:11 ` Ansuel Smith
0 siblings, 0 replies; 8+ messages in thread
From: Ansuel Smith @ 2020-09-18 18:11 UTC (permalink / raw)
To: Kalle Valo
Cc: devicetree, netdev, linux-wireless, linux-kernel, ath10k,
David S. Miller, Rob Herring, Jakub Kicinski, Ansuel Smith
Document use of qcom,ath10k-pre-calibration-data-mtd bindings used to
define from where the driver will load the pre-cal data in the defined
mtd partition.
Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
---
.../devicetree/bindings/net/wireless/qcom,ath10k.txt | 12 +++++++++---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt
index b61c2d5a0..568364243 100644
--- a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt
+++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt
@@ -15,9 +15,9 @@ and also uses most of the properties defined in this doc (except
"qcom,ath10k-calibration-data"). It uses "qcom,ath10k-pre-calibration-data"
to carry pre calibration data.
-In general, entry "qcom,ath10k-pre-calibration-data" and
-"qcom,ath10k-calibration-data" conflict with each other and only one
-can be provided per device.
+In general, entry "qcom,ath10k-pre-calibration-data",
+"qcom,ath10k-calibration-data-mtd" and "qcom,ath10k-calibration-data" conflict with
+each other and only one can be provided per device.
SNOC based devices (i.e. wcn3990) uses compatible string "qcom,wcn3990-wifi".
@@ -63,6 +63,12 @@ Optional properties:
hw versions.
- qcom,ath10k-pre-calibration-data : pre calibration data as an array,
the length can vary between hw versions.
+- qcom,ath10k-pre-calibration-data-mtd :
+ Usage: optional
+ Value type: <phandle offset size>
+ Definition: pre calibration data read from mtd partition. Take 3 value, the
+ mtd to read data from, the offset in the mtd partition and the
+ size of data to read.
- <supply-name>-supply: handle to the regulator device tree node
optional "supply-name" are "vdd-0.8-cx-mx",
"vdd-1.8-xo", "vdd-1.3-rfa", "vdd-3.3-ch0",
--
2.27.0
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH v2 2/2] dt: bindings: ath10k: Document qcom,ath10k-pre-calibration-data-mtd
2020-09-18 18:11 ` [PATCH v2 2/2] dt: bindings: ath10k: Document qcom, ath10k-pre-calibration-data-mtd Ansuel Smith
@ 2020-09-23 20:58 ` Rob Herring
-1 siblings, 0 replies; 8+ messages in thread
From: Rob Herring @ 2020-09-23 20:58 UTC (permalink / raw)
To: Ansuel Smith
Cc: Kalle Valo, David S. Miller, Jakub Kicinski, linux-wireless,
netdev, devicetree, linux-kernel, ath10k
On Fri, Sep 18, 2020 at 08:11:03PM +0200, Ansuel Smith wrote:
> Document use of qcom,ath10k-pre-calibration-data-mtd bindings used to
> define from where the driver will load the pre-cal data in the defined
> mtd partition.
>
> Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
> ---
> .../devicetree/bindings/net/wireless/qcom,ath10k.txt | 12 +++++++++---
> 1 file changed, 9 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt
> index b61c2d5a0..568364243 100644
> --- a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt
> +++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt
> @@ -15,9 +15,9 @@ and also uses most of the properties defined in this doc (except
> "qcom,ath10k-calibration-data"). It uses "qcom,ath10k-pre-calibration-data"
> to carry pre calibration data.
>
> -In general, entry "qcom,ath10k-pre-calibration-data" and
> -"qcom,ath10k-calibration-data" conflict with each other and only one
> -can be provided per device.
> +In general, entry "qcom,ath10k-pre-calibration-data",
> +"qcom,ath10k-calibration-data-mtd" and "qcom,ath10k-calibration-data" conflict with
> +each other and only one can be provided per device.
>
> SNOC based devices (i.e. wcn3990) uses compatible string "qcom,wcn3990-wifi".
>
> @@ -63,6 +63,12 @@ Optional properties:
> hw versions.
> - qcom,ath10k-pre-calibration-data : pre calibration data as an array,
> the length can vary between hw versions.
> +- qcom,ath10k-pre-calibration-data-mtd :
mtd is a Linuxism.
> + Usage: optional
> + Value type: <phandle offset size>
> + Definition: pre calibration data read from mtd partition. Take 3 value, the
> + mtd to read data from, the offset in the mtd partition and the
The phandle is the mtd or partition?
Maybe you should be using nvmem binding here.
> + size of data to read.
> - <supply-name>-supply: handle to the regulator device tree node
> optional "supply-name" are "vdd-0.8-cx-mx",
> "vdd-1.8-xo", "vdd-1.3-rfa", "vdd-3.3-ch0",
> --
> 2.27.0
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2 2/2] dt: bindings: ath10k: Document qcom,ath10k-pre-calibration-data-mtd
@ 2020-09-23 20:58 ` Rob Herring
0 siblings, 0 replies; 8+ messages in thread
From: Rob Herring @ 2020-09-23 20:58 UTC (permalink / raw)
To: Ansuel Smith
Cc: devicetree, netdev, linux-wireless, linux-kernel, ath10k,
Jakub Kicinski, David S. Miller, Kalle Valo
On Fri, Sep 18, 2020 at 08:11:03PM +0200, Ansuel Smith wrote:
> Document use of qcom,ath10k-pre-calibration-data-mtd bindings used to
> define from where the driver will load the pre-cal data in the defined
> mtd partition.
>
> Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
> ---
> .../devicetree/bindings/net/wireless/qcom,ath10k.txt | 12 +++++++++---
> 1 file changed, 9 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt
> index b61c2d5a0..568364243 100644
> --- a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt
> +++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt
> @@ -15,9 +15,9 @@ and also uses most of the properties defined in this doc (except
> "qcom,ath10k-calibration-data"). It uses "qcom,ath10k-pre-calibration-data"
> to carry pre calibration data.
>
> -In general, entry "qcom,ath10k-pre-calibration-data" and
> -"qcom,ath10k-calibration-data" conflict with each other and only one
> -can be provided per device.
> +In general, entry "qcom,ath10k-pre-calibration-data",
> +"qcom,ath10k-calibration-data-mtd" and "qcom,ath10k-calibration-data" conflict with
> +each other and only one can be provided per device.
>
> SNOC based devices (i.e. wcn3990) uses compatible string "qcom,wcn3990-wifi".
>
> @@ -63,6 +63,12 @@ Optional properties:
> hw versions.
> - qcom,ath10k-pre-calibration-data : pre calibration data as an array,
> the length can vary between hw versions.
> +- qcom,ath10k-pre-calibration-data-mtd :
mtd is a Linuxism.
> + Usage: optional
> + Value type: <phandle offset size>
> + Definition: pre calibration data read from mtd partition. Take 3 value, the
> + mtd to read data from, the offset in the mtd partition and the
The phandle is the mtd or partition?
Maybe you should be using nvmem binding here.
> + size of data to read.
> - <supply-name>-supply: handle to the regulator device tree node
> optional "supply-name" are "vdd-0.8-cx-mx",
> "vdd-1.8-xo", "vdd-1.3-rfa", "vdd-3.3-ch0",
> --
> 2.27.0
>
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply [flat|nested] 8+ messages in thread
* RE: [PATCH v2 2/2] dt: bindings: ath10k: Document qcom,ath10k-pre-calibration-data-mtd
2020-09-23 20:58 ` Rob Herring
@ 2020-09-23 21:04 ` ansuelsmth
-1 siblings, 0 replies; 8+ messages in thread
From: ansuelsmth @ 2020-09-23 21:04 UTC (permalink / raw)
To: 'Rob Herring'
Cc: 'Kalle Valo', 'David S. Miller',
'Jakub Kicinski',
linux-wireless, netdev, devicetree, linux-kernel, ath10k
> -----Original Message-----
> From: Rob Herring <robh@kernel.org>
> Sent: Wednesday, September 23, 2020 10:58 PM
> To: Ansuel Smith <ansuelsmth@gmail.com>
> Cc: Kalle Valo <kvalo@codeaurora.org>; David S. Miller
> <davem@davemloft.net>; Jakub Kicinski <kuba@kernel.org>; linux-
> wireless@vger.kernel.org; netdev@vger.kernel.org;
> devicetree@vger.kernel.org; linux-kernel@vger.kernel.org;
> ath10k@lists.infradead.org
> Subject: Re: [PATCH v2 2/2] dt: bindings: ath10k: Document qcom,ath10k-
> pre-calibration-data-mtd
>
> On Fri, Sep 18, 2020 at 08:11:03PM +0200, Ansuel Smith wrote:
> > Document use of qcom,ath10k-pre-calibration-data-mtd bindings used to
> > define from where the driver will load the pre-cal data in the defined
> > mtd partition.
> >
> > Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
> > ---
> > .../devicetree/bindings/net/wireless/qcom,ath10k.txt | 12 +++++++++---
> > 1 file changed, 9 insertions(+), 3 deletions(-)
> >
> > diff --git
> a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt
> b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt
> > index b61c2d5a0..568364243 100644
> > --- a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt
> > +++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt
> > @@ -15,9 +15,9 @@ and also uses most of the properties defined in this
> doc (except
> > "qcom,ath10k-calibration-data"). It uses "qcom,ath10k-pre-calibration-
> data"
> > to carry pre calibration data.
> >
> > -In general, entry "qcom,ath10k-pre-calibration-data" and
> > -"qcom,ath10k-calibration-data" conflict with each other and only one
> > -can be provided per device.
> > +In general, entry "qcom,ath10k-pre-calibration-data",
> > +"qcom,ath10k-calibration-data-mtd" and "qcom,ath10k-calibration-
> data" conflict with
> > +each other and only one can be provided per device.
> >
> > SNOC based devices (i.e. wcn3990) uses compatible string
> "qcom,wcn3990-wifi".
> >
> > @@ -63,6 +63,12 @@ Optional properties:
> > hw versions.
> > - qcom,ath10k-pre-calibration-data : pre calibration data as an array,
> > the length can vary between hw
versions.
> > +- qcom,ath10k-pre-calibration-data-mtd :
>
> mtd is a Linuxism.
>
> > + Usage: optional
> > + Value type: <phandle offset size>
> > + Definition: pre calibration data read from mtd partition. Take 3
> value, the
> > + mtd to read data from, the offset in the mtd partition
and
> the
>
> The phandle is the mtd or partition?
>
> Maybe you should be using nvmem binding here.
>
The phandle is to the mtd.
You are right about nvmem... Problem is that nvmem for mtd is still not
supported. I already sent a patch to fix this in the mtd mailing list but
I'm waiting for review...
If that will be accepted, I can convert this patch to use nvmem api.
> > + size of data to read.
> > - <supply-name>-supply: handle to the regulator device tree node
> > optional "supply-name" are "vdd-0.8-cx-mx",
> > "vdd-1.8-xo", "vdd-1.3-rfa", "vdd-3.3-ch0",
> > --
> > 2.27.0
> >
^ permalink raw reply [flat|nested] 8+ messages in thread
* RE: [PATCH v2 2/2] dt: bindings: ath10k: Document qcom, ath10k-pre-calibration-data-mtd
@ 2020-09-23 21:04 ` ansuelsmth
0 siblings, 0 replies; 8+ messages in thread
From: ansuelsmth @ 2020-09-23 21:04 UTC (permalink / raw)
To: 'Rob Herring'
Cc: devicetree, netdev, linux-wireless, linux-kernel, ath10k,
'Jakub Kicinski', 'David S. Miller',
'Kalle Valo'
> -----Original Message-----
> From: Rob Herring <robh@kernel.org>
> Sent: Wednesday, September 23, 2020 10:58 PM
> To: Ansuel Smith <ansuelsmth@gmail.com>
> Cc: Kalle Valo <kvalo@codeaurora.org>; David S. Miller
> <davem@davemloft.net>; Jakub Kicinski <kuba@kernel.org>; linux-
> wireless@vger.kernel.org; netdev@vger.kernel.org;
> devicetree@vger.kernel.org; linux-kernel@vger.kernel.org;
> ath10k@lists.infradead.org
> Subject: Re: [PATCH v2 2/2] dt: bindings: ath10k: Document qcom,ath10k-
> pre-calibration-data-mtd
>
> On Fri, Sep 18, 2020 at 08:11:03PM +0200, Ansuel Smith wrote:
> > Document use of qcom,ath10k-pre-calibration-data-mtd bindings used to
> > define from where the driver will load the pre-cal data in the defined
> > mtd partition.
> >
> > Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
> > ---
> > .../devicetree/bindings/net/wireless/qcom,ath10k.txt | 12 +++++++++---
> > 1 file changed, 9 insertions(+), 3 deletions(-)
> >
> > diff --git
> a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt
> b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt
> > index b61c2d5a0..568364243 100644
> > --- a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt
> > +++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt
> > @@ -15,9 +15,9 @@ and also uses most of the properties defined in this
> doc (except
> > "qcom,ath10k-calibration-data"). It uses "qcom,ath10k-pre-calibration-
> data"
> > to carry pre calibration data.
> >
> > -In general, entry "qcom,ath10k-pre-calibration-data" and
> > -"qcom,ath10k-calibration-data" conflict with each other and only one
> > -can be provided per device.
> > +In general, entry "qcom,ath10k-pre-calibration-data",
> > +"qcom,ath10k-calibration-data-mtd" and "qcom,ath10k-calibration-
> data" conflict with
> > +each other and only one can be provided per device.
> >
> > SNOC based devices (i.e. wcn3990) uses compatible string
> "qcom,wcn3990-wifi".
> >
> > @@ -63,6 +63,12 @@ Optional properties:
> > hw versions.
> > - qcom,ath10k-pre-calibration-data : pre calibration data as an array,
> > the length can vary between hw
versions.
> > +- qcom,ath10k-pre-calibration-data-mtd :
>
> mtd is a Linuxism.
>
> > + Usage: optional
> > + Value type: <phandle offset size>
> > + Definition: pre calibration data read from mtd partition. Take 3
> value, the
> > + mtd to read data from, the offset in the mtd partition
and
> the
>
> The phandle is the mtd or partition?
>
> Maybe you should be using nvmem binding here.
>
The phandle is to the mtd.
You are right about nvmem... Problem is that nvmem for mtd is still not
supported. I already sent a patch to fix this in the mtd mailing list but
I'm waiting for review...
If that will be accepted, I can convert this patch to use nvmem api.
> > + size of data to read.
> > - <supply-name>-supply: handle to the regulator device tree node
> > optional "supply-name" are "vdd-0.8-cx-mx",
> > "vdd-1.8-xo", "vdd-1.3-rfa", "vdd-3.3-ch0",
> > --
> > 2.27.0
> >
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2020-09-23 21:04 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-18 18:11 [PATCH v2 1/2] ath10k: Introduce download cal from mtd Ansuel Smith
2020-09-18 18:11 ` Ansuel Smith
2020-09-18 18:11 ` [PATCH v2 2/2] dt: bindings: ath10k: Document qcom,ath10k-pre-calibration-data-mtd Ansuel Smith
2020-09-18 18:11 ` [PATCH v2 2/2] dt: bindings: ath10k: Document qcom, ath10k-pre-calibration-data-mtd Ansuel Smith
2020-09-23 20:58 ` [PATCH v2 2/2] dt: bindings: ath10k: Document qcom,ath10k-pre-calibration-data-mtd Rob Herring
2020-09-23 20:58 ` Rob Herring
2020-09-23 21:04 ` ansuelsmth
2020-09-23 21:04 ` [PATCH v2 2/2] dt: bindings: ath10k: Document qcom, ath10k-pre-calibration-data-mtd ansuelsmth
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.