[meta-oe][PATCH] luajit: create developer symlinks

[meta-oe][PATCH] luajit: create developer symlinks

[Pascal Bach]

LuaJIT tries to call ldconfig during installation which doesn't work.
This causes the .so and .so.2 symlinks to no be created.

By setting "LDCONFIG= :" the call will be skipped the same as on Darwin

Signed-off-by: Pascal Bach <pascal.bach@siemens.com>
---
 meta-oe/recipes-devtools/luajit/luajit_2.0.5.bb | 1 +
 1 file changed, 1 insertion(+)

diff --git a/meta-oe/recipes-devtools/luajit/luajit_2.0.5.bb b/meta-oe/recipes-devtools/luajit/luajit_2.0.5.bb
index d7477ed..1e06e34 100644
--- a/meta-oe/recipes-devtools/luajit/luajit_2.0.5.bb
+++ b/meta-oe/recipes-devtools/luajit/luajit_2.0.5.bb
@@ -52,6 +52,7 @@ EXTRA_OEMAKE = "\
     \
     'PREFIX=${prefix}' \
     'MULTILIB=${baselib}' \
+    'LDCONFIG= :' \
 "
 
 do_compile () {
-- 
2.1.4

Re: [meta-oe][PATCH] luajit: create developer symlinks

[Andre McCurdy]

On Thu, Sep 21, 2017 at 5:01 AM, Pascal Bach <pascal.bach@siemens.com> wrote:
> LuaJIT tries to call ldconfig during installation which doesn't work.

Presumably this stopped working recently (since host tools now need to
be whitelisted and ldconfig is not included in HOSTTOOLS)? If so,
maybe mention that in the commit message.

> This causes the .so and .so.2 symlinks to no be created.
>
> By setting "LDCONFIG= :" the call will be skipped the same as on Darwin
>
> Signed-off-by: Pascal Bach <pascal.bach@siemens.com>
> ---
>  meta-oe/recipes-devtools/luajit/luajit_2.0.5.bb | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/meta-oe/recipes-devtools/luajit/luajit_2.0.5.bb b/meta-oe/recipes-devtools/luajit/luajit_2.0.5.bb
> index d7477ed..1e06e34 100644
> --- a/meta-oe/recipes-devtools/luajit/luajit_2.0.5.bb
> +++ b/meta-oe/recipes-devtools/luajit/luajit_2.0.5.bb
> @@ -52,6 +52,7 @@ EXTRA_OEMAKE = "\
>      \
>      'PREFIX=${prefix}' \
>      'MULTILIB=${baselib}' \
> +    'LDCONFIG= :' \
>  "
>
>  do_compile () {
> --
> 2.1.4
>
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel

Re: [meta-oe][PATCH] luajit: create developer symlinks

[Pascal Bach]

On 21.09.2017 20:32, Andre McCurdy wrote:
> On Thu, Sep 21, 2017 at 5:01 AM, Pascal Bach <pascal.bach@siemens.com> wrote:
>> LuaJIT tries to call ldconfig during installation which doesn't work.
> Presumably this stopped working recently (since host tools now need to
> be whitelisted and ldconfig is not included in HOSTTOOLS)? If so,
> maybe mention that in the commit message.
I'm not sure when it stopped working. I just tried it now with Pyro ;-)
However I'm not sure what ldconfig does in the context of cross compilation or if it makes sense at all to call it.
My assumption was not so I decided to just disable it. But I'm happy to correct my assumption if I'm wrong.
>> This causes the .so and .so.2 symlinks to no be created.
>>
>> By setting "LDCONFIG= :" the call will be skipped the same as on Darwin
>>
>> Signed-off-by: Pascal Bach <pascal.bach@siemens.com>
>> ---
>>  meta-oe/recipes-devtools/luajit/luajit_2.0.5.bb | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/meta-oe/recipes-devtools/luajit/luajit_2.0.5.bb b/meta-oe/recipes-devtools/luajit/luajit_2.0.5.bb
>> index d7477ed..1e06e34 100644
>> --- a/meta-oe/recipes-devtools/luajit/luajit_2.0.5.bb
>> +++ b/meta-oe/recipes-devtools/luajit/luajit_2.0.5.bb
>> @@ -52,6 +52,7 @@ EXTRA_OEMAKE = "\
>>      \
>>      'PREFIX=${prefix}' \
>>      'MULTILIB=${baselib}' \
>> +    'LDCONFIG= :' \
>>  "
>>
>>  do_compile () {
>> --
>> 2.1.4
>>
>> --
>> _______________________________________________
>> Openembedded-devel mailing list
>> Openembedded-devel@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-devel

Re: [meta-oe][PATCH] luajit: create developer symlinks

[Andre McCurdy]

On Fri, Sep 22, 2017 at 12:23 AM, Pascal Bach <pascal.bach@siemens.com> wrote:
> On 21.09.2017 20:32, Andre McCurdy wrote:
>> On Thu, Sep 21, 2017 at 5:01 AM, Pascal Bach <pascal.bach@siemens.com> wrote:
>>> LuaJIT tries to call ldconfig during installation which doesn't work.
>> Presumably this stopped working recently (since host tools now need to
>> be whitelisted and ldconfig is not included in HOSTTOOLS)? If so,
>> maybe mention that in the commit message.
> I'm not sure when it stopped working. I just tried it now with Pyro ;-)
> However I'm not sure what ldconfig does in the context of cross compilation or if it makes sense at all to call it.
> My assumption was not so I decided to just disable it. But I'm happy to correct my assumption if I'm wrong.

The change is fine, just the commit message which could perhaps be improved.

Details of when or why something stopped working are very useful for
anyone maintaining release branches etc and trying to decide which
fixes to backport.

>>> This causes the .so and .so.2 symlinks to no be created.
>>>
>>> By setting "LDCONFIG= :" the call will be skipped the same as on Darwin
>>>
>>> Signed-off-by: Pascal Bach <pascal.bach@siemens.com>
>>> ---
>>>  meta-oe/recipes-devtools/luajit/luajit_2.0.5.bb | 1 +
>>>  1 file changed, 1 insertion(+)
>>>
>>> diff --git a/meta-oe/recipes-devtools/luajit/luajit_2.0.5.bb b/meta-oe/recipes-devtools/luajit/luajit_2.0.5.bb
>>> index d7477ed..1e06e34 100644
>>> --- a/meta-oe/recipes-devtools/luajit/luajit_2.0.5.bb
>>> +++ b/meta-oe/recipes-devtools/luajit/luajit_2.0.5.bb
>>> @@ -52,6 +52,7 @@ EXTRA_OEMAKE = "\
>>>      \
>>>      'PREFIX=${prefix}' \
>>>      'MULTILIB=${baselib}' \
>>> +    'LDCONFIG= :' \

Maybe drop the space after the = (it doesn't hurt, but looks odd...).

>>>  "
>>>
>>>  do_compile () {
>>> --
>>> 2.1.4
>>>
>>> --
>>> _______________________________________________
>>> Openembedded-devel mailing list
>>> Openembedded-devel@lists.openembedded.org
>>> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>