All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakob Unterwurzacher <jakob.unterwurzacher@theobroma-systems.com>
To: Wolfgang Grandegger <wg@grandegger.com>
Cc: Martin Elshuber <martin.elshuber@theobroma-systems.com>,
	Philipp Tomsich <philipp.tomsich@theobroma-systems.com>,
	Marc Kleine-Budde <mkl@pengutronix.de>,
	linux-can@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 0/1] can: ucan: add driver for Theobroma Systems UCAN devices
Date: Fri, 23 Mar 2018 11:12:46 +0100	[thread overview]
Message-ID: <01b11c3d-76df-0e4c-1479-1321a6ecd96c@theobroma-systems.com> (raw)
In-Reply-To: <e6d4bfc8-d43f-20ef-7b00-43ecf0a87f96@grandegger.com>

On 23.03.18 11:04, Wolfgang Grandegger wrote:
> 
>> But I'm open to other suggestions (use a fixed "ucan: " prefix?) or to
>> drop it entirely if you think it is not worth it.
> 
> But there is already a device prefix, e.g.:
> 
>    peak_usb 1-6:1.0: PEAK-System PCAN-USB adapter hwrev 28 serial FFFFFFFF (1 channel)
>    peak_usb 1-6:1.0 can0: attached to PCAN-USB channel 0 (device 255)
>    ^^^^^^^^

Interesting. Looks like the UCAN driver is missing something to make 
this work:

[   67.792947] usb 5-1.4: ucan_probe: registered UCAN device at can0

I'll take a closer look.

Thanks,
Jakob

  reply	other threads:[~2018-03-23 10:12 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-22 13:53 [PATCH v3 0/1] can: ucan: add driver for Theobroma Systems UCAN devices Jakob Unterwurzacher
2018-03-22 13:53 ` [PATCH v3 1/1] " Jakob Unterwurzacher
2018-03-23  8:42   ` Wolfgang Grandegger
2018-03-24 11:43   ` kbuild test robot
2018-03-24 11:43     ` kbuild test robot
2018-03-27 10:20     ` Martin Elshuber
2018-03-23  8:32 ` [PATCH v3 0/1] " Wolfgang Grandegger
2018-03-23  9:40   ` Jakob Unterwurzacher
2018-03-23 10:04     ` Wolfgang Grandegger
2018-03-23 10:12       ` Jakob Unterwurzacher [this message]
2018-03-27 10:19         ` Martin Elshuber

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=01b11c3d-76df-0e4c-1479-1321a6ecd96c@theobroma-systems.com \
    --to=jakob.unterwurzacher@theobroma-systems.com \
    --cc=linux-can@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=martin.elshuber@theobroma-systems.com \
    --cc=mkl@pengutronix.de \
    --cc=philipp.tomsich@theobroma-systems.com \
    --cc=wg@grandegger.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.