From: Martin Elshuber <martin.elshuber@theobroma-systems.com>
To: Jakob Unterwurzacher <jakob.unterwurzacher@theobroma-systems.com>,
Wolfgang Grandegger <wg@grandegger.com>
Cc: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>,
Marc Kleine-Budde <mkl@pengutronix.de>,
linux-can@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 0/1] can: ucan: add driver for Theobroma Systems UCAN devices
Date: Tue, 27 Mar 2018 12:19:37 +0200 [thread overview]
Message-ID: <cb761460-791f-023f-eabb-9b5610bfb6a6@theobroma-systems.com> (raw)
In-Reply-To: <01b11c3d-76df-0e4c-1479-1321a6ecd96c@theobroma-systems.com>
[-- Attachment #1.1: Type: text/plain, Size: 1186 bytes --]
Where possible we changed dev_XXX to netdev_XXX. and removed all __func__.
netdev_XXX prints the necessary information on the device, bus and netif
The remaining dev_XXX (within probe) are extended such that they print
the string "ucan" (__func__ are also removed)
Am 23.03.18 um 11:12 schrieb Jakob Unterwurzacher:
> On 23.03.18 11:04, Wolfgang Grandegger wrote:
>>
>>> But I'm open to other suggestions (use a fixed "ucan: " prefix?) or to
>>> drop it entirely if you think it is not worth it.
>>
>> But there is already a device prefix, e.g.:
>>
>> peak_usb 1-6:1.0: PEAK-System PCAN-USB adapter hwrev 28 serial
>> FFFFFFFF (1 channel)
>> peak_usb 1-6:1.0 can0: attached to PCAN-USB channel 0 (device 255)
>> ^^^^^^^^
>
> Interesting. Looks like the UCAN driver is missing something to make
> this work:
>
> [ 67.792947] usb 5-1.4: ucan_probe: registered UCAN device at can0
>
> I'll take a closer look.
>
> Thanks,
> Jakob
--
Martin Elshuber
Theobroma Systems Design und Consulting GmbH
Seestadtstraße 27 (Aspern IQ), 1220 Wien, Austria
Phone: +43 1 236 98 93-405, Fax: +43 1 236 98 93-9
http://www.theobroma-systems.com
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 842 bytes --]
prev parent reply other threads:[~2018-03-27 10:19 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-22 13:53 [PATCH v3 0/1] can: ucan: add driver for Theobroma Systems UCAN devices Jakob Unterwurzacher
2018-03-22 13:53 ` [PATCH v3 1/1] " Jakob Unterwurzacher
2018-03-23 8:42 ` Wolfgang Grandegger
2018-03-24 11:43 ` kbuild test robot
2018-03-24 11:43 ` kbuild test robot
2018-03-27 10:20 ` Martin Elshuber
2018-03-23 8:32 ` [PATCH v3 0/1] " Wolfgang Grandegger
2018-03-23 9:40 ` Jakob Unterwurzacher
2018-03-23 10:04 ` Wolfgang Grandegger
2018-03-23 10:12 ` Jakob Unterwurzacher
2018-03-27 10:19 ` Martin Elshuber [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cb761460-791f-023f-eabb-9b5610bfb6a6@theobroma-systems.com \
--to=martin.elshuber@theobroma-systems.com \
--cc=jakob.unterwurzacher@theobroma-systems.com \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=philipp.tomsich@theobroma-systems.com \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.