* ✗ patchtest: failure for uboot-sign.bbclass: Remove tab indentations in python code
2018-11-23 11:08 [PATCH 0/1] uboot-sign.bbclass: Remove tab indentations in python code Robert Yang
@ 2018-11-23 11:07 ` Patchwork
2018-11-23 11:08 ` [PATCH 1/1] " Robert Yang
1 sibling, 0 replies; 6+ messages in thread
From: Patchwork @ 2018-11-23 11:07 UTC (permalink / raw)
To: Robert Yang; +Cc: openembedded-core
== Series Details ==
Series: uboot-sign.bbclass: Remove tab indentations in python code
Revision: 1
URL : https://patchwork.openembedded.org/series/15061/
State : failure
== Summary ==
Thank you for submitting this patch series to OpenEmbedded Core. This is
an automated response. Several tests have been executed on the proposed
series by patchtest resulting in the following failures:
* Issue Series does not apply on top of target branch [test_series_merge_on_head]
Suggested fix Rebase your series on top of targeted branch
Targeted branch master (currently at c80972be1f)
If you believe any of these test results are incorrect, please reply to the
mailing list (openembedded-core@lists.openembedded.org) raising your concerns.
Otherwise we would appreciate you correcting the issues and submitting a new
version of the patchset if applicable. Please ensure you add/increment the
version number when sending the new version (i.e. [PATCH] -> [PATCH v2] ->
[PATCH v3] -> ...).
---
Guidelines: https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines
Test framework: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest
Test suite: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest-oe
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 0/1] uboot-sign.bbclass: Remove tab indentations in python code
@ 2018-11-23 11:08 Robert Yang
2018-11-23 11:07 ` ✗ patchtest: failure for " Patchwork
2018-11-23 11:08 ` [PATCH 1/1] " Robert Yang
0 siblings, 2 replies; 6+ messages in thread
From: Robert Yang @ 2018-11-23 11:08 UTC (permalink / raw)
To: openembedded-core
Note, I send this patch separately is because it depends on another patch of
mine which was sent on Wed.:
uboot-sign.bbclass: fix signature and deployment
// Robert
The following changes since commit d29e9922e750bc1637f4fe454f4cc6dcfb74f09a:
uboot-sign.bbclass: fix signature and deployment (2018-11-23 19:05:39 +0800)
are available in the git repository at:
git://git.openembedded.org/openembedded-core-contrib rbt/uboot_py
http://cgit.openembedded.org/openembedded-core-contrib/log/?h=rbt/uboot_py
Robert Yang (1):
uboot-sign.bbclass: Remove tab indentations in python code
meta/classes/uboot-sign.bbclass | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
--
2.7.4
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 1/1] uboot-sign.bbclass: Remove tab indentations in python code
2018-11-23 11:08 [PATCH 0/1] uboot-sign.bbclass: Remove tab indentations in python code Robert Yang
2018-11-23 11:07 ` ✗ patchtest: failure for " Patchwork
@ 2018-11-23 11:08 ` Robert Yang
2018-12-05 14:40 ` Martin Jansa
1 sibling, 1 reply; 6+ messages in thread
From: Robert Yang @ 2018-11-23 11:08 UTC (permalink / raw)
To: openembedded-core
Use 4 spaces to replace a tab.
Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
---
meta/classes/uboot-sign.bbclass | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/meta/classes/uboot-sign.bbclass b/meta/classes/uboot-sign.bbclass
index 0e5e1b1..03100b8 100644
--- a/meta/classes/uboot-sign.bbclass
+++ b/meta/classes/uboot-sign.bbclass
@@ -93,14 +93,14 @@ do_install_append() {
}
python () {
- if d.getVar('UBOOT_SIGN_ENABLE') == '1' and d.getVar('PN') == d.getVar('UBOOT_PN'):
- kernel_pn = d.getVar('PREFERRED_PROVIDER_virtual/kernel')
+ if d.getVar('UBOOT_SIGN_ENABLE') == '1' and d.getVar('PN') == d.getVar('UBOOT_PN'):
+ kernel_pn = d.getVar('PREFERRED_PROVIDER_virtual/kernel')
- # Make "bitbake u-boot -cdeploy" deploys the signed u-boot.dtb
- d.appendVarFlag('do_deploy', 'depends', ' %s:do_deploy' % kernel_pn)
+ # Make "bitbake u-boot -cdeploy" deploys the signed u-boot.dtb
+ d.appendVarFlag('do_deploy', 'depends', ' %s:do_deploy' % kernel_pn)
- # kernerl's do_deploy is a litle special, so we can't use
- # do_deploy_append, otherwise it would override
- # kernel_do_deploy.
- d.appendVarFlag('do_deploy', 'prefuncs', ' concat_dtb')
+ # kernerl's do_deploy is a litle special, so we can't use
+ # do_deploy_append, otherwise it would override
+ # kernel_do_deploy.
+ d.appendVarFlag('do_deploy', 'prefuncs', ' concat_dtb')
}
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 1/1] uboot-sign.bbclass: Remove tab indentations in python code
2018-11-23 11:08 ` [PATCH 1/1] " Robert Yang
@ 2018-12-05 14:40 ` Martin Jansa
2018-12-06 2:59 ` Robert Yang
0 siblings, 1 reply; 6+ messages in thread
From: Martin Jansa @ 2018-12-05 14:40 UTC (permalink / raw)
To: Robert Yang; +Cc: Patches and discussions about the oe-core layer
[-- Attachment #1: Type: text/plain, Size: 2360 bytes --]
I wish we could have the same warning for shell code as well :).
Can you please take care of meta-gplv2 as well?
WARNING: meta-gplv2/recipes-core/coreutils/coreutils_6.9.bb: python should
use 4 spaces indentation, but found tabs in coreutils_6.9.bb, line 95
I've sent patch for meta-oe issue:
http://lists.openembedded.org/pipermail/openembedded-devel/2018-December/197803.html
On Fri, Nov 23, 2018 at 11:51 AM Robert Yang <liezhi.yang@windriver.com>
wrote:
> Use 4 spaces to replace a tab.
>
> Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
> ---
> meta/classes/uboot-sign.bbclass | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/meta/classes/uboot-sign.bbclass
> b/meta/classes/uboot-sign.bbclass
> index 0e5e1b1..03100b8 100644
> --- a/meta/classes/uboot-sign.bbclass
> +++ b/meta/classes/uboot-sign.bbclass
> @@ -93,14 +93,14 @@ do_install_append() {
> }
>
> python () {
> - if d.getVar('UBOOT_SIGN_ENABLE') == '1' and d.getVar('PN') ==
> d.getVar('UBOOT_PN'):
> - kernel_pn = d.getVar('PREFERRED_PROVIDER_virtual/kernel')
> + if d.getVar('UBOOT_SIGN_ENABLE') == '1' and d.getVar('PN') ==
> d.getVar('UBOOT_PN'):
> + kernel_pn = d.getVar('PREFERRED_PROVIDER_virtual/kernel')
>
> - # Make "bitbake u-boot -cdeploy" deploys the signed
> u-boot.dtb
> - d.appendVarFlag('do_deploy', 'depends', ' %s:do_deploy' %
> kernel_pn)
> + # Make "bitbake u-boot -cdeploy" deploys the signed u-boot.dtb
> + d.appendVarFlag('do_deploy', 'depends', ' %s:do_deploy' %
> kernel_pn)
>
> - # kernerl's do_deploy is a litle special, so we can't use
> - # do_deploy_append, otherwise it would override
> - # kernel_do_deploy.
> - d.appendVarFlag('do_deploy', 'prefuncs', ' concat_dtb')
> + # kernerl's do_deploy is a litle special, so we can't use
> + # do_deploy_append, otherwise it would override
> + # kernel_do_deploy.
> + d.appendVarFlag('do_deploy', 'prefuncs', ' concat_dtb')
> }
> --
> 2.7.4
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
[-- Attachment #2: Type: text/html, Size: 3553 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/1] uboot-sign.bbclass: Remove tab indentations in python code
2018-12-05 14:40 ` Martin Jansa
@ 2018-12-06 2:59 ` Robert Yang
2018-12-06 8:15 ` Martin Jansa
0 siblings, 1 reply; 6+ messages in thread
From: Robert Yang @ 2018-12-06 2:59 UTC (permalink / raw)
To: Martin Jansa; +Cc: Patches and discussions about the oe-core layer
Hi Martin,
On 12/5/18 10:40 PM, Martin Jansa wrote:
> I wish we could have the same warning for shell code as well :).
>
According to oe's Format Guidelines:
https://www.openembedded.org/wiki/Styleguide#Format_Guidelines
- Python functions must be four space indented - no tabs.
- Shell functions in OE-Core usually use tabs for indentation, but other layers
usually use consistent indentation with 4 spaces (in shell functions, python
functions and for indentation of multi-line variables)
So I think that shell code can use either spaces or tabs as indentation.
> Can you please take care of meta-gplv2 as well?
> WARNING: meta-gplv2/recipes-core/coreutils/coreutils_6.9.bb
> <http://coreutils_6.9.bb>: python should use 4 spaces indentation, but found
> tabs in coreutils_6.9.bb <http://coreutils_6.9.bb>, line 95
Thanks, I've sent a patch for it.
// Robert
>
> I've sent patch for meta-oe issue:
> http://lists.openembedded.org/pipermail/openembedded-devel/2018-December/197803.html
>
>
> On Fri, Nov 23, 2018 at 11:51 AM Robert Yang <liezhi.yang@windriver.com
> <mailto:liezhi.yang@windriver.com>> wrote:
>
> Use 4 spaces to replace a tab.
>
> Signed-off-by: Robert Yang <liezhi.yang@windriver.com
> <mailto:liezhi.yang@windriver.com>>
> ---
> meta/classes/uboot-sign.bbclass | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/meta/classes/uboot-sign.bbclass b/meta/classes/uboot-sign.bbclass
> index 0e5e1b1..03100b8 100644
> --- a/meta/classes/uboot-sign.bbclass
> +++ b/meta/classes/uboot-sign.bbclass
> @@ -93,14 +93,14 @@ do_install_append() {
> }
>
> python () {
> - if d.getVar('UBOOT_SIGN_ENABLE') == '1' and d.getVar('PN') ==
> d.getVar('UBOOT_PN'):
> - kernel_pn = d.getVar('PREFERRED_PROVIDER_virtual/kernel')
> + if d.getVar('UBOOT_SIGN_ENABLE') == '1' and d.getVar('PN') ==
> d.getVar('UBOOT_PN'):
> + kernel_pn = d.getVar('PREFERRED_PROVIDER_virtual/kernel')
>
> - # Make "bitbake u-boot -cdeploy" deploys the signed u-boot.dtb
> - d.appendVarFlag('do_deploy', 'depends', ' %s:do_deploy' %
> kernel_pn)
> + # Make "bitbake u-boot -cdeploy" deploys the signed u-boot.dtb
> + d.appendVarFlag('do_deploy', 'depends', ' %s:do_deploy' % kernel_pn)
>
> - # kernerl's do_deploy is a litle special, so we can't use
> - # do_deploy_append, otherwise it would override
> - # kernel_do_deploy.
> - d.appendVarFlag('do_deploy', 'prefuncs', ' concat_dtb')
> + # kernerl's do_deploy is a litle special, so we can't use
> + # do_deploy_append, otherwise it would override
> + # kernel_do_deploy.
> + d.appendVarFlag('do_deploy', 'prefuncs', ' concat_dtb')
> }
> --
> 2.7.4
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> <mailto:Openembedded-core@lists.openembedded.org>
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/1] uboot-sign.bbclass: Remove tab indentations in python code
2018-12-06 2:59 ` Robert Yang
@ 2018-12-06 8:15 ` Martin Jansa
0 siblings, 0 replies; 6+ messages in thread
From: Martin Jansa @ 2018-12-06 8:15 UTC (permalink / raw)
To: Robert Yang; +Cc: Patches and discussions about the oe-core layer
[-- Attachment #1: Type: text/plain, Size: 3818 bytes --]
> So I think that shell code can use either spaces or tabs as indentation.
True, that's why I used "I wish" and ":)" because as Christmas gift I
always wanted consistency (not only between layers, but between shell and
python code as well).
On Thu, Dec 6, 2018 at 3:55 AM Robert Yang <liezhi.yang@windriver.com>
wrote:
> Hi Martin,
>
> On 12/5/18 10:40 PM, Martin Jansa wrote:
> > I wish we could have the same warning for shell code as well :).
> >
>
> According to oe's Format Guidelines:
>
> https://www.openembedded.org/wiki/Styleguide#Format_Guidelines
>
> - Python functions must be four space indented - no tabs.
> - Shell functions in OE-Core usually use tabs for indentation, but other
> layers
> usually use consistent indentation with 4 spaces (in shell functions,
> python
> functions and for indentation of multi-line variables)
>
>
> So I think that shell code can use either spaces or tabs as indentation.
>
> > Can you please take care of meta-gplv2 as well?
> > WARNING: meta-gplv2/recipes-core/coreutils/coreutils_6.9.bb
> > <http://coreutils_6.9.bb>: python should use 4 spaces indentation, but
> found
> > tabs in coreutils_6.9.bb <http://coreutils_6.9.bb>, line 95
>
> Thanks, I've sent a patch for it.
>
> // Robert
>
> >
> > I've sent patch for meta-oe issue:
> >
> http://lists.openembedded.org/pipermail/openembedded-devel/2018-December/197803.html
> >
> >
> > On Fri, Nov 23, 2018 at 11:51 AM Robert Yang <liezhi.yang@windriver.com
> > <mailto:liezhi.yang@windriver.com>> wrote:
> >
> > Use 4 spaces to replace a tab.
> >
> > Signed-off-by: Robert Yang <liezhi.yang@windriver.com
> > <mailto:liezhi.yang@windriver.com>>
> > ---
> > meta/classes/uboot-sign.bbclass | 16 ++++++++--------
> > 1 file changed, 8 insertions(+), 8 deletions(-)
> >
> > diff --git a/meta/classes/uboot-sign.bbclass
> b/meta/classes/uboot-sign.bbclass
> > index 0e5e1b1..03100b8 100644
> > --- a/meta/classes/uboot-sign.bbclass
> > +++ b/meta/classes/uboot-sign.bbclass
> > @@ -93,14 +93,14 @@ do_install_append() {
> > }
> >
> > python () {
> > - if d.getVar('UBOOT_SIGN_ENABLE') == '1' and d.getVar('PN') ==
> > d.getVar('UBOOT_PN'):
> > - kernel_pn =
> d.getVar('PREFERRED_PROVIDER_virtual/kernel')
> > + if d.getVar('UBOOT_SIGN_ENABLE') == '1' and d.getVar('PN') ==
> > d.getVar('UBOOT_PN'):
> > + kernel_pn = d.getVar('PREFERRED_PROVIDER_virtual/kernel')
> >
> > - # Make "bitbake u-boot -cdeploy" deploys the signed
> u-boot.dtb
> > - d.appendVarFlag('do_deploy', 'depends', '
> %s:do_deploy' %
> > kernel_pn)
> > + # Make "bitbake u-boot -cdeploy" deploys the signed
> u-boot.dtb
> > + d.appendVarFlag('do_deploy', 'depends', ' %s:do_deploy' %
> kernel_pn)
> >
> > - # kernerl's do_deploy is a litle special, so we
> can't use
> > - # do_deploy_append, otherwise it would override
> > - # kernel_do_deploy.
> > - d.appendVarFlag('do_deploy', 'prefuncs', '
> concat_dtb')
> > + # kernerl's do_deploy is a litle special, so we can't use
> > + # do_deploy_append, otherwise it would override
> > + # kernel_do_deploy.
> > + d.appendVarFlag('do_deploy', 'prefuncs', ' concat_dtb')
> > }
> > --
> > 2.7.4
> >
> > --
> > _______________________________________________
> > Openembedded-core mailing list
> > Openembedded-core@lists.openembedded.org
> > <mailto:Openembedded-core@lists.openembedded.org>
> > http://lists.openembedded.org/mailman/listinfo/openembedded-core
> >
>
[-- Attachment #2: Type: text/html, Size: 5982 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-12-06 8:15 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-23 11:08 [PATCH 0/1] uboot-sign.bbclass: Remove tab indentations in python code Robert Yang
2018-11-23 11:07 ` ✗ patchtest: failure for " Patchwork
2018-11-23 11:08 ` [PATCH 1/1] " Robert Yang
2018-12-05 14:40 ` Martin Jansa
2018-12-06 2:59 ` Robert Yang
2018-12-06 8:15 ` Martin Jansa
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.