* [PATCH] media: dt-bindings: coda: Add missing 'additionalProperties'
@ 2020-11-12 22:49 Rob Herring
2020-11-13 9:03 ` Philipp Zabel
2020-11-17 13:48 ` Rob Herring
0 siblings, 2 replies; 4+ messages in thread
From: Rob Herring @ 2020-11-12 22:49 UTC (permalink / raw)
To: Mauro Carvalho Chehab; +Cc: devicetree, Philipp Zabel, linux-media
'additionalProperties' is now required by the meta-schema. Add it for
coda.
Cc: Philipp Zabel <p.zabel@pengutronix.de>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: linux-media@vger.kernel.org
Signed-off-by: Rob Herring <robh@kernel.org>
---
Documentation/devicetree/bindings/media/coda.yaml | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/media/coda.yaml b/Documentation/devicetree/bindings/media/coda.yaml
index 7bac0057faf7..be6218354631 100644
--- a/Documentation/devicetree/bindings/media/coda.yaml
+++ b/Documentation/devicetree/bindings/media/coda.yaml
@@ -59,6 +59,8 @@ required:
- clocks
- clock-names
+additionalProperties: false
+
allOf:
- if:
properties:
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] media: dt-bindings: coda: Add missing 'additionalProperties'
2020-11-12 22:49 [PATCH] media: dt-bindings: coda: Add missing 'additionalProperties' Rob Herring
@ 2020-11-13 9:03 ` Philipp Zabel
2020-11-17 13:48 ` Rob Herring
1 sibling, 0 replies; 4+ messages in thread
From: Philipp Zabel @ 2020-11-13 9:03 UTC (permalink / raw)
To: Rob Herring, Mauro Carvalho Chehab; +Cc: devicetree, linux-media
On Thu, 2020-11-12 at 16:49 -0600, Rob Herring wrote:
> 'additionalProperties' is now required by the meta-schema. Add it for
> coda.
>
> Cc: Philipp Zabel <p.zabel@pengutronix.de>
> Cc: Mauro Carvalho Chehab <mchehab@kernel.org>
> Cc: linux-media@vger.kernel.org
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> Documentation/devicetree/bindings/media/coda.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/media/coda.yaml b/Documentation/devicetree/bindings/media/coda.yaml
> index 7bac0057faf7..be6218354631 100644
> --- a/Documentation/devicetree/bindings/media/coda.yaml
> +++ b/Documentation/devicetree/bindings/media/coda.yaml
> @@ -59,6 +59,8 @@ required:
> - clocks
> - clock-names
>
> +additionalProperties: false
> +
> allOf:
> - if:
> properties:
Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>
regards
Philipp
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] media: dt-bindings: coda: Add missing 'additionalProperties'
2020-11-12 22:49 [PATCH] media: dt-bindings: coda: Add missing 'additionalProperties' Rob Herring
2020-11-13 9:03 ` Philipp Zabel
@ 2020-11-17 13:48 ` Rob Herring
2020-11-17 14:07 ` Philipp Zabel
1 sibling, 1 reply; 4+ messages in thread
From: Rob Herring @ 2020-11-17 13:48 UTC (permalink / raw)
To: Mauro Carvalho Chehab; +Cc: devicetree, Philipp Zabel, Linux Media Mailing List
On Thu, Nov 12, 2020 at 4:49 PM Rob Herring <robh@kernel.org> wrote:
>
> 'additionalProperties' is now required by the meta-schema. Add it for
> coda.
>
> Cc: Philipp Zabel <p.zabel@pengutronix.de>
> Cc: Mauro Carvalho Chehab <mchehab@kernel.org>
> Cc: linux-media@vger.kernel.org
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> Documentation/devicetree/bindings/media/coda.yaml | 2 ++
> 1 file changed, 2 insertions(+)
I missed an error this introduces:
/home/rob/proj/git/linux-dt/.build-arm/Documentation/devicetree/bindings/media/coda.example.dt.yaml:
video-codec@63ff4000: 'interrupts' does not match any of the regexes:
'pinctrl-[0-9]+'
From schema:
/home/rob/proj/git/linux-dt/Documentation/devicetree/bindings/media/coda.yaml
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] media: dt-bindings: coda: Add missing 'additionalProperties'
2020-11-17 13:48 ` Rob Herring
@ 2020-11-17 14:07 ` Philipp Zabel
0 siblings, 0 replies; 4+ messages in thread
From: Philipp Zabel @ 2020-11-17 14:07 UTC (permalink / raw)
To: Rob Herring, Mauro Carvalho Chehab; +Cc: devicetree, Linux Media Mailing List
On Tue, 2020-11-17 at 07:48 -0600, Rob Herring wrote:
> On Thu, Nov 12, 2020 at 4:49 PM Rob Herring <robh@kernel.org> wrote:
> > 'additionalProperties' is now required by the meta-schema. Add it for
> > coda.
> >
> > Cc: Philipp Zabel <p.zabel@pengutronix.de>
> > Cc: Mauro Carvalho Chehab <mchehab@kernel.org>
> > Cc: linux-media@vger.kernel.org
> > Signed-off-by: Rob Herring <robh@kernel.org>
> > ---
> > Documentation/devicetree/bindings/media/coda.yaml | 2 ++
> > 1 file changed, 2 insertions(+)
>
> I missed an error this introduces:
>
> /home/rob/proj/git/linux-dt/.build-arm/Documentation/devicetree/bindings/media/coda.example.dt.yaml:
> video-codec@63ff4000: 'interrupts' does not match any of the regexes:
> 'pinctrl-[0-9]+'
> From schema:
> /home/rob/proj/git/linux-dt/Documentation/devicetree/bindings/media/coda.yaml
Right, because interrupts are only specified conditionally:
allOf:
- if:
properties:
compatible:
contains:
const: cnm,coda960
then:
properties:
interrupts:
items:
- description: BIT processor interrupt
- description: JPEG unit interrupt
interrupt-names:
items:
- const: bit
- const: jpeg
else:
properties:
interrupts:
items:
- description: BIT processor interrupt
What is the proper way to fix this?
regards
Philipp
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-11-17 14:08 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-12 22:49 [PATCH] media: dt-bindings: coda: Add missing 'additionalProperties' Rob Herring
2020-11-13 9:03 ` Philipp Zabel
2020-11-17 13:48 ` Rob Herring
2020-11-17 14:07 ` Philipp Zabel
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.