From: <milanpa@amazon.com>
To: Paolo Bonzini <pbonzini@redhat.com>,
Alexander Graf <graf@amazon.de>,
Milan Pandurov <milanpa@amazon.de>, <kvm@vger.kernel.org>
Cc: <rkrcmar@redhat.com>, <borntraeger@de.ibm.com>
Subject: Re: [PATCH 2/2] kvm: Add ioctl for gathering debug counters
Date: Thu, 23 Jan 2020 16:27:46 +0100 [thread overview]
Message-ID: <01dc5863-91b4-6ee0-2985-8c2bf41e73e9@amazon.com> (raw)
In-Reply-To: <2e2cd423-ab6c-87ec-b856-2c7ca191d809@redhat.com>
On 1/23/20 4:05 PM, Paolo Bonzini wrote:
> On 23/01/20 15:58, Alexander Graf wrote:
>>> the case, of course it would be fine for me to use ONE_REG on a VM. The
>>> part which I don't like is having to make all ONE_REG part of the
>>> userspace ABI/API.
>> We don't have all of ONE_REG as part of the user space ABI today.
> Still those that exist cannot change their id. This makes them a part
> of the userspace ABI.
>
>> But I like the idea of a ONE_REG query interface that gives you the list
>> of available registers and a string representation of them. It would
>> make programming kvm from Python so easy!
> Yeah, wouldn't it? Milan, what do you think about it?
>
> Paolo
>
I agree, extending the API with GET_AVAILABLE_ONE_REGS (and possibly a
bitmask argument to narrow down which type of registers userspace is
interested in) is a clean solution. We won't require userspace to rely
on constants in compile time if it doesn't need to.
Only concern is that now we need to have some kind of datastructure for
keeping the mappings between all available ONE_REG IDs and their
strings/descriptions. Additionally enforcing that newly added ONE_REGs
always get added to that mapping, is also necessary.
Milan
Amazon Development Center Germany GmbH
Krausenstr. 38
10117 Berlin
Geschaeftsfuehrung: Christian Schlaeger, Jonathan Weiss
Eingetragen am Amtsgericht Charlottenburg unter HRB 149173 B
Sitz: Berlin
Ust-ID: DE 289 237 879
next prev parent reply other threads:[~2020-01-23 15:27 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-15 13:43 [PATCH 2/2] kvm: Add ioctl for gathering debug counters Milan Pandurov
2020-01-15 14:04 ` Alexander Graf
2020-01-15 14:43 ` milanpa
2020-01-15 14:59 ` Alexander Graf
2020-01-17 23:38 ` Paolo Bonzini
2020-01-20 17:53 ` Alexander Graf
2020-01-20 18:57 ` milanpa
2020-01-21 15:38 ` Alexander Graf
2020-01-23 12:08 ` Paolo Bonzini
2020-01-23 12:32 ` Alexander Graf
2020-01-23 14:19 ` Paolo Bonzini
2020-01-23 14:45 ` Alexander Graf
2020-01-23 14:50 ` Paolo Bonzini
2020-01-23 14:58 ` Alexander Graf
2020-01-23 15:05 ` Paolo Bonzini
2020-01-23 15:27 ` milanpa [this message]
2020-01-23 16:15 ` Paolo Bonzini
2020-01-23 18:31 ` milanpa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=01dc5863-91b4-6ee0-2985-8c2bf41e73e9@amazon.com \
--to=milanpa@amazon.com \
--cc=borntraeger@de.ibm.com \
--cc=graf@amazon.de \
--cc=kvm@vger.kernel.org \
--cc=milanpa@amazon.de \
--cc=pbonzini@redhat.com \
--cc=rkrcmar@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.