All of lore.kernel.org
 help / color / mirror / Atom feed
From: <milanpa@amazon.com>
To: Paolo Bonzini <pbonzini@redhat.com>,
	Alexander Graf <graf@amazon.de>,
	Milan Pandurov <milanpa@amazon.de>, <kvm@vger.kernel.org>
Cc: <rkrcmar@redhat.com>, <borntraeger@de.ibm.com>
Subject: Re: [PATCH 2/2] kvm: Add ioctl for gathering debug counters
Date: Thu, 23 Jan 2020 19:31:52 +0100	[thread overview]
Message-ID: <45329483-5a7c-089e-fa85-4b3ada231493@amazon.com> (raw)
In-Reply-To: <f71763ad-2336-0436-39fc-bb476b559eee@redhat.com>

On 1/23/20 5:15 PM, Paolo Bonzini wrote:
> On 23/01/20 16:27, milanpa@amazon.com wrote:
>>>
>>> Paolo
>>>
>> I agree, extending the API with GET_AVAILABLE_ONE_REGS (and possibly a
>> bitmask argument to narrow down which type of registers userspace is
>> interested in) is a clean solution. We won't require userspace to rely
>> on constants in compile time if it doesn't need to.
>>
>> Only concern is that now we need to have some kind of datastructure for
>> keeping the mappings between all available ONE_REG IDs and their
>> strings/descriptions. Additionally enforcing that newly added ONE_REGs
>> always get added to that mapping, is also necessary.
> For now just do the implementation for VM ONE_REGs.  We'll worry about
> the existing VCPU registers later.
>
> Paolo
>
Sounds good.

Thanks for the help, I will update the patch soon.

Milan




Amazon Development Center Germany GmbH
Krausenstr. 38
10117 Berlin
Geschaeftsfuehrung: Christian Schlaeger, Jonathan Weiss
Eingetragen am Amtsgericht Charlottenburg unter HRB 149173 B
Sitz: Berlin
Ust-ID: DE 289 237 879



      reply	other threads:[~2020-01-23 18:32 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-15 13:43 [PATCH 2/2] kvm: Add ioctl for gathering debug counters Milan Pandurov
2020-01-15 14:04 ` Alexander Graf
2020-01-15 14:43   ` milanpa
2020-01-15 14:59     ` Alexander Graf
2020-01-17 23:38       ` Paolo Bonzini
2020-01-20 17:53         ` Alexander Graf
2020-01-20 18:57           ` milanpa
2020-01-21 15:38             ` Alexander Graf
2020-01-23 12:08               ` Paolo Bonzini
2020-01-23 12:32                 ` Alexander Graf
2020-01-23 14:19                   ` Paolo Bonzini
2020-01-23 14:45                     ` Alexander Graf
2020-01-23 14:50                       ` Paolo Bonzini
2020-01-23 14:58                         ` Alexander Graf
2020-01-23 15:05                           ` Paolo Bonzini
2020-01-23 15:27                             ` milanpa
2020-01-23 16:15                               ` Paolo Bonzini
2020-01-23 18:31                                 ` milanpa [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45329483-5a7c-089e-fa85-4b3ada231493@amazon.com \
    --to=milanpa@amazon.com \
    --cc=borntraeger@de.ibm.com \
    --cc=graf@amazon.de \
    --cc=kvm@vger.kernel.org \
    --cc=milanpa@amazon.de \
    --cc=pbonzini@redhat.com \
    --cc=rkrcmar@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.