All of lore.kernel.org
 help / color / mirror / Atom feed
* [GIT PULL] Fujitsu for 4.5
@ 2016-01-13  9:28 Zhao Lei
  2016-01-14 14:17 ` David Sterba
  2016-02-10 10:13 ` David Sterba
  0 siblings, 2 replies; 9+ messages in thread
From: Zhao Lei @ 2016-01-13  9:28 UTC (permalink / raw)
  To: 'Chris Mason'; +Cc: 'btrfs', zhaolei

Hi Chris,

This is collection of some bug fix, enhance and cleanup from fujitsu
against btrfs for v4.5, mainly for reada, plus some small fix and cleanup
for scrub and raid56.

All patchs are in btrfs-maillist, rebased on top of integration-4.5.

TEST STATUS:
Tested by xfstests, btrfs and generic group with default mount option,
diffed result with 4.4-rc8 and confirmed no regression:
Diff From:
  dir=/var/ltf/testqueue/v4.4-rc8/xfstests/
  head=v4.4-rc8
Diff To:
  dir=/var/ltf/testqueue/8e16378041f7f3531c256fd3e17a36a4fca92d29
  head=v4.4-rc6_00037_8e1637
Test:
  node=ALL
Decrease items:
  none

Xfstests for other 9 mount options is in running, I'll check results after finished.

Would you please consider merging the following fixes to integration-4.5 branch?

REPO is:
https://github.com/zhaoleidd/btrfs.git integration-4.5

--
Zhao Lei (26):
  btrfs: Small cleanup for get index_srcdev loop
  btrfs: Use direct way to determine raid56 write/recover mode
  btrfs: Fix in-segment calculation for reada
  btrfs: reduce additional fs_info->reada_lock in reada_find_zone
  btrfs: Add missed segment checking in reada_find_zone
  btrfs: reada: Avoid many times of empty loop
  btrfs: reada: Move is_need_to_readahead contition earlier
  btrfs: reada: add all reachable mirrors into reada device list
  btrfs: reada: bypass adding extent when all zone failed
  btrfs: reada: Remove level argument in severial functions
  btrfs: reada: move reada_extent_put to place after __readahead_hook()
  btrfs: reada: Pass reada_extent into __readahead_hook directly
  btrfs: reada: Use fs_info instead of root in __readahead_hook's
    argument
  btrfs: reada: Jump into cleanup in direct way for __readahead_hook()
  btrfs: reada: Fix a debug code typo
  btrfs: Continue write in case of can_not_nocow
  btrfs: delete no_used argument in btrfs_copy_from_user
  btrfs: merge functions for wait snapshot creation
  btrfs: reada: limit max works count
  btrfs: reada: simplify dev->reada_in_flight processing
  btrfs: Fix no_space in write and rm loop
  btrfs: Fix calculation of rbio->dbitmap's size calculation
  btrfs: Use unified stripe_page's index calculation
  btrfs: use rbio->nr_pages to reduce calculation
  btrfs: Remove unnecessary ClearPageUptodate for raid56
  btrfs: raid56: Use raid_write_end_io for scrub

 fs/btrfs/ctree.h       |   5 +-
 fs/btrfs/disk-io.c     |  22 ++---
 fs/btrfs/extent-tree.c |  24 +++++-
 fs/btrfs/file.c        |  43 +++++-----
 fs/btrfs/inode.c       |  22 +----
 fs/btrfs/raid56.c      | 100 ++++++++--------------
 fs/btrfs/reada.c       | 224 ++++++++++++++++++++++++-------------------------
 fs/btrfs/scrub.c       |   2 +-
 fs/btrfs/volumes.c     |  45 +++++-----
 9 files changed, 225 insertions(+), 262 deletions(-)

Thanks
Zhaolei





^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [GIT PULL] Fujitsu for 4.5
  2016-01-13  9:28 [GIT PULL] Fujitsu for 4.5 Zhao Lei
@ 2016-01-14 14:17 ` David Sterba
  2016-01-15  9:46   ` Zhao Lei
  2016-01-15 16:12   ` Chris Mason
  2016-02-10 10:13 ` David Sterba
  1 sibling, 2 replies; 9+ messages in thread
From: David Sterba @ 2016-01-14 14:17 UTC (permalink / raw)
  To: Zhao Lei; +Cc: 'Chris Mason', 'btrfs'

On Wed, Jan 13, 2016 at 05:28:12PM +0800, Zhao Lei wrote:
> This is collection of some bug fix, enhance and cleanup from fujitsu
> against btrfs for v4.5, mainly for reada, plus some small fix and cleanup
> for scrub and raid56.
> 
> All patchs are in btrfs-maillist, rebased on top of integration-4.5.
> 
> Would you please consider merging the following fixes to integration-4.5 branch?

> Zhao Lei (26):
...
>   btrfs: reada: Avoid many times of empty loop
>   btrfs: reada: Move is_need_to_readahead contition earlier
>   btrfs: reada: add all reachable mirrors into reada device list
>   btrfs: reada: bypass adding extent when all zone failed
>   btrfs: reada: Remove level argument in severial functions
>   btrfs: reada: move reada_extent_put to place after __readahead_hook()
>   btrfs: reada: Pass reada_extent into __readahead_hook directly
>   btrfs: reada: Use fs_info instead of root in __readahead_hook's
>     argument
>   btrfs: reada: Jump into cleanup in direct way for __readahead_hook()
>   btrfs: reada: Fix a debug code typo
...
>   btrfs: reada: limit max works count
>   btrfs: reada: simplify dev->reada_in_flight processing

I have reviewed the readahead patches and ack them for 4.5.

^ permalink raw reply	[flat|nested] 9+ messages in thread

* RE: [GIT PULL] Fujitsu for 4.5
  2016-01-14 14:17 ` David Sterba
@ 2016-01-15  9:46   ` Zhao Lei
  2016-01-15 16:49     ` David Sterba
  2016-01-15 16:12   ` Chris Mason
  1 sibling, 1 reply; 9+ messages in thread
From: Zhao Lei @ 2016-01-15  9:46 UTC (permalink / raw)
  To: dsterba; +Cc: 'Chris Mason', 'btrfs'

Hi, David Sterba

> From: David Sterba [mailto:dsterba@suse.cz]
> Sent: Thursday, January 14, 2016 10:17 PM
> To: Zhao Lei <zhaolei@cn.fujitsu.com>
> Cc: 'Chris Mason' <clm@fb.com>; 'btrfs' <linux-btrfs@vger.kernel.org>
> Subject: Re: [GIT PULL] Fujitsu for 4.5
> 
> On Wed, Jan 13, 2016 at 05:28:12PM +0800, Zhao Lei wrote:
> > This is collection of some bug fix, enhance and cleanup from fujitsu
> > against btrfs for v4.5, mainly for reada, plus some small fix and
> > cleanup for scrub and raid56.
> >
> > All patchs are in btrfs-maillist, rebased on top of integration-4.5.
> >
> > Would you please consider merging the following fixes to integration-4.5
> branch?
> 
> > Zhao Lei (26):
> ...
> >   btrfs: reada: Avoid many times of empty loop
> >   btrfs: reada: Move is_need_to_readahead contition earlier
> >   btrfs: reada: add all reachable mirrors into reada device list
> >   btrfs: reada: bypass adding extent when all zone failed
> >   btrfs: reada: Remove level argument in severial functions
> >   btrfs: reada: move reada_extent_put to place after __readahead_hook()
> >   btrfs: reada: Pass reada_extent into __readahead_hook directly
> >   btrfs: reada: Use fs_info instead of root in __readahead_hook's
> >     argument
> >   btrfs: reada: Jump into cleanup in direct way for __readahead_hook()
> >   btrfs: reada: Fix a debug code typo
> ...
> >   btrfs: reada: limit max works count
> >   btrfs: reada: simplify dev->reada_in_flight processing
> 
> I have reviewed the readahead patches and ack them for 4.5.

Great thanks for reviewing these patchs.

And following 3 patchs in this branch are also for readahead, but sorry that
I forgot adding "reada" prefix in subject.
  btrfs: Fix in-segment calculation for reada
  btrfs: reduce additional fs_info->reada_lock in reada_find_zone
  btrfs: Add missed segment checking in reada_find_zone

Would you please consider helping me to review them?

Thanks
Zhaolei





^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [GIT PULL] Fujitsu for 4.5
  2016-01-14 14:17 ` David Sterba
  2016-01-15  9:46   ` Zhao Lei
@ 2016-01-15 16:12   ` Chris Mason
  1 sibling, 0 replies; 9+ messages in thread
From: Chris Mason @ 2016-01-15 16:12 UTC (permalink / raw)
  To: dsterba, Zhao Lei, 'btrfs'

On Thu, Jan 14, 2016 at 03:17:10PM +0100, David Sterba wrote:
> On Wed, Jan 13, 2016 at 05:28:12PM +0800, Zhao Lei wrote:
> > This is collection of some bug fix, enhance and cleanup from fujitsu
> > against btrfs for v4.5, mainly for reada, plus some small fix and cleanup
> > for scrub and raid56.
> > 
> > All patchs are in btrfs-maillist, rebased on top of integration-4.5.
> > 
> > Would you please consider merging the following fixes to integration-4.5 branch?
> 
> > Zhao Lei (26):
> ...
> >   btrfs: reada: Avoid many times of empty loop
> >   btrfs: reada: Move is_need_to_readahead contition earlier
> >   btrfs: reada: add all reachable mirrors into reada device list
> >   btrfs: reada: bypass adding extent when all zone failed
> >   btrfs: reada: Remove level argument in severial functions
> >   btrfs: reada: move reada_extent_put to place after __readahead_hook()
> >   btrfs: reada: Pass reada_extent into __readahead_hook directly
> >   btrfs: reada: Use fs_info instead of root in __readahead_hook's
> >     argument
> >   btrfs: reada: Jump into cleanup in direct way for __readahead_hook()
> >   btrfs: reada: Fix a debug code typo
> ...
> >   btrfs: reada: limit max works count
> >   btrfs: reada: simplify dev->reada_in_flight processing
> 
> I have reviewed the readahead patches and ack them for 4.5.

My plan is to send the first 4.5 pull on Monday with the current
integration.  I hit an oom during overnight runs, and I'm double
checking things after that.

I'll get the reada stuff merged for a second pull.

-chris


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [GIT PULL] Fujitsu for 4.5
  2016-01-15  9:46   ` Zhao Lei
@ 2016-01-15 16:49     ` David Sterba
  2016-01-18 11:02       ` Zhao Lei
  0 siblings, 1 reply; 9+ messages in thread
From: David Sterba @ 2016-01-15 16:49 UTC (permalink / raw)
  To: Zhao Lei; +Cc: dsterba, 'Chris Mason', 'btrfs'

On Fri, Jan 15, 2016 at 05:46:42PM +0800, Zhao Lei wrote:
> And following 3 patchs in this branch are also for readahead, but sorry that
> I forgot adding "reada" prefix in subject.
>   btrfs: Fix in-segment calculation for reada
>   btrfs: reduce additional fs_info->reada_lock in reada_find_zone
>   btrfs: Add missed segment checking in reada_find_zone
> 
> Would you please consider helping me to review them?

All three reviewed and look ok, but the changelogs could be improved,
eg. what are the implications of missing the zones etc.

^ permalink raw reply	[flat|nested] 9+ messages in thread

* RE: [GIT PULL] Fujitsu for 4.5
  2016-01-15 16:49     ` David Sterba
@ 2016-01-18 11:02       ` Zhao Lei
  0 siblings, 0 replies; 9+ messages in thread
From: Zhao Lei @ 2016-01-18 11:02 UTC (permalink / raw)
  To: dsterba; +Cc: 'Chris Mason', 'btrfs'

Hi, David Sterba

> From: David Sterba [mailto:dsterba@suse.cz]
> Sent: Saturday, January 16, 2016 12:50 AM
> To: Zhao Lei <zhaolei@cn.fujitsu.com>
> Cc: dsterba@suse.cz; 'Chris Mason' <clm@fb.com>; 'btrfs'
> <linux-btrfs@vger.kernel.org>
> Subject: Re: [GIT PULL] Fujitsu for 4.5
> 
> On Fri, Jan 15, 2016 at 05:46:42PM +0800, Zhao Lei wrote:
> > And following 3 patchs in this branch are also for readahead, but
> > sorry that I forgot adding "reada" prefix in subject.
> >   btrfs: Fix in-segment calculation for reada
> >   btrfs: reduce additional fs_info->reada_lock in reada_find_zone
> >   btrfs: Add missed segment checking in reada_find_zone
> >
> > Would you please consider helping me to review them?
> 
> All three reviewed and look ok, but the changelogs could be improved, eg. what
> are the implications of missing the zones etc.

Thanks for review.
I'll update changelogs in the tree.

Thanks
Zhaolei




^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [GIT PULL] Fujitsu for 4.5
  2016-01-13  9:28 [GIT PULL] Fujitsu for 4.5 Zhao Lei
  2016-01-14 14:17 ` David Sterba
@ 2016-02-10 10:13 ` David Sterba
  2016-02-15  4:07   ` Zhao Lei
  1 sibling, 1 reply; 9+ messages in thread
From: David Sterba @ 2016-02-10 10:13 UTC (permalink / raw)
  To: Zhao Lei; +Cc: 'Chris Mason', 'btrfs'

On Wed, Jan 13, 2016 at 05:28:12PM +0800, Zhao Lei wrote:
> This is collection of some bug fix, enhance and cleanup from fujitsu
> against btrfs for v4.5, mainly for reada, plus some small fix and cleanup
> for scrub and raid56.
> 
> All patchs are in btrfs-maillist, rebased on top of integration-4.5.

I was trying to isolate safe fixes for 4.5 but saw hangs (same as Chris
reported) and was not able to find the right followups.

Can you please collect all your readahead patches sent recently? I got
lost. Make it a git branch and let me know, I'll add it to for-next and
send pull request for 4.6 later.

^ permalink raw reply	[flat|nested] 9+ messages in thread

* RE: [GIT PULL] Fujitsu for 4.5
  2016-02-10 10:13 ` David Sterba
@ 2016-02-15  4:07   ` Zhao Lei
  2016-02-16 10:05     ` David Sterba
  0 siblings, 1 reply; 9+ messages in thread
From: Zhao Lei @ 2016-02-15  4:07 UTC (permalink / raw)
  To: dsterba; +Cc: 'Chris Mason', 'btrfs'

Hi, David Sterba

Thanks for notice me, sorry for reply late.

> From: David Sterba [mailto:dsterba@suse.cz]
> Sent: Wednesday, February 10, 2016 6:14 PM
> To: Zhao Lei <zhaolei@cn.fujitsu.com>
> Cc: 'Chris Mason' <clm@fb.com>; 'btrfs' <linux-btrfs@vger.kernel.org>
> Subject: Re: [GIT PULL] Fujitsu for 4.5
> 
> On Wed, Jan 13, 2016 at 05:28:12PM +0800, Zhao Lei wrote:
> > This is collection of some bug fix, enhance and cleanup from fujitsu
> > against btrfs for v4.5, mainly for reada, plus some small fix and cleanup
> > for scrub and raid56.
> >
> > All patchs are in btrfs-maillist, rebased on top of integration-4.5.
> 
> I was trying to isolate safe fixes for 4.5 but saw hangs (same as Chris
> reported) and was not able to find the right followups.
> 
The problem is discussed in btrfs maillist from:
http://www.spinics.net/lists/linux-btrfs/msg51275.html
to
http://www.spinics.net/lists/linux-btrfs/msg51538.html

It is fixed now.

> Can you please collect all your readahead patches sent recently? I got
> lost. Make it a git branch and let me know, I'll add it to for-next and
> send pull request for 4.6 later.
I collected all reada patchs in:
https://github.com/zhaoleidd/btrfs.git integration-4.5

The description of above branch is this:
http://www.spinics.net/lists/linux-btrfs/msg51531.html

Thanks
Zhaolei




^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [GIT PULL] Fujitsu for 4.5
  2016-02-15  4:07   ` Zhao Lei
@ 2016-02-16 10:05     ` David Sterba
  0 siblings, 0 replies; 9+ messages in thread
From: David Sterba @ 2016-02-16 10:05 UTC (permalink / raw)
  To: Zhao Lei; +Cc: 'Chris Mason', 'btrfs'

On Mon, Feb 15, 2016 at 12:07:01PM +0800, Zhao Lei wrote:
> Hi, David Sterba
> 
> Thanks for notice me, sorry for reply late.
> 
> > From: David Sterba [mailto:dsterba@suse.cz]
> > Sent: Wednesday, February 10, 2016 6:14 PM
> > To: Zhao Lei <zhaolei@cn.fujitsu.com>
> > Cc: 'Chris Mason' <clm@fb.com>; 'btrfs' <linux-btrfs@vger.kernel.org>
> > Subject: Re: [GIT PULL] Fujitsu for 4.5
> > 
> > On Wed, Jan 13, 2016 at 05:28:12PM +0800, Zhao Lei wrote:
> > > This is collection of some bug fix, enhance and cleanup from fujitsu
> > > against btrfs for v4.5, mainly for reada, plus some small fix and cleanup
> > > for scrub and raid56.
> > >
> > > All patchs are in btrfs-maillist, rebased on top of integration-4.5.
> > 
> > I was trying to isolate safe fixes for 4.5 but saw hangs (same as Chris
> > reported) and was not able to find the right followups.
> > 
> The problem is discussed in btrfs maillist from:
> http://www.spinics.net/lists/linux-btrfs/msg51275.html
> to
> http://www.spinics.net/lists/linux-btrfs/msg51538.html
> 
> It is fixed now.
> 
> > Can you please collect all your readahead patches sent recently? I got
> > lost. Make it a git branch and let me know, I'll add it to for-next and
> > send pull request for 4.6 later.
> I collected all reada patchs in:
> https://github.com/zhaoleidd/btrfs.git integration-4.5

There's patch

btrfs: Continue write in case of can_not_nocow

that does not count as readahead fix, so I'll pull it via different
branch.

^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2016-02-16 10:05 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-01-13  9:28 [GIT PULL] Fujitsu for 4.5 Zhao Lei
2016-01-14 14:17 ` David Sterba
2016-01-15  9:46   ` Zhao Lei
2016-01-15 16:49     ` David Sterba
2016-01-18 11:02       ` Zhao Lei
2016-01-15 16:12   ` Chris Mason
2016-02-10 10:13 ` David Sterba
2016-02-15  4:07   ` Zhao Lei
2016-02-16 10:05     ` David Sterba

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.