* [igt-dev] [PATCH i-g-t] lib/tests: Drop automake support
@ 2019-02-07 15:25 Daniel Vetter
2019-02-07 15:57 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
` (3 more replies)
0 siblings, 4 replies; 8+ messages in thread
From: Daniel Vetter @ 2019-02-07 15:25 UTC (permalink / raw)
To: IGT development; +Cc: Daniel Vetter
Really not needed if we check this with meson.
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
---
Passed gitlab-ci:
https://gitlab.freedesktop.org/danvet/igt-gpu-tools/commit/28a1d87c2001c473ecd2b89edf7ad1ba26b5d039
---
configure.ac | 1 -
lib/Makefile.am | 2 --
lib/tests/Makefile.am | 24 ------------------------
lib/tests/Makefile.sources | 36 ------------------------------------
4 files changed, 63 deletions(-)
delete mode 100644 lib/tests/Makefile.am
delete mode 100644 lib/tests/Makefile.sources
diff --git a/configure.ac b/configure.ac
index b46f024f875a..0588b0f9dad3 100644
--- a/configure.ac
+++ b/configure.ac
@@ -294,7 +294,6 @@ AC_CONFIG_FILES([
Makefile
benchmarks/Makefile
lib/Makefile
- lib/tests/Makefile
scripts/Makefile
tests/Makefile
tests/intel-ci/Makefile
diff --git a/lib/Makefile.am b/lib/Makefile.am
index 3b88e3397833..3e6a7fdba9ac 100644
--- a/lib/Makefile.am
+++ b/lib/Makefile.am
@@ -1,8 +1,6 @@
IGT_LIB_PATH := $(builddir)
GPU_TOOLS_PATH := $(top_srcdir)
-SUBDIRS = . tests
-
include Makefile.sources
libintel_tools_la_SOURCES = $(lib_source_list)
diff --git a/lib/tests/Makefile.am b/lib/tests/Makefile.am
deleted file mode 100644
index 789fc551f9be..000000000000
--- a/lib/tests/Makefile.am
+++ /dev/null
@@ -1,24 +0,0 @@
-include Makefile.sources
-
-check_PROGRAMS = $(check_prog_list)
-check_SCRIPTS = $(check_script_list)
-
-AM_TESTS_ENVIRONMENT = \
- top_builddir=$(top_builddir) \
- top_srcdir=$(top_srcdir)
-
-AM_CPPFLAGS = \
- -I$(top_srcdir)/include/drm-uapi \
- -I$(srcdir)/../.. \
- -I$(srcdir)/.. \
- -I$(top_srcdir)/lib/stubs/syscalls \
- -include "$(srcdir)/../../lib/check-ndebug.h" \
- -DIGT_DATADIR=\""$(abs_srcdir)"\" \
- -D_GNU_SOURCE
-
-AM_CFLAGS = $(DRM_CFLAGS) $(CWARNFLAGS) $(DEBUG_CFLAGS)
-
-LDADD = ../libintel_tools.la $(PCIACCESS_LIBS) $(DRM_LIBS) $(LIBUNWIND_LIBS) $(TIMER_LIBS)
-
-LDADD += $(CAIRO_LIBS) $(LIBUDEV_LIBS) $(GLIB_LIBS) -lm
-AM_CFLAGS += $(CAIRO_CFLAGS) $(LIBUDEV_CFLAGS) $(GLIB_CFLAGS)
diff --git a/lib/tests/Makefile.sources b/lib/tests/Makefile.sources
deleted file mode 100644
index 8d1a8dea8263..000000000000
--- a/lib/tests/Makefile.sources
+++ /dev/null
@@ -1,36 +0,0 @@
-check_prog_list = \
- igt_no_exit \
- igt_no_exit_list_only \
- igt_fork_helper \
- igt_list_only \
- igt_no_subtest \
- igt_simulation \
- igt_simple_test_subtests \
- igt_stats \
- igt_timeout \
- igt_invalid_subtest_name \
- igt_segfault \
- igt_subtest_group \
- igt_assert \
- igt_exit_handler \
- igt_hdmi_inject \
- igt_can_fail \
- igt_can_fail_simple \
- $(NULL)
-
-TESTS = \
- $(check_prog_list) \
- $(check_script_list) \
- $(NULL)
-
-# Test that exercise specific asserts in the test framework library and are
-# hence expected to fail.
-DISABLE_HARD_ERRORS=1
-XFAIL_TESTS = \
- igt_no_exit \
- igt_no_exit_list_only \
- igt_no_subtest \
- igt_simple_test_subtests \
- igt_timeout \
- igt_invalid_subtest_name \
- $(NULL)
--
2.20.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for lib/tests: Drop automake support
2019-02-07 15:25 [igt-dev] [PATCH i-g-t] lib/tests: Drop automake support Daniel Vetter
@ 2019-02-07 15:57 ` Patchwork
2019-02-07 16:19 ` [igt-dev] [PATCH i-g-t] " Antonio Argenziano
` (2 subsequent siblings)
3 siblings, 0 replies; 8+ messages in thread
From: Patchwork @ 2019-02-07 15:57 UTC (permalink / raw)
To: Daniel Vetter; +Cc: igt-dev
== Series Details ==
Series: lib/tests: Drop automake support
URL : https://patchwork.freedesktop.org/series/56346/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5560 -> IGTPW_2353
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/56346/revisions/1/mbox/
Known issues
------------
Here are the changes found in IGTPW_2353 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@amdgpu/amd_basic@userptr:
- fi-kbl-8809g: PASS -> DMESG-WARN [fdo#108965]
* igt@gem_exec_suspend@basic-s3:
- fi-blb-e6850: PASS -> INCOMPLETE [fdo#107718]
* igt@i915_selftest@live_hangcheck:
- fi-skl-iommu: PASS -> INCOMPLETE [fdo#108602] / [fdo#108744]
* igt@kms_busy@basic-flip-b:
- fi-gdg-551: PASS -> FAIL [fdo#103182]
* igt@kms_chamelium@common-hpd-after-suspend:
- fi-kbl-7500u: NOTRUN -> DMESG-WARN [fdo#102505] / [fdo#103558] / [fdo#105079] / [fdo#105602]
#### Possible fixes ####
* igt@i915_selftest@live_hangcheck:
- fi-skl-gvtdvm: INCOMPLETE [fdo#105600] / [fdo#108744] -> PASS
* igt@kms_chamelium@common-hpd-after-suspend:
- fi-kbl-7567u: WARN [fdo#109380] -> PASS
* igt@kms_pipe_crc_basic@hang-read-crc-pipe-b:
- fi-byt-clapper: FAIL [fdo#103191] / [fdo#107362] -> PASS
* igt@kms_pipe_crc_basic@nonblocking-crc-pipe-c:
- fi-kbl-7567u: {SKIP} [fdo#109271] -> PASS +33
* igt@pm_rpm@basic-pci-d3-state:
- fi-byt-j1900: {SKIP} [fdo#109271] -> PASS
* igt@pm_rpm@basic-rte:
- fi-byt-j1900: FAIL [fdo#108800] -> PASS
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#102505]: https://bugs.freedesktop.org/show_bug.cgi?id=102505
[fdo#103182]: https://bugs.freedesktop.org/show_bug.cgi?id=103182
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#103558]: https://bugs.freedesktop.org/show_bug.cgi?id=103558
[fdo#104108]: https://bugs.freedesktop.org/show_bug.cgi?id=104108
[fdo#105079]: https://bugs.freedesktop.org/show_bug.cgi?id=105079
[fdo#105600]: https://bugs.freedesktop.org/show_bug.cgi?id=105600
[fdo#105602]: https://bugs.freedesktop.org/show_bug.cgi?id=105602
[fdo#107362]: https://bugs.freedesktop.org/show_bug.cgi?id=107362
[fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
[fdo#108569]: https://bugs.freedesktop.org/show_bug.cgi?id=108569
[fdo#108602]: https://bugs.freedesktop.org/show_bug.cgi?id=108602
[fdo#108744]: https://bugs.freedesktop.org/show_bug.cgi?id=108744
[fdo#108800]: https://bugs.freedesktop.org/show_bug.cgi?id=108800
[fdo#108965]: https://bugs.freedesktop.org/show_bug.cgi?id=108965
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109380]: https://bugs.freedesktop.org/show_bug.cgi?id=109380
[fdo#109527]: https://bugs.freedesktop.org/show_bug.cgi?id=109527
[fdo#109567]: https://bugs.freedesktop.org/show_bug.cgi?id=109567
Participating hosts (48 -> 44)
------------------------------
Additional (1): fi-kbl-7500u
Missing (5): fi-ilk-m540 fi-bxt-dsi fi-byt-squawks fi-bsw-cyan fi-bdw-samus
Build changes
-------------
* IGT: IGT_4813 -> IGTPW_2353
CI_DRM_5560: b3cc6ae9211bbf4e40195469147a884b74c0ec8e @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2353: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2353/
IGT_4813: 09f506726d0e115ee7f4a1604ae71adcf9f12690 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2353/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] lib/tests: Drop automake support
2019-02-07 15:25 [igt-dev] [PATCH i-g-t] lib/tests: Drop automake support Daniel Vetter
2019-02-07 15:57 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
@ 2019-02-07 16:19 ` Antonio Argenziano
2019-02-07 16:36 ` Daniel Vetter
2019-02-07 17:24 ` [igt-dev] ✓ Fi.CI.IGT: success for " Patchwork
2019-02-08 11:51 ` [igt-dev] [PATCH i-g-t] " Petri Latvala
3 siblings, 1 reply; 8+ messages in thread
From: Antonio Argenziano @ 2019-02-07 16:19 UTC (permalink / raw)
To: Daniel Vetter, IGT development; +Cc: Daniel Vetter
On 07/02/19 07:25, Daniel Vetter wrote:
> Really not needed if we check this with meson.
Maybe now drop the automake support from readme as well: "Currently we
support both meson and automake as build systems".
Antonio
>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> ---
> Passed gitlab-ci:
>
> https://gitlab.freedesktop.org/danvet/igt-gpu-tools/commit/28a1d87c2001c473ecd2b89edf7ad1ba26b5d039
> ---
> configure.ac | 1 -
> lib/Makefile.am | 2 --
> lib/tests/Makefile.am | 24 ------------------------
> lib/tests/Makefile.sources | 36 ------------------------------------
> 4 files changed, 63 deletions(-)
> delete mode 100644 lib/tests/Makefile.am
> delete mode 100644 lib/tests/Makefile.sources
>
> diff --git a/configure.ac b/configure.ac
> index b46f024f875a..0588b0f9dad3 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -294,7 +294,6 @@ AC_CONFIG_FILES([
> Makefile
> benchmarks/Makefile
> lib/Makefile
> - lib/tests/Makefile
> scripts/Makefile
> tests/Makefile
> tests/intel-ci/Makefile
> diff --git a/lib/Makefile.am b/lib/Makefile.am
> index 3b88e3397833..3e6a7fdba9ac 100644
> --- a/lib/Makefile.am
> +++ b/lib/Makefile.am
> @@ -1,8 +1,6 @@
> IGT_LIB_PATH := $(builddir)
> GPU_TOOLS_PATH := $(top_srcdir)
>
> -SUBDIRS = . tests
> -
> include Makefile.sources
>
> libintel_tools_la_SOURCES = $(lib_source_list)
> diff --git a/lib/tests/Makefile.am b/lib/tests/Makefile.am
> deleted file mode 100644
> index 789fc551f9be..000000000000
> --- a/lib/tests/Makefile.am
> +++ /dev/null
> @@ -1,24 +0,0 @@
> -include Makefile.sources
> -
> -check_PROGRAMS = $(check_prog_list)
> -check_SCRIPTS = $(check_script_list)
> -
> -AM_TESTS_ENVIRONMENT = \
> - top_builddir=$(top_builddir) \
> - top_srcdir=$(top_srcdir)
> -
> -AM_CPPFLAGS = \
> - -I$(top_srcdir)/include/drm-uapi \
> - -I$(srcdir)/../.. \
> - -I$(srcdir)/.. \
> - -I$(top_srcdir)/lib/stubs/syscalls \
> - -include "$(srcdir)/../../lib/check-ndebug.h" \
> - -DIGT_DATADIR=\""$(abs_srcdir)"\" \
> - -D_GNU_SOURCE
> -
> -AM_CFLAGS = $(DRM_CFLAGS) $(CWARNFLAGS) $(DEBUG_CFLAGS)
> -
> -LDADD = ../libintel_tools.la $(PCIACCESS_LIBS) $(DRM_LIBS) $(LIBUNWIND_LIBS) $(TIMER_LIBS)
> -
> -LDADD += $(CAIRO_LIBS) $(LIBUDEV_LIBS) $(GLIB_LIBS) -lm
> -AM_CFLAGS += $(CAIRO_CFLAGS) $(LIBUDEV_CFLAGS) $(GLIB_CFLAGS)
> diff --git a/lib/tests/Makefile.sources b/lib/tests/Makefile.sources
> deleted file mode 100644
> index 8d1a8dea8263..000000000000
> --- a/lib/tests/Makefile.sources
> +++ /dev/null
> @@ -1,36 +0,0 @@
> -check_prog_list = \
> - igt_no_exit \
> - igt_no_exit_list_only \
> - igt_fork_helper \
> - igt_list_only \
> - igt_no_subtest \
> - igt_simulation \
> - igt_simple_test_subtests \
> - igt_stats \
> - igt_timeout \
> - igt_invalid_subtest_name \
> - igt_segfault \
> - igt_subtest_group \
> - igt_assert \
> - igt_exit_handler \
> - igt_hdmi_inject \
> - igt_can_fail \
> - igt_can_fail_simple \
> - $(NULL)
> -
> -TESTS = \
> - $(check_prog_list) \
> - $(check_script_list) \
> - $(NULL)
> -
> -# Test that exercise specific asserts in the test framework library and are
> -# hence expected to fail.
> -DISABLE_HARD_ERRORS=1
> -XFAIL_TESTS = \
> - igt_no_exit \
> - igt_no_exit_list_only \
> - igt_no_subtest \
> - igt_simple_test_subtests \
> - igt_timeout \
> - igt_invalid_subtest_name \
> - $(NULL)
>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] lib/tests: Drop automake support
2019-02-07 16:19 ` [igt-dev] [PATCH i-g-t] " Antonio Argenziano
@ 2019-02-07 16:36 ` Daniel Vetter
2019-02-07 16:42 ` Antonio Argenziano
0 siblings, 1 reply; 8+ messages in thread
From: Daniel Vetter @ 2019-02-07 16:36 UTC (permalink / raw)
To: Antonio Argenziano; +Cc: IGT development, Daniel Vetter
On Thu, Feb 07, 2019 at 08:19:15AM -0800, Antonio Argenziano wrote:
>
>
> On 07/02/19 07:25, Daniel Vetter wrote:
> > Really not needed if we check this with meson.
>
> Maybe now drop the automake support from readme as well: "Currently we
> support both meson and automake as build systems".
automake is still supported for building tools and tests. Just not for the
more auxiliary stuff like library self-tests, documentation and all that.
I did merge a few patches to make it clear that you should use meson, but
automake is still there somewhat. Not yet clear enough?
-Daniel
>
> Antonio
>
> >
> > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> > ---
> > Passed gitlab-ci:
> >
> > https://gitlab.freedesktop.org/danvet/igt-gpu-tools/commit/28a1d87c2001c473ecd2b89edf7ad1ba26b5d039
> > ---
> > configure.ac | 1 -
> > lib/Makefile.am | 2 --
> > lib/tests/Makefile.am | 24 ------------------------
> > lib/tests/Makefile.sources | 36 ------------------------------------
> > 4 files changed, 63 deletions(-)
> > delete mode 100644 lib/tests/Makefile.am
> > delete mode 100644 lib/tests/Makefile.sources
> >
> > diff --git a/configure.ac b/configure.ac
> > index b46f024f875a..0588b0f9dad3 100644
> > --- a/configure.ac
> > +++ b/configure.ac
> > @@ -294,7 +294,6 @@ AC_CONFIG_FILES([
> > Makefile
> > benchmarks/Makefile
> > lib/Makefile
> > - lib/tests/Makefile
> > scripts/Makefile
> > tests/Makefile
> > tests/intel-ci/Makefile
> > diff --git a/lib/Makefile.am b/lib/Makefile.am
> > index 3b88e3397833..3e6a7fdba9ac 100644
> > --- a/lib/Makefile.am
> > +++ b/lib/Makefile.am
> > @@ -1,8 +1,6 @@
> > IGT_LIB_PATH := $(builddir)
> > GPU_TOOLS_PATH := $(top_srcdir)
> > -SUBDIRS = . tests
> > -
> > include Makefile.sources
> > libintel_tools_la_SOURCES = $(lib_source_list)
> > diff --git a/lib/tests/Makefile.am b/lib/tests/Makefile.am
> > deleted file mode 100644
> > index 789fc551f9be..000000000000
> > --- a/lib/tests/Makefile.am
> > +++ /dev/null
> > @@ -1,24 +0,0 @@
> > -include Makefile.sources
> > -
> > -check_PROGRAMS = $(check_prog_list)
> > -check_SCRIPTS = $(check_script_list)
> > -
> > -AM_TESTS_ENVIRONMENT = \
> > - top_builddir=$(top_builddir) \
> > - top_srcdir=$(top_srcdir)
> > -
> > -AM_CPPFLAGS = \
> > - -I$(top_srcdir)/include/drm-uapi \
> > - -I$(srcdir)/../.. \
> > - -I$(srcdir)/.. \
> > - -I$(top_srcdir)/lib/stubs/syscalls \
> > - -include "$(srcdir)/../../lib/check-ndebug.h" \
> > - -DIGT_DATADIR=\""$(abs_srcdir)"\" \
> > - -D_GNU_SOURCE
> > -
> > -AM_CFLAGS = $(DRM_CFLAGS) $(CWARNFLAGS) $(DEBUG_CFLAGS)
> > -
> > -LDADD = ../libintel_tools.la $(PCIACCESS_LIBS) $(DRM_LIBS) $(LIBUNWIND_LIBS) $(TIMER_LIBS)
> > -
> > -LDADD += $(CAIRO_LIBS) $(LIBUDEV_LIBS) $(GLIB_LIBS) -lm
> > -AM_CFLAGS += $(CAIRO_CFLAGS) $(LIBUDEV_CFLAGS) $(GLIB_CFLAGS)
> > diff --git a/lib/tests/Makefile.sources b/lib/tests/Makefile.sources
> > deleted file mode 100644
> > index 8d1a8dea8263..000000000000
> > --- a/lib/tests/Makefile.sources
> > +++ /dev/null
> > @@ -1,36 +0,0 @@
> > -check_prog_list = \
> > - igt_no_exit \
> > - igt_no_exit_list_only \
> > - igt_fork_helper \
> > - igt_list_only \
> > - igt_no_subtest \
> > - igt_simulation \
> > - igt_simple_test_subtests \
> > - igt_stats \
> > - igt_timeout \
> > - igt_invalid_subtest_name \
> > - igt_segfault \
> > - igt_subtest_group \
> > - igt_assert \
> > - igt_exit_handler \
> > - igt_hdmi_inject \
> > - igt_can_fail \
> > - igt_can_fail_simple \
> > - $(NULL)
> > -
> > -TESTS = \
> > - $(check_prog_list) \
> > - $(check_script_list) \
> > - $(NULL)
> > -
> > -# Test that exercise specific asserts in the test framework library and are
> > -# hence expected to fail.
> > -DISABLE_HARD_ERRORS=1
> > -XFAIL_TESTS = \
> > - igt_no_exit \
> > - igt_no_exit_list_only \
> > - igt_no_subtest \
> > - igt_simple_test_subtests \
> > - igt_timeout \
> > - igt_invalid_subtest_name \
> > - $(NULL)
> >
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] lib/tests: Drop automake support
2019-02-07 16:36 ` Daniel Vetter
@ 2019-02-07 16:42 ` Antonio Argenziano
0 siblings, 0 replies; 8+ messages in thread
From: Antonio Argenziano @ 2019-02-07 16:42 UTC (permalink / raw)
To: Daniel Vetter; +Cc: IGT development, Daniel Vetter
On 07/02/19 08:36, Daniel Vetter wrote:
> On Thu, Feb 07, 2019 at 08:19:15AM -0800, Antonio Argenziano wrote:
>>
>>
>> On 07/02/19 07:25, Daniel Vetter wrote:
>>> Really not needed if we check this with meson.
>>
>> Maybe now drop the automake support from readme as well: "Currently we
>> support both meson and automake as build systems".
>
> automake is still supported for building tools and tests. Just not for the
> more auxiliary stuff like library self-tests, documentation and all that.
> I did merge a few patches to make it clear that you should use meson, but
> automake is still there somewhat. Not yet clear enough?
:) Missed the fact this is *lib*/tests not tests/
Antonio
> -Daniel
>
>>
>> Antonio
>>
>>>
>>> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
>>> ---
>>> Passed gitlab-ci:
>>>
>>> https://gitlab.freedesktop.org/danvet/igt-gpu-tools/commit/28a1d87c2001c473ecd2b89edf7ad1ba26b5d039
>>> ---
>>> configure.ac | 1 -
>>> lib/Makefile.am | 2 --
>>> lib/tests/Makefile.am | 24 ------------------------
>>> lib/tests/Makefile.sources | 36 ------------------------------------
>>> 4 files changed, 63 deletions(-)
>>> delete mode 100644 lib/tests/Makefile.am
>>> delete mode 100644 lib/tests/Makefile.sources
>>>
>>> diff --git a/configure.ac b/configure.ac
>>> index b46f024f875a..0588b0f9dad3 100644
>>> --- a/configure.ac
>>> +++ b/configure.ac
>>> @@ -294,7 +294,6 @@ AC_CONFIG_FILES([
>>> Makefile
>>> benchmarks/Makefile
>>> lib/Makefile
>>> - lib/tests/Makefile
>>> scripts/Makefile
>>> tests/Makefile
>>> tests/intel-ci/Makefile
>>> diff --git a/lib/Makefile.am b/lib/Makefile.am
>>> index 3b88e3397833..3e6a7fdba9ac 100644
>>> --- a/lib/Makefile.am
>>> +++ b/lib/Makefile.am
>>> @@ -1,8 +1,6 @@
>>> IGT_LIB_PATH := $(builddir)
>>> GPU_TOOLS_PATH := $(top_srcdir)
>>> -SUBDIRS = . tests
>>> -
>>> include Makefile.sources
>>> libintel_tools_la_SOURCES = $(lib_source_list)
>>> diff --git a/lib/tests/Makefile.am b/lib/tests/Makefile.am
>>> deleted file mode 100644
>>> index 789fc551f9be..000000000000
>>> --- a/lib/tests/Makefile.am
>>> +++ /dev/null
>>> @@ -1,24 +0,0 @@
>>> -include Makefile.sources
>>> -
>>> -check_PROGRAMS = $(check_prog_list)
>>> -check_SCRIPTS = $(check_script_list)
>>> -
>>> -AM_TESTS_ENVIRONMENT = \
>>> - top_builddir=$(top_builddir) \
>>> - top_srcdir=$(top_srcdir)
>>> -
>>> -AM_CPPFLAGS = \
>>> - -I$(top_srcdir)/include/drm-uapi \
>>> - -I$(srcdir)/../.. \
>>> - -I$(srcdir)/.. \
>>> - -I$(top_srcdir)/lib/stubs/syscalls \
>>> - -include "$(srcdir)/../../lib/check-ndebug.h" \
>>> - -DIGT_DATADIR=\""$(abs_srcdir)"\" \
>>> - -D_GNU_SOURCE
>>> -
>>> -AM_CFLAGS = $(DRM_CFLAGS) $(CWARNFLAGS) $(DEBUG_CFLAGS)
>>> -
>>> -LDADD = ../libintel_tools.la $(PCIACCESS_LIBS) $(DRM_LIBS) $(LIBUNWIND_LIBS) $(TIMER_LIBS)
>>> -
>>> -LDADD += $(CAIRO_LIBS) $(LIBUDEV_LIBS) $(GLIB_LIBS) -lm
>>> -AM_CFLAGS += $(CAIRO_CFLAGS) $(LIBUDEV_CFLAGS) $(GLIB_CFLAGS)
>>> diff --git a/lib/tests/Makefile.sources b/lib/tests/Makefile.sources
>>> deleted file mode 100644
>>> index 8d1a8dea8263..000000000000
>>> --- a/lib/tests/Makefile.sources
>>> +++ /dev/null
>>> @@ -1,36 +0,0 @@
>>> -check_prog_list = \
>>> - igt_no_exit \
>>> - igt_no_exit_list_only \
>>> - igt_fork_helper \
>>> - igt_list_only \
>>> - igt_no_subtest \
>>> - igt_simulation \
>>> - igt_simple_test_subtests \
>>> - igt_stats \
>>> - igt_timeout \
>>> - igt_invalid_subtest_name \
>>> - igt_segfault \
>>> - igt_subtest_group \
>>> - igt_assert \
>>> - igt_exit_handler \
>>> - igt_hdmi_inject \
>>> - igt_can_fail \
>>> - igt_can_fail_simple \
>>> - $(NULL)
>>> -
>>> -TESTS = \
>>> - $(check_prog_list) \
>>> - $(check_script_list) \
>>> - $(NULL)
>>> -
>>> -# Test that exercise specific asserts in the test framework library and are
>>> -# hence expected to fail.
>>> -DISABLE_HARD_ERRORS=1
>>> -XFAIL_TESTS = \
>>> - igt_no_exit \
>>> - igt_no_exit_list_only \
>>> - igt_no_subtest \
>>> - igt_simple_test_subtests \
>>> - igt_timeout \
>>> - igt_invalid_subtest_name \
>>> - $(NULL)
>>>
>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 8+ messages in thread
* [igt-dev] ✓ Fi.CI.IGT: success for lib/tests: Drop automake support
2019-02-07 15:25 [igt-dev] [PATCH i-g-t] lib/tests: Drop automake support Daniel Vetter
2019-02-07 15:57 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-02-07 16:19 ` [igt-dev] [PATCH i-g-t] " Antonio Argenziano
@ 2019-02-07 17:24 ` Patchwork
2019-02-08 11:51 ` [igt-dev] [PATCH i-g-t] " Petri Latvala
3 siblings, 0 replies; 8+ messages in thread
From: Patchwork @ 2019-02-07 17:24 UTC (permalink / raw)
To: Daniel Vetter; +Cc: igt-dev
== Series Details ==
Series: lib/tests: Drop automake support
URL : https://patchwork.freedesktop.org/series/56346/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5560_full -> IGTPW_2353_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/56346/revisions/1/mbox/
Known issues
------------
Here are the changes found in IGTPW_2353_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@kms_available_modes_crc@available_mode_test_crc:
- shard-kbl: PASS -> FAIL [fdo#106641]
* igt@kms_cursor_crc@cursor-128x128-onscreen:
- shard-kbl: PASS -> FAIL [fdo#103232] +2
* igt@kms_cursor_crc@cursor-256x256-sliding:
- shard-glk: PASS -> FAIL [fdo#103232] +4
* igt@kms_cursor_crc@cursor-256x85-random:
- shard-apl: PASS -> FAIL [fdo#103232] +6
* igt@kms_cursor_legacy@cursor-vs-flip-toggle:
- shard-hsw: PASS -> FAIL [fdo#103355]
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-indfb-msflip-blt:
- shard-glk: PASS -> FAIL [fdo#103167] +6
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-gtt:
- shard-apl: PASS -> FAIL [fdo#103167] +3
- shard-kbl: PASS -> FAIL [fdo#103167]
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
- shard-kbl: PASS -> INCOMPLETE [fdo#103665]
* igt@kms_plane@pixel-format-pipe-a-planes-source-clamping:
- shard-glk: PASS -> FAIL [fdo#108948]
- shard-apl: PASS -> FAIL [fdo#108948]
* igt@kms_plane_alpha_blend@pipe-a-alpha-transparant-fb:
- shard-glk: NOTRUN -> FAIL [fdo#108145]
* igt@kms_plane_alpha_blend@pipe-b-alpha-opaque-fb:
- shard-glk: PASS -> FAIL [fdo#108145]
* igt@kms_plane_multiple@atomic-pipe-b-tiling-none:
- shard-glk: PASS -> FAIL [fdo#103166] +3
- shard-apl: PASS -> FAIL [fdo#103166] +2
* igt@kms_setmode@basic:
- shard-hsw: PASS -> FAIL [fdo#99912]
- shard-snb: NOTRUN -> FAIL [fdo#99912]
#### Possible fixes ####
* igt@gem_ctx_isolation@vcs0-s3:
- shard-kbl: INCOMPLETE [fdo#103665] -> PASS
* igt@kms_ccs@pipe-b-crc-sprite-planes-basic:
- shard-apl: FAIL [fdo#106510] / [fdo#108145] -> PASS
- shard-glk: FAIL [fdo#108145] -> PASS
* igt@kms_cursor_crc@cursor-128x42-sliding:
- shard-glk: FAIL [fdo#103232] -> PASS +2
* igt@kms_cursor_crc@cursor-256x256-onscreen:
- shard-apl: FAIL [fdo#103232] -> PASS +1
* igt@kms_cursor_crc@cursor-256x256-suspend:
- shard-apl: FAIL [fdo#103191] / [fdo#103232] -> PASS
* igt@kms_cursor_crc@cursor-alpha-opaque:
- shard-apl: FAIL [fdo#109350] -> PASS
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-shrfb-plflip-blt:
- shard-snb: {SKIP} [fdo#109271] -> PASS +1
* igt@kms_plane@plane-position-covered-pipe-c-planes:
- shard-apl: FAIL [fdo#103166] -> PASS +1
* igt@kms_setmode@basic:
- shard-kbl: FAIL [fdo#99912] -> PASS
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
[fdo#103355]: https://bugs.freedesktop.org/show_bug.cgi?id=103355
[fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
[fdo#106510]: https://bugs.freedesktop.org/show_bug.cgi?id=106510
[fdo#106641]: https://bugs.freedesktop.org/show_bug.cgi?id=106641
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#108948]: https://bugs.freedesktop.org/show_bug.cgi?id=108948
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109350]: https://bugs.freedesktop.org/show_bug.cgi?id=109350
[fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
Participating hosts (7 -> 5)
------------------------------
Missing (2): shard-skl shard-iclb
Build changes
-------------
* IGT: IGT_4813 -> IGTPW_2353
* Piglit: piglit_4509 -> None
CI_DRM_5560: b3cc6ae9211bbf4e40195469147a884b74c0ec8e @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2353: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2353/
IGT_4813: 09f506726d0e115ee7f4a1604ae71adcf9f12690 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2353/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] lib/tests: Drop automake support
2019-02-07 15:25 [igt-dev] [PATCH i-g-t] lib/tests: Drop automake support Daniel Vetter
` (2 preceding siblings ...)
2019-02-07 17:24 ` [igt-dev] ✓ Fi.CI.IGT: success for " Patchwork
@ 2019-02-08 11:51 ` Petri Latvala
2019-02-11 17:31 ` Daniel Vetter
3 siblings, 1 reply; 8+ messages in thread
From: Petri Latvala @ 2019-02-08 11:51 UTC (permalink / raw)
To: Daniel Vetter; +Cc: IGT development, Daniel Vetter
On Thu, Feb 07, 2019 at 04:25:24PM +0100, Daniel Vetter wrote:
> Really not needed if we check this with meson.
>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Acked-by: Petri Latvala <petri.latvala@intel.com>
> ---
> Passed gitlab-ci:
>
> https://gitlab.freedesktop.org/danvet/igt-gpu-tools/commit/28a1d87c2001c473ecd2b89edf7ad1ba26b5d039
> ---
> configure.ac | 1 -
> lib/Makefile.am | 2 --
> lib/tests/Makefile.am | 24 ------------------------
> lib/tests/Makefile.sources | 36 ------------------------------------
> 4 files changed, 63 deletions(-)
> delete mode 100644 lib/tests/Makefile.am
> delete mode 100644 lib/tests/Makefile.sources
>
> diff --git a/configure.ac b/configure.ac
> index b46f024f875a..0588b0f9dad3 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -294,7 +294,6 @@ AC_CONFIG_FILES([
> Makefile
> benchmarks/Makefile
> lib/Makefile
> - lib/tests/Makefile
> scripts/Makefile
> tests/Makefile
> tests/intel-ci/Makefile
> diff --git a/lib/Makefile.am b/lib/Makefile.am
> index 3b88e3397833..3e6a7fdba9ac 100644
> --- a/lib/Makefile.am
> +++ b/lib/Makefile.am
> @@ -1,8 +1,6 @@
> IGT_LIB_PATH := $(builddir)
> GPU_TOOLS_PATH := $(top_srcdir)
>
> -SUBDIRS = . tests
> -
> include Makefile.sources
>
> libintel_tools_la_SOURCES = $(lib_source_list)
> diff --git a/lib/tests/Makefile.am b/lib/tests/Makefile.am
> deleted file mode 100644
> index 789fc551f9be..000000000000
> --- a/lib/tests/Makefile.am
> +++ /dev/null
> @@ -1,24 +0,0 @@
> -include Makefile.sources
> -
> -check_PROGRAMS = $(check_prog_list)
> -check_SCRIPTS = $(check_script_list)
> -
> -AM_TESTS_ENVIRONMENT = \
> - top_builddir=$(top_builddir) \
> - top_srcdir=$(top_srcdir)
> -
> -AM_CPPFLAGS = \
> - -I$(top_srcdir)/include/drm-uapi \
> - -I$(srcdir)/../.. \
> - -I$(srcdir)/.. \
> - -I$(top_srcdir)/lib/stubs/syscalls \
> - -include "$(srcdir)/../../lib/check-ndebug.h" \
> - -DIGT_DATADIR=\""$(abs_srcdir)"\" \
> - -D_GNU_SOURCE
> -
> -AM_CFLAGS = $(DRM_CFLAGS) $(CWARNFLAGS) $(DEBUG_CFLAGS)
> -
> -LDADD = ../libintel_tools.la $(PCIACCESS_LIBS) $(DRM_LIBS) $(LIBUNWIND_LIBS) $(TIMER_LIBS)
> -
> -LDADD += $(CAIRO_LIBS) $(LIBUDEV_LIBS) $(GLIB_LIBS) -lm
> -AM_CFLAGS += $(CAIRO_CFLAGS) $(LIBUDEV_CFLAGS) $(GLIB_CFLAGS)
> diff --git a/lib/tests/Makefile.sources b/lib/tests/Makefile.sources
> deleted file mode 100644
> index 8d1a8dea8263..000000000000
> --- a/lib/tests/Makefile.sources
> +++ /dev/null
> @@ -1,36 +0,0 @@
> -check_prog_list = \
> - igt_no_exit \
> - igt_no_exit_list_only \
> - igt_fork_helper \
> - igt_list_only \
> - igt_no_subtest \
> - igt_simulation \
> - igt_simple_test_subtests \
> - igt_stats \
> - igt_timeout \
> - igt_invalid_subtest_name \
> - igt_segfault \
> - igt_subtest_group \
> - igt_assert \
> - igt_exit_handler \
> - igt_hdmi_inject \
> - igt_can_fail \
> - igt_can_fail_simple \
> - $(NULL)
> -
> -TESTS = \
> - $(check_prog_list) \
> - $(check_script_list) \
> - $(NULL)
> -
> -# Test that exercise specific asserts in the test framework library and are
> -# hence expected to fail.
> -DISABLE_HARD_ERRORS=1
> -XFAIL_TESTS = \
> - igt_no_exit \
> - igt_no_exit_list_only \
> - igt_no_subtest \
> - igt_simple_test_subtests \
> - igt_timeout \
> - igt_invalid_subtest_name \
> - $(NULL)
> --
> 2.20.1
>
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] lib/tests: Drop automake support
2019-02-08 11:51 ` [igt-dev] [PATCH i-g-t] " Petri Latvala
@ 2019-02-11 17:31 ` Daniel Vetter
0 siblings, 0 replies; 8+ messages in thread
From: Daniel Vetter @ 2019-02-11 17:31 UTC (permalink / raw)
To: Daniel Vetter, IGT development, Daniel Vetter
On Fri, Feb 08, 2019 at 01:51:43PM +0200, Petri Latvala wrote:
> On Thu, Feb 07, 2019 at 04:25:24PM +0100, Daniel Vetter wrote:
> > Really not needed if we check this with meson.
> >
> > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
>
> Acked-by: Petri Latvala <petri.latvala@intel.com>
Pushed, thanks for taking a look.
-Daniel
>
>
> > ---
> > Passed gitlab-ci:
> >
> > https://gitlab.freedesktop.org/danvet/igt-gpu-tools/commit/28a1d87c2001c473ecd2b89edf7ad1ba26b5d039
> > ---
> > configure.ac | 1 -
> > lib/Makefile.am | 2 --
> > lib/tests/Makefile.am | 24 ------------------------
> > lib/tests/Makefile.sources | 36 ------------------------------------
> > 4 files changed, 63 deletions(-)
> > delete mode 100644 lib/tests/Makefile.am
> > delete mode 100644 lib/tests/Makefile.sources
> >
> > diff --git a/configure.ac b/configure.ac
> > index b46f024f875a..0588b0f9dad3 100644
> > --- a/configure.ac
> > +++ b/configure.ac
> > @@ -294,7 +294,6 @@ AC_CONFIG_FILES([
> > Makefile
> > benchmarks/Makefile
> > lib/Makefile
> > - lib/tests/Makefile
> > scripts/Makefile
> > tests/Makefile
> > tests/intel-ci/Makefile
> > diff --git a/lib/Makefile.am b/lib/Makefile.am
> > index 3b88e3397833..3e6a7fdba9ac 100644
> > --- a/lib/Makefile.am
> > +++ b/lib/Makefile.am
> > @@ -1,8 +1,6 @@
> > IGT_LIB_PATH := $(builddir)
> > GPU_TOOLS_PATH := $(top_srcdir)
> >
> > -SUBDIRS = . tests
> > -
> > include Makefile.sources
> >
> > libintel_tools_la_SOURCES = $(lib_source_list)
> > diff --git a/lib/tests/Makefile.am b/lib/tests/Makefile.am
> > deleted file mode 100644
> > index 789fc551f9be..000000000000
> > --- a/lib/tests/Makefile.am
> > +++ /dev/null
> > @@ -1,24 +0,0 @@
> > -include Makefile.sources
> > -
> > -check_PROGRAMS = $(check_prog_list)
> > -check_SCRIPTS = $(check_script_list)
> > -
> > -AM_TESTS_ENVIRONMENT = \
> > - top_builddir=$(top_builddir) \
> > - top_srcdir=$(top_srcdir)
> > -
> > -AM_CPPFLAGS = \
> > - -I$(top_srcdir)/include/drm-uapi \
> > - -I$(srcdir)/../.. \
> > - -I$(srcdir)/.. \
> > - -I$(top_srcdir)/lib/stubs/syscalls \
> > - -include "$(srcdir)/../../lib/check-ndebug.h" \
> > - -DIGT_DATADIR=\""$(abs_srcdir)"\" \
> > - -D_GNU_SOURCE
> > -
> > -AM_CFLAGS = $(DRM_CFLAGS) $(CWARNFLAGS) $(DEBUG_CFLAGS)
> > -
> > -LDADD = ../libintel_tools.la $(PCIACCESS_LIBS) $(DRM_LIBS) $(LIBUNWIND_LIBS) $(TIMER_LIBS)
> > -
> > -LDADD += $(CAIRO_LIBS) $(LIBUDEV_LIBS) $(GLIB_LIBS) -lm
> > -AM_CFLAGS += $(CAIRO_CFLAGS) $(LIBUDEV_CFLAGS) $(GLIB_CFLAGS)
> > diff --git a/lib/tests/Makefile.sources b/lib/tests/Makefile.sources
> > deleted file mode 100644
> > index 8d1a8dea8263..000000000000
> > --- a/lib/tests/Makefile.sources
> > +++ /dev/null
> > @@ -1,36 +0,0 @@
> > -check_prog_list = \
> > - igt_no_exit \
> > - igt_no_exit_list_only \
> > - igt_fork_helper \
> > - igt_list_only \
> > - igt_no_subtest \
> > - igt_simulation \
> > - igt_simple_test_subtests \
> > - igt_stats \
> > - igt_timeout \
> > - igt_invalid_subtest_name \
> > - igt_segfault \
> > - igt_subtest_group \
> > - igt_assert \
> > - igt_exit_handler \
> > - igt_hdmi_inject \
> > - igt_can_fail \
> > - igt_can_fail_simple \
> > - $(NULL)
> > -
> > -TESTS = \
> > - $(check_prog_list) \
> > - $(check_script_list) \
> > - $(NULL)
> > -
> > -# Test that exercise specific asserts in the test framework library and are
> > -# hence expected to fail.
> > -DISABLE_HARD_ERRORS=1
> > -XFAIL_TESTS = \
> > - igt_no_exit \
> > - igt_no_exit_list_only \
> > - igt_no_subtest \
> > - igt_simple_test_subtests \
> > - igt_timeout \
> > - igt_invalid_subtest_name \
> > - $(NULL)
> > --
> > 2.20.1
> >
> > _______________________________________________
> > igt-dev mailing list
> > igt-dev@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/igt-dev
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2019-02-11 17:31 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-07 15:25 [igt-dev] [PATCH i-g-t] lib/tests: Drop automake support Daniel Vetter
2019-02-07 15:57 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-02-07 16:19 ` [igt-dev] [PATCH i-g-t] " Antonio Argenziano
2019-02-07 16:36 ` Daniel Vetter
2019-02-07 16:42 ` Antonio Argenziano
2019-02-07 17:24 ` [igt-dev] ✓ Fi.CI.IGT: success for " Patchwork
2019-02-08 11:51 ` [igt-dev] [PATCH i-g-t] " Petri Latvala
2019-02-11 17:31 ` Daniel Vetter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.