From: "Uwe Kleine-König" <uwe@kleine-koenig.org>
To: Dennis Gilmore <dgilmore@redhat.com>, linux-rockchip@lists.infradead.org
Cc: Rob Herring <robh+dt@kernel.org>,
Heiko Stuebner <heiko@sntech.de>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
"moderated list:ARM/Rockchip SoC support"
<linux-arm-kernel@lists.infradead.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/4] arm64: dts: rockchip: helios64: fixup USB setup
Date: Thu, 1 Jul 2021 11:31:09 +0200 [thread overview]
Message-ID: <01f1b032-14a8-a6fa-9063-23de65fc6f43@kleine-koenig.org> (raw)
In-Reply-To: <20210701004043.18585-1-dgilmore@redhat.com>
[-- Attachment #1.1: Type: text/plain, Size: 721 bytes --]
Hello,
On 7/1/21 2:40 AM, Dennis Gilmore wrote:
> Without the usbdrd_dwc3_1 node defined u-boot will throw an error and
> reset the system.
I wonder if this should better be fixed in u-boot then?!
> All other rk3399 systems use this format
This is true for the dwc nodes, however for the usb2 nodes there are
several that use this idiom (and even repeat the label name), see for
example the &u2phy0 node in
arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dtsi .
In my eyes it's a bit ugly to have the two nodes as separate entities
and on the same indentation level in the machine dts given that one is
the parent of the other and enabling USB needs both status settings.
Best regards
Uwe
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: "Uwe Kleine-König" <uwe@kleine-koenig.org>
To: Dennis Gilmore <dgilmore@redhat.com>, linux-rockchip@lists.infradead.org
Cc: Rob Herring <robh+dt@kernel.org>,
Heiko Stuebner <heiko@sntech.de>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
"moderated list:ARM/Rockchip SoC support"
<linux-arm-kernel@lists.infradead.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/4] arm64: dts: rockchip: helios64: fixup USB setup
Date: Thu, 1 Jul 2021 11:31:09 +0200 [thread overview]
Message-ID: <01f1b032-14a8-a6fa-9063-23de65fc6f43@kleine-koenig.org> (raw)
In-Reply-To: <20210701004043.18585-1-dgilmore@redhat.com>
[-- Attachment #1.1.1: Type: text/plain, Size: 721 bytes --]
Hello,
On 7/1/21 2:40 AM, Dennis Gilmore wrote:
> Without the usbdrd_dwc3_1 node defined u-boot will throw an error and
> reset the system.
I wonder if this should better be fixed in u-boot then?!
> All other rk3399 systems use this format
This is true for the dwc nodes, however for the usb2 nodes there are
several that use this idiom (and even repeat the label name), see for
example the &u2phy0 node in
arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dtsi .
In my eyes it's a bit ugly to have the two nodes as separate entities
and on the same indentation level in the machine dts given that one is
the parent of the other and enabling USB needs both status settings.
Best regards
Uwe
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 170 bytes --]
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
WARNING: multiple messages have this Message-ID (diff)
From: "Uwe Kleine-König" <uwe@kleine-koenig.org>
To: Dennis Gilmore <dgilmore@redhat.com>, linux-rockchip@lists.infradead.org
Cc: Rob Herring <robh+dt@kernel.org>,
Heiko Stuebner <heiko@sntech.de>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
"moderated list:ARM/Rockchip SoC support"
<linux-arm-kernel@lists.infradead.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/4] arm64: dts: rockchip: helios64: fixup USB setup
Date: Thu, 1 Jul 2021 11:31:09 +0200 [thread overview]
Message-ID: <01f1b032-14a8-a6fa-9063-23de65fc6f43@kleine-koenig.org> (raw)
In-Reply-To: <20210701004043.18585-1-dgilmore@redhat.com>
[-- Attachment #1.1.1: Type: text/plain, Size: 721 bytes --]
Hello,
On 7/1/21 2:40 AM, Dennis Gilmore wrote:
> Without the usbdrd_dwc3_1 node defined u-boot will throw an error and
> reset the system.
I wonder if this should better be fixed in u-boot then?!
> All other rk3399 systems use this format
This is true for the dwc nodes, however for the usb2 nodes there are
several that use this idiom (and even repeat the label name), see for
example the &u2phy0 node in
arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dtsi .
In my eyes it's a bit ugly to have the two nodes as separate entities
and on the same indentation level in the machine dts given that one is
the parent of the other and enabling USB needs both status settings.
Best regards
Uwe
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-07-01 9:31 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-01 0:40 [PATCH 1/4] arm64: dts: rockchip: helios64: fixup USB setup Dennis Gilmore
2021-07-01 0:40 ` Dennis Gilmore
2021-07-01 0:40 ` Dennis Gilmore
2021-07-01 0:40 ` [PATCH 2/4] arm64: dts: rockchip: helios64: set stdout-path Dennis Gilmore
2021-07-01 0:40 ` Dennis Gilmore
2021-07-01 0:40 ` Dennis Gilmore
2021-07-01 0:40 ` [PATCH 3/4] arm64: dts: rockchip: helios64: add SPI support Dennis Gilmore
2021-07-01 0:40 ` Dennis Gilmore
2021-07-01 0:40 ` Dennis Gilmore
2021-07-01 0:40 ` [PATCH 4/4] arm64: dts: rockchip: helios64: enable tsadc on helios64 Dennis Gilmore
2021-07-01 0:40 ` Dennis Gilmore
2021-07-01 0:40 ` Dennis Gilmore
2021-07-01 9:31 ` Uwe Kleine-König [this message]
2021-07-01 9:31 ` [PATCH 1/4] arm64: dts: rockchip: helios64: fixup USB setup Uwe Kleine-König
2021-07-01 9:31 ` Uwe Kleine-König
2021-07-01 12:59 ` Dennis Gilmore
2021-07-01 12:59 ` Dennis Gilmore
2021-07-01 12:59 ` Dennis Gilmore
2021-07-01 13:35 ` Uwe Kleine-König
2021-07-01 13:35 ` Uwe Kleine-König
2021-07-01 13:35 ` Uwe Kleine-König
2021-07-01 18:13 ` Dennis Gilmore
2021-07-01 18:13 ` Dennis Gilmore
2021-07-01 18:13 ` Dennis Gilmore
2021-07-01 9:32 ` Robin Murphy
2021-07-01 9:32 ` Robin Murphy
2021-07-01 9:32 ` Robin Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=01f1b032-14a8-a6fa-9063-23de65fc6f43@kleine-koenig.org \
--to=uwe@kleine-koenig.org \
--cc=devicetree@vger.kernel.org \
--cc=dgilmore@redhat.com \
--cc=heiko@sntech.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.