* [PATCH] uxa/glamor: Use a macro to specify module name.
@ 2012-02-02 3:30 zhigang.gong
2012-02-02 8:51 ` Chris Wilson
2012-02-08 6:17 ` Zhigang Gong
0 siblings, 2 replies; 4+ messages in thread
From: zhigang.gong @ 2012-02-02 3:30 UTC (permalink / raw)
To: chris; +Cc: intel-gfx
From: Zhigang Gong <zhigang.gong@linux.intel.com>
Signed-off-by: Zhigang Gong <zhigang.gong@linux.intel.com>
---
src/intel_glamor.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/intel_glamor.c b/src/intel_glamor.c
index 446dd3d..f908b7c 100644
--- a/src/intel_glamor.c
+++ b/src/intel_glamor.c
@@ -67,7 +67,7 @@ intel_glamor_pre_init(ScrnInfoPtr scrn)
intel = intel_get_screen_private(scrn);
/* Load glamor module */
- if ((glamor_module = xf86LoadSubModule(scrn, "glamor_egl"))) {
+ if ((glamor_module = xf86LoadSubModule(scrn, GLAMOR_EGL_MODULE_NAME))) {
version = xf86GetModuleVersion(glamor_module);
if (version < MODULE_VERSION_NUMERIC(0,3,0)) {
xf86DrvMsg(scrn->scrnIndex, X_ERROR,
--
1.7.4.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] uxa/glamor: Use a macro to specify module name.
2012-02-02 3:30 [PATCH] uxa/glamor: Use a macro to specify module name zhigang.gong
@ 2012-02-02 8:51 ` Chris Wilson
2012-02-02 9:43 ` Zhigang Gong
2012-02-08 6:17 ` Zhigang Gong
1 sibling, 1 reply; 4+ messages in thread
From: Chris Wilson @ 2012-02-02 8:51 UTC (permalink / raw)
To: zhigang.gong; +Cc: intel-gfx
On Thu, 2 Feb 2012 11:30:57 +0800, zhigang.gong@linux.intel.com wrote:
> From: Zhigang Gong <zhigang.gong@linux.intel.com>
Would be good to mention which commit introduces the macro into glamor,
just to serve as a reminder that one needs to update. Same for the other
patches that introduces a new dependency.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] uxa/glamor: Use a macro to specify module name.
2012-02-02 8:51 ` Chris Wilson
@ 2012-02-02 9:43 ` Zhigang Gong
0 siblings, 0 replies; 4+ messages in thread
From: Zhigang Gong @ 2012-02-02 9:43 UTC (permalink / raw)
To: 'Chris Wilson'; +Cc: intel-gfx
> -----Original Message-----
> From: Chris Wilson [mailto:chris@chris-wilson.co.uk]
> Sent: Thursday, February 02, 2012 4:52 PM
> To: zhigang.gong@linux.intel.com
> Cc: intel-gfx@lists.freedesktop.org; zhigang.gong@linux.intel.com
> Subject: Re: [PATCH] uxa/glamor: Use a macro to specify module name.
>
> On Thu, 2 Feb 2012 11:30:57 +0800, zhigang.gong@linux.intel.com
> wrote:
> > From: Zhigang Gong <zhigang.gong@linux.intel.com>
>
> Would be good to mention which commit introduces the macro into
> glamor, just to serve as a reminder that one needs to update. Same for the
> other patches that introduces a new dependency.
Agree, these patches should be reviewed with the corresponding glamor
patches.
For this patch, the glamor patch is as below:
http://lists.freedesktop.org/archives/glamor/2012-February/000068.html
> -Chris
>
> --
> Chris Wilson, Intel Open Source Technology Centre
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] uxa/glamor: Use a macro to specify module name.
2012-02-02 3:30 [PATCH] uxa/glamor: Use a macro to specify module name zhigang.gong
2012-02-02 8:51 ` Chris Wilson
@ 2012-02-08 6:17 ` Zhigang Gong
1 sibling, 0 replies; 4+ messages in thread
From: Zhigang Gong @ 2012-02-08 6:17 UTC (permalink / raw)
To: chris; +Cc: intel-gfx
> -----Original Message-----
> From: zhigang.gong@linux.intel.com [mailto:zhigang.gong@linux.intel.com]
> Sent: Thursday, February 02, 2012 11:31 AM
> To: chris@chris-wilson.co.uk
> Cc: intel-gfx@lists.freedesktop.org; zhigang.gong@linux.intel.com
> Subject: [PATCH] uxa/glamor: Use a macro to specify module name.
>
> From: Zhigang Gong <zhigang.gong@linux.intel.com>
>
> Signed-off-by: Zhigang Gong <zhigang.gong@linux.intel.com>
> ---
> src/intel_glamor.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/src/intel_glamor.c b/src/intel_glamor.c index
446dd3d..f908b7c
> 100644
> --- a/src/intel_glamor.c
> +++ b/src/intel_glamor.c
> @@ -67,7 +67,7 @@ intel_glamor_pre_init(ScrnInfoPtr scrn)
> intel = intel_get_screen_private(scrn);
>
> /* Load glamor module */
> - if ((glamor_module = xf86LoadSubModule(scrn, "glamor_egl"))) {
> + if ((glamor_module = xf86LoadSubModule(scrn,
> GLAMOR_EGL_MODULE_NAME)))
> +{
> version = xf86GetModuleVersion(glamor_module);
> if (version < MODULE_VERSION_NUMERIC(0,3,0)) {
> xf86DrvMsg(scrn->scrnIndex, X_ERROR,
> --
> 1.7.4.4
This patch depends on glamor commit b5f8d...
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-02-08 6:17 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-02-02 3:30 [PATCH] uxa/glamor: Use a macro to specify module name zhigang.gong
2012-02-02 8:51 ` Chris Wilson
2012-02-02 9:43 ` Zhigang Gong
2012-02-08 6:17 ` Zhigang Gong
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.