All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Ahern <dsahern@gmail.com>
To: Rocco Yue <rocco.yue@mediatek.com>, Greg KH <gregkh@linuxfoundation.org>
Cc: "David S . Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	Jonathan Corbet <corbet@lwn.net>,
	Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
	David Ahern <dsahern@kernel.org>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Felix Fietkau <nbd@nbd.name>, John Crispin <john@phrozen.org>,
	Sean Wang <sean.wang@mediatek.com>,
	Mark Lee <Mark-MC.Lee@mediatek.com>,
	netdev@vger.kernel.org, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org, bpf@vger.kernel.org,
	wsd_upstream@mediatek.com, chao.song@mediatek.com,
	kuohong.wang@mediatek.com
Subject: Re: [PATCH 1/4] net: if_arp: add ARPHRD_PUREIP type
Date: Wed, 23 Jun 2021 23:15:03 -0600	[thread overview]
Message-ID: <020403ac-0c2a-4ad8-236b-d32e59aef772@gmail.com> (raw)
In-Reply-To: <20210624033353.25636-1-rocco.yue@mediatek.com>

On 6/23/21 9:33 PM, Rocco Yue wrote:
> 
> The difference between RAWIP and PUREIP is that they generate IPv6
> link-local address and IPv6 global address in different ways.
> 
> RAWIP:
> ~~~~~~
> In the ipv6_generate_eui64() function, using RAWIP will always return 0,
> which will cause the kernel to automatically generate an IPv6 link-local
> address in EUI64 format and an IPv6 global address in EUI64 format.
> 
> PUREIP:
> ~~~~~~~
> After this patch set, when using PUREIP, kernel doesn't generate IPv6
> link-local address regardless of which IN6_ADDR_GEN_MODE is used.
> 
> @@  static void addrconf_dev_config(struct net_device *dev)
> +       if (dev->type == ARPHRD_PUREIP)
> +               return;
> 
> And after recving RA message, kernel iterates over the link-local address
> that exists for the interface and uses the low 64bits of the link-local
> address to generate the IPv6 global address.
> The general process is as follows:
> ndisc_router_discovery() -> addrconf_prefix_rcv() -> ipv6_generate_eui64() -> ipv6_inherit_eui64()
> 

please add that to the commit message.

WARNING: multiple messages have this Message-ID (diff)
From: David Ahern <dsahern@gmail.com>
To: Rocco Yue <rocco.yue@mediatek.com>, Greg KH <gregkh@linuxfoundation.org>
Cc: "David S . Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	Jonathan Corbet <corbet@lwn.net>,
	Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
	David Ahern <dsahern@kernel.org>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Felix Fietkau <nbd@nbd.name>, John Crispin <john@phrozen.org>,
	Sean Wang <sean.wang@mediatek.com>,
	Mark Lee <Mark-MC.Lee@mediatek.com>,
	netdev@vger.kernel.org, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org, bpf@vger.kernel.org,
	wsd_upstream@mediatek.com, chao.song@mediatek.com,
	kuohong.wang@mediatek.com
Subject: Re: [PATCH 1/4] net: if_arp: add ARPHRD_PUREIP type
Date: Wed, 23 Jun 2021 23:15:03 -0600	[thread overview]
Message-ID: <020403ac-0c2a-4ad8-236b-d32e59aef772@gmail.com> (raw)
In-Reply-To: <20210624033353.25636-1-rocco.yue@mediatek.com>

On 6/23/21 9:33 PM, Rocco Yue wrote:
> 
> The difference between RAWIP and PUREIP is that they generate IPv6
> link-local address and IPv6 global address in different ways.
> 
> RAWIP:
> ~~~~~~
> In the ipv6_generate_eui64() function, using RAWIP will always return 0,
> which will cause the kernel to automatically generate an IPv6 link-local
> address in EUI64 format and an IPv6 global address in EUI64 format.
> 
> PUREIP:
> ~~~~~~~
> After this patch set, when using PUREIP, kernel doesn't generate IPv6
> link-local address regardless of which IN6_ADDR_GEN_MODE is used.
> 
> @@  static void addrconf_dev_config(struct net_device *dev)
> +       if (dev->type == ARPHRD_PUREIP)
> +               return;
> 
> And after recving RA message, kernel iterates over the link-local address
> that exists for the interface and uses the low 64bits of the link-local
> address to generate the IPv6 global address.
> The general process is as follows:
> ndisc_router_discovery() -> addrconf_prefix_rcv() -> ipv6_generate_eui64() -> ipv6_inherit_eui64()
> 

please add that to the commit message.

_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

WARNING: multiple messages have this Message-ID (diff)
From: David Ahern <dsahern@gmail.com>
To: Rocco Yue <rocco.yue@mediatek.com>, Greg KH <gregkh@linuxfoundation.org>
Cc: "David S . Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	Jonathan Corbet <corbet@lwn.net>,
	Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
	David Ahern <dsahern@kernel.org>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Felix Fietkau <nbd@nbd.name>, John Crispin <john@phrozen.org>,
	Sean Wang <sean.wang@mediatek.com>,
	Mark Lee <Mark-MC.Lee@mediatek.com>,
	netdev@vger.kernel.org, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org, bpf@vger.kernel.org,
	wsd_upstream@mediatek.com, chao.song@mediatek.com,
	kuohong.wang@mediatek.com
Subject: Re: [PATCH 1/4] net: if_arp: add ARPHRD_PUREIP type
Date: Wed, 23 Jun 2021 23:15:03 -0600	[thread overview]
Message-ID: <020403ac-0c2a-4ad8-236b-d32e59aef772@gmail.com> (raw)
In-Reply-To: <20210624033353.25636-1-rocco.yue@mediatek.com>

On 6/23/21 9:33 PM, Rocco Yue wrote:
> 
> The difference between RAWIP and PUREIP is that they generate IPv6
> link-local address and IPv6 global address in different ways.
> 
> RAWIP:
> ~~~~~~
> In the ipv6_generate_eui64() function, using RAWIP will always return 0,
> which will cause the kernel to automatically generate an IPv6 link-local
> address in EUI64 format and an IPv6 global address in EUI64 format.
> 
> PUREIP:
> ~~~~~~~
> After this patch set, when using PUREIP, kernel doesn't generate IPv6
> link-local address regardless of which IN6_ADDR_GEN_MODE is used.
> 
> @@  static void addrconf_dev_config(struct net_device *dev)
> +       if (dev->type == ARPHRD_PUREIP)
> +               return;
> 
> And after recving RA message, kernel iterates over the link-local address
> that exists for the interface and uses the low 64bits of the link-local
> address to generate the IPv6 global address.
> The general process is as follows:
> ndisc_router_discovery() -> addrconf_prefix_rcv() -> ipv6_generate_eui64() -> ipv6_inherit_eui64()
> 

please add that to the commit message.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-06-24  5:15 UTC|newest]

Thread overview: 73+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-23 11:34 [PATCH 1/4] net: if_arp: add ARPHRD_PUREIP type Rocco Yue
2021-06-23 11:34 ` Rocco Yue
2021-06-23 11:34 ` Rocco Yue
2021-06-23 11:34 ` [PATCH 2/4] net: ipv6: don't generate link local address on PUREIP device Rocco Yue
2021-06-23 11:34   ` Rocco Yue
2021-06-23 11:34   ` Rocco Yue
2021-06-23 11:34 ` [PATCH 3/4] net: dev_is_mac_header_xmit() return false for ARPHRD_PUREIP Rocco Yue
2021-06-23 11:34   ` Rocco Yue
2021-06-23 11:34   ` Rocco Yue
2021-06-23 11:34 ` [PATCH 4/4] drivers: net: mediatek: initial implementation of ccmni Rocco Yue
2021-06-23 11:34   ` Rocco Yue
2021-06-23 11:34   ` Rocco Yue
2021-06-23 17:25   ` Greg KH
2021-06-23 17:25     ` Greg KH
2021-06-23 17:25     ` Greg KH
2021-06-23 17:26   ` kernel test robot
2021-06-23 17:31   ` Greg KH
2021-06-23 17:31     ` Greg KH
2021-06-23 17:31     ` Greg KH
2021-06-24 11:53     ` [PATCH 1/4] net: if_arp: add ARPHRD_PUREIP type Rocco Yue
2021-06-24 11:53       ` Rocco Yue
2021-06-24 11:53       ` Rocco Yue
2021-06-24 12:23       ` Greg KH
2021-06-24 12:23         ` Greg KH
2021-06-24 12:23         ` Greg KH
2021-06-24 15:55         ` [PATCH 4/4] drivers: net: mediatek: initial implementation of ccmni Rocco Yue
2021-06-24 15:55           ` Rocco Yue
2021-06-24 15:55           ` Rocco Yue
2021-06-24 16:51           ` Greg KH
2021-06-24 16:51             ` Greg KH
2021-06-24 16:51             ` Greg KH
2021-06-28  7:18             ` Rocco Yue
2021-06-28  7:18               ` Rocco Yue
2021-06-28  7:18               ` Rocco Yue
2021-06-28  9:30               ` Greg KH
2021-06-28  9:30                 ` Greg KH
2021-06-28  9:30                 ` Greg KH
2021-06-23 17:19 ` [PATCH 1/4] net: if_arp: add ARPHRD_PUREIP type Greg KH
2021-06-23 17:19   ` Greg KH
2021-06-23 17:19   ` Greg KH
2021-06-24  3:33   ` Rocco Yue
2021-06-24  3:33     ` Rocco Yue
2021-06-24  3:33     ` Rocco Yue
2021-06-24  5:15     ` David Ahern [this message]
2021-06-24  5:15       ` David Ahern
2021-06-24  5:15       ` David Ahern
2021-06-24  5:31       ` Rocco Yue
2021-06-24  5:31         ` Rocco Yue
2021-06-24  5:31         ` Rocco Yue
2021-06-24  5:29     ` Greg KH
2021-06-24  5:29       ` Greg KH
2021-06-24  5:29       ` Greg KH
2021-06-24  6:13       ` Rocco Yue
2021-06-24  6:13         ` Rocco Yue
2021-06-24  6:13         ` Rocco Yue
2021-06-24  9:04         ` Greg KH
2021-06-24  9:04           ` Greg KH
2021-06-24  9:04           ` Greg KH
2021-06-24 12:24           ` Rocco Yue
2021-06-24 12:24             ` Rocco Yue
2021-06-24 12:24             ` Rocco Yue
2021-06-24 13:06             ` Greg KH
2021-06-24 13:06               ` Greg KH
2021-06-24 13:06               ` Greg KH
2021-06-25  6:01               ` Rocco Yue
2021-06-25  6:01                 ` Rocco Yue
2021-06-25  6:01                 ` Rocco Yue
2021-06-24 16:14         ` Dan Williams
2021-06-24 16:14           ` Dan Williams
2021-06-24 16:14           ` Dan Williams
2021-06-25  6:04           ` Rocco Yue
2021-06-25  6:04             ` Rocco Yue
2021-06-25  6:04             ` Rocco Yue

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=020403ac-0c2a-4ad8-236b-d32e59aef772@gmail.com \
    --to=dsahern@gmail.com \
    --cc=Mark-MC.Lee@mediatek.com \
    --cc=bpf@vger.kernel.org \
    --cc=chao.song@mediatek.com \
    --cc=corbet@lwn.net \
    --cc=davem@davemloft.net \
    --cc=dsahern@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=john@phrozen.org \
    --cc=kuba@kernel.org \
    --cc=kuohong.wang@mediatek.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    --cc=nbd@nbd.name \
    --cc=netdev@vger.kernel.org \
    --cc=rocco.yue@mediatek.com \
    --cc=sean.wang@mediatek.com \
    --cc=wsd_upstream@mediatek.com \
    --cc=yoshfuji@linux-ipv6.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.