* 2.6.1-rc1 arch/i386/kernel/setup.c wrong parameter order to request resources ?
@ 2004-03-29 15:42 Arjan van de Ven
0 siblings, 0 replies; 4+ messages in thread
From: Arjan van de Ven @ 2004-03-29 15:42 UTC (permalink / raw)
To: Administrator; +Cc: torvalds, akpm, davej
[-- Attachment #1: Type: text/plain, Size: 782 bytes --]
Hi,
in setup.c the kernel tries to reserve ram resources for system ram etc
etc. However it seems it's done with the parameters to request_resource in
the wrong order (it certainly is opposite order from other neighboring
code). Can someone confirm I'm not overlooking something?
Greetings,
Arjan van de Ven
--- linux-2.6.0/arch/i386/kernel/setup.c~ 2004-01-04 16:37:34.622450000 +0100
+++ linux-2.6.0/arch/i386/kernel/setup.c 2004-01-04 16:37:34.622450000 +0100
@@ -834,8 +834,8 @@
* so we try it repeatedly and let the resource manager
* test it.
*/
- request_resource(res, &code_resource);
- request_resource(res, &data_resource);
+ request_resource(&code_resource, res);
+ request_resource(&data_resource, res);
}
}
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: 2.6.1-rc1 arch/i386/kernel/setup.c wrong parameter order to request resources ?
[not found] ` <Pine.LNX.4.58.0401041305440.2162@home.osdl.org>
2004-01-04 22:00 ` Arjan van de Ven
@ 2004-03-29 15:43 ` Arjan van de Ven
1 sibling, 0 replies; 4+ messages in thread
From: Arjan van de Ven @ 2004-03-29 15:43 UTC (permalink / raw)
To: Administrator; +Cc: linux-kernel, akpm, davej
[-- Attachment #1: Type: text/plain, Size: 927 bytes --]
On Sun, Jan 04, 2004 at 01:08:52PM -0800, Linus Torvalds wrote:
>
>
> On Sun, 4 Jan 2004, Arjan van de Ven wrote:
> >
> > in setup.c the kernel tries to reserve ram resources for system ram etc
> > etc. However it seems it's done with the parameters to request_resource in
> > the wrong order (it certainly is opposite order from other neighboring
> > code). Can someone confirm I'm not overlooking something?
>
> You've overlooked something.
>
> The core uses the rigth order: it's literally trying to find _which_ of
> the e820 resources contains the "code" and "data" resource.
>
> In other words: the code and data resources don't contain anything. They
> are contained _in_ something, but we don't know which one off-hand, so we
> try to register them in all the memory resources we find.
> and not used for anything else.
ok fair enough; maybe deserves more comment but it makes sense.
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: 2.6.1-rc1 arch/i386/kernel/setup.c wrong parameter order to request resources ?
[not found] ` <Pine.LNX.4.58.0401041305440.2162@home.osdl.org>
@ 2004-01-04 22:00 ` Arjan van de Ven
2004-03-29 15:43 ` Arjan van de Ven
1 sibling, 0 replies; 4+ messages in thread
From: Arjan van de Ven @ 2004-01-04 22:00 UTC (permalink / raw)
To: Linus Torvalds; +Cc: linux-kernel, akpm, davej
[-- Attachment #1: Type: text/plain, Size: 927 bytes --]
On Sun, Jan 04, 2004 at 01:08:52PM -0800, Linus Torvalds wrote:
>
>
> On Sun, 4 Jan 2004, Arjan van de Ven wrote:
> >
> > in setup.c the kernel tries to reserve ram resources for system ram etc
> > etc. However it seems it's done with the parameters to request_resource in
> > the wrong order (it certainly is opposite order from other neighboring
> > code). Can someone confirm I'm not overlooking something?
>
> You've overlooked something.
>
> The core uses the rigth order: it's literally trying to find _which_ of
> the e820 resources contains the "code" and "data" resource.
>
> In other words: the code and data resources don't contain anything. They
> are contained _in_ something, but we don't know which one off-hand, so we
> try to register them in all the memory resources we find.
> and not used for anything else.
ok fair enough; maybe deserves more comment but it makes sense.
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* 2.6.1-rc1 arch/i386/kernel/setup.c wrong parameter order to request resources ?
@ 2004-01-04 15:39 Arjan van de Ven
[not found] ` <Pine.LNX.4.58.0401041305440.2162@home.osdl.org>
0 siblings, 1 reply; 4+ messages in thread
From: Arjan van de Ven @ 2004-01-04 15:39 UTC (permalink / raw)
To: linux-kernel; +Cc: torvalds, akpm, davej
[-- Attachment #1: Type: text/plain, Size: 782 bytes --]
Hi,
in setup.c the kernel tries to reserve ram resources for system ram etc
etc. However it seems it's done with the parameters to request_resource in
the wrong order (it certainly is opposite order from other neighboring
code). Can someone confirm I'm not overlooking something?
Greetings,
Arjan van de Ven
--- linux-2.6.0/arch/i386/kernel/setup.c~ 2004-01-04 16:37:34.622450000 +0100
+++ linux-2.6.0/arch/i386/kernel/setup.c 2004-01-04 16:37:34.622450000 +0100
@@ -834,8 +834,8 @@
* so we try it repeatedly and let the resource manager
* test it.
*/
- request_resource(res, &code_resource);
- request_resource(res, &data_resource);
+ request_resource(&code_resource, res);
+ request_resource(&data_resource, res);
}
}
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2004-03-29 15:43 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-03-29 15:42 2.6.1-rc1 arch/i386/kernel/setup.c wrong parameter order to request resources ? Arjan van de Ven
-- strict thread matches above, loose matches on Subject: below --
2004-01-04 15:39 Arjan van de Ven
[not found] ` <Pine.LNX.4.58.0401041305440.2162@home.osdl.org>
2004-01-04 22:00 ` Arjan van de Ven
2004-03-29 15:43 ` Arjan van de Ven
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.