From: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
To: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>,
Matti Vaittinen <mazziesaccount@gmail.com>
Cc: Chanwoo Choi <cw00.choi@samsung.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
MyungJoo Ham <myungjoo.ham@samsung.com>,
Hans de Goede <hdegoede@redhat.com>,
Marek Szyprowski <m.szyprowski@samsung.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] devm-helpers: Add resource managed version of work init
Date: Mon, 10 May 2021 10:11:36 -0400 [thread overview]
Message-ID: <021e3e2c-f0f5-32fe-50b4-7ae7882a85b3@canonical.com> (raw)
In-Reply-To: <82a9670d02ae96de4976c655d97b74c4a137f145.1620633360.git.matti.vaittinen@fi.rohmeurope.com>
On 10/05/2021 04:10, Matti Vaittinen wrote:
> A few drivers which need a work-queue must cancel work at driver detach.
> Some of those implement remove() solely for this purpose. Help drivers to
> avoid unnecessary remove and error-branch implementation by adding managed
> verision of work initialization. This will also help drivers to avoid
> mixing manual and devm based unwinding when other resources are handled by
> devm.
>
> Signed-off-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
> ---
> include/linux/devm-helpers.h | 25 +++++++++++++++++++++++++
> 1 file changed, 25 insertions(+)
>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Best regards,
Krzysztof
next prev parent reply other threads:[~2021-05-10 14:16 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-10 8:09 [PATCH 0/4] Add devm helper for work-queue initialization Matti Vaittinen
2021-05-10 8:10 ` [PATCH 1/4] devm-helpers: Add resource managed version of work init Matti Vaittinen
2021-05-10 14:11 ` Krzysztof Kozlowski [this message]
2021-05-10 8:11 ` [PATCH 2/4] extcon: extcon-max14577: Fix potential work-queue cancellation race Matti Vaittinen
2021-05-10 14:13 ` Krzysztof Kozlowski
2021-05-10 8:12 ` [PATCH 3/4] extcon: extcon-max77693.c: " Matti Vaittinen
2021-05-10 14:16 ` Krzysztof Kozlowski
2021-05-10 8:12 ` [PATCH 4/4] extcon: extcon-max8997: Fix IRQ freeing at error path Matti Vaittinen
2021-05-10 14:21 ` Krzysztof Kozlowski
2021-05-11 3:32 ` Matti Vaittinen
2021-05-11 16:27 ` Krzysztof Kozlowski
2021-05-14 8:12 ` Vaittinen, Matti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=021e3e2c-f0f5-32fe-50b4-7ae7882a85b3@canonical.com \
--to=krzysztof.kozlowski@canonical.com \
--cc=b.zolnierkie@samsung.com \
--cc=cw00.choi@samsung.com \
--cc=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=matti.vaittinen@fi.rohmeurope.com \
--cc=mazziesaccount@gmail.com \
--cc=myungjoo.ham@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.