All of lore.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
To: matti.vaittinen@fi.rohmeurope.com
Cc: Chanwoo Choi <cw00.choi@samsung.com>,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
	MyungJoo Ham <myungjoo.ham@samsung.com>,
	Hans de Goede <hdegoede@redhat.com>,
	Marek Szyprowski <m.szyprowski@samsung.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/4] extcon: extcon-max8997: Fix IRQ freeing at error path
Date: Tue, 11 May 2021 12:27:10 -0400	[thread overview]
Message-ID: <f5b5c30f-9a84-459e-d3c8-5a5760912cb1@canonical.com> (raw)
In-Reply-To: <978a829103c768a01ed8a1b37ea607ea5fb0ddb0.camel@fi.rohmeurope.com>

On 10/05/2021 23:32, Matti Vaittinen wrote:
> Hi Krzysztof,
> 
> On Mon, 2021-05-10 at 10:21 -0400, Krzysztof Kozlowski wrote:
>> On 10/05/2021 04:12, Matti Vaittinen wrote:
>>> If reading MAX8997_MUIC_REG_STATUS1 fails at probe the driver exits
>>> without freeing the requested IRQs.
>>
>> The driver frees IRQ on probe failure, so maybe you meant missing IRQ
>> mapping dispose?
> 
> No. The commit 3e34c8198960 ("extcon: max8997: Avoid forcing UART path
> on drive probe") introduced a return w/o IRQ freeing if reading the
> MAX8997_MUIC_REG_STATUS1 fails at the end of the probe. This is not
> visible in the patch though - as the return is Ok after the IRQs and
> work-queue cancellation are managed by devm.

I see it now, right. The fix is big and changes too much to be
backportable. I would prefer to simply fix the problem with "goto
err_irq" and convert to devm in next patch.


Best regards,
Krzysztof

  reply	other threads:[~2021-05-11 16:27 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-10  8:09 [PATCH 0/4] Add devm helper for work-queue initialization Matti Vaittinen
2021-05-10  8:10 ` [PATCH 1/4] devm-helpers: Add resource managed version of work init Matti Vaittinen
2021-05-10 14:11   ` Krzysztof Kozlowski
2021-05-10  8:11 ` [PATCH 2/4] extcon: extcon-max14577: Fix potential work-queue cancellation race Matti Vaittinen
2021-05-10 14:13   ` Krzysztof Kozlowski
2021-05-10  8:12 ` [PATCH 3/4] extcon: extcon-max77693.c: " Matti Vaittinen
2021-05-10 14:16   ` Krzysztof Kozlowski
2021-05-10  8:12 ` [PATCH 4/4] extcon: extcon-max8997: Fix IRQ freeing at error path Matti Vaittinen
2021-05-10 14:21   ` Krzysztof Kozlowski
2021-05-11  3:32     ` Matti Vaittinen
2021-05-11 16:27       ` Krzysztof Kozlowski [this message]
2021-05-14  8:12         ` Vaittinen, Matti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f5b5c30f-9a84-459e-d3c8-5a5760912cb1@canonical.com \
    --to=krzysztof.kozlowski@canonical.com \
    --cc=b.zolnierkie@samsung.com \
    --cc=cw00.choi@samsung.com \
    --cc=hdegoede@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=m.szyprowski@samsung.com \
    --cc=matti.vaittinen@fi.rohmeurope.com \
    --cc=myungjoo.ham@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.