* [meta-oe][PATCH] poppler: compile with -fpermissive to workaround code diagnostics errors on armv5
@ 2019-08-20 9:36 Hongxu Jia
2019-08-20 16:30 ` Khem Raj
0 siblings, 1 reply; 6+ messages in thread
From: Hongxu Jia @ 2019-08-20 9:36 UTC (permalink / raw)
To: raj.khem; +Cc: openembedded-devel
Build on qemuarmv5 failed:
...
|poppler-0.79.0/splash/SplashFont.h:69:36: error: passing ' const
SplashCoord' {aka 'const FixedPoint'} as 'this' argument discards
qualifiers [-fpermissive]
...
Compile with -fpermissive to workaround error with warning
Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com>
---
meta-oe/recipes-support/poppler/poppler_0.79.0.bb | 2 ++
1 file changed, 2 insertions(+)
diff --git a/meta-oe/recipes-support/poppler/poppler_0.79.0.bb b/meta-oe/recipes-support/poppler/poppler_0.79.0.bb
index b285eec..7a5ec13 100644
--- a/meta-oe/recipes-support/poppler/poppler_0.79.0.bb
+++ b/meta-oe/recipes-support/poppler/poppler_0.79.0.bb
@@ -28,6 +28,8 @@ inherit ${@bb.utils.contains('PACKAGECONFIG', 'qt5', 'cmake_qt5', '', d)}
SECURITY_CFLAGS = "${SECURITY_NO_PIE_CFLAGS}"
+CXXFLAGS_append_armv5 = " -fpermissive"
+
EXTRA_OECMAKE += " \
-DENABLE_CMS=lcms2 \
-DENABLE_UNSTABLE_API_ABI_HEADERS=ON \
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [meta-oe][PATCH] poppler: compile with -fpermissive to workaround code diagnostics errors on armv5
2019-08-20 9:36 [meta-oe][PATCH] poppler: compile with -fpermissive to workaround code diagnostics errors on armv5 Hongxu Jia
@ 2019-08-20 16:30 ` Khem Raj
2019-08-20 16:44 ` Adrian Bunk
0 siblings, 1 reply; 6+ messages in thread
From: Khem Raj @ 2019-08-20 16:30 UTC (permalink / raw)
To: Hongxu Jia; +Cc: openembeded-devel
On Tue, Aug 20, 2019 at 2:37 AM Hongxu Jia <hongxu.jia@windriver.com> wrote:
>
> Build on qemuarmv5 failed:
> ...
> |poppler-0.79.0/splash/SplashFont.h:69:36: error: passing ' const
> SplashCoord' {aka 'const FixedPoint'} as 'this' argument discards
> qualifiers [-fpermissive]
> ...
I wonder why this warning only shows up for armv5 and not for other
arm subarches or
non-arm arches.
>
> Compile with -fpermissive to workaround error with warning
>
> Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com>
> ---
> meta-oe/recipes-support/poppler/poppler_0.79.0.bb | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/meta-oe/recipes-support/poppler/poppler_0.79.0.bb b/meta-oe/recipes-support/poppler/poppler_0.79.0.bb
> index b285eec..7a5ec13 100644
> --- a/meta-oe/recipes-support/poppler/poppler_0.79.0.bb
> +++ b/meta-oe/recipes-support/poppler/poppler_0.79.0.bb
> @@ -28,6 +28,8 @@ inherit ${@bb.utils.contains('PACKAGECONFIG', 'qt5', 'cmake_qt5', '', d)}
>
> SECURITY_CFLAGS = "${SECURITY_NO_PIE_CFLAGS}"
>
> +CXXFLAGS_append_armv5 = " -fpermissive"
> +
> EXTRA_OECMAKE += " \
> -DENABLE_CMS=lcms2 \
> -DENABLE_UNSTABLE_API_ABI_HEADERS=ON \
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [meta-oe][PATCH] poppler: compile with -fpermissive to workaround code diagnostics errors on armv5
2019-08-20 16:30 ` Khem Raj
@ 2019-08-20 16:44 ` Adrian Bunk
2019-08-20 16:53 ` Khem Raj
0 siblings, 1 reply; 6+ messages in thread
From: Adrian Bunk @ 2019-08-20 16:44 UTC (permalink / raw)
To: Khem Raj; +Cc: openembeded-devel
On Tue, Aug 20, 2019 at 09:30:36AM -0700, Khem Raj wrote:
> On Tue, Aug 20, 2019 at 2:37 AM Hongxu Jia <hongxu.jia@windriver.com> wrote:
> >
> > Build on qemuarmv5 failed:
> > ...
> > |poppler-0.79.0/splash/SplashFont.h:69:36: error: passing ' const
> > SplashCoord' {aka 'const FixedPoint'} as 'this' argument discards
> > qualifiers [-fpermissive]
> > ...
>
> I wonder why this warning only shows up for armv5 and not for other
> arm subarches or
> non-arm arches.
>...
https://gitlab.freedesktop.org/poppler/poppler/issues/821
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [meta-oe][PATCH] poppler: compile with -fpermissive to workaround code diagnostics errors on armv5
2019-08-20 16:44 ` Adrian Bunk
@ 2019-08-20 16:53 ` Khem Raj
2019-08-20 20:11 ` Adrian Bunk
0 siblings, 1 reply; 6+ messages in thread
From: Khem Raj @ 2019-08-20 16:53 UTC (permalink / raw)
To: Adrian Bunk; +Cc: openembeded-devel
On Tue, Aug 20, 2019 at 9:44 AM Adrian Bunk <bunk@stusta.de> wrote:
>
> On Tue, Aug 20, 2019 at 09:30:36AM -0700, Khem Raj wrote:
> > On Tue, Aug 20, 2019 at 2:37 AM Hongxu Jia <hongxu.jia@windriver.com> wrote:
> > >
> > > Build on qemuarmv5 failed:
> > > ...
> > > |poppler-0.79.0/splash/SplashFont.h:69:36: error: passing ' const
> > > SplashCoord' {aka 'const FixedPoint'} as 'this' argument discards
> > > qualifiers [-fpermissive]
> > > ...
> >
> > I wonder why this warning only shows up for armv5 and not for other
> > arm subarches or
> > non-arm arches.
> >...
>
> https://gitlab.freedesktop.org/poppler/poppler/issues/821
I see. This makes sense now. I wonder if we should just disable the
support instead of keeping
it dragging along ?
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [meta-oe][PATCH] poppler: compile with -fpermissive to workaround code diagnostics errors on armv5
2019-08-20 16:53 ` Khem Raj
@ 2019-08-20 20:11 ` Adrian Bunk
2019-08-21 1:27 ` Hongxu Jia
0 siblings, 1 reply; 6+ messages in thread
From: Adrian Bunk @ 2019-08-20 20:11 UTC (permalink / raw)
To: Khem Raj; +Cc: openembeded-devel
On Tue, Aug 20, 2019 at 09:53:11AM -0700, Khem Raj wrote:
> On Tue, Aug 20, 2019 at 9:44 AM Adrian Bunk <bunk@stusta.de> wrote:
> >
> > On Tue, Aug 20, 2019 at 09:30:36AM -0700, Khem Raj wrote:
> > > On Tue, Aug 20, 2019 at 2:37 AM Hongxu Jia <hongxu.jia@windriver.com> wrote:
> > > >
> > > > Build on qemuarmv5 failed:
> > > > ...
> > > > |poppler-0.79.0/splash/SplashFont.h:69:36: error: passing ' const
> > > > SplashCoord' {aka 'const FixedPoint'} as 'this' argument discards
> > > > qualifiers [-fpermissive]
> > > > ...
> > >
> > > I wonder why this warning only shows up for armv5 and not for other
> > > arm subarches or
> > > non-arm arches.
> > >...
> >
> > https://gitlab.freedesktop.org/poppler/poppler/issues/821
>
> I see. This makes sense now. I wonder if we should just disable the
> support instead of keeping
> it dragging along ?
Patch sent.
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [meta-oe][PATCH] poppler: compile with -fpermissive to workaround code diagnostics errors on armv5
2019-08-20 20:11 ` Adrian Bunk
@ 2019-08-21 1:27 ` Hongxu Jia
0 siblings, 0 replies; 6+ messages in thread
From: Hongxu Jia @ 2019-08-21 1:27 UTC (permalink / raw)
To: Adrian Bunk, Khem Raj; +Cc: openembeded-devel
On 8/21/19 4:11 AM, Adrian Bunk wrote:
> On Tue, Aug 20, 2019 at 09:53:11AM -0700, Khem Raj wrote:
>> On Tue, Aug 20, 2019 at 9:44 AM Adrian Bunk <bunk@stusta.de> wrote:
>>> On Tue, Aug 20, 2019 at 09:30:36AM -0700, Khem Raj wrote:
>>>> On Tue, Aug 20, 2019 at 2:37 AM Hongxu Jia <hongxu.jia@windriver.com> wrote:
>>>>> Build on qemuarmv5 failed:
>>>>> ...
>>>>> |poppler-0.79.0/splash/SplashFont.h:69:36: error: passing ' const
>>>>> SplashCoord' {aka 'const FixedPoint'} as 'this' argument discards
>>>>> qualifiers [-fpermissive]
>>>>> ...
>>>> I wonder why this warning only shows up for armv5 and not for other
>>>> arm subarches or
>>>> non-arm arches.
>>>> ...
>>> https://gitlab.freedesktop.org/poppler/poppler/issues/821
>> I see. This makes sense now. I wonder if we should just disable the
>> support instead of keeping
>> it dragging along ?
> Patch sent.
Understood, thank you very much
//Hongxu
> cu
> Adrian
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-08-21 1:28 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-20 9:36 [meta-oe][PATCH] poppler: compile with -fpermissive to workaround code diagnostics errors on armv5 Hongxu Jia
2019-08-20 16:30 ` Khem Raj
2019-08-20 16:44 ` Adrian Bunk
2019-08-20 16:53 ` Khem Raj
2019-08-20 20:11 ` Adrian Bunk
2019-08-21 1:27 ` Hongxu Jia
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.