From: Matan Barak <matanb@mellanox.com>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>, leonro@mellanox.com
Cc: netdev@vger.kernel.org, linux-rdma@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] net/mlx5: Simplify a test
Date: Tue, 1 Nov 2016 11:38:18 +0200 [thread overview]
Message-ID: <025cb4e1-f5e8-8bc9-0d4f-3ee8f8d1bb5d@mellanox.com> (raw)
In-Reply-To: <20161101071053.12486-1-christophe.jaillet@wanadoo.fr>
On 01/11/2016 09:10, Christophe JAILLET wrote:
> 'create_root_ns()' does not return an error pointer, so the test can be
> simplified to be more consistent.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> drivers/net/ethernet/mellanox/mlx5/core/fs_core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/fs_core.c b/drivers/net/ethernet/mellanox/mlx5/core/fs_core.c
> index 904853f9cf7a..330955f6badc 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/fs_core.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/fs_core.c
> @@ -1833,7 +1833,7 @@ static int init_root_ns(struct mlx5_flow_steering *steering)
> {
>
> steering->root_ns = create_root_ns(steering, FS_FT_NIC_RX);
> - if (IS_ERR_OR_NULL(steering->root_ns))
> + if (!steering->root_ns)
> goto cleanup;
>
> if (init_root_tree(steering, &root_fs, &steering->root_ns->ns.node))
>
Thanks.
Acked-by: Matan Barak <matanb@mellanox.com>
WARNING: multiple messages have this Message-ID (diff)
From: Matan Barak <matanb@mellanox.com>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
<leonro@mellanox.com>
Cc: <netdev@vger.kernel.org>, <linux-rdma@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <kernel-janitors@vger.kernel.org>
Subject: Re: [PATCH] net/mlx5: Simplify a test
Date: Tue, 1 Nov 2016 11:38:18 +0200 [thread overview]
Message-ID: <025cb4e1-f5e8-8bc9-0d4f-3ee8f8d1bb5d@mellanox.com> (raw)
In-Reply-To: <20161101071053.12486-1-christophe.jaillet@wanadoo.fr>
On 01/11/2016 09:10, Christophe JAILLET wrote:
> 'create_root_ns()' does not return an error pointer, so the test can be
> simplified to be more consistent.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> drivers/net/ethernet/mellanox/mlx5/core/fs_core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/fs_core.c b/drivers/net/ethernet/mellanox/mlx5/core/fs_core.c
> index 904853f9cf7a..330955f6badc 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/fs_core.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/fs_core.c
> @@ -1833,7 +1833,7 @@ static int init_root_ns(struct mlx5_flow_steering *steering)
> {
>
> steering->root_ns = create_root_ns(steering, FS_FT_NIC_RX);
> - if (IS_ERR_OR_NULL(steering->root_ns))
> + if (!steering->root_ns)
> goto cleanup;
>
> if (init_root_tree(steering, &root_fs, &steering->root_ns->ns.node))
>
Thanks.
Acked-by: Matan Barak <matanb@mellanox.com>
WARNING: multiple messages have this Message-ID (diff)
From: Matan Barak <matanb@mellanox.com>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>, leonro@mellanox.com
Cc: netdev@vger.kernel.org, linux-rdma@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] net/mlx5: Simplify a test
Date: Tue, 01 Nov 2016 09:38:18 +0000 [thread overview]
Message-ID: <025cb4e1-f5e8-8bc9-0d4f-3ee8f8d1bb5d@mellanox.com> (raw)
In-Reply-To: <20161101071053.12486-1-christophe.jaillet@wanadoo.fr>
On 01/11/2016 09:10, Christophe JAILLET wrote:
> 'create_root_ns()' does not return an error pointer, so the test can be
> simplified to be more consistent.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> drivers/net/ethernet/mellanox/mlx5/core/fs_core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/fs_core.c b/drivers/net/ethernet/mellanox/mlx5/core/fs_core.c
> index 904853f9cf7a..330955f6badc 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/fs_core.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/fs_core.c
> @@ -1833,7 +1833,7 @@ static int init_root_ns(struct mlx5_flow_steering *steering)
> {
>
> steering->root_ns = create_root_ns(steering, FS_FT_NIC_RX);
> - if (IS_ERR_OR_NULL(steering->root_ns))
> + if (!steering->root_ns)
> goto cleanup;
>
> if (init_root_tree(steering, &root_fs, &steering->root_ns->ns.node))
>
Thanks.
Acked-by: Matan Barak <matanb@mellanox.com>
next prev parent reply other threads:[~2016-11-01 9:38 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-01 7:10 [PATCH] net/mlx5: Simplify a test Christophe JAILLET
2016-11-01 7:10 ` Christophe JAILLET
2016-11-01 7:10 ` Christophe JAILLET
2016-11-01 9:38 ` Matan Barak [this message]
2016-11-01 9:38 ` Matan Barak
2016-11-01 9:38 ` Matan Barak
[not found] ` <025cb4e1-f5e8-8bc9-0d4f-3ee8f8d1bb5d-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2016-11-01 18:12 ` David Miller
2016-11-01 18:12 ` David Miller
2016-11-01 18:12 ` David Miller
2016-11-01 9:59 ` Saeed Mahameed
2016-11-01 9:59 ` Saeed Mahameed
2016-11-01 9:59 ` Saeed Mahameed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=025cb4e1-f5e8-8bc9-0d4f-3ee8f8d1bb5d@mellanox.com \
--to=matanb@mellanox.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=leonro@mellanox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.