* [PATCH v2] RDMA/rxe: Get rid of redundant plus
@ 2022-01-04 1:24 Li Zhijian
2022-01-04 2:46 ` Zhu Yanjun
2022-01-04 7:54 ` Christoph Hellwig
0 siblings, 2 replies; 4+ messages in thread
From: Li Zhijian @ 2022-01-04 1:24 UTC (permalink / raw)
To: zyjzyj2000, jgg, leon; +Cc: linux-rdma, linux-kernel, Li Zhijian
From: Li Zhijian <lizhijian@cn.fujitsu.com>
Get rid of the duplicate plus in a line to be consistent with others.
Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com>
---
drivers/infiniband/sw/rxe/rxe_opcode.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/infiniband/sw/rxe/rxe_opcode.c b/drivers/infiniband/sw/rxe/rxe_opcode.c
index 3ef5a10a6efd..79122eeb4d82 100644
--- a/drivers/infiniband/sw/rxe/rxe_opcode.c
+++ b/drivers/infiniband/sw/rxe/rxe_opcode.c
@@ -879,9 +879,9 @@ struct rxe_opcode_info rxe_opcode[RXE_NUM_OPCODE] = {
[RXE_ATMETH] = RXE_BTH_BYTES
+ RXE_RDETH_BYTES
+ RXE_DETH_BYTES,
- [RXE_PAYLOAD] = RXE_BTH_BYTES +
+ [RXE_PAYLOAD] = RXE_BTH_BYTES
+ RXE_ATMETH_BYTES
- + RXE_DETH_BYTES +
+ + RXE_DETH_BYTES
+ RXE_RDETH_BYTES,
}
},
@@ -900,9 +900,9 @@ struct rxe_opcode_info rxe_opcode[RXE_NUM_OPCODE] = {
[RXE_ATMETH] = RXE_BTH_BYTES
+ RXE_RDETH_BYTES
+ RXE_DETH_BYTES,
- [RXE_PAYLOAD] = RXE_BTH_BYTES +
+ [RXE_PAYLOAD] = RXE_BTH_BYTES
+ RXE_ATMETH_BYTES
- + RXE_DETH_BYTES +
+ + RXE_DETH_BYTES
+ RXE_RDETH_BYTES,
}
},
--
2.33.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2] RDMA/rxe: Get rid of redundant plus
2022-01-04 1:24 [PATCH v2] RDMA/rxe: Get rid of redundant plus Li Zhijian
@ 2022-01-04 2:46 ` Zhu Yanjun
2022-01-04 7:54 ` Christoph Hellwig
1 sibling, 0 replies; 4+ messages in thread
From: Zhu Yanjun @ 2022-01-04 2:46 UTC (permalink / raw)
To: Li Zhijian
Cc: Jason Gunthorpe, Leon Romanovsky, RDMA mailing list, LKML, Li Zhijian
On Tue, Jan 4, 2022 at 9:25 AM Li Zhijian <lizhijian@fujitsu.com> wrote:
>
> From: Li Zhijian <lizhijian@cn.fujitsu.com>
>
> Get rid of the duplicate plus in a line to be consistent with others.
>
> Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com>
Reviewed-by: Zhu Yanjun <zyjzyj2000@gmail.com>
Zhu Yanjun
> ---
> drivers/infiniband/sw/rxe/rxe_opcode.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/infiniband/sw/rxe/rxe_opcode.c b/drivers/infiniband/sw/rxe/rxe_opcode.c
> index 3ef5a10a6efd..79122eeb4d82 100644
> --- a/drivers/infiniband/sw/rxe/rxe_opcode.c
> +++ b/drivers/infiniband/sw/rxe/rxe_opcode.c
> @@ -879,9 +879,9 @@ struct rxe_opcode_info rxe_opcode[RXE_NUM_OPCODE] = {
> [RXE_ATMETH] = RXE_BTH_BYTES
> + RXE_RDETH_BYTES
> + RXE_DETH_BYTES,
> - [RXE_PAYLOAD] = RXE_BTH_BYTES +
> + [RXE_PAYLOAD] = RXE_BTH_BYTES
> + RXE_ATMETH_BYTES
> - + RXE_DETH_BYTES +
> + + RXE_DETH_BYTES
> + RXE_RDETH_BYTES,
> }
> },
> @@ -900,9 +900,9 @@ struct rxe_opcode_info rxe_opcode[RXE_NUM_OPCODE] = {
> [RXE_ATMETH] = RXE_BTH_BYTES
> + RXE_RDETH_BYTES
> + RXE_DETH_BYTES,
> - [RXE_PAYLOAD] = RXE_BTH_BYTES +
> + [RXE_PAYLOAD] = RXE_BTH_BYTES
> + RXE_ATMETH_BYTES
> - + RXE_DETH_BYTES +
> + + RXE_DETH_BYTES
> + RXE_RDETH_BYTES,
> }
> },
> --
> 2.33.0
>
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] RDMA/rxe: Get rid of redundant plus
2022-01-04 1:24 [PATCH v2] RDMA/rxe: Get rid of redundant plus Li Zhijian
2022-01-04 2:46 ` Zhu Yanjun
@ 2022-01-04 7:54 ` Christoph Hellwig
2022-01-04 10:38 ` lizhijian
1 sibling, 1 reply; 4+ messages in thread
From: Christoph Hellwig @ 2022-01-04 7:54 UTC (permalink / raw)
To: Li Zhijian; +Cc: zyjzyj2000, jgg, leon, linux-rdma, linux-kernel, Li Zhijian
On Tue, Jan 04, 2022 at 09:24:06AM +0800, Li Zhijian wrote:
> --- a/drivers/infiniband/sw/rxe/rxe_opcode.c
> +++ b/drivers/infiniband/sw/rxe/rxe_opcode.c
> @@ -879,9 +879,9 @@ struct rxe_opcode_info rxe_opcode[RXE_NUM_OPCODE] = {
> [RXE_ATMETH] = RXE_BTH_BYTES
> + RXE_RDETH_BYTES
> + RXE_DETH_BYTES,
> - [RXE_PAYLOAD] = RXE_BTH_BYTES +
> + [RXE_PAYLOAD] = RXE_BTH_BYTES
> + RXE_ATMETH_BYTES
> - + RXE_DETH_BYTES +
> + + RXE_DETH_BYTES
> + RXE_RDETH_BYTES,
> }
> },
> @@ -900,9 +900,9 @@ struct rxe_opcode_info rxe_opcode[RXE_NUM_OPCODE] = {
> [RXE_ATMETH] = RXE_BTH_BYTES
> + RXE_RDETH_BYTES
> + RXE_DETH_BYTES,
> - [RXE_PAYLOAD] = RXE_BTH_BYTES +
> + [RXE_PAYLOAD] = RXE_BTH_BYTES
> + RXE_ATMETH_BYTES
> - + RXE_DETH_BYTES +
> + + RXE_DETH_BYTES
> + RXE_RDETH_BYTES,
> }
> },
Please fix this up to always have the + on the continuing line which
is the normal kernel style.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] RDMA/rxe: Get rid of redundant plus
2022-01-04 7:54 ` Christoph Hellwig
@ 2022-01-04 10:38 ` lizhijian
0 siblings, 0 replies; 4+ messages in thread
From: lizhijian @ 2022-01-04 10:38 UTC (permalink / raw)
To: Christoph Hellwig
Cc: zyjzyj2000, jgg, leon, linux-rdma, linux-kernel, lizhijian
On 04/01/2022 15:54, Christoph Hellwig wrote:
> On Tue, Jan 04, 2022 at 09:24:06AM +0800, Li Zhijian wrote:
>> --- a/drivers/infiniband/sw/rxe/rxe_opcode.c
>> +++ b/drivers/infiniband/sw/rxe/rxe_opcode.c
>> @@ -879,9 +879,9 @@ struct rxe_opcode_info rxe_opcode[RXE_NUM_OPCODE] = {
>> [RXE_ATMETH] = RXE_BTH_BYTES
>> + RXE_RDETH_BYTES
>> + RXE_DETH_BYTES,
>> - [RXE_PAYLOAD] = RXE_BTH_BYTES +
>> + [RXE_PAYLOAD] = RXE_BTH_BYTES
>> + RXE_ATMETH_BYTES
>> - + RXE_DETH_BYTES +
>> + + RXE_DETH_BYTES
>> + RXE_RDETH_BYTES,
>> }
>> },
>> @@ -900,9 +900,9 @@ struct rxe_opcode_info rxe_opcode[RXE_NUM_OPCODE] = {
>> [RXE_ATMETH] = RXE_BTH_BYTES
>> + RXE_RDETH_BYTES
>> + RXE_DETH_BYTES,
>> - [RXE_PAYLOAD] = RXE_BTH_BYTES +
>> + [RXE_PAYLOAD] = RXE_BTH_BYTES
>> + RXE_ATMETH_BYTES
>> - + RXE_DETH_BYTES +
>> + + RXE_DETH_BYTES
>> + RXE_RDETH_BYTES,
>> }
>> },
> Please fix this up to always have the + on the continuing line which
> is the normal kernel style.
I'm so glad to hear that, i will also update the existing unconventional style in this file.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-01-04 10:38 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-04 1:24 [PATCH v2] RDMA/rxe: Get rid of redundant plus Li Zhijian
2022-01-04 2:46 ` Zhu Yanjun
2022-01-04 7:54 ` Christoph Hellwig
2022-01-04 10:38 ` lizhijian
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.