All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Keller, Jacob E" <jacob.e.keller@intel.com>
To: David Miller <davem@davemloft.net>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"intel-wired-lan@lists.osuosl.org"
	<intel-wired-lan@lists.osuosl.org>
Subject: RE: [PATCH RFC v1] ethtool: implement helper to get flow_type value
Date: Mon, 28 Nov 2016 22:49:38 +0000	[thread overview]
Message-ID: <02874ECE860811409154E81DA85FBB5857CCA45D@ORSMSX115.amr.corp.intel.com> (raw)
In-Reply-To: <20161125.160634.944615331208897862.davem@davemloft.net>

> -----Original Message-----
> From: netdev-owner@vger.kernel.org [mailto:netdev-owner@vger.kernel.org] On
> Behalf Of David Miller
> Sent: Friday, November 25, 2016 1:07 PM
> To: Keller, Jacob E <jacob.e.keller@intel.com>
> Cc: netdev@vger.kernel.org; intel-wired-lan@lists.osuosl.org
> Subject: Re: [PATCH RFC v1] ethtool: implement helper to get flow_type value
> 
> From: Jacob Keller <jacob.e.keller@intel.com>
> Date: Tue, 22 Nov 2016 15:44:53 -0800
> 
> > @@ -880,6 +880,14 @@ struct ethtool_rx_flow_spec {
> >  	__u32		location;
> >  };
> >
> > +/* Flag to enable additional fields in struct ethtool_rx_flow_spec */
> > +#define	FLOW_EXT	0x80000000
> > +#define	FLOW_MAC_EXT	0x40000000
> > +static inline __u32 ethtool_get_flow_spec_type(__u32 flow_type)
> > +{
> > +	return flow_type & (FLOW_EXT | FLOW_MAC_EXT);
> > +}
> > +
> >  /* How rings are layed out when accessing virtual functions or
> >   * offloaded queues is device specific. To allow users to do flow
> >   * steering and specify these queues the ring cookie is partitioned
> > @@ -1579,9 +1587,6 @@ static inline int ethtool_validate_duplex(__u8 duplex)
> >  #define	IPV4_FLOW	0x10	/* hash only */
> >  #define	IPV6_FLOW	0x11	/* hash only */
> >  #define	ETHER_FLOW	0x12	/* spec only (ether_spec) */
> > -/* Flag to enable additional fields in struct ethtool_rx_flow_spec */
> > -#define	FLOW_EXT	0x80000000
> > -#define	FLOW_MAC_EXT	0x40000000
> >
> >  /* L3-L4 network traffic flow hash options */
> >  #define	RXH_L2DA	(1 << 1)
> 
> Please put the helper after the FLOW_* definitions rather than moving
> them earlier in the file.

Will do. I originally moved them to place these with other similar helpers but I can re-spin this.

Thanks,
Jake

WARNING: multiple messages have this Message-ID (diff)
From: Keller, Jacob E <jacob.e.keller@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH RFC v1] ethtool: implement helper to get flow_type value
Date: Mon, 28 Nov 2016 22:49:38 +0000	[thread overview]
Message-ID: <02874ECE860811409154E81DA85FBB5857CCA45D@ORSMSX115.amr.corp.intel.com> (raw)
In-Reply-To: <20161125.160634.944615331208897862.davem@davemloft.net>

> -----Original Message-----
> From: netdev-owner at vger.kernel.org [mailto:netdev-owner at vger.kernel.org] On
> Behalf Of David Miller
> Sent: Friday, November 25, 2016 1:07 PM
> To: Keller, Jacob E <jacob.e.keller@intel.com>
> Cc: netdev at vger.kernel.org; intel-wired-lan at lists.osuosl.org
> Subject: Re: [PATCH RFC v1] ethtool: implement helper to get flow_type value
> 
> From: Jacob Keller <jacob.e.keller@intel.com>
> Date: Tue, 22 Nov 2016 15:44:53 -0800
> 
> > @@ -880,6 +880,14 @@ struct ethtool_rx_flow_spec {
> >  	__u32		location;
> >  };
> >
> > +/* Flag to enable additional fields in struct ethtool_rx_flow_spec */
> > +#define	FLOW_EXT	0x80000000
> > +#define	FLOW_MAC_EXT	0x40000000
> > +static inline __u32 ethtool_get_flow_spec_type(__u32 flow_type)
> > +{
> > +	return flow_type & (FLOW_EXT | FLOW_MAC_EXT);
> > +}
> > +
> >  /* How rings are layed out when accessing virtual functions or
> >   * offloaded queues is device specific. To allow users to do flow
> >   * steering and specify these queues the ring cookie is partitioned
> > @@ -1579,9 +1587,6 @@ static inline int ethtool_validate_duplex(__u8 duplex)
> >  #define	IPV4_FLOW	0x10	/* hash only */
> >  #define	IPV6_FLOW	0x11	/* hash only */
> >  #define	ETHER_FLOW	0x12	/* spec only (ether_spec) */
> > -/* Flag to enable additional fields in struct ethtool_rx_flow_spec */
> > -#define	FLOW_EXT	0x80000000
> > -#define	FLOW_MAC_EXT	0x40000000
> >
> >  /* L3-L4 network traffic flow hash options */
> >  #define	RXH_L2DA	(1 << 1)
> 
> Please put the helper after the FLOW_* definitions rather than moving
> them earlier in the file.

Will do. I originally moved them to place these with other similar helpers but I can re-spin this.

Thanks,
Jake

  reply	other threads:[~2016-11-28 22:49 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-22 23:44 [PATCH RFC v1] ethtool: implement helper to get flow_type value Jacob Keller
2016-11-22 23:44 ` [Intel-wired-lan] " Jacob Keller
2016-11-25 21:06 ` David Miller
2016-11-25 21:06   ` [Intel-wired-lan] " David Miller
2016-11-28 22:49   ` Keller, Jacob E [this message]
2016-11-28 22:49     ` Keller, Jacob E

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=02874ECE860811409154E81DA85FBB5857CCA45D@ORSMSX115.amr.corp.intel.com \
    --to=jacob.e.keller@intel.com \
    --cc=davem@davemloft.net \
    --cc=intel-wired-lan@lists.osuosl.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.