All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Keller, Jacob E" <jacob.e.keller@intel.com>
To: Bjorn Helgaas <helgaas@kernel.org>,
	"Kirsher, Jeffrey T" <jeffrey.t.kirsher@intel.com>,
	Ganesh Goudar <ganeshgr@chelsio.com>,
	"Michael Chan" <michael.chan@broadcom.com>,
	Ariel Elior <ariel.elior@cavium.com>
Cc: "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
	"everest-linux-l2@cavium.com" <everest-linux-l2@cavium.com>,
	"intel-wired-lan@lists.osuosl.org"
	<intel-wired-lan@lists.osuosl.org>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Tal Gilboa <talgi@mellanox.com>,
	Tariq Toukan <tariqt@mellanox.com>,
	Jakub Kicinski <kubakici@wp.pl>
Subject: RE: [PATCH v6 0/5] PCI: Improve PCIe link status reporting
Date: Thu, 3 May 2018 20:29:38 +0000	[thread overview]
Message-ID: <02874ECE860811409154E81DA85FBB5882DBA48B@ORSMSX115.amr.corp.intel.com> (raw)
In-Reply-To: <152537719056.62474.2571390812509425478.stgit@bhelgaas-glaptop.roam.corp.google.com>

> -----Original Message-----
> This does change the dmesg reporting of link speeds, and in the ixgbe case,
> it changes the reporting from KERN_WARN level to KERN_INFO.  If that's an
> issue, let's talk about it.  I'm hoping the reduce code size, improved
> functionality, and consistency across drivers is enough to make this
> worthwhile.
> 

I personally have no issue with this change, but I don't work on the ixgbe driver much anymore.

Thanks,
Jake

WARNING: multiple messages have this Message-ID (diff)
From: "Keller, Jacob E" <jacob.e.keller@intel.com>
To: Bjorn Helgaas <helgaas@kernel.org>,
	"Kirsher, Jeffrey T" <jeffrey.t.kirsher@intel.com>,
	Ganesh Goudar <ganeshgr@chelsio.com>,
	"Michael Chan" <michael.chan@broadcom.com>,
	Ariel Elior <ariel.elior@cavium.com>
Cc: "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
	"everest-linux-l2@cavium.com" <everest-linux-l2@cavium.com>,
	"intel-wired-lan@lists.osuosl.org"
	<intel-wired-lan@lists.osuosl.org>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Tal Gilboa <talgi@mellanox.com>,
	Tariq Toukan <tariqt@mellanox.com>,
	Jakub Kicinski <kubakici@wp.pl>
Subject: RE: [PATCH v6 0/5] PCI: Improve PCIe link status reporting
Date: Thu, 3 May 2018 20:29:38 +0000	[thread overview]
Message-ID: <02874ECE860811409154E81DA85FBB5882DBA48B@ORSMSX115.amr.corp.intel.com> (raw)
In-Reply-To: <152537719056.62474.2571390812509425478.stgit@bhelgaas-glaptop.roam.corp.google.com>

PiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiBUaGlzIGRvZXMgY2hhbmdlIHRoZSBkbWVz
ZyByZXBvcnRpbmcgb2YgbGluayBzcGVlZHMsIGFuZCBpbiB0aGUgaXhnYmUgY2FzZSwNCj4gaXQg
Y2hhbmdlcyB0aGUgcmVwb3J0aW5nIGZyb20gS0VSTl9XQVJOIGxldmVsIHRvIEtFUk5fSU5GTy4g
IElmIHRoYXQncyBhbg0KPiBpc3N1ZSwgbGV0J3MgdGFsayBhYm91dCBpdC4gIEknbSBob3Bpbmcg
dGhlIHJlZHVjZSBjb2RlIHNpemUsIGltcHJvdmVkDQo+IGZ1bmN0aW9uYWxpdHksIGFuZCBjb25z
aXN0ZW5jeSBhY3Jvc3MgZHJpdmVycyBpcyBlbm91Z2ggdG8gbWFrZSB0aGlzDQo+IHdvcnRod2hp
bGUuDQo+IA0KDQpJIHBlcnNvbmFsbHkgaGF2ZSBubyBpc3N1ZSB3aXRoIHRoaXMgY2hhbmdlLCBi
dXQgSSBkb24ndCB3b3JrIG9uIHRoZSBpeGdiZSBkcml2ZXIgbXVjaCBhbnltb3JlLg0KDQpUaGFu
a3MsDQpKYWtlDQoNCg==

WARNING: multiple messages have this Message-ID (diff)
From: Keller, Jacob E <jacob.e.keller@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH v6 0/5] PCI: Improve PCIe link status reporting
Date: Thu, 3 May 2018 20:29:38 +0000	[thread overview]
Message-ID: <02874ECE860811409154E81DA85FBB5882DBA48B@ORSMSX115.amr.corp.intel.com> (raw)
In-Reply-To: <152537719056.62474.2571390812509425478.stgit@bhelgaas-glaptop.roam.corp.google.com>

> -----Original Message-----
> This does change the dmesg reporting of link speeds, and in the ixgbe case,
> it changes the reporting from KERN_WARN level to KERN_INFO.  If that's an
> issue, let's talk about it.  I'm hoping the reduce code size, improved
> functionality, and consistency across drivers is enough to make this
> worthwhile.
> 

I personally have no issue with this change, but I don't work on the ixgbe driver much anymore.

Thanks,
Jake


  parent reply	other threads:[~2018-05-03 20:29 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-03 20:00 [PATCH v6 0/5] PCI: Improve PCIe link status reporting Bjorn Helgaas
2018-05-03 20:00 ` [Intel-wired-lan] " Bjorn Helgaas
2018-05-03 20:00 ` [PATCH v6 1/5] bnx2x: Report PCIe link properties with pcie_print_link_status() Bjorn Helgaas
2018-05-03 20:00   ` [Intel-wired-lan] " Bjorn Helgaas
2018-05-03 20:00 ` [PATCH v6 2/5] bnxt_en: " Bjorn Helgaas
2018-05-03 20:00   ` [Intel-wired-lan] " Bjorn Helgaas
2018-05-03 20:00 ` [PATCH v6 3/5] cxgb4: " Bjorn Helgaas
2018-05-03 20:00   ` [Intel-wired-lan] " Bjorn Helgaas
2018-05-03 20:00 ` [PATCH v6 4/5] ixgbe: " Bjorn Helgaas
2018-05-03 20:00   ` [Intel-wired-lan] " Bjorn Helgaas
2018-05-10 19:12   ` Bowers, AndrewX
2018-05-10 20:37   ` Jeff Kirsher
2018-05-10 20:37     ` [Intel-wired-lan] " Jeff Kirsher
2018-05-10 20:37     ` Jeff Kirsher
2018-05-03 20:00 ` [PATCH v6 5/5] PCI: Remove unused pcie_get_minimum_link() Bjorn Helgaas
2018-05-03 20:00   ` [Intel-wired-lan] " Bjorn Helgaas
2018-05-10 16:33   ` Bjorn Helgaas
2018-05-10 16:33     ` [Intel-wired-lan] " Bjorn Helgaas
2018-05-10 20:34     ` Jeff Kirsher
2018-05-10 20:34       ` [Intel-wired-lan] " Jeff Kirsher
2018-05-10 20:34       ` Jeff Kirsher
2018-05-03 20:29 ` Keller, Jacob E [this message]
2018-05-03 20:29   ` [Intel-wired-lan] [PATCH v6 0/5] PCI: Improve PCIe link status reporting Keller, Jacob E
2018-05-03 20:29   ` Keller, Jacob E
2018-05-10 22:29 ` Bjorn Helgaas
2018-05-10 22:29   ` [Intel-wired-lan] " Bjorn Helgaas
2018-05-23 21:46 ` Bjorn Helgaas
2018-05-23 21:46   ` [Intel-wired-lan] " Bjorn Helgaas
2018-05-24 10:18   ` Ganesh Goudar
2018-05-24 10:18     ` [Intel-wired-lan] " Ganesh Goudar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=02874ECE860811409154E81DA85FBB5882DBA48B@ORSMSX115.amr.corp.intel.com \
    --to=jacob.e.keller@intel.com \
    --cc=ariel.elior@cavium.com \
    --cc=everest-linux-l2@cavium.com \
    --cc=ganeshgr@chelsio.com \
    --cc=helgaas@kernel.org \
    --cc=intel-wired-lan@lists.osuosl.org \
    --cc=jeffrey.t.kirsher@intel.com \
    --cc=kubakici@wp.pl \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=michael.chan@broadcom.com \
    --cc=netdev@vger.kernel.org \
    --cc=talgi@mellanox.com \
    --cc=tariqt@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.