* [[XSATOOL]] repo: Add missing spaces in the configure cmdline for "xentools"
@ 2020-07-27 16:04 Julien Grall
2020-07-27 16:04 ` Julien Grall
0 siblings, 1 reply; 3+ messages in thread
From: Julien Grall @ 2020-07-27 16:04 UTC (permalink / raw)
To: xen-devel; +Cc: Julien Grall, julien
From: Julien Grall <jgrall@amazon.com>
The operator + will just concatenate two strings. As the result, the
configure cmdline for "xentools" will look like:
./configure --disable-stubdom --disable-qemu-traditional--with-system-qemu=/bin/false --with-system-seabios=/bin/false--disable-ovmf
This can be avoided by explicitely adding the spaces.
Signed-off-by: Julien Grall <jgrall@amazon.com>
---
repo.go | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/repo.go b/repo.go
index 1e7802f8142c..f00b7469101f 100644
--- a/repo.go
+++ b/repo.go
@@ -139,8 +139,8 @@ func MainRepoInit(unused *XSAMeta, args []string) (ret int) {
G.config.Tool.BuildSequences = map[string]BuildSequence{
"simple": {"./configure", "make -j 8"},
"xen": {"make -j 8 xen"},
- "xentools": {"./configure --disable-stubdom --disable-qemu-traditional" +
- "--with-system-qemu=/bin/false --with-system-seabios=/bin/false" +
+ "xentools": {"./configure --disable-stubdom --disable-qemu-traditional " +
+ "--with-system-qemu=/bin/false --with-system-seabios=/bin/false " +
"--disable-ovmf",
"make -j 8"},
}
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [[XSATOOL]] repo: Add missing spaces in the configure cmdline for "xentools"
2020-07-27 16:04 [[XSATOOL]] repo: Add missing spaces in the configure cmdline for "xentools" Julien Grall
@ 2020-07-27 16:04 ` Julien Grall
2020-07-28 10:12 ` George Dunlap
0 siblings, 1 reply; 3+ messages in thread
From: Julien Grall @ 2020-07-27 16:04 UTC (permalink / raw)
To: xen-devel; +Cc: Julien Grall, George Dunlap
Hmmm I forgot to CC George. Sorry for that.
On 27/07/2020 17:04, Julien Grall wrote:
> From: Julien Grall <jgrall@amazon.com>
>
> The operator + will just concatenate two strings. As the result, the
> configure cmdline for "xentools" will look like:
>
> ./configure --disable-stubdom --disable-qemu-traditional--with-system-qemu=/bin/false --with-system-seabios=/bin/false--disable-ovmf
>
> This can be avoided by explicitely adding the spaces.
>
> Signed-off-by: Julien Grall <jgrall@amazon.com>
> ---
> repo.go | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/repo.go b/repo.go
> index 1e7802f8142c..f00b7469101f 100644
> --- a/repo.go
> +++ b/repo.go
> @@ -139,8 +139,8 @@ func MainRepoInit(unused *XSAMeta, args []string) (ret int) {
> G.config.Tool.BuildSequences = map[string]BuildSequence{
> "simple": {"./configure", "make -j 8"},
> "xen": {"make -j 8 xen"},
> - "xentools": {"./configure --disable-stubdom --disable-qemu-traditional" +
> - "--with-system-qemu=/bin/false --with-system-seabios=/bin/false" +
> + "xentools": {"./configure --disable-stubdom --disable-qemu-traditional " +
> + "--with-system-qemu=/bin/false --with-system-seabios=/bin/false " +
> "--disable-ovmf",
> "make -j 8"},
> }
>
--
Julien Grall
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [[XSATOOL]] repo: Add missing spaces in the configure cmdline for "xentools"
2020-07-27 16:04 ` Julien Grall
@ 2020-07-28 10:12 ` George Dunlap
0 siblings, 0 replies; 3+ messages in thread
From: George Dunlap @ 2020-07-28 10:12 UTC (permalink / raw)
To: Julien Grall; +Cc: xen-devel, Julien Grall
> On Jul 27, 2020, at 5:04 PM, Julien Grall <julien@xen.org> wrote:
>
> Hmmm I forgot to CC George. Sorry for that.
>
> On 27/07/2020 17:04, Julien Grall wrote:
>> From: Julien Grall <jgrall@amazon.com>
>> The operator + will just concatenate two strings. As the result, the
>> configure cmdline for "xentools" will look like:
>> ./configure --disable-stubdom --disable-qemu-traditional--with-system-qemu=/bin/false --with-system-seabios=/bin/false--disable-ovmf
>> This can be avoided by explicitely adding the spaces.
>> Signed-off-by: Julien Grall <jgrall@amazon.com>
Oops — thanks.
Reviewed-by: George Dunlap <george.dunlap@citrix.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-07-28 10:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-27 16:04 [[XSATOOL]] repo: Add missing spaces in the configure cmdline for "xentools" Julien Grall
2020-07-27 16:04 ` Julien Grall
2020-07-28 10:12 ` George Dunlap
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.