All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/1] cmd: CMD_USB depends on USB
@ 2021-04-04 13:35 Heinrich Schuchardt
  2021-04-04 13:41 ` Marek Vasut
  2021-04-04 23:16 ` Tom Rini
  0 siblings, 2 replies; 3+ messages in thread
From: Heinrich Schuchardt @ 2021-04-04 13:35 UTC (permalink / raw)
  To: u-boot

The usb command cannot be compiled with CONFIG_USB=n:

ld.bfd: cmd/usb.c:660: undefined reference to `usb_stop'
ld.bfd: cmd/usb.c:663: undefined reference to `usb_started'

Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
---
 cmd/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/cmd/Kconfig b/cmd/Kconfig
index eff238cb38..863b7f9fda 100644
--- a/cmd/Kconfig
+++ b/cmd/Kconfig
@@ -1309,6 +1309,7 @@ config CMD_UNIVERSE

 config CMD_USB
 	bool "usb"
+	depends on USB
 	select HAVE_BLOCK_DEVICE
 	help
 	  USB support.
--
2.31.0

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH 1/1] cmd: CMD_USB depends on USB
  2021-04-04 13:35 [PATCH 1/1] cmd: CMD_USB depends on USB Heinrich Schuchardt
@ 2021-04-04 13:41 ` Marek Vasut
  2021-04-04 23:16 ` Tom Rini
  1 sibling, 0 replies; 3+ messages in thread
From: Marek Vasut @ 2021-04-04 13:41 UTC (permalink / raw)
  To: u-boot

On 4/4/21 3:35 PM, Heinrich Schuchardt wrote:
> The usb command cannot be compiled with CONFIG_USB=n:
> 
> ld.bfd: cmd/usb.c:660: undefined reference to `usb_stop'
> ld.bfd: cmd/usb.c:663: undefined reference to `usb_started'
> 
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>

Reviewed-by: Marek Vasut <marex@denx.de>

It would be nice to include this in current release, since it's 
obviously a bugfix.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH 1/1] cmd: CMD_USB depends on USB
  2021-04-04 13:35 [PATCH 1/1] cmd: CMD_USB depends on USB Heinrich Schuchardt
  2021-04-04 13:41 ` Marek Vasut
@ 2021-04-04 23:16 ` Tom Rini
  1 sibling, 0 replies; 3+ messages in thread
From: Tom Rini @ 2021-04-04 23:16 UTC (permalink / raw)
  To: u-boot

On Sun, Apr 04, 2021 at 01:35:07PM +0000, Heinrich Schuchardt wrote:

> The usb command cannot be compiled with CONFIG_USB=n:
> 
> ld.bfd: cmd/usb.c:660: undefined reference to `usb_stop'
> ld.bfd: cmd/usb.c:663: undefined reference to `usb_started'
> 
> Reviewed-by: Marek Vasut <marex@denx.de>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20210404/395f1e3d/attachment.sig>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-04-04 23:16 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-04 13:35 [PATCH 1/1] cmd: CMD_USB depends on USB Heinrich Schuchardt
2021-04-04 13:41 ` Marek Vasut
2021-04-04 23:16 ` Tom Rini

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.