Issues running nvme-tcp/rdma passthru blktests

Issues running nvme-tcp/rdma passthru blktests

[Alan Adamson]

When executing blktest nvme tests with tcp and rdma, and with 
CONFIG_NVME_TARGET_PASSTHRU enabled, tests nvme/034-037 did not
complete.

This was because the nvme/rc helper for setting up passthru targets
hardcoded trtype to "loop" which resulted in the nvme connect to
fail.

The following patch resolves this.

Alan

[PATCH blktests] nvme tests should use nvme_trtype when setting up passthru target

[Alan Adamson]

No matter what was passed in with nvme_trtype, the target was being
set up with trtype as "loop".  This caused several passthru tests
to fail when testing tcp or rdma.

Signed-off-by: Alan Adamson <alan.adamson@oracle.com>
---
 tests/nvme/rc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/nvme/rc b/tests/nvme/rc
index 1c27cdee1b5f..3c38408a0bfe 100644
--- a/tests/nvme/rc
+++ b/tests/nvme/rc
@@ -335,7 +335,7 @@ _nvmet_passthru_target_setup() {
 	local subsys_name=$1
 
 	_create_nvmet_passthru "${subsys_name}"
-	port="$(_create_nvmet_port "loop")"
+	port="$(_create_nvmet_port "${nvme_trtype}")"
 	_add_nvmet_subsys_to_port "${port}" "${subsys_name}"
 
 	echo "$port"
-- 
2.27.0

Re: [PATCH blktests] nvme tests should use nvme_trtype when setting up passthru target

[Sagi Grimberg]

Reviewed-by: Sagi Grimberg <sagi@grimberg.me>

Re: [PATCH blktests] nvme tests should use nvme_trtype when setting up passthru target

[Chaitanya Kulkarni]

(+Logan)
On 3/31/22 14:45, Alan Adamson wrote:
> No matter what was passed in with nvme_trtype, the target was being
> set up with trtype as "loop".  This caused several passthru tests
> to fail when testing tcp or rdma.
> 
> Signed-off-by: Alan Adamson <alan.adamson@oracle.com>
> ---


Thanks for your fix, looks good.

Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>

-ck

Re: Issues running nvme-tcp/rdma passthru blktests

[Himanshu Madhani]

> On Mar 31, 2022, at 2:45 PM, Alan Adamson <ALAN.ADAMSON@ORACLE.COM> wrote:
> 
> When executing blktest nvme tests with tcp and rdma, and with 
> CONFIG_NVME_TARGET_PASSTHRU enabled, tests nvme/034-037 did not
> complete.
> 
> This was because the nvme/rc helper for setting up passthru targets
> hardcoded trtype to "loop" which resulted in the nvme connect to
> fail.
> 
> The following patch resolves this.
> 
> Alan
> 

Can you resend with the patch included? 

--
Himanshu Madhani	 Oracle Linux Engineering

Re: [PATCH blktests] nvme tests should use nvme_trtype when setting up passthru target

[Himanshu Madhani]

> On Mar 31, 2022, at 2:45 PM, Alan Adamson <ALAN.ADAMSON@ORACLE.COM> wrote:
> 
> No matter what was passed in with nvme_trtype, the target was being
> set up with trtype as "loop".  This caused several passthru tests
> to fail when testing tcp or rdma.
> 
> Signed-off-by: Alan Adamson <alan.adamson@oracle.com>
> ---
> tests/nvme/rc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/nvme/rc b/tests/nvme/rc
> index 1c27cdee1b5f..3c38408a0bfe 100644
> --- a/tests/nvme/rc
> +++ b/tests/nvme/rc
> @@ -335,7 +335,7 @@ _nvmet_passthru_target_setup() {
> 	local subsys_name=$1
> 
> 	_create_nvmet_passthru "${subsys_name}"
> -	port="$(_create_nvmet_port "loop")"
> +	port="$(_create_nvmet_port "${nvme_trtype}")"
> 	_add_nvmet_subsys_to_port "${port}" "${subsys_name}"
> 
> 	echo "$port"
> -- 
> 2.27.0
> 

Looks Good

Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>

--
Himanshu Madhani	 Oracle Linux Engineering

Re: Issues running nvme-tcp/rdma passthru blktests

[Himanshu Madhani]

> On Apr 4, 2022, at 9:11 AM, Himanshu Madhani <himanshu.madhani@oracle.com> wrote:
> 
> 
> 
>> On Mar 31, 2022, at 2:45 PM, Alan Adamson <ALAN.ADAMSON@ORACLE.COM> wrote:
>> 
>> When executing blktest nvme tests with tcp and rdma, and with 
>> CONFIG_NVME_TARGET_PASSTHRU enabled, tests nvme/034-037 did not
>> complete.
>> 
>> This was because the nvme/rc helper for setting up passthru targets
>> hardcoded trtype to "loop" which resulted in the nvme connect to
>> fail.
>> 
>> The following patch resolves this.
>> 
>> Alan
>> 
> 
> Can you resend with the patch included? 
> 

Ignore this.. patch showed up in my inbox. ..

> --
> Himanshu Madhani	 Oracle Linux Engineering
> 

--
Himanshu Madhani	 Oracle Linux Engineering

Re: [PATCH blktests] nvme tests should use nvme_trtype when setting up passthru target

[Omar Sandoval]

On Thu, Mar 31, 2022 at 02:45:26PM -0700, Alan Adamson wrote:
> No matter what was passed in with nvme_trtype, the target was being
> set up with trtype as "loop".  This caused several passthru tests
> to fail when testing tcp or rdma.
> 
> Signed-off-by: Alan Adamson <alan.adamson@oracle.com>
> ---
>  tests/nvme/rc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks.