From: Stefan Roese <sr@denx.de>
To: "Pali Rohár" <pali@kernel.org>, "Marek Behún" <marek.behun@nic.cz>
Cc: u-boot@lists.denx.de
Subject: Re: [PATCH u-boot-marvell 3/4] arm: a37xx: pci: Use dev_read_addr()
Date: Tue, 15 Feb 2022 10:21:33 +0100 [thread overview]
Message-ID: <02a54ace-b50a-f9a6-7ad0-b413daa7bbb2@denx.de> (raw)
In-Reply-To: <20220210135345.28452-3-pali@kernel.org>
On 2/10/22 14:53, Pali Rohár wrote:
> There is only one base address, so use dev_read_addr() instead of dev_read_addr_index().
>
> Signed-off-by: Pali Rohár <pali@kernel.org>
Reviewed-by: Stefan Roese <sr@denx.de>
Thanks,
Stefan
> ---
> drivers/pci/pci-aardvark.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/pci-aardvark.c b/drivers/pci/pci-aardvark.c
> index 8e3b13b49ea0..6e65c0e1558c 100644
> --- a/drivers/pci/pci-aardvark.c
> +++ b/drivers/pci/pci-aardvark.c
> @@ -991,7 +991,7 @@ static int pcie_advk_of_to_plat(struct udevice *dev)
> struct pcie_advk *pcie = dev_get_priv(dev);
>
> /* Get the register base address */
> - pcie->base = (void *)dev_read_addr_index(dev, 0);
> + pcie->base = (void *)dev_read_addr(dev);
> if ((fdt_addr_t)pcie->base == FDT_ADDR_T_NONE)
> return -EINVAL;
>
Viele Grüße,
Stefan Roese
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de
next prev parent reply other threads:[~2022-02-15 9:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-10 13:53 [PATCH u-boot-marvell 1/4] arm: a37xx: pci: Use standard register macros from pci.h Pali Rohár
2022-02-10 13:53 ` [PATCH u-boot-marvell 2/4] arm: a37xx: pci: Cleanup macro names Pali Rohár
2022-02-15 9:21 ` Stefan Roese
2022-02-17 15:35 ` Stefan Roese
2022-02-10 13:53 ` [PATCH u-boot-marvell 3/4] arm: a37xx: pci: Use dev_read_addr() Pali Rohár
2022-02-15 9:21 ` Stefan Roese [this message]
2022-02-17 15:36 ` Stefan Roese
2022-02-10 13:53 ` [PATCH u-boot-marvell 4/4] arm: a37xx: pci: Ensure that root port is always on root zero bus Pali Rohár
2022-02-15 9:21 ` Stefan Roese
2022-02-17 15:36 ` Stefan Roese
2022-02-15 9:20 ` [PATCH u-boot-marvell 1/4] arm: a37xx: pci: Use standard register macros from pci.h Stefan Roese
2022-02-17 15:35 ` Stefan Roese
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=02a54ace-b50a-f9a6-7ad0-b413daa7bbb2@denx.de \
--to=sr@denx.de \
--cc=marek.behun@nic.cz \
--cc=pali@kernel.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.