* [Buildroot] [PATCH 1/1] package/ibm-sw-tpm2: fix patch to address musl builds
@ 2020-04-30 19:44 Vincent Fazio
2020-05-01 17:18 ` Vincent Fazio
2020-08-15 21:30 ` Thomas Petazzoni
0 siblings, 2 replies; 4+ messages in thread
From: Vincent Fazio @ 2020-04-30 19:44 UTC (permalink / raw)
To: buildroot
From: Vincent Fazio <vfazio@gmail.com>
Previously, __WORDSIZE was being used to define RADIX_BITS.
__WORDSIZE is not defined consistently via limits.h across all libc
variants, so use LONG_BIT instead.
Fixes:
http://autobuild.buildroot.net/results/b5cb347a98dc64f77982633c0fc48d14030aa5b6/
Signed-off-by: Vincent Fazio <vfazio@gmail.com>
Signed-off-by: Vincent Fazio <vfazio@xes-inc.com>
---
...TS.patch => 0001-Use-LONG_BIT-to-define-RADIX_BITS.patch} | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
rename package/ibm-sw-tpm2/{0001-Use-__WORDSIZE-to-define-RADIX_BITS.patch => 0001-Use-LONG_BIT-to-define-RADIX_BITS.patch} (91%)
diff --git a/package/ibm-sw-tpm2/0001-Use-__WORDSIZE-to-define-RADIX_BITS.patch b/package/ibm-sw-tpm2/0001-Use-LONG_BIT-to-define-RADIX_BITS.patch
similarity index 91%
rename from package/ibm-sw-tpm2/0001-Use-__WORDSIZE-to-define-RADIX_BITS.patch
rename to package/ibm-sw-tpm2/0001-Use-LONG_BIT-to-define-RADIX_BITS.patch
index a19160f68c..3a7e02ba7a 100644
--- a/package/ibm-sw-tpm2/0001-Use-__WORDSIZE-to-define-RADIX_BITS.patch
+++ b/package/ibm-sw-tpm2/0001-Use-LONG_BIT-to-define-RADIX_BITS.patch
@@ -1,12 +1,13 @@
From 24a352fc99ebde22235b05b18615817ef7f4263c Mon Sep 17 00:00:00 2001
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Date: Sun, 26 Apr 2020 15:33:39 +0200
-Subject: [PATCH] Use __WORDSIZE to define RADIX_BITS
+Subject: [PATCH] Use LONG_BIT to define RADIX_BITS
This allows to avoid having to support each CPU architecture
individually.
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
+Signed-off-by: Vincent Fazio <vfazio@gmail.com>
---
src/LibSupport.h | 17 +++--------------
1 file changed, 3 insertions(+), 14 deletions(-)
@@ -35,7 +36,7 @@ index b2e6a51..f064d20 100644
-#endif // RADIX_BITS
+#include <limits.h>
+
-+#define RADIX_BITS __WORDSIZE
++#define RADIX_BITS LONG_BIT
// These macros use the selected libraries to the proper include files.
#define LIB_QUOTE(_STRING_) #_STRING_
--
2.26.2
^ permalink raw reply related [flat|nested] 4+ messages in thread* [Buildroot] [PATCH 1/1] package/ibm-sw-tpm2: fix patch to address musl builds
2020-04-30 19:44 [Buildroot] [PATCH 1/1] package/ibm-sw-tpm2: fix patch to address musl builds Vincent Fazio
@ 2020-05-01 17:18 ` Vincent Fazio
2020-08-15 21:30 ` Thomas Petazzoni
1 sibling, 0 replies; 4+ messages in thread
From: Vincent Fazio @ 2020-05-01 17:18 UTC (permalink / raw)
To: buildroot
Note, if we don't like this option i've also seen other packages do
something akin to:
#if ULONG_MAX == 0xffffffff
#define RADIX_BITS 32
#elif ULONG_MAX == 0xffffffffffffffff
#define RADIX_BITS 64
#else
#error "Unsupported radix size"
#endif
Vincent Fazio
Embedded Software Engineer - Linux
Extreme Engineering Solutions, Inc
http://www.xes-inc.com
On 4/30/20 2:44 PM, Vincent Fazio wrote:
> From: Vincent Fazio <vfazio@gmail.com>
>
> Previously, __WORDSIZE was being used to define RADIX_BITS.
>
> __WORDSIZE is not defined consistently via limits.h across all libc
> variants, so use LONG_BIT instead.
>
> Fixes:
>
> http://autobuild.buildroot.net/results/b5cb347a98dc64f77982633c0fc48d14030aa5b6/
>
> Signed-off-by: Vincent Fazio <vfazio@gmail.com>
> Signed-off-by: Vincent Fazio <vfazio@xes-inc.com>
> ---
> ...TS.patch => 0001-Use-LONG_BIT-to-define-RADIX_BITS.patch} | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
> rename package/ibm-sw-tpm2/{0001-Use-__WORDSIZE-to-define-RADIX_BITS.patch => 0001-Use-LONG_BIT-to-define-RADIX_BITS.patch} (91%)
>
> diff --git a/package/ibm-sw-tpm2/0001-Use-__WORDSIZE-to-define-RADIX_BITS.patch b/package/ibm-sw-tpm2/0001-Use-LONG_BIT-to-define-RADIX_BITS.patch
> similarity index 91%
> rename from package/ibm-sw-tpm2/0001-Use-__WORDSIZE-to-define-RADIX_BITS.patch
> rename to package/ibm-sw-tpm2/0001-Use-LONG_BIT-to-define-RADIX_BITS.patch
> index a19160f68c..3a7e02ba7a 100644
> --- a/package/ibm-sw-tpm2/0001-Use-__WORDSIZE-to-define-RADIX_BITS.patch
> +++ b/package/ibm-sw-tpm2/0001-Use-LONG_BIT-to-define-RADIX_BITS.patch
> @@ -1,12 +1,13 @@
> From 24a352fc99ebde22235b05b18615817ef7f4263c Mon Sep 17 00:00:00 2001
> From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
> Date: Sun, 26 Apr 2020 15:33:39 +0200
> -Subject: [PATCH] Use __WORDSIZE to define RADIX_BITS
> +Subject: [PATCH] Use LONG_BIT to define RADIX_BITS
>
> This allows to avoid having to support each CPU architecture
> individually.
>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
> +Signed-off-by: Vincent Fazio <vfazio@gmail.com>
> ---
> src/LibSupport.h | 17 +++--------------
> 1 file changed, 3 insertions(+), 14 deletions(-)
> @@ -35,7 +36,7 @@ index b2e6a51..f064d20 100644
> -#endif // RADIX_BITS
> +#include <limits.h>
> +
> -+#define RADIX_BITS __WORDSIZE
> ++#define RADIX_BITS LONG_BIT
>
> // These macros use the selected libraries to the proper include files.
> #define LIB_QUOTE(_STRING_) #_STRING_
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20200501/df20f264/attachment.html>
^ permalink raw reply [flat|nested] 4+ messages in thread* [Buildroot] [PATCH 1/1] package/ibm-sw-tpm2: fix patch to address musl builds
2020-04-30 19:44 [Buildroot] [PATCH 1/1] package/ibm-sw-tpm2: fix patch to address musl builds Vincent Fazio
2020-05-01 17:18 ` Vincent Fazio
@ 2020-08-15 21:30 ` Thomas Petazzoni
2020-08-28 21:26 ` Peter Korsgaard
1 sibling, 1 reply; 4+ messages in thread
From: Thomas Petazzoni @ 2020-08-15 21:30 UTC (permalink / raw)
To: buildroot
On Thu, 30 Apr 2020 14:44:21 -0500
Vincent Fazio <vfazio@xes-inc.com> wrote:
> From: Vincent Fazio <vfazio@gmail.com>
>
> Previously, __WORDSIZE was being used to define RADIX_BITS.
>
> __WORDSIZE is not defined consistently via limits.h across all libc
> variants, so use LONG_BIT instead.
>
> Fixes:
>
> http://autobuild.buildroot.net/results/b5cb347a98dc64f77982633c0fc48d14030aa5b6/
>
> Signed-off-by: Vincent Fazio <vfazio@gmail.com>
> Signed-off-by: Vincent Fazio <vfazio@xes-inc.com>
> ---
> ...TS.patch => 0001-Use-LONG_BIT-to-define-RADIX_BITS.patch} | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
> rename package/ibm-sw-tpm2/{0001-Use-__WORDSIZE-to-define-RADIX_BITS.patch => 0001-Use-LONG_BIT-to-define-RADIX_BITS.patch} (91%)
Applied to master, thanks.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 4+ messages in thread* [Buildroot] [PATCH 1/1] package/ibm-sw-tpm2: fix patch to address musl builds
2020-08-15 21:30 ` Thomas Petazzoni
@ 2020-08-28 21:26 ` Peter Korsgaard
0 siblings, 0 replies; 4+ messages in thread
From: Peter Korsgaard @ 2020-08-28 21:26 UTC (permalink / raw)
To: buildroot
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@bootlin.com> writes:
> On Thu, 30 Apr 2020 14:44:21 -0500
> Vincent Fazio <vfazio@xes-inc.com> wrote:
>> From: Vincent Fazio <vfazio@gmail.com>
>>
>> Previously, __WORDSIZE was being used to define RADIX_BITS.
>>
>> __WORDSIZE is not defined consistently via limits.h across all libc
>> variants, so use LONG_BIT instead.
>>
>> Fixes:
>>
>> http://autobuild.buildroot.net/results/b5cb347a98dc64f77982633c0fc48d14030aa5b6/
>>
>> Signed-off-by: Vincent Fazio <vfazio@gmail.com>
>> Signed-off-by: Vincent Fazio <vfazio@xes-inc.com>
>> ---
>> ...TS.patch => 0001-Use-LONG_BIT-to-define-RADIX_BITS.patch} | 5 +++--
>> 1 file changed, 3 insertions(+), 2 deletions(-)
>> rename package/ibm-sw-tpm2/{0001-Use-__WORDSIZE-to-define-RADIX_BITS.patch => 0001-Use-LONG_BIT-to-define-RADIX_BITS.patch} (91%)
Committed to 2020.05.x, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-08-28 21:26 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-30 19:44 [Buildroot] [PATCH 1/1] package/ibm-sw-tpm2: fix patch to address musl builds Vincent Fazio
2020-05-01 17:18 ` Vincent Fazio
2020-08-15 21:30 ` Thomas Petazzoni
2020-08-28 21:26 ` Peter Korsgaard
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.