All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/tilcdc: include linux/pinctrl/consumer.h again
@ 2019-09-30 14:15 Jyri Sarha
  2019-09-30 15:25 ` Sam Ravnborg
  0 siblings, 1 reply; 5+ messages in thread
From: Jyri Sarha @ 2019-09-30 14:15 UTC (permalink / raw)
  To: dri-devel; +Cc: sam, arnd, laurent.pinchart, jsarha

From: Arnd Bergmann <arnd@arndb.de>

This was apparently dropped by accident in a recent
cleanup, causing a build failure in some configurations now:

drivers/gpu/drm/tilcdc/tilcdc_tfp410.c:296:12: error: implicit declaration of function 'devm_pinctrl_get_select_default' [-Werror,-Wimplicit-function-declaration]

Fixes: fcb57664172e ("drm/tilcdc: drop use of drmP.h")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Jyri Sarha <jsarha@ti.com>
---
Just reordered the includes in aplhapetical order and applied
Laurent's Reviewed-by. I'll apply this to drm-misc-next.

 drivers/gpu/drm/tilcdc/tilcdc_tfp410.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/tilcdc/tilcdc_tfp410.c b/drivers/gpu/drm/tilcdc/tilcdc_tfp410.c
index 525dc1c0f1c1..530edb3b51cc 100644
--- a/drivers/gpu/drm/tilcdc/tilcdc_tfp410.c
+++ b/drivers/gpu/drm/tilcdc/tilcdc_tfp410.c
@@ -7,6 +7,7 @@
 #include <linux/gpio.h>
 #include <linux/mod_devicetable.h>
 #include <linux/of_gpio.h>
+#include <linux/pinctrl/consumer.h>
 #include <linux/platform_device.h>
 
 #include <drm/drm_atomic_helper.h>
-- 
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply related	[flat|nested] 5+ messages in thread
* Re: [PATCH] drm/tilcdc: include linux/pinctrl/consumer.h again
  2019-09-30 14:15 [PATCH] drm/tilcdc: include linux/pinctrl/consumer.h again Jyri Sarha
@ 2019-09-30 15:25 ` Sam Ravnborg
  0 siblings, 0 replies; 5+ messages in thread
From: Sam Ravnborg @ 2019-09-30 15:25 UTC (permalink / raw)
  To: Jyri Sarha; +Cc: arnd, laurent.pinchart, dri-devel

On Mon, Sep 30, 2019 at 05:15:53PM +0300, Jyri Sarha wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> This was apparently dropped by accident in a recent
> cleanup, causing a build failure in some configurations now:
> 
> drivers/gpu/drm/tilcdc/tilcdc_tfp410.c:296:12: error: implicit declaration of function 'devm_pinctrl_get_select_default' [-Werror,-Wimplicit-function-declaration]
> 
> Fixes: fcb57664172e ("drm/tilcdc: drop use of drmP.h")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Signed-off-by: Jyri Sarha <jsarha@ti.com>

Thanks
Acked-by: Sam Ravnborg <sam@ravnborg.org>

> ---
> Just reordered the includes in aplhapetical order and applied
> Laurent's Reviewed-by. I'll apply this to drm-misc-next.
> 
>  drivers/gpu/drm/tilcdc/tilcdc_tfp410.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/tilcdc/tilcdc_tfp410.c b/drivers/gpu/drm/tilcdc/tilcdc_tfp410.c
> index 525dc1c0f1c1..530edb3b51cc 100644
> --- a/drivers/gpu/drm/tilcdc/tilcdc_tfp410.c
> +++ b/drivers/gpu/drm/tilcdc/tilcdc_tfp410.c
> @@ -7,6 +7,7 @@
>  #include <linux/gpio.h>
>  #include <linux/mod_devicetable.h>
>  #include <linux/of_gpio.h>
> +#include <linux/pinctrl/consumer.h>
>  #include <linux/platform_device.h>
>  
>  #include <drm/drm_atomic_helper.h>
> -- 
> Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH] drm/tilcdc: include linux/pinctrl/consumer.h again
  2019-09-09 20:33 ` Arnd Bergmann
  (?)
@ 2019-09-09 22:35 ` Laurent Pinchart
  -1 siblings, 0 replies; 5+ messages in thread
From: Laurent Pinchart @ 2019-09-09 22:35 UTC (permalink / raw)
  To: Arnd Bergmann
  Cc: Jyri Sarha, David Airlie, Daniel Vetter, Sam Ravnborg,
	Emil Velikov, Tomi Valkeinen, Alexios Zavras, dri-devel,
	linux-kernel

Hi Arnd,

Thank you for the patch.

On Mon, Sep 09, 2019 at 10:33:57PM +0200, Arnd Bergmann wrote:
> This was apparently dropped by accident in a recent
> cleanup, causing a build failure in some configurations now:
> 
> drivers/gpu/drm/tilcdc/tilcdc_tfp410.c:296:12: error: implicit declaration of function 'devm_pinctrl_get_select_default' [-Werror,-Wimplicit-function-declaration]
> 
> Fixes: fcb57664172e ("drm/tilcdc: drop use of drmP.h")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  drivers/gpu/drm/tilcdc/tilcdc_tfp410.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/tilcdc/tilcdc_tfp410.c b/drivers/gpu/drm/tilcdc/tilcdc_tfp410.c
> index 525dc1c0f1c1..9edcdd7f2b96 100644
> --- a/drivers/gpu/drm/tilcdc/tilcdc_tfp410.c
> +++ b/drivers/gpu/drm/tilcdc/tilcdc_tfp410.c
> @@ -8,6 +8,7 @@
>  #include <linux/mod_devicetable.h>
>  #include <linux/of_gpio.h>
>  #include <linux/platform_device.h>
> +#include <linux/pinctrl/consumer.h>

I'd put this before platform_device.h to keep the headers alphabetically
ordered. Apart from that,

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

>  #include <drm/drm_atomic_helper.h>
>  #include <drm/drm_encoder.h>

-- 
Regards,

Laurent Pinchart

^ permalink raw reply	[flat|nested] 5+ messages in thread
* [PATCH] drm/tilcdc: include linux/pinctrl/consumer.h again
@ 2019-09-09 20:33 ` Arnd Bergmann
  0 siblings, 0 replies; 5+ messages in thread
From: Arnd Bergmann @ 2019-09-09 20:33 UTC (permalink / raw)
  To: Jyri Sarha, David Airlie, Daniel Vetter
  Cc: Arnd Bergmann, Sam Ravnborg, Emil Velikov, Tomi Valkeinen,
	Laurent Pinchart, Alexios Zavras, dri-devel, linux-kernel

This was apparently dropped by accident in a recent
cleanup, causing a build failure in some configurations now:

drivers/gpu/drm/tilcdc/tilcdc_tfp410.c:296:12: error: implicit declaration of function 'devm_pinctrl_get_select_default' [-Werror,-Wimplicit-function-declaration]

Fixes: fcb57664172e ("drm/tilcdc: drop use of drmP.h")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/gpu/drm/tilcdc/tilcdc_tfp410.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/tilcdc/tilcdc_tfp410.c b/drivers/gpu/drm/tilcdc/tilcdc_tfp410.c
index 525dc1c0f1c1..9edcdd7f2b96 100644
--- a/drivers/gpu/drm/tilcdc/tilcdc_tfp410.c
+++ b/drivers/gpu/drm/tilcdc/tilcdc_tfp410.c
@@ -8,6 +8,7 @@
 #include <linux/mod_devicetable.h>
 #include <linux/of_gpio.h>
 #include <linux/platform_device.h>
+#include <linux/pinctrl/consumer.h>
 
 #include <drm/drm_atomic_helper.h>
 #include <drm/drm_encoder.h>
-- 
2.20.0


^ permalink raw reply related	[flat|nested] 5+ messages in thread
* [PATCH] drm/tilcdc: include linux/pinctrl/consumer.h again
@ 2019-09-09 20:33 ` Arnd Bergmann
  0 siblings, 0 replies; 5+ messages in thread
From: Arnd Bergmann @ 2019-09-09 20:33 UTC (permalink / raw)
  To: Jyri Sarha, David Airlie, Daniel Vetter
  Cc: Arnd Bergmann, linux-kernel, dri-devel, Alexios Zavras,
	Tomi Valkeinen, Laurent Pinchart, Sam Ravnborg, Emil Velikov

This was apparently dropped by accident in a recent
cleanup, causing a build failure in some configurations now:

drivers/gpu/drm/tilcdc/tilcdc_tfp410.c:296:12: error: implicit declaration of function 'devm_pinctrl_get_select_default' [-Werror,-Wimplicit-function-declaration]

Fixes: fcb57664172e ("drm/tilcdc: drop use of drmP.h")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/gpu/drm/tilcdc/tilcdc_tfp410.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/tilcdc/tilcdc_tfp410.c b/drivers/gpu/drm/tilcdc/tilcdc_tfp410.c
index 525dc1c0f1c1..9edcdd7f2b96 100644
--- a/drivers/gpu/drm/tilcdc/tilcdc_tfp410.c
+++ b/drivers/gpu/drm/tilcdc/tilcdc_tfp410.c
@@ -8,6 +8,7 @@
 #include <linux/mod_devicetable.h>
 #include <linux/of_gpio.h>
 #include <linux/platform_device.h>
+#include <linux/pinctrl/consumer.h>
 
 #include <drm/drm_atomic_helper.h>
 #include <drm/drm_encoder.h>
-- 
2.20.0

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply related	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-09-30 15:26 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-30 14:15 [PATCH] drm/tilcdc: include linux/pinctrl/consumer.h again Jyri Sarha
2019-09-30 15:25 ` Sam Ravnborg
  -- strict thread matches above, loose matches on Subject: below --
2019-09-09 20:33 Arnd Bergmann
2019-09-09 20:33 ` Arnd Bergmann
2019-09-09 22:35 ` Laurent Pinchart

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.