All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Ardelean, Alexandru" <alexandru.Ardelean@analog.com>
To: "lars@engebretsen.ch" <lars@engebretsen.ch>,
	"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>
Subject: Re: Small error in iio/iio.h
Date: Mon, 13 Apr 2020 09:04:36 +0000	[thread overview]
Message-ID: <02c6aff918a4cda27f2f16d852a9e52a81fbce5d.camel@analog.com> (raw)
In-Reply-To: <CA+XPV5MX1aH3yMcRmukmOU4cPFL34dFfPoznwxGT6cTeqYSTvg@mail.gmail.com>

On Mon, 2020-04-13 at 10:38 +0200, Lars Engebretsen wrote:
> Hi all,
> 
> I just came across a small thing: I think that there is an erroneous
> semicolon at the end of line 603 in include/linux/iio/iio.h

yep;
good find :)

> 
> https://urldefense.com/v3/__https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/include/linux/iio/iio.h?h=v5.7-rc1*n602__;Iw!!A3Ni8CS0y2Y!rXR19w3XDkuxpdAY4teDN4bSsfqvea7Sz5ZW26L2TCEeYhwf1mgTjt63tIp3Xld9oFWgcg$ 
> 
> I'm completely new to kernel development, so I don't know the process for
> submitting patches. Moreover, the macro seems to be gone in git://
> git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git so maybe the issue
> has been fixed already? In any case, I'd be happy to submit a patch if that
> is the right thing to do. But then I'd need a bit of help to get started.
> 

You're probably looking at the wrong branch.
It's a good idea to look at the ones that have been updated more recently.
It's still there.

Check 'togreg' or 'testing'.

I suggest editing those.
Look for patterns in the commit title & descriptions, don't forget to add your
Signed-off-by tag with  'git commit -s'
If you want, an idea for a commit title would be:
'iio: core: remove extra semi-colon from devm_iio_device_register() macro'

Add a comment describing the change.

Generate the patch with:
git format-patch HEAD~1..

then run ./scripts/get_maintainers.pl <patch-file>

The output suggests which lists to target.
What I do, is put lists with --to=<list>, maintainers [other people] with --
cc=<maintainer> --cc=<driver-author> --cc=<other-potentially-interested-people>

You first need to configure git-email to send emails; there should be some docs
on the web about that.

Lastly:
git send-email --to=linux-iio@vger.kernel.org --to=linux-kernel@vger.kernel.org 
--cc=jic@kernel.org <patch-file>


That's roughly it.

We should see your patch on the list.
https://lore.kernel.org/linux-iio/
&
https://patchwork.kernel.org/project/linux-iio/list/


> Thanks,
> Lars

  reply	other threads:[~2020-04-13  9:04 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-13  8:38 Small error in iio/iio.h Lars Engebretsen
2020-04-13  9:04 ` Ardelean, Alexandru [this message]
2020-04-14 18:43   ` Lars Engebretsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=02c6aff918a4cda27f2f16d852a9e52a81fbce5d.camel@analog.com \
    --to=alexandru.ardelean@analog.com \
    --cc=lars@engebretsen.ch \
    --cc=linux-iio@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.