All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kukjin Kim <kgene.kim@samsung.com>
To: 'Sachin Kamat' <sachin.kamat@linaro.org>,
	linux-arm-kernel@lists.infradead.org
Cc: linux-samsung-soc@vger.kernel.org, mturquette@linaro.org,
	patches@linaro.org
Subject: RE: [PATCH 2/6] clk: exynos4: Remove unused function
Date: Tue, 16 Jul 2013 16:30:19 +0900	[thread overview]
Message-ID: <02d701ce81f6$532ab9d0$f9802d70$%kim@samsung.com> (raw)
In-Reply-To: <1373533334-5169-3-git-send-email-sachin.kamat@linaro.org>

Sachin Kamat wrote:
> 
> Subsequent to the cleanup in commit 3c70348c7c ("ARM: EXYNOS:
> Remove legacy timer initialization code"), this function has no more
> users. Hence remove it.
> 
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> ---
>  drivers/clk/samsung/clk-exynos4.c |   14 --------------
>  1 file changed, 14 deletions(-)
> 
> diff --git a/drivers/clk/samsung/clk-exynos4.c b/drivers/clk/samsung/clk-
> exynos4.c
> index 18eadc4..75635eb 100644
> --- a/drivers/clk/samsung/clk-exynos4.c
> +++ b/drivers/clk/samsung/clk-exynos4.c
> @@ -969,20 +969,6 @@ static void __init
> exynos4_clk_register_finpll(unsigned long xom)
> 
>  }
> 
> -/*
> - * This function allows non-dt platforms to specify the clock speed of
> the
> - * xxti and xusbxti clocks. These clocks are then registered with the
> specified
> - * clock speed.
> - */
> -void __init exynos4_clk_register_fixed_ext(unsigned long xxti_f,
> -						  unsigned long xusbxti_f)
> -{
> -	exynos4_fixed_rate_ext_clks[0].fixed_rate = xxti_f;
> -	exynos4_fixed_rate_ext_clks[1].fixed_rate = xusbxti_f;
> -	samsung_clk_register_fixed_rate(exynos4_fixed_rate_ext_clks,
> -			ARRAY_SIZE(exynos4_fixed_rate_ext_clks));
> -}
> -
>  static __initdata struct of_device_id ext_clk_match[] = {
>  	{ .compatible = "samsung,clock-xxti", .data = (void *)0, },
>  	{ .compatible = "samsung,clock-xusbxti", .data = (void *)1, },
> --
> 1.7.9.5

And need following?

diff --git a/arch/arm/mach-exynos/common.h b/arch/arm/mach-exynos/common.h
index 3e156bc..1037da0 100644
--- a/arch/arm/mach-exynos/common.h
+++ b/arch/arm/mach-exynos/common.h
@@ -27,7 +27,6 @@ void exynos_init_late(void);

 /* ToDo: remove these after migrating legacy exynos4 platforms to dt */
 void exynos4_clk_init(struct device_node *np, int is_exynos4210, void
__iomem *reg_base, unsigned long xom);
-void exynos4_clk_register_fixed_ext(unsigned long, unsigned long);

 void exynos_firmware_init(void);

- Kukjin

WARNING: multiple messages have this Message-ID (diff)
From: kgene.kim@samsung.com (Kukjin Kim)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/6] clk: exynos4: Remove unused function
Date: Tue, 16 Jul 2013 16:30:19 +0900	[thread overview]
Message-ID: <02d701ce81f6$532ab9d0$f9802d70$%kim@samsung.com> (raw)
In-Reply-To: <1373533334-5169-3-git-send-email-sachin.kamat@linaro.org>

Sachin Kamat wrote:
> 
> Subsequent to the cleanup in commit 3c70348c7c ("ARM: EXYNOS:
> Remove legacy timer initialization code"), this function has no more
> users. Hence remove it.
> 
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> ---
>  drivers/clk/samsung/clk-exynos4.c |   14 --------------
>  1 file changed, 14 deletions(-)
> 
> diff --git a/drivers/clk/samsung/clk-exynos4.c b/drivers/clk/samsung/clk-
> exynos4.c
> index 18eadc4..75635eb 100644
> --- a/drivers/clk/samsung/clk-exynos4.c
> +++ b/drivers/clk/samsung/clk-exynos4.c
> @@ -969,20 +969,6 @@ static void __init
> exynos4_clk_register_finpll(unsigned long xom)
> 
>  }
> 
> -/*
> - * This function allows non-dt platforms to specify the clock speed of
> the
> - * xxti and xusbxti clocks. These clocks are then registered with the
> specified
> - * clock speed.
> - */
> -void __init exynos4_clk_register_fixed_ext(unsigned long xxti_f,
> -						  unsigned long xusbxti_f)
> -{
> -	exynos4_fixed_rate_ext_clks[0].fixed_rate = xxti_f;
> -	exynos4_fixed_rate_ext_clks[1].fixed_rate = xusbxti_f;
> -	samsung_clk_register_fixed_rate(exynos4_fixed_rate_ext_clks,
> -			ARRAY_SIZE(exynos4_fixed_rate_ext_clks));
> -}
> -
>  static __initdata struct of_device_id ext_clk_match[] = {
>  	{ .compatible = "samsung,clock-xxti", .data = (void *)0, },
>  	{ .compatible = "samsung,clock-xusbxti", .data = (void *)1, },
> --
> 1.7.9.5

And need following?

diff --git a/arch/arm/mach-exynos/common.h b/arch/arm/mach-exynos/common.h
index 3e156bc..1037da0 100644
--- a/arch/arm/mach-exynos/common.h
+++ b/arch/arm/mach-exynos/common.h
@@ -27,7 +27,6 @@ void exynos_init_late(void);

 /* ToDo: remove these after migrating legacy exynos4 platforms to dt */
 void exynos4_clk_init(struct device_node *np, int is_exynos4210, void
__iomem *reg_base, unsigned long xom);
-void exynos4_clk_register_fixed_ext(unsigned long, unsigned long);

 void exynos_firmware_init(void);

- Kukjin

  reply	other threads:[~2013-07-16  7:30 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-11  9:02 [PATCH 0/6] clk: exynos: Some fixes and cleanup Sachin Kamat
2013-07-11  9:02 ` Sachin Kamat
2013-07-11  9:02 ` [PATCH 1/6] clk: exynos4: Staticize local symbols Sachin Kamat
2013-07-11  9:02   ` Sachin Kamat
2013-07-16  7:34   ` Kukjin Kim
2013-07-16  7:34     ` Kukjin Kim
2013-07-16  9:08     ` Sachin Kamat
2013-07-16  9:08       ` Sachin Kamat
2013-07-11  9:02 ` [PATCH 2/6] clk: exynos4: Remove unused function Sachin Kamat
2013-07-11  9:02   ` Sachin Kamat
2013-07-16  7:30   ` Kukjin Kim [this message]
2013-07-16  7:30     ` Kukjin Kim
2013-07-16  9:08     ` Sachin Kamat
2013-07-16  9:08       ` Sachin Kamat
2013-07-11  9:02 ` [PATCH 3/6] clk: exynos5250: Staticize local symbols Sachin Kamat
2013-07-11  9:02   ` Sachin Kamat
2013-07-11  9:02 ` [PATCH 4/6] clk: exynos5420: " Sachin Kamat
2013-07-11  9:02   ` Sachin Kamat
2013-07-11  9:02 ` [PATCH 5/6] clk: exynos5440: " Sachin Kamat
2013-07-11  9:02   ` Sachin Kamat
2013-07-11  9:02 ` [PATCH 6/6] clk: exynos-audss: Staticize exynos_audss_clk_init Sachin Kamat
2013-07-11  9:02   ` Sachin Kamat
2013-07-16  7:36 ` [PATCH 0/6] clk: exynos: Some fixes and cleanup Kukjin Kim
2013-07-16  7:36   ` Kukjin Kim
2013-07-18 10:01 [PATCH v2 " Sachin Kamat
2013-07-18 10:01 ` [PATCH 2/6] clk: exynos4: Remove unused function Sachin Kamat
2013-07-18 10:01   ` Sachin Kamat

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='02d701ce81f6$532ab9d0$f9802d70$%kim@samsung.com' \
    --to=kgene.kim@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=mturquette@linaro.org \
    --cc=patches@linaro.org \
    --cc=sachin.kamat@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.