From: "Michel Dänzer" <michel@daenzer.net>
To: Alex Deucher <alexdeucher@gmail.com>, helgaas@kernel.org
Cc: dri-devel@lists.freedesktop.org, linux-pci@vger.kernel.org,
Alex Deucher <alexander.deucher@amd.com>
Subject: Re: [PATCH] PCI: use dev_info rather than dev_err for rom validation
Date: Mon, 27 Nov 2017 19:00:43 +0100 [thread overview]
Message-ID: <02e87fb8-8b77-281b-eac7-d592802da054@daenzer.net> (raw)
In-Reply-To: <20171127172110.16699-1-alexander.deucher@amd.com>
On 2017-11-27 06:21 PM, Alex Deucher wrote:
> On AMD GPUs, we use several mechanisms to fetch the vbios
> rom depending on the platform. We try to read the rom
> back via the rom BAR and fall back to other methods in
> some cases. This leads to spurious error messages
> from the pci rom code which are harmless in our case.
> This leads to bugs being files, etc. Change these to
> dev_info rather than dev_err to avoid that.
Does dev_info still print the message by default though? If so, I wonder
if this will change anything in practice...
--
Earthling Michel Dänzer | http://www.amd.com
Libre software enthusiast | Mesa and X developer
WARNING: multiple messages have this Message-ID (diff)
From: "Michel Dänzer" <michel@daenzer.net>
To: Alex Deucher <alexdeucher@gmail.com>, helgaas@kernel.org
Cc: Alex Deucher <alexander.deucher@amd.com>,
linux-pci@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] PCI: use dev_info rather than dev_err for rom validation
Date: Mon, 27 Nov 2017 19:00:43 +0100 [thread overview]
Message-ID: <02e87fb8-8b77-281b-eac7-d592802da054@daenzer.net> (raw)
In-Reply-To: <20171127172110.16699-1-alexander.deucher@amd.com>
On 2017-11-27 06:21 PM, Alex Deucher wrote:
> On AMD GPUs, we use several mechanisms to fetch the vbios
> rom depending on the platform. We try to read the rom
> back via the rom BAR and fall back to other methods in
> some cases. This leads to spurious error messages
> from the pci rom code which are harmless in our case.
> This leads to bugs being files, etc. Change these to
> dev_info rather than dev_err to avoid that.
Does dev_info still print the message by default though? If so, I wonder
if this will change anything in practice...
--
Earthling Michel Dänzer | http://www.amd.com
Libre software enthusiast | Mesa and X developer
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2017-11-27 18:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-27 17:21 [PATCH] PCI: use dev_info rather than dev_err for rom validation Alex Deucher
2017-11-27 17:26 ` Christian König
2017-11-27 18:00 ` Michel Dänzer [this message]
2017-11-27 18:00 ` Michel Dänzer
2017-11-27 18:05 ` Alex Deucher
2017-11-27 18:05 ` Alex Deucher
2017-12-04 21:41 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=02e87fb8-8b77-281b-eac7-d592802da054@daenzer.net \
--to=michel@daenzer.net \
--cc=alexander.deucher@amd.com \
--cc=alexdeucher@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=helgaas@kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.