All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Livepatch: fix typos
@ 2022-03-11 19:11 Bjoern Doebel
  2022-03-17 16:39 ` Luca Fancellu
  2022-03-31  8:50 ` Jan Beulich
  0 siblings, 2 replies; 3+ messages in thread
From: Bjoern Doebel @ 2022-03-11 19:11 UTC (permalink / raw)
  To: xen-devel; +Cc: Bjoern Doebel, Konrad Rzeszutek Wilk, Ross Lagerwall

Fix a couple of typos in livepatch code.

Signed-off-by: Bjoern Doebel <doebel@amazon.de>
CC: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
CC: Ross Lagerwall <ross.lagerwall@citrix.com>
---
 xen/arch/x86/livepatch.c |  2 +-
 xen/common/livepatch.c   | 10 +++++-----
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/xen/arch/x86/livepatch.c b/xen/arch/x86/livepatch.c
index 81c48fda7f..c4a19f3169 100644
--- a/xen/arch/x86/livepatch.c
+++ b/xen/arch/x86/livepatch.c
@@ -28,7 +28,7 @@ static bool has_active_waitqueue(const struct vm_event_domain *ved)
 }
 
 /*
- * x86's implementation of waitqueue violates the livepatching safey principle
+ * x86's implementation of waitqueue violates the livepatching safety principle
  * of having unwound every CPUs stack before modifying live content.
  *
  * Search through every domain and check that no vCPUs have an active
diff --git a/xen/common/livepatch.c b/xen/common/livepatch.c
index be2cf75c2d..edf56a357f 100644
--- a/xen/common/livepatch.c
+++ b/xen/common/livepatch.c
@@ -40,7 +40,7 @@ static LIST_HEAD(payload_list);
 
 /*
  * Patches which have been applied. Need RCU in case we crash (and then
- * traps code would iterate via applied_list) when adding entries onthe list.
+ * traps code would iterate via applied_list) when adding entries on the list.
  */
 static DEFINE_RCU_READ_LOCK(rcu_applied_lock);
 static LIST_HEAD(applied_list);
@@ -326,8 +326,8 @@ static int move_payload(struct payload *payload, struct livepatch_elf *elf)
 
     /*
      * Total of all three regions - RX, RW, and RO. We have to have
-     * keep them in seperate pages so we PAGE_ALIGN the RX and RW to have
-     * them on seperate pages. The last one will by default fall on its
+     * keep them in separate pages so we PAGE_ALIGN the RX and RW to have
+     * them on separate pages. The last one will by default fall on its
      * own page.
      */
     size = PAGE_ALIGN(payload->text_size) + PAGE_ALIGN(payload->rw_size) +
@@ -882,7 +882,7 @@ static bool_t is_payload_symbol(const struct livepatch_elf *elf,
         return 0;
 
     /*
-     * The payload is not a final image as we dynmically link against it.
+     * The payload is not a final image as we dynamically link against it.
      * As such the linker has left symbols we don't care about and which
      * binutils would have removed had it be a final image. Hence we:
      * - For SHF_ALLOC - ignore symbols referring to sections that are not
@@ -1523,7 +1523,7 @@ static bool_t is_work_scheduled(const struct payload *data)
 
 /*
  * Check if payload has any of the vetoing, non-atomic hooks assigned.
- * A vetoing, non-atmic hook may perform an operation that changes the
+ * A vetoing, non-atomic hook may perform an operation that changes the
  * hypervisor state and may not be guaranteed to succeed. Result of
  * such operation may be returned and may change the livepatch workflow.
  * Such hooks may require additional cleanup actions performed by other
-- 
2.32.0




Amazon Development Center Germany GmbH
Krausenstr. 38
10117 Berlin
Geschaeftsfuehrung: Christian Schlaeger, Jonathan Weiss
Eingetragen am Amtsgericht Charlottenburg unter HRB 149173 B
Sitz: Berlin
Ust-ID: DE 289 237 879





^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] Livepatch: fix typos
  2022-03-11 19:11 [PATCH] Livepatch: fix typos Bjoern Doebel
@ 2022-03-17 16:39 ` Luca Fancellu
  2022-03-31  8:50 ` Jan Beulich
  1 sibling, 0 replies; 3+ messages in thread
From: Luca Fancellu @ 2022-03-17 16:39 UTC (permalink / raw)
  To: Bjoern Doebel; +Cc: xen-devel, Konrad Rzeszutek Wilk, Ross Lagerwall



> On 11 Mar 2022, at 19:11, Bjoern Doebel <doebel@amazon.de> wrote:
> 
> Fix a couple of typos in livepatch code.

NIT: I would say: [...] in livepatch code comments.

> 
> Signed-off-by: Bjoern Doebel <doebel@amazon.de>

With or without it:

Reviewed-by: Luca Fancellu <luca.fancellu@arm.com>

Cheers,
Luca

> CC: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> CC: Ross Lagerwall <ross.lagerwall@citrix.com>




^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] Livepatch: fix typos
  2022-03-11 19:11 [PATCH] Livepatch: fix typos Bjoern Doebel
  2022-03-17 16:39 ` Luca Fancellu
@ 2022-03-31  8:50 ` Jan Beulich
  1 sibling, 0 replies; 3+ messages in thread
From: Jan Beulich @ 2022-03-31  8:50 UTC (permalink / raw)
  To: Bjoern Doebel; +Cc: Konrad Rzeszutek Wilk, Ross Lagerwall, xen-devel

On 11.03.2022 20:11, Bjoern Doebel wrote:
> Fix a couple of typos in livepatch code.
> 
> Signed-off-by: Bjoern Doebel <doebel@amazon.de>
> CC: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> CC: Ross Lagerwall <ross.lagerwall@citrix.com>

Acked-by: Jan Beulich <jbeulich@suse.com>
and committed in spite of a lack of a maintainer ack.

Jan



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-03-31  8:50 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-11 19:11 [PATCH] Livepatch: fix typos Bjoern Doebel
2022-03-17 16:39 ` Luca Fancellu
2022-03-31  8:50 ` Jan Beulich

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.