From: "Steve Wise" <swise@opengridcomputing.com> To: 'Leon Romanovsky' <leon@kernel.org> Cc: 'Doug Ledford' <dledford@redhat.com>, linux-rdma@vger.kernel.org, 'Chien Tin Tung' <chien.tin.tung@intel.com>, 'Stephen Hemminger' <stephen@networkplumber.org>, 'Jiri Pirko' <jiri@mellanox.com>, 'Ariel Almog' <ariela@mellanox.com>, 'Linux Netdev' <netdev@vger.kernel.org> Subject: RE: [PATCH rdma-next 11/19] RDMA/netlink: Convert LS to doit callback Date: Wed, 21 Jun 2017 10:25:18 -0500 [thread overview] Message-ID: <033201d2eaa2$96e55860$c4b00920$@opengridcomputing.com> (raw) In-Reply-To: <20170621145354.GF1248@mtr-leonro.local> > > > - /* > > > - * For response or local service set_timeout request, > > > - * there is no need to use netlink_dump_start. > > > - */ > > > - if (!(nlh->nlmsg_flags & NLM_F_REQUEST) || > > > - (index == RDMA_NL_LS && op == RDMA_NL_LS_OP_SET_TIMEOUT)) { > > > - cb.skb = skb; > > > - cb.nlh = nlh; > > > - cb.dump = cb_table[op].dump; > > > - return cb.dump(skb, &cb); > > > - } else { > > > - c.dump = cb_table[op].dump; > > > + /* TODO: Convert IWCM to properly handle doit callbacks */ > > > + if ((nlh->nlmsg_flags & NLM_F_DUMP) || index == RDMA_NL_RDMA_CM > > > || > > > + index == RDMA_NL_IWCM) { > > > + struct netlink_dump_control c = { > > > + .dump = cb_table[op].dump, > > > + }; > > > > Any reason you didn't fix IWCM as part of this series? Or will you fix it in an > > upcoming series? Also, isn't FIXME: the norm for these sorts of "I don't want > > to fix this now" comments? > > I wanted to stop before it is growing into enormous series. There are > number of things which I wanted to discuss and fix before moving forward. > > 1. What should we do with exported RDMA-CM statistics and structures? I > have a very strong feeling that it is broken and anyway, I'm not going to > use it, because it doesn't follow netlink's TLV style. > > 2. How to handle IWCM code which sets manually MSG_DONE and isn't using > MULTI flag? It has very similar pattern to my "workarounds", when I didn't > handle properly end of message. > > 3. Need to remove nl_client from IWCM code. > Chien, can you please comment on this? Thanks! Steve.
WARNING: multiple messages have this Message-ID (diff)
From: "Steve Wise" <swise@opengridcomputing.com> To: "'Leon Romanovsky'" <leon@kernel.org> Cc: "'Doug Ledford'" <dledford@redhat.com>, <linux-rdma@vger.kernel.org>, "'Chien Tin Tung'" <chien.tin.tung@intel.com>, "'Stephen Hemminger'" <stephen@networkplumber.org>, "'Jiri Pirko'" <jiri@mellanox.com>, "'Ariel Almog'" <ariela@mellanox.com>, "'Linux Netdev'" <netdev@vger.kernel.org> Subject: RE: [PATCH rdma-next 11/19] RDMA/netlink: Convert LS to doit callback Date: Wed, 21 Jun 2017 10:25:18 -0500 [thread overview] Message-ID: <033201d2eaa2$96e55860$c4b00920$@opengridcomputing.com> (raw) In-Reply-To: <20170621145354.GF1248@mtr-leonro.local> > > > - /* > > > - * For response or local service set_timeout request, > > > - * there is no need to use netlink_dump_start. > > > - */ > > > - if (!(nlh->nlmsg_flags & NLM_F_REQUEST) || > > > - (index == RDMA_NL_LS && op == RDMA_NL_LS_OP_SET_TIMEOUT)) { > > > - cb.skb = skb; > > > - cb.nlh = nlh; > > > - cb.dump = cb_table[op].dump; > > > - return cb.dump(skb, &cb); > > > - } else { > > > - c.dump = cb_table[op].dump; > > > + /* TODO: Convert IWCM to properly handle doit callbacks */ > > > + if ((nlh->nlmsg_flags & NLM_F_DUMP) || index == RDMA_NL_RDMA_CM > > > || > > > + index == RDMA_NL_IWCM) { > > > + struct netlink_dump_control c = { > > > + .dump = cb_table[op].dump, > > > + }; > > > > Any reason you didn't fix IWCM as part of this series? Or will you fix it in an > > upcoming series? Also, isn't FIXME: the norm for these sorts of "I don't want > > to fix this now" comments? > > I wanted to stop before it is growing into enormous series. There are > number of things which I wanted to discuss and fix before moving forward. > > 1. What should we do with exported RDMA-CM statistics and structures? I > have a very strong feeling that it is broken and anyway, I'm not going to > use it, because it doesn't follow netlink's TLV style. > > 2. How to handle IWCM code which sets manually MSG_DONE and isn't using > MULTI flag? It has very similar pattern to my "workarounds", when I didn't > handle properly end of message. > > 3. Need to remove nl_client from IWCM code. > Chien, can you please comment on this? Thanks! Steve.
next prev parent reply other threads:[~2017-06-21 15:25 UTC|newest] Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-06-21 6:05 [PATCH rdma-next 00/19] RDMA Netlink Device Client Leon Romanovsky 2017-06-21 6:05 ` [PATCH rdma-next 02/19] RDMA/netlink: Simplify the put_msg and put_attr Leon Romanovsky 2017-06-21 14:01 ` Steve Wise 2017-06-21 14:01 ` Steve Wise 2017-06-21 6:05 ` [PATCH rdma-next 03/19] RDMA/netlink: Rename and remove redundant parameter from ibnl_unicast Leon Romanovsky 2017-06-21 14:01 ` Steve Wise 2017-06-21 14:01 ` Steve Wise 2017-06-21 6:05 ` [PATCH rdma-next 05/19] RDMA/netlink: Simplify and rename ibnl_chk_listeners Leon Romanovsky [not found] ` <20170621060528.3752-6-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> 2017-06-21 14:04 ` Steve Wise 2017-06-21 14:04 ` Steve Wise 2017-06-21 6:05 ` [PATCH rdma-next 07/19] RDMA/core: Add iterator over ib_devices Leon Romanovsky [not found] ` <20170621060528.3752-8-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> 2017-06-21 14:07 ` Steve Wise 2017-06-21 14:07 ` Steve Wise 2017-06-21 6:05 ` [PATCH rdma-next 08/19] RDMA/core: Expose translation from device name to ib_device Leon Romanovsky [not found] ` <20170621060528.3752-9-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> 2017-06-21 14:09 ` Steve Wise 2017-06-21 14:09 ` Steve Wise 2017-06-21 15:00 ` Leon Romanovsky 2017-06-21 16:07 ` Jason Gunthorpe [not found] ` <20170621160748.GA10200-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org> 2017-06-22 5:31 ` Leon Romanovsky 2017-06-21 6:05 ` [PATCH rdma-next 10/19] RDMA/netlink: Reduce indirection access to cb_table Leon Romanovsky [not found] ` <20170621060528.3752-11-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> 2017-06-21 14:13 ` Steve Wise 2017-06-21 14:13 ` Steve Wise 2017-06-21 6:05 ` [PATCH rdma-next 11/19] RDMA/netlink: Convert LS to doit callback Leon Romanovsky [not found] ` <20170621060528.3752-12-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> 2017-06-21 14:18 ` Steve Wise 2017-06-21 14:18 ` Steve Wise 2017-06-21 14:53 ` Leon Romanovsky 2017-06-21 15:25 ` Steve Wise [this message] 2017-06-21 15:25 ` Steve Wise 2017-06-21 6:05 ` [PATCH rdma-next 12/19] RDMA/netlink: Update copyright Leon Romanovsky 2017-06-21 14:18 ` Steve Wise 2017-06-21 14:18 ` Steve Wise [not found] ` <20170621060528.3752-1-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> 2017-06-21 6:05 ` [PATCH rdma-next 01/19] RDMA/netlink: Add flag to consolidate common handing Leon Romanovsky [not found] ` <20170621060528.3752-2-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> 2017-06-21 14:01 ` Steve Wise 2017-06-21 14:01 ` Steve Wise 2017-06-21 6:05 ` [PATCH rdma-next 04/19] RDMA/netlink: Rename and remove redundant parameter from ibnl_multicast Leon Romanovsky [not found] ` <20170621060528.3752-5-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> 2017-06-21 14:03 ` Steve Wise 2017-06-21 14:03 ` Steve Wise 2017-06-21 6:05 ` [PATCH rdma-next 06/19] RDMA/netlink: Rename netlink callback struct Leon Romanovsky 2017-06-21 14:04 ` Steve Wise 2017-06-21 14:04 ` Steve Wise 2017-06-21 6:05 ` [PATCH rdma-next 09/19] RDMA/netlink: Add and implement doit netlink callback Leon Romanovsky 2017-06-21 14:11 ` Steve Wise 2017-06-21 14:11 ` Steve Wise 2017-06-21 6:05 ` [PATCH rdma-next 13/19] RDMA/netlink: Add netlink device definitions to UAPI Leon Romanovsky 2017-06-21 14:21 ` Steve Wise 2017-06-21 14:21 ` Steve Wise 2017-06-21 16:11 ` Jason Gunthorpe [not found] ` <20170621161149.GB10200-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org> 2017-06-21 16:18 ` Tung, Chien Tin [not found] ` <748B799B6A00724488C603FD7E5E7EB976FA5C5C-XfjTATA9Em864kNsxIetb7fspsVTdybXVpNB7YpNyf8@public.gmane.org> 2017-06-22 4:28 ` Leon Romanovsky 2017-06-21 6:05 ` [PATCH rdma-next 14/19] RDMA/netlink: Add nldev initialization flows Leon Romanovsky [not found] ` <20170621060528.3752-15-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> 2017-06-21 14:22 ` Steve Wise 2017-06-21 14:22 ` Steve Wise 2017-06-21 6:05 ` [PATCH rdma-next 15/19] RDMA/netlink: Implement nldev device dumpit calback Leon Romanovsky 2017-06-21 14:25 ` Steve Wise 2017-06-21 14:25 ` Steve Wise 2017-06-21 6:05 ` [PATCH rdma-next 16/19] RDMa/netlink: Add nldev device doit implementation Leon Romanovsky [not found] ` <20170621060528.3752-17-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> 2017-06-21 14:26 ` Steve Wise 2017-06-21 14:26 ` Steve Wise 2017-06-21 6:05 ` [PATCH rdma-next 17/19] RDMA/netlink: Add nldev port dumpit implementation Leon Romanovsky [not found] ` <20170621060528.3752-18-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> 2017-06-21 14:28 ` Steve Wise 2017-06-21 14:28 ` Steve Wise 2017-06-21 14:42 ` Leon Romanovsky [not found] ` <20170621144211.GE1248-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org> 2017-06-21 15:21 ` Leon Romanovsky 2017-06-21 6:05 ` [PATCH rdma-next 18/19] RDMA/netlink: Implement nldev port doit callback Leon Romanovsky [not found] ` <20170621060528.3752-19-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> 2017-06-21 14:29 ` Steve Wise 2017-06-21 14:29 ` Steve Wise 2017-06-21 6:05 ` [PATCH rdma-next 19/19] RDMA/netlink: Expose device and port capability masks Leon Romanovsky [not found] ` <20170621060528.3752-20-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> 2017-06-21 14:31 ` Steve Wise 2017-06-21 14:31 ` Steve Wise
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='033201d2eaa2$96e55860$c4b00920$@opengridcomputing.com' \ --to=swise@opengridcomputing.com \ --cc=ariela@mellanox.com \ --cc=chien.tin.tung@intel.com \ --cc=dledford@redhat.com \ --cc=jiri@mellanox.com \ --cc=leon@kernel.org \ --cc=linux-rdma@vger.kernel.org \ --cc=netdev@vger.kernel.org \ --cc=stephen@networkplumber.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.