* [PATCH] drm/ttm: fix missing parameter change for ttm_bo_cleanup_refs
@ 2018-01-19 6:42 Roger He
2018-01-19 8:49 ` Christian König
0 siblings, 1 reply; 2+ messages in thread
From: Roger He @ 2018-01-19 6:42 UTC (permalink / raw)
To: dri-devel; +Cc: Roger He, Christian.Koenig
Missed in the patche:
dc94777 drm/ttm: enable swapout for reserved BOs during allocation.
don't unreserve the BO if it is not reserved by itself.
Signed-off-by: Roger He <Hongbo.He@amd.com>
---
drivers/gpu/drm/ttm/ttm_bo.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c
index 893003f..2fef09a 100644
--- a/drivers/gpu/drm/ttm/ttm_bo.c
+++ b/drivers/gpu/drm/ttm/ttm_bo.c
@@ -1727,7 +1727,7 @@ int ttm_bo_swapout(struct ttm_bo_global *glob, struct ttm_operation_ctx *ctx)
kref_get(&bo->list_kref);
if (!list_empty(&bo->ddestroy)) {
- ret = ttm_bo_cleanup_refs(bo, false, false, true);
+ ret = ttm_bo_cleanup_refs(bo, false, false, locked);
kref_put(&bo->list_kref, ttm_bo_release_list);
return ret;
}
--
2.7.4
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/ttm: fix missing parameter change for ttm_bo_cleanup_refs
2018-01-19 6:42 [PATCH] drm/ttm: fix missing parameter change for ttm_bo_cleanup_refs Roger He
@ 2018-01-19 8:49 ` Christian König
0 siblings, 0 replies; 2+ messages in thread
From: Christian König @ 2018-01-19 8:49 UTC (permalink / raw)
To: Roger He, dri-devel
Am 19.01.2018 um 07:42 schrieb Roger He:
> Missed in the patche:
> dc94777 drm/ttm: enable swapout for reserved BOs during allocation.
> don't unreserve the BO if it is not reserved by itself.
>
> Signed-off-by: Roger He <Hongbo.He@amd.com>
Reviewed-by: Christian König <christian.koenig@amd.com>.
I already wondered if we shouldn't use "locked" somewhere else as well,
Christian.
> ---
> drivers/gpu/drm/ttm/ttm_bo.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c
> index 893003f..2fef09a 100644
> --- a/drivers/gpu/drm/ttm/ttm_bo.c
> +++ b/drivers/gpu/drm/ttm/ttm_bo.c
> @@ -1727,7 +1727,7 @@ int ttm_bo_swapout(struct ttm_bo_global *glob, struct ttm_operation_ctx *ctx)
> kref_get(&bo->list_kref);
>
> if (!list_empty(&bo->ddestroy)) {
> - ret = ttm_bo_cleanup_refs(bo, false, false, true);
> + ret = ttm_bo_cleanup_refs(bo, false, false, locked);
> kref_put(&bo->list_kref, ttm_bo_release_list);
> return ret;
> }
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-01-19 8:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-19 6:42 [PATCH] drm/ttm: fix missing parameter change for ttm_bo_cleanup_refs Roger He
2018-01-19 8:49 ` Christian König
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.