From: Krzysztof Kozlowski <krzk@kernel.org>
To: Sakari Ailus <sakari.ailus@linux.intel.com>, linux-media@vger.kernel.org
Cc: devicetree@vger.kernel.org, robh@kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: Convert Dongwoon dw9807-vcm bindings to json-schema
Date: Sun, 20 Mar 2022 12:56:48 +0100 [thread overview]
Message-ID: <035a1501-4a40-2f1a-2220-1a35a4419876@kernel.org> (raw)
In-Reply-To: <20220318165119.12191-2-sakari.ailus@linux.intel.com>
On 18/03/2022 17:51, Sakari Ailus wrote:
> Convert the old text based dw9807-vcm chip DT bindings to json-schema.
>
> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> ---
> .../media/i2c/dongwoon,dw9807-vcm.txt | 9 ----
> .../media/i2c/dongwoon,dw9807-vcm.yaml | 43 +++++++++++++++++++
> 2 files changed, 43 insertions(+), 9 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/media/i2c/dongwoon,dw9807-vcm.txt
> create mode 100644 Documentation/devicetree/bindings/media/i2c/dongwoon,dw9807-vcm.yaml
>
> diff --git a/Documentation/devicetree/bindings/media/i2c/dongwoon,dw9807-vcm.txt b/Documentation/devicetree/bindings/media/i2c/dongwoon,dw9807-vcm.txt
> deleted file mode 100644
> index c4701f1eaaf63..0000000000000
> --- a/Documentation/devicetree/bindings/media/i2c/dongwoon,dw9807-vcm.txt
> +++ /dev/null
> @@ -1,9 +0,0 @@
> -Dongwoon Anatech DW9807 voice coil lens driver
> -
> -DW9807 is a 10-bit DAC with current sink capability. It is intended for
> -controlling voice coil lenses.
> -
> -Mandatory properties:
> -
> -- compatible: "dongwoon,dw9807-vcm"
> -- reg: I2C slave address
> diff --git a/Documentation/devicetree/bindings/media/i2c/dongwoon,dw9807-vcm.yaml b/Documentation/devicetree/bindings/media/i2c/dongwoon,dw9807-vcm.yaml
> new file mode 100644
> index 0000000000000..0cf153ed547fe
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/i2c/dongwoon,dw9807-vcm.yaml
> @@ -0,0 +1,43 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +# Copyright (C) 2018, 2021 Intel Corporation
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/media/i2c/dongwoon,dw9807-vcm.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Dongwoon Anatech DW9807 voice coil lens driver
> +
> +maintainers:
> + - Sakari Ailus <sakari.ailus@linux.intel.com>
> +
> +description: |
> + DW9807 is a 10-bit DAC with current sink capability. It is intended for
> + controlling voice coil lenses.
> +
> +properties:
> +
No blank line.
> + compatible:
> + const: "dongwoon,dw9807-vcm"
No quotes.
> +
> + reg:
> + maxItems: 1
> +
> +required:
> + - compatible
> + - reg
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> +
No blank line.
With the changes above:
Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-03-20 11:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-18 16:51 [PATCH 0/2] dw9807 binding and driver compatible changes Sakari Ailus
2022-03-18 16:51 ` [PATCH 1/2] dt-bindings: Convert Dongwoon dw9807-vcm bindings to json-schema Sakari Ailus
2022-03-20 11:56 ` Krzysztof Kozlowski [this message]
2022-03-23 14:54 ` Sakari Ailus
2022-03-23 14:55 ` Krzysztof Kozlowski
2022-03-23 15:35 ` Sakari Ailus
2022-03-18 16:51 ` [PATCH 2/2] dw9807-vcm: Add "dongwoon,dw9807" compatible string Sakari Ailus
2022-03-20 11:58 ` Krzysztof Kozlowski
2022-03-23 14:50 ` Sakari Ailus
2022-03-23 14:59 ` Krzysztof Kozlowski
2022-03-23 15:33 ` Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=035a1501-4a40-2f1a-2220-1a35a4419876@kernel.org \
--to=krzk@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.