From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org, robh@kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: Convert Dongwoon dw9807-vcm bindings to json-schema
Date: Wed, 23 Mar 2022 17:35:25 +0200 [thread overview]
Message-ID: <Yjs+PUKLqJI05NfP@paasikivi.fi.intel.com> (raw)
In-Reply-To: <eac26181-3e59-f915-e310-4b1679b416cd@kernel.org>
On Wed, Mar 23, 2022 at 03:55:50PM +0100, Krzysztof Kozlowski wrote:
> On 23/03/2022 15:54, Sakari Ailus wrote:
> > Hi Krzysztof,
> >
> > On Sun, Mar 20, 2022 at 12:56:48PM +0100, Krzysztof Kozlowski wrote:
> >> On 18/03/2022 17:51, Sakari Ailus wrote:
> >>> +$id: http://devicetree.org/schemas/media/i2c/dongwoon,dw9807-vcm.yaml#
> >>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> >>> +
> >>> +title: Dongwoon Anatech DW9807 voice coil lens driver
> >>> +
> >>> +maintainers:
> >>> + - Sakari Ailus <sakari.ailus@linux.intel.com>
> >>> +
> >>> +description: |
> >>> + DW9807 is a 10-bit DAC with current sink capability. It is intended for
> >>> + controlling voice coil lenses.
> >>> +
> >>> +properties:
> >>> +
> >>
> >> No blank line.
> >>
> >>> + compatible:
> >>> + const: "dongwoon,dw9807-vcm"
> >>
> >> No quotes.
> >
> > Hmm. Strings generally need to be quoted, including the compatible
> > strings.
>
> No, not in dtschema. Almost none of strings are ever quoted. If you need
> reference - you example-schema.yaml.
Good point. I suppose it's because YAML doesn't require that.
I'll drop the quotes in v2.
--
Sakari Ailus
next prev parent reply other threads:[~2022-03-23 15:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-18 16:51 [PATCH 0/2] dw9807 binding and driver compatible changes Sakari Ailus
2022-03-18 16:51 ` [PATCH 1/2] dt-bindings: Convert Dongwoon dw9807-vcm bindings to json-schema Sakari Ailus
2022-03-20 11:56 ` Krzysztof Kozlowski
2022-03-23 14:54 ` Sakari Ailus
2022-03-23 14:55 ` Krzysztof Kozlowski
2022-03-23 15:35 ` Sakari Ailus [this message]
2022-03-18 16:51 ` [PATCH 2/2] dw9807-vcm: Add "dongwoon,dw9807" compatible string Sakari Ailus
2022-03-20 11:58 ` Krzysztof Kozlowski
2022-03-23 14:50 ` Sakari Ailus
2022-03-23 14:59 ` Krzysztof Kozlowski
2022-03-23 15:33 ` Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yjs+PUKLqJI05NfP@paasikivi.fi.intel.com \
--to=sakari.ailus@linux.intel.com \
--cc=devicetree@vger.kernel.org \
--cc=krzk@kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.