[Buildroot] [PATCH] package/python-cryptography: needs cargo env when downloading

[Buildroot] [PATCH] package/python-cryptography: needs cargo env when downloading

[Yann E. MORIN]

python-cryptography is a python package, but it internally builds a rust
crate. As such, it needs to be vendored at install time.

Currently, we only pass the path to the sub-directory where the rust
source is in the package tree, but calling cargo needs additional
variables, most notably it needs CARGO_HOME to be set in the
environment, otherwise it ends up writing in the user's own cargo home,
which is by default ~/.cargo/

We do not really know what variables are used at vendor tie, so we pass
the full Cargo environment, that we pass when building target packages.

Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Cc: Yegor Yefremov <yegorslists@googlemail.com>
Cc: Asaf Kahlon <asafka7@gmail.com>
---
 package/python-cryptography/python-cryptography.mk | 1 +
 1 file changed, 1 insertion(+)

diff --git a/package/python-cryptography/python-cryptography.mk b/package/python-cryptography/python-cryptography.mk
index e642691bc5..a524f729c8 100644
--- a/package/python-cryptography/python-cryptography.mk
+++ b/package/python-cryptography/python-cryptography.mk
@@ -24,6 +24,7 @@ PYTHON_CRYPTOGRAPHY_ENV = \
 PYTHON_CRYPTOGRAPHY_DOWNLOAD_POST_PROCESS = cargo
 PYTHON_CRYPTOGRAPHY_DOWNLOAD_DEPENDENCIES = host-rustc
 PYTHON_CRYPTOGRAPHY_DL_ENV = \
+	$(PKG_CARGO_ENV) \
 	BR_CARGO_MANIFEST_PATH=src/rust/Cargo.toml
 
 $(eval $(python-package))
-- 
2.25.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] package/python-cryptography: needs cargo env when downloading

[Arnout Vandecappelle]

On 14/02/2022 11:28, Yann E. MORIN wrote:
> python-cryptography is a python package, but it internally builds a rust
> crate. As such, it needs to be vendored at install time.
> 
> Currently, we only pass the path to the sub-directory where the rust
> source is in the package tree, but calling cargo needs additional
> variables, most notably it needs CARGO_HOME to be set in the
> environment, otherwise it ends up writing in the user's own cargo home,
> which is by default ~/.cargo/
> 
> We do not really know what variables are used at vendor tie, so we pass
> the full Cargo environment, that we pass when building target packages.
> 
> Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
> Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
> Cc: Yegor Yefremov <yegorslists@googlemail.com>
> Cc: Asaf Kahlon <asafka7@gmail.com>

  Applied to master, thanks.

  Regards,
  Arnout

> ---
>   package/python-cryptography/python-cryptography.mk | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/package/python-cryptography/python-cryptography.mk b/package/python-cryptography/python-cryptography.mk
> index e642691bc5..a524f729c8 100644
> --- a/package/python-cryptography/python-cryptography.mk
> +++ b/package/python-cryptography/python-cryptography.mk
> @@ -24,6 +24,7 @@ PYTHON_CRYPTOGRAPHY_ENV = \
>   PYTHON_CRYPTOGRAPHY_DOWNLOAD_POST_PROCESS = cargo
>   PYTHON_CRYPTOGRAPHY_DOWNLOAD_DEPENDENCIES = host-rustc
>   PYTHON_CRYPTOGRAPHY_DL_ENV = \
> +	$(PKG_CARGO_ENV) \
>   	BR_CARGO_MANIFEST_PATH=src/rust/Cargo.toml
>   
>   $(eval $(python-package))
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot