[PATCH 0/3] Add dt support for exynos hdmiphy settings

[PATCH 0/3] Add dt support for exynos hdmiphy settings

[Shirish S]

For various revisions of a chipset if the signal pattern is changed for every
revision, then the phy setting need to be updated correspondingly by measuring
the signal.
For getting correct signals the clock level and data de-emphasis 
levels needs to be adjusted.
Since only these 2 values matter,we can move the same to dt, 
wherein we can have different dt files for every revision. 

This is an initial patchset towards achieving the same 
for exynos 5250 and can be later extended to future chipsets.

V2: replaced moving of entire phy config structure with only
required and justifiable conf registers.

V3: Incorporated Mark Rutland's comments.

Shirish S (3):
  ARM: dts: smdk5250: Add hdmi phy settings
  ARM: dts: arndale: Add hdmi phy settings
  drm: exynos: hdmi: Add dt support for hdmiphy settings

 .../devicetree/bindings/video/exynos_hdmi.txt      |   32 +++++++++
 arch/arm/boot/dts/exynos5250-arndale.dts           |   68 ++++++++++++++++++
 arch/arm/boot/dts/exynos5250-smdk5250.dts          |   68 ++++++++++++++++++
 drivers/gpu/drm/exynos/exynos_hdmi.c               |   76 ++++++++++++++++++--
 4 files changed, 240 insertions(+), 4 deletions(-)

-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 1/3] ARM: dts: smdk5250: Add hdmi phy settings

[Shirish S]

This patch moves the hdmi phy setting to smdk5250
dts,as its more of a per board configuration and
also shall be easier for supporting future chipsets.

Signed-off-by: Shirish S <s.shirish-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
---
 arch/arm/boot/dts/exynos5250-smdk5250.dts |   68 +++++++++++++++++++++++++++++
 1 file changed, 68 insertions(+)

diff --git a/arch/arm/boot/dts/exynos5250-smdk5250.dts b/arch/arm/boot/dts/exynos5250-smdk5250.dts
index 49f18c2..0795e23 100644
--- a/arch/arm/boot/dts/exynos5250-smdk5250.dts
+++ b/arch/arm/boot/dts/exynos5250-smdk5250.dts
@@ -220,6 +220,74 @@
 
 	hdmi {
 		hpd-gpio = <&gpx3 7 0>;
+		hdmiphy-configs {
+			nr-configs = <13>;
+			config0: config0 {
+				pixel-clock = <25200000>;
+				config-de-emphasis-level =  /bits/ 8 <0x26>;
+				config-clock-level =  /bits/ 8 < 0x66>;
+			};
+			config1: config1 {
+				pixel-clock = <27000000>;
+				config-de-emphasis-level =  /bits/ 8 <0x26>;
+				config-clock-level =  /bits/ 8 < 0x66>;
+			};
+			config2: config2 {
+				pixel-clock = <27027000>;
+				config-de-emphasis-level =  /bits/ 8 <0x26>;
+				config-clock-level =  /bits/ 8 < 0x66>;
+			};
+			config3: config3 {
+				pixel-clock = <36000000>;
+				config-de-emphasis-level =  /bits/ 8 <0x26>;
+				config-clock-level =  /bits/ 8 < 0x66>;
+			};
+			config4: config4 {
+				pixel-clock = <40000000>;
+				config-de-emphasis-level =  /bits/ 8 <0x26>;
+				config-clock-level =  /bits/ 8 < 0x66>;
+			};
+			config5: config5 {
+				pixel-clock = <65000000>;
+				config-de-emphasis-level =  /bits/ 8 <0x26>;
+				config-clock-level =  /bits/ 8 < 0x66>;
+			};
+			config6: config6 {
+				pixel-clock = <74176000>;
+				config-de-emphasis-level =  /bits/ 8 <0x26>;
+				config-clock-level =  /bits/ 8 < 0x66>;
+			};
+			config7: config7 {
+				pixel-clock = <74250000>;
+				config-de-emphasis-level =  /bits/ 8 <0x26>;
+				config-clock-level =  /bits/ 8 < 0x66>;
+			};
+			config8: config8 {
+				pixel-clock = <83500000>;
+				config-de-emphasis-level =  /bits/ 8 <0x26>;
+				config-clock-level =  /bits/ 8 < 0x66>;
+			};
+			config9: config9 {
+				pixel-clock = <106500000>;
+				config-de-emphasis-level =  /bits/ 8 <0x26>;
+				config-clock-level =  /bits/ 8 < 0x66>;
+			};
+			config10: config10 {
+				pixel-clock = <108000000>;
+				config-de-emphasis-level =  /bits/ 8 <0x26>;
+				config-clock-level =  /bits/ 8 < 0x66>;
+			};
+			config11: config11 {
+				pixel-clock = <146250000>;
+				config-de-emphasis-level =  /bits/ 8 <0x26>;
+				config-clock-level =  /bits/ 8 < 0x66>;
+			};
+			config12: config12 {
+				pixel-clock = <148500000>;
+				config-de-emphasis-level =  /bits/ 8 <0x26>;
+				config-clock-level =  /bits/ 8 < 0x66>;
+			};
+		};
 	};
 
 	codec@11000000 {
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 2/3] ARM: dts: arndale: Add hdmi phy settings

[Shirish S]

This patch moves the hdmi phy setting to arndale dts,
as its more of a per board configuration and also
shall be easier for supporting future chipsets.

Signed-off-by: Shirish S <s.shirish-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
---
 arch/arm/boot/dts/exynos5250-arndale.dts |   68 ++++++++++++++++++++++++++++++
 1 file changed, 68 insertions(+)

diff --git a/arch/arm/boot/dts/exynos5250-arndale.dts b/arch/arm/boot/dts/exynos5250-arndale.dts
index abc7272..3b33704 100644
--- a/arch/arm/boot/dts/exynos5250-arndale.dts
+++ b/arch/arm/boot/dts/exynos5250-arndale.dts
@@ -427,6 +427,74 @@
 		vdd_osc-supply = <&ldo10_reg>;
 		vdd_pll-supply = <&ldo8_reg>;
 		vdd-supply = <&ldo8_reg>;
+		hdmiphy-configs {
+			nr-configs = <13>;
+			config0: config0 {
+				pixel-clock = <25200000>;
+				config-de-emphasis-level =  /bits/ 8 <0x26>;
+				config-clock-level =  /bits/ 8 < 0x66>;
+			};
+			config1: config1 {
+				pixel-clock = <27000000>;
+				config-de-emphasis-level =  /bits/ 8 <0x26>;
+				config-clock-level =  /bits/ 8 < 0x66>;
+			};
+			config2: config2 {
+				pixel-clock = <27027000>;
+				config-de-emphasis-level =  /bits/ 8 <0x26>;
+				config-clock-level =  /bits/ 8 < 0x66>;
+			};
+			config3: config3 {
+				pixel-clock = <36000000>;
+				config-de-emphasis-level =  /bits/ 8 <0x26>;
+				config-clock-level =  /bits/ 8 < 0x66>;
+			};
+			config4: config4 {
+				pixel-clock = <40000000>;
+				config-de-emphasis-level =  /bits/ 8 <0x26>;
+				config-clock-level =  /bits/ 8 < 0x66>;
+			};
+			config5: config5 {
+				pixel-clock = <65000000>;
+				config-de-emphasis-level =  /bits/ 8 <0x26>;
+				config-clock-level =  /bits/ 8 < 0x66>;
+			};
+			config6: config6 {
+				pixel-clock = <74176000>;
+				config-de-emphasis-level =  /bits/ 8 <0x26>;
+				config-clock-level =  /bits/ 8 < 0x66>;
+			};
+			config7: config7 {
+				pixel-clock = <74250000>;
+				config-de-emphasis-level =  /bits/ 8 <0x26>;
+				config-clock-level =  /bits/ 8 < 0x66>;
+			};
+			config8: config8 {
+				pixel-clock = <83500000>;
+				config-de-emphasis-level =  /bits/ 8 <0x26>;
+				config-clock-level =  /bits/ 8 < 0x66>;
+			};
+			config9: config9 {
+				pixel-clock = <106500000>;
+				config-de-emphasis-level =  /bits/ 8 <0x26>;
+				config-clock-level =  /bits/ 8 < 0x66>;
+			};
+			config10: config10 {
+				pixel-clock = <108000000>;
+				config-de-emphasis-level =  /bits/ 8 <0x26>;
+				config-clock-level =  /bits/ 8 < 0x66>;
+			};
+			config11: config11 {
+				pixel-clock = <146250000>;
+				config-de-emphasis-level =  /bits/ 8 <0x26>;
+				config-clock-level =  /bits/ 8 < 0x66>;
+			};
+			config12: config12 {
+				pixel-clock = <148500000>;
+				config-de-emphasis-level =  /bits/ 8 <0x26>;
+				config-clock-level =  /bits/ 8 < 0x66>;
+			};
+		};
 	};
 
 	mmc_reg: voltage-regulator {
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 3/3] drm: exynos: hdmi: Add dt support for hdmiphy settings

[Shirish S]

This patch adds dt support to hdmiphy config settings
as it is board specific and depends on the signal pattern
of board.

Signed-off-by: Shirish S <s.shirish-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
---
 .../devicetree/bindings/video/exynos_hdmi.txt      |   32 +++++++++
 drivers/gpu/drm/exynos/exynos_hdmi.c               |   76 ++++++++++++++++++--
 2 files changed, 104 insertions(+), 4 deletions(-)

diff --git a/Documentation/devicetree/bindings/video/exynos_hdmi.txt b/Documentation/devicetree/bindings/video/exynos_hdmi.txt
index 323983b..c3b546a 100644
--- a/Documentation/devicetree/bindings/video/exynos_hdmi.txt
+++ b/Documentation/devicetree/bindings/video/exynos_hdmi.txt
@@ -13,6 +13,30 @@ Required properties:
 	b) pin number within the gpio controller.
 	c) optional flags and pull up/down.
 
+- hdmiphy-configs: following information about the hdmiphy config settings.
+        a) "nr-configs" specifies the number of pixel clocks supported.
+	b) "config<N>: config<N>" specifies the phy configuration settings,
+		wher 'N' denotes the number of iteration.
+		"pixel-clock" specifies the pixel clock
+		"conifig-de-emphasis-level" specifies the 8 bit configuration
+		of Data De-emphasis levels,below shown is example for
+		data de-emphasis register at address 0x145D0040.
+			0x145D0040 [3:0] permitted values:
+				0000 means 760 mVdiff && 1111 means 1400 mVdiff
+			0x145D0040 [7:4] permitted values:
+				0000 	0dB
+				0001	-0.25dB
+				0010	-0.7dB
+				0011	-1.15dB
+				1111	-7.45dB
+		"config-clock-level" specifies the 8 bit configuration for
+		the corresponding clock level, for example if 0x145D005C
+		is the address of clock level register.
+			0x145D005C [1:0] permitted values:
+				00 means 0 mVdiff && 11 means 60 mVdiff
+			0x145D005C [7:3] permitted values:
+				00000 is 790 mVdiff
+				11111 is 1430 mVdiff
 Example:
 
 	hdmi {
@@ -20,4 +44,12 @@ Example:
 		reg = <0x14530000 0x100000>;
 		interrupts = <0 95 0>;
 		hpd-gpio = <&gpx3 7 1>;
+		hdmiphy-configs {
+			nr-configs = <1>;
+			config0: config0 {
+				pixel-clock = <25200000>;
+				config-de-emphasis-level =  /bits/ 8 <0x26>;
+				config-clock-level =  /bits/ 8 < 0x66>;
+			};
+		}
 	};
diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c b/drivers/gpu/drm/exynos/exynos_hdmi.c
index a0e10ae..7b94a5d 100644
--- a/drivers/gpu/drm/exynos/exynos_hdmi.c
+++ b/drivers/gpu/drm/exynos/exynos_hdmi.c
@@ -200,6 +200,9 @@ struct hdmi_context {
 
 	struct hdmi_resources		res;
 
+	struct hdmiphy_config		*confs;
+	int				nr_confs;
+
 	int				hpd_gpio;
 
 	enum hdmi_type			type;
@@ -259,7 +262,7 @@ static const struct hdmiphy_config hdmiphy_v13_configs[] = {
 	},
 };
 
-static const struct hdmiphy_config hdmiphy_v14_configs[] = {
+static struct hdmiphy_config hdmiphy_v14_configs[] = {
 	{
 		.pixel_clock = 25200000,
 		.conf = {
@@ -778,8 +781,8 @@ static int hdmi_find_phy_conf(struct hdmi_context *hdata, u32 pixel_clock)
 		confs = hdmiphy_v13_configs;
 		count = ARRAY_SIZE(hdmiphy_v13_configs);
 	} else if (hdata->type == HDMI_TYPE14) {
-		confs = hdmiphy_v14_configs;
-		count = ARRAY_SIZE(hdmiphy_v14_configs);
+		confs = hdata->confs;
+		count = hdata->nr_confs;
 	} else
 		return -EINVAL;
 
@@ -1366,7 +1369,7 @@ static void hdmiphy_conf_apply(struct hdmi_context *hdata)
 	if (hdata->type == HDMI_TYPE13)
 		hdmiphy_data = hdmiphy_v13_configs[i].conf;
 	else
-		hdmiphy_data = hdmiphy_v14_configs[i].conf;
+		hdmiphy_data = hdata->confs[i].conf;
 
 	memcpy(buffer, hdmiphy_data, 32);
 	ret = i2c_master_send(hdata->hdmiphy_port, buffer, 32);
@@ -1858,6 +1861,62 @@ void hdmi_attach_hdmiphy_client(struct i2c_client *hdmiphy)
 		hdmi_hdmiphy = hdmiphy;
 }
 
+static int drm_hdmi_dt_parse_phy_conf(struct platform_device *pdev,
+						struct hdmi_context *hdata)
+{
+	struct device *dev = &pdev->dev;
+	struct device_node *dev_np = dev->of_node;
+	struct device_node *phy_conf, *cfg_np;
+	int i = 0;
+
+	/* Initialize with default config */
+	hdata->confs = hdmiphy_v14_configs;
+
+	phy_conf = of_find_node_by_name(dev_np, "hdmiphy-configs");
+	if (phy_conf == NULL) {
+		DRM_ERROR("Did not find hdmiphy-configs node\n");
+		return -ENODEV;
+	}
+
+	if (of_property_read_u32(phy_conf, "nr-configs", &hdata->nr_confs)) {
+		DRM_ERROR("Failed to get the number of configurations");
+		return -EINVAL;
+	}
+
+	if (hdata->nr_confs < ARRAY_SIZE(hdmiphy_v14_configs)) {
+		DRM_ERROR("mismatch in the number of configs\n");
+		return -EINVAL;
+	}
+
+	for_each_child_of_node(phy_conf, cfg_np) {
+		if (!of_find_property(cfg_np, "pixel-clock", NULL))
+			continue;
+
+		if (of_property_read_u32_array(cfg_np, "pixel-clock",
+					&hdata->confs[i].pixel_clock, 1)) {
+				DRM_ERROR("Failed to get pixel clock\n");
+				return -EINVAL;
+		}
+
+		/* Overwrite the data de-emphasis and data level */
+		if (of_property_read_u8_array(cfg_np,
+			 "config-de-emphasis-level",
+					 &hdata->confs[i].conf[16], 1)) {
+				DRM_ERROR("Failed to get conf\n");
+				return -EINVAL;
+		}
+		/* Overwrite the clock level diff */
+		if (of_property_read_u8_array(cfg_np, "config-clock-level",
+					&hdata->confs[i].conf[23], 1)) {
+				DRM_ERROR("Failed to get conf\n");
+				return -EINVAL;
+		}
+		i++;
+	}
+	return 0;
+
+}
+
 static struct s5p_hdmi_platform_data *drm_hdmi_dt_parse_pdata
 					(struct device *dev)
 {
@@ -1986,6 +2045,15 @@ static int hdmi_probe(struct platform_device *pdev)
 		goto err_hdmiphy;
 	}
 
+	/* get hdmiphy confs */
+	if (hdata->type == HDMI_TYPE14) {
+		ret = drm_hdmi_dt_parse_phy_conf(pdev, hdata);
+		if (ret) {
+			DRM_ERROR("failed to get user defined config,will use
+			default configs, eye diagram tests may fail\n");
+		}
+	}
+
 	/* Attach HDMI Driver to common hdmi. */
 	exynos_hdmi_drv_attach(drm_hdmi_ctx);
 
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: [PATCH 0/3] Add dt support for exynos hdmiphy settings

[Inki Dae]

Hi Shirish,

I have merged the re-factoring patch set from Sean Paul to exynos-drm-next.
Can you re-base your patch set at top of exynos-drm-next?

Thanks,
Inki Dae

> -----Original Message-----
> From: Shirish S [mailto:s.shirish-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org]
> Sent: Monday, October 28, 2013 7:39 PM
> To: dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org; inki.dae-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org;
> devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> Cc: seanpaul-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org; sw0312.kim-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org; mark.rutland-5wv7dgnIgG8@public.gmane.org;
> shirish-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org; Shirish S
> Subject: [PATCH 0/3] Add dt support for exynos hdmiphy settings
> 
> For various revisions of a chipset if the signal pattern is changed for
> every
> revision, then the phy setting need to be updated correspondingly by
> measuring
> the signal.
> For getting correct signals the clock level and data de-emphasis
> levels needs to be adjusted.
> Since only these 2 values matter,we can move the same to dt,
> wherein we can have different dt files for every revision.
> 
> This is an initial patchset towards achieving the same
> for exynos 5250 and can be later extended to future chipsets.
> 
> V2: replaced moving of entire phy config structure with only
> required and justifiable conf registers.
> 
> V3: Incorporated Mark Rutland's comments.
> 
> Shirish S (3):
>   ARM: dts: smdk5250: Add hdmi phy settings
>   ARM: dts: arndale: Add hdmi phy settings
>   drm: exynos: hdmi: Add dt support for hdmiphy settings
> 
>  .../devicetree/bindings/video/exynos_hdmi.txt      |   32 +++++++++
>  arch/arm/boot/dts/exynos5250-arndale.dts           |   68
++++++++++++++++++
>  arch/arm/boot/dts/exynos5250-smdk5250.dts          |   68
++++++++++++++++++
>  drivers/gpu/drm/exynos/exynos_hdmi.c               |   76
++++++++++++++++++-
> -
>  4 files changed, 240 insertions(+), 4 deletions(-)
> 
> --
> 1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 0/3] Add dt support for exynos hdmiphy settings

[Shirish S]

[-- Attachment #1.1: Type: text/plain, Size: 1988 bytes --]

Ok, i shall rebase.


On Mon, Oct 28, 2013 at 7:32 PM, Inki Dae <inki.dae@samsung.com> wrote:

> Hi Shirish,
>
> I have merged the re-factoring patch set from Sean Paul to exynos-drm-next.
> Can you re-base your patch set at top of exynos-drm-next?
>
> Thanks,
> Inki Dae
>
> > -----Original Message-----
> > From: Shirish S [mailto:s.shirish@samsung.com]
> > Sent: Monday, October 28, 2013 7:39 PM
> > To: dri-devel@lists.freedesktop.org; inki.dae@samsung.com;
> > devicetree@vger.kernel.org
> > Cc: seanpaul@chromium.org; sw0312.kim@samsung.com; mark.rutland@arm.com;
> > shirish@chromium.org; Shirish S
> > Subject: [PATCH 0/3] Add dt support for exynos hdmiphy settings
> >
> > For various revisions of a chipset if the signal pattern is changed for
> > every
> > revision, then the phy setting need to be updated correspondingly by
> > measuring
> > the signal.
> > For getting correct signals the clock level and data de-emphasis
> > levels needs to be adjusted.
> > Since only these 2 values matter,we can move the same to dt,
> > wherein we can have different dt files for every revision.
> >
> > This is an initial patchset towards achieving the same
> > for exynos 5250 and can be later extended to future chipsets.
> >
> > V2: replaced moving of entire phy config structure with only
> > required and justifiable conf registers.
> >
> > V3: Incorporated Mark Rutland's comments.
> >
> > Shirish S (3):
> >   ARM: dts: smdk5250: Add hdmi phy settings
> >   ARM: dts: arndale: Add hdmi phy settings
> >   drm: exynos: hdmi: Add dt support for hdmiphy settings
> >
> >  .../devicetree/bindings/video/exynos_hdmi.txt      |   32 +++++++++
> >  arch/arm/boot/dts/exynos5250-arndale.dts           |   68
> ++++++++++++++++++
> >  arch/arm/boot/dts/exynos5250-smdk5250.dts          |   68
> ++++++++++++++++++
> >  drivers/gpu/drm/exynos/exynos_hdmi.c               |   76
> ++++++++++++++++++-
> > -
> >  4 files changed, 240 insertions(+), 4 deletions(-)
> >
> > --
> > 1.7.9.5
>
>

[-- Attachment #1.2: Type: text/html, Size: 2985 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH 0/3] Add dt support for exynos hdmiphy settings

[Shirish S]

For various revisions of a chipset if the signal pattern is changed for every
revision, then the phy setting need to be updated correspondingly by measuring
the signal.
For getting correct signals the clock level and data de-emphasis 
levels needs to be adjusted.
Since only these 2 values matter,we can move the same to dt, 
wherein we can have different dt files for every revision. 

This is an initial patchset towards achieving the same 
for exynos 5250 and can be later extended to future chipsets.

V2: replaced moving of entire phy config structure with only
required and justifiable conf registers.

Shirish S (3):
  ARM: dts: smdk5250: Add hdmi phy settings
  ARM: dts: arndale: Add hdmi phy settings
  drm: exynos: hdmi: Add dt support for hdmiphy settings

 .../devicetree/bindings/video/exynos_hdmi.txt      |   29 ++++++++
 arch/arm/boot/dts/exynos5250-arndale.dts           |   68 +++++++++++++++++++
 arch/arm/boot/dts/exynos5250-smdk5250.dts          |   68 +++++++++++++++++++
 drivers/gpu/drm/exynos/exynos_hdmi.c               |   70 ++++++++++++++++++--
 4 files changed, 231 insertions(+), 4 deletions(-)

-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 0/3] Add dt support for exynos hdmiphy settings

[Shirish S]

For various revision of chipset if the signal pattern is changed for every 
board, then the phy setting need to be updated correspondingly by measuring
the signal.
With the hdmiphy settings fixed in the driver the only way currently is to
either add a new structure or add compile time option.
To avoid this, we can move the same to dt, wherin we can have different dt
files for every revision. This patchset can be considered as an initiative
towards achieving the same for exynos 5250 and can be later extended to
future chipsets.
Also this patchset moves the entire structure to dt file as-is in the 
driver and hence we can find all the hex values, which are not logically
explained similar to driver.

Shirish S (3):
  ARM: dts: smdk5250: Add hdmi phy settings
  ARM: dts: arndale:  Add hdmi phy settings
  drm: exynos: hdmi: Add dt support for hdmiphy settings

 .../devicetree/bindings/video/exynos_hdmi.txt      |   18 +-
 arch/arm/boot/dts/exynos5250-arndale.dts           |  120 ++++++++++++
 arch/arm/boot/dts/exynos5250-smdk5250.dts          |  120 ++++++++++++
 drivers/gpu/drm/exynos/exynos_hdmi.c               |  191 +++++++-------------
 4 files changed, 320 insertions(+), 129 deletions(-)

-- 
1.7.10.4

Re: [PATCH 0/3] Add dt support for exynos hdmiphy settings

[Tomasz Figa]

Hi Shirish,

On Tuesday 13 of August 2013 12:39:27 Shirish S wrote:
> For various revision of chipset if the signal pattern is changed for
> every board, then the phy setting need to be updated correspondingly by
> measuring the signal.
> With the hdmiphy settings fixed in the driver the only way currently is
> to either add a new structure or add compile time option.
> To avoid this, we can move the same to dt, wherin we can have different
> dt files for every revision. This patchset can be considered as an
> initiative towards achieving the same for exynos 5250 and can be later
> extended to future chipsets.
> Also this patchset moves the entire structure to dt file as-is in the
> driver and hence we can find all the hex values, which are not logically
> explained similar to driver.
> 
> Shirish S (3):
>   ARM: dts: smdk5250: Add hdmi phy settings
>   ARM: dts: arndale:  Add hdmi phy settings
>   drm: exynos: hdmi: Add dt support for hdmiphy settings
> 
>  .../devicetree/bindings/video/exynos_hdmi.txt      |   18 +-
>  arch/arm/boot/dts/exynos5250-arndale.dts           |  120 ++++++++++++
>  arch/arm/boot/dts/exynos5250-smdk5250.dts          |  120 ++++++++++++
>  drivers/gpu/drm/exynos/exynos_hdmi.c               |  191
> +++++++------------- 4 files changed, 320 insertions(+), 129
> deletions(-)

Since this series is related to Exynos platform files, please also Cc the 
linux-samsung-soc mailing list and Kukjin Kim.

Same goes for device tree bindings. If you change anything related to 
device tree, you need to post your patches to devicetree@vger.kernel.org 
mailing list. Ccing device tree maintainers is also a good practice.

Please resend this series with above two issues addressed.

Best regards,
Tomasz

[PATCH 0/3] Add dt support for exynos hdmiphy settings

[Shirish S]

For various revision of chipset if the signal pattern is changed for every 
board, then the phy setting need to be updated correspondingly by measuring
the signal.
With the hdmiphy settings fixed in the driver the only way currently is to
either add a new structure or add compile time option.
To avoid this, we can move the same to dt, wherin we can have different dt
files for every revision. This patchset can be considered as an initiative
towards achieving the same for exynos 5250 and can be later extended to
future chipsets.
Also this patchset moves the entire structure to dt file as-is in the 
driver and hence we can find all the hex values, which are not logically
explained similar to driver.

Shirish S (3):
  ARM: dts: smdk5250: Add hdmi phy settings
  ARM: dts: arndale:  Add hdmi phy settings
  drm: exynos: hdmi: Add dt support for hdmiphy settings

 .../devicetree/bindings/video/exynos_hdmi.txt      |   18 +-
 arch/arm/boot/dts/exynos5250-arndale.dts           |  120 ++++++++++++
 arch/arm/boot/dts/exynos5250-smdk5250.dts          |  120 ++++++++++++
 drivers/gpu/drm/exynos/exynos_hdmi.c               |  191 +++++++-------------
 4 files changed, 320 insertions(+), 129 deletions(-)

-- 
1.7.10.4

[PATCH 0/3] Add dt support for exynos hdmiphy settings

[Shirish S]

For various revision of chipset if the signal pattern is changed for every 
board, then the phy setting need to be updated correspondingly by measuring
the signal.
With the hdmiphy settings fixed in the driver the only way currently is to
either add a new structure or add compile time option.
To avoid this, we can move the same to dt, wherin we can have different dt
files for every revision. This patchset can be considered as an initiative
towards achieving the same for exynos 5250 and can be later extended to
future chipsets.
Also this patchset moves the entire structure to dt file as-is in the 
driver and hence we can find all the hex values, which are not logically
explained similar to driver.

Shirish S (3):
  ARM: dts: smdk5250: Add hdmi phy settings
  ARM: dts: arndale:  Add hdmi phy settings
  drm: exynos: hdmi: Add dt support for hdmiphy settings

 .../devicetree/bindings/video/exynos_hdmi.txt      |   18 +-
 arch/arm/boot/dts/exynos5250-arndale.dts           |  120 ++++++++++++
 arch/arm/boot/dts/exynos5250-smdk5250.dts          |  120 ++++++++++++
 drivers/gpu/drm/exynos/exynos_hdmi.c               |  191 +++++++-------------
 4 files changed, 320 insertions(+), 129 deletions(-)

-- 
1.7.10.4