* [U-Boot] [PATCH 1/1] riscv: allow native compilation
@ 2018-08-06 17:15 Heinrich Schuchardt
[not found] ` <752D002CFF5D0F4FA35C0100F1D73F3F6BCAEA11@ATCPCS16.andestech.com>
0 siblings, 1 reply; 6+ messages in thread
From: Heinrich Schuchardt @ 2018-08-06 17:15 UTC (permalink / raw)
To: u-boot
If environment variable CROSS_COMPILE is not set, this indicates native
compilation. In this case we should not set an arbitrary value which is
not applicable for 64bit anyway.
Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
---
arch/riscv/config.mk | 4 ----
1 file changed, 4 deletions(-)
diff --git a/arch/riscv/config.mk b/arch/riscv/config.mk
index 219e66683d..f7a2ffbbc6 100644
--- a/arch/riscv/config.mk
+++ b/arch/riscv/config.mk
@@ -10,10 +10,6 @@
# Rick Chen, Andes Technology Corporation <rick@andestech.com>
#
-ifeq ($(CROSS_COMPILE),)
-CROSS_COMPILE := riscv32-unknown-linux-gnu-
-endif
-
32bit-emul := elf32lriscv
64bit-emul := elf64lriscv
--
2.18.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH 1/1] riscv: allow native compilation
[not found] ` <752D002CFF5D0F4FA35C0100F1D73F3F6BCAEA11@ATCPCS16.andestech.com>
@ 2018-08-07 8:57 ` Rick Chen
2018-09-23 20:06 ` Heinrich Schuchardt
0 siblings, 1 reply; 6+ messages in thread
From: Rick Chen @ 2018-08-07 8:57 UTC (permalink / raw)
To: u-boot
> If environment variable CROSS_COMPILE is not set, this indicates native
> compilation. In this case we should not set an arbitrary value which is not
> applicable for 64bit anyway.
>
OK !
Thanks for your correction.
B.R
Rick
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> ---
> arch/riscv/config.mk | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/arch/riscv/config.mk b/arch/riscv/config.mk index
> 219e66683d..f7a2ffbbc6 100644
> --- a/arch/riscv/config.mk
> +++ b/arch/riscv/config.mk
> @@ -10,10 +10,6 @@
> # Rick Chen, Andes Technology Corporation <rick@andestech.com> #
>
> -ifeq ($(CROSS_COMPILE),)
> -CROSS_COMPILE := riscv32-unknown-linux-gnu- -endif
> -
> 32bit-emul := elf32lriscv
> 64bit-emul := elf64lriscv
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH 1/1] riscv: allow native compilation
2018-08-07 8:57 ` Rick Chen
@ 2018-09-23 20:06 ` Heinrich Schuchardt
2018-10-03 1:16 ` Rick Chen
0 siblings, 1 reply; 6+ messages in thread
From: Heinrich Schuchardt @ 2018-09-23 20:06 UTC (permalink / raw)
To: u-boot
On 08/07/2018 10:57 AM, Rick Chen wrote:
>> If environment variable CROSS_COMPILE is not set, this indicates native
>> compilation. In this case we should not set an arbitrary value which is not
>> applicable for 64bit anyway.
>>
>
> OK !
> Thanks for your correction.
>
> B.R
>
> Rick
Somehow the patch never made it into git.denx.de/u-boot-riscv.git.
Could you, please, consider the patch for your next pull request.
Best regards
Heinrich
>
>> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
>> ---
>> arch/riscv/config.mk | 4 ----
>> 1 file changed, 4 deletions(-)
>>
>> diff --git a/arch/riscv/config.mk b/arch/riscv/config.mk index
>> 219e66683d..f7a2ffbbc6 100644
>> --- a/arch/riscv/config.mk
>> +++ b/arch/riscv/config.mk
>> @@ -10,10 +10,6 @@
>> # Rick Chen, Andes Technology Corporation <rick@andestech.com> #
>>
>> -ifeq ($(CROSS_COMPILE),)
>> -CROSS_COMPILE := riscv32-unknown-linux-gnu- -endif
>> -
>> 32bit-emul := elf32lriscv
>> 64bit-emul := elf64lriscv
>>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH 1/1] riscv: allow native compilation
2018-09-23 20:06 ` Heinrich Schuchardt
@ 2018-10-03 1:16 ` Rick Chen
2018-10-03 1:23 ` Tom Rini
0 siblings, 1 reply; 6+ messages in thread
From: Rick Chen @ 2018-10-03 1:16 UTC (permalink / raw)
To: u-boot
Heinrich Schuchardt <xypron.glpk@gmx.de> 於 2018年9月24日 週一 上午4:06寫道：
>
> On 08/07/2018 10:57 AM, Rick Chen wrote:
> >> If environment variable CROSS_COMPILE is not set, this indicates native
> >> compilation. In this case we should not set an arbitrary value which is not
> >> applicable for 64bit anyway.
> >>
> >
> > OK !
> > Thanks for your correction.
> >
> > B.R
> >
> > Rick
>
> Somehow the patch never made it into git.denx.de/u-boot-riscv.git.
>
> Could you, please, consider the patch for your next pull request.
>
Hi Heinrich
Sorry !
I was busy this period of time. And miss this time merge window.
I will merge it to git.denx.de/u-boot-riscv.git this week .
And try to send pull request to Tom.
Though I am not sure if it is legal to send pull request to Tom when
the merge window was closed.
Rick
> Best regards
>
> Heinrich
>
> >
> >> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> >> ---
> >> arch/riscv/config.mk | 4 ----
> >> 1 file changed, 4 deletions(-)
> >>
> >> diff --git a/arch/riscv/config.mk b/arch/riscv/config.mk index
> >> 219e66683d..f7a2ffbbc6 100644
> >> --- a/arch/riscv/config.mk
> >> +++ b/arch/riscv/config.mk
> >> @@ -10,10 +10,6 @@
> >> # Rick Chen, Andes Technology Corporation <rick@andestech.com> #
> >>
> >> -ifeq ($(CROSS_COMPILE),)
> >> -CROSS_COMPILE := riscv32-unknown-linux-gnu- -endif
> >> -
> >> 32bit-emul := elf32lriscv
> >> 64bit-emul := elf64lriscv
> >>
> >
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH 1/1] riscv: allow native compilation
2018-10-03 1:16 ` Rick Chen
@ 2018-10-03 1:23 ` Tom Rini
2018-10-03 1:51 ` Rick Chen
0 siblings, 1 reply; 6+ messages in thread
From: Tom Rini @ 2018-10-03 1:23 UTC (permalink / raw)
To: u-boot
On Wed, Oct 03, 2018 at 09:16:48AM +0800, Rick Chen wrote:
> Heinrich Schuchardt <xypron.glpk@gmx.de> 於 2018年9月24日 週一 上午4:06寫道：
> >
> > On 08/07/2018 10:57 AM, Rick Chen wrote:
> > >> If environment variable CROSS_COMPILE is not set, this indicates native
> > >> compilation. In this case we should not set an arbitrary value which is not
> > >> applicable for 64bit anyway.
> > >>
> > >
> > > OK !
> > > Thanks for your correction.
> > >
> > > B.R
> > >
> > > Rick
> >
> > Somehow the patch never made it into git.denx.de/u-boot-riscv.git.
> >
> > Could you, please, consider the patch for your next pull request.
> >
>
> Hi Heinrich
>
> Sorry !
> I was busy this period of time. And miss this time merge window.
>
> I will merge it to git.denx.de/u-boot-riscv.git this week .
> And try to send pull request to Tom.
> Though I am not sure if it is legal to send pull request to Tom when
> the merge window was closed.
With the window closed, yes, I want to see careful review taken by all
custodians. But that doesn't mean nothing can go in. This looks
reasonable to me, for example. Thanks!
>
> Rick
>
> > Best regards
> >
> > Heinrich
> >
> > >
> > >> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> > >> ---
> > >> arch/riscv/config.mk | 4 ----
> > >> 1 file changed, 4 deletions(-)
> > >>
> > >> diff --git a/arch/riscv/config.mk b/arch/riscv/config.mk index
> > >> 219e66683d..f7a2ffbbc6 100644
> > >> --- a/arch/riscv/config.mk
> > >> +++ b/arch/riscv/config.mk
> > >> @@ -10,10 +10,6 @@
> > >> # Rick Chen, Andes Technology Corporation <rick@andestech.com> #
> > >>
> > >> -ifeq ($(CROSS_COMPILE),)
> > >> -CROSS_COMPILE := riscv32-unknown-linux-gnu- -endif
> > >> -
> > >> 32bit-emul := elf32lriscv
> > >> 64bit-emul := elf64lriscv
> > >>
> > >
> >
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20181002/c3a32c6d/attachment.sig>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH 1/1] riscv: allow native compilation
2018-10-03 1:23 ` Tom Rini
@ 2018-10-03 1:51 ` Rick Chen
0 siblings, 0 replies; 6+ messages in thread
From: Rick Chen @ 2018-10-03 1:51 UTC (permalink / raw)
To: u-boot
Tom Rini <trini@konsulko.com> 於 2018年10月3日 週三 上午9:23寫道：
>
> On Wed, Oct 03, 2018 at 09:16:48AM +0800, Rick Chen wrote:
> > Heinrich Schuchardt <xypron.glpk@gmx.de> 於 2018年9月24日 週一 上午4:06寫道：
> > >
> > > On 08/07/2018 10:57 AM, Rick Chen wrote:
> > > >> If environment variable CROSS_COMPILE is not set, this indicates native
> > > >> compilation. In this case we should not set an arbitrary value which is not
> > > >> applicable for 64bit anyway.
> > > >>
> > > >
> > > > OK !
> > > > Thanks for your correction.
> > > >
> > > > B.R
> > > >
> > > > Rick
> > >
> > > Somehow the patch never made it into git.denx.de/u-boot-riscv.git.
> > >
> > > Could you, please, consider the patch for your next pull request.
> > >
> >
> > Hi Heinrich
> >
> > Sorry !
> > I was busy this period of time. And miss this time merge window.
> >
> > I will merge it to git.denx.de/u-boot-riscv.git this week .
> > And try to send pull request to Tom.
> > Though I am not sure if it is legal to send pull request to Tom when
> > the merge window was closed.
>
> With the window closed, yes, I want to see careful review taken by all
> custodians. But that doesn't mean nothing can go in. This looks
> reasonable to me, for example. Thanks!
Hi Tom
Got it.
And thanks for your reply and explain.
Rick
>
> >
> > Rick
> >
> > > Best regards
> > >
> > > Heinrich
> > >
> > > >
> > > >> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> > > >> ---
> > > >> arch/riscv/config.mk | 4 ----
> > > >> 1 file changed, 4 deletions(-)
> > > >>
> > > >> diff --git a/arch/riscv/config.mk b/arch/riscv/config.mk index
> > > >> 219e66683d..f7a2ffbbc6 100644
> > > >> --- a/arch/riscv/config.mk
> > > >> +++ b/arch/riscv/config.mk
> > > >> @@ -10,10 +10,6 @@
> > > >> # Rick Chen, Andes Technology Corporation <rick@andestech.com> #
> > > >>
> > > >> -ifeq ($(CROSS_COMPILE),)
> > > >> -CROSS_COMPILE := riscv32-unknown-linux-gnu- -endif
> > > >> -
> > > >> 32bit-emul := elf32lriscv
> > > >> 64bit-emul := elf64lriscv
> > > >>
> > > >
> > >
>
> --
> Tom
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-10-03 1:51 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-06 17:15 [U-Boot] [PATCH 1/1] riscv: allow native compilation Heinrich Schuchardt
[not found] ` <752D002CFF5D0F4FA35C0100F1D73F3F6BCAEA11@ATCPCS16.andestech.com>
2018-08-07 8:57 ` Rick Chen
2018-09-23 20:06 ` Heinrich Schuchardt
2018-10-03 1:16 ` Rick Chen
2018-10-03 1:23 ` Tom Rini
2018-10-03 1:51 ` Rick Chen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.