All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arek Burdach <arek.burdach@gmail.com>
To: Andrew Duggan <aduggan@synaptics.com>,
	Benjamin Tissoires <benjamin.tissoires@gmail.com>
Cc: "Stéphane Chatty" <chatty@enac.fr>,
	linux-input <linux-input@vger.kernel.org>
Subject: Re: Missing release event for Synaptics touchscreen
Date: Wed, 10 May 2017 11:36:46 +0200	[thread overview]
Message-ID: <03d13b14-1f97-eee7-4131-60ef014cbf50@gmail.com> (raw)
In-Reply-To: <dee48656-1993-b52d-5451-7a0cb186f18a@synaptics.com>

Hi Andrew,

On 10.05.2017 01:47, Andrew Duggan wrote:
> HI Arek,
>
> On 05/09/2017 04:17 PM, Arek Burdach wrote:
>> Hi,
>>
>> I've tried described by you solution:
>>
>> diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c
>> index 37084b645785..81f271554b6c 100644
>> --- a/drivers/hid/hid-core.c
>> +++ b/drivers/hid/hid-core.c
>> @@ -2510,6 +2510,7 @@ static const struct hid_device_id 
>> hid_ignore_list[] = {
>
> You need to add this to the hid_have_special_driver[] and not the 
> hid_ignore_list[].
Nice score for me - two lines and one bug :-)

> But, if you do success in binding hid-rmi to a touchscreen it won't 
> work. The firmware between touchpads and touchscreens are different 
> enough that the hid-rmi driver will be looking for data which does not 
> exist in touchscreen's HID report. These differences also mean that it 
> really isn't a good idea to try to support touchscreens with hid-rmi. 
> It would actually result in more transactions and be less efficient 
> then simply using hid-multitouch. That's why hid-core checks for the 
> HID_SCAN_FLAG_GD_POINTER in an attempt to make sure it's binding to a 
> touchpad and not a touchscreen.
It was just like you predict. On rmi, after first tap on screen, hidraw 
produced infinite number of events and it is not usable anymore.


>>
>> On 09.05.2017 16:02, Benjamin Tissoires wrote:
>>> On Tue, May 9, 2017 at 2:51 PM, Arek Burdach 
>>> <arek.burdach@gmail.com> wrote:
>>>> On 09.05.2017 14:20, Benjamin Tissoires wrote:
>>>>> On Tue, May 9, 2017 at 11:20 AM, Arek Burdach 
>>>>> <arek.burdach@gmail.com>
>>>>> wrote:
>>>>>> Hi,
>>>>>>
>>>>>> Thank you for response.
>>>>>>
>>>>>> On 09.05.2017 10:35, Benjamin Tissoires wrote:
>>>>>>> On Sat, May 6, 2017 at 9:28 PM, Arek Burdach 
>>>>>>> <arek.burdach@gmail.com>
>>>>>>> wrote:
>>>>>>>> Hi,
>>>>>>>>
>>>>>>>> A week ago I've reported a bug:
>>>>>>>> https://bugzilla.kernel.org/show_bug.cgi?id=195625 Is there 
>>>>>>>> anybody
>>>>>>>> that
>>>>>>>> can
>>>>>>>> help me with it?
>>>>>>> I can have a look at it.
>>>>>>> Please attach the full outputs of hid-recorder and evemu-record 
>>>>>>> in the
>>>>>>> bugs, or it'll be difficult for us to debug it.
>>>>>> I've attached full logs for two situations. More details in the 
>>>>>> issue.
>>>>> Thanks, looks like a firmware issue (I'll comment in the bug).
>>>> Sorry for my noob questions, but do you suggest that it can't be 
>>>> fixed by
>>>> changes in kernel modules and I need to report it to the manufacturer?
>>> Yes. Though Andrew, in CC, works for Synaptics and might give us 
>>> some pointers.
>>>
>>>> If it so, do you have an idea why it works well on Windows? Do they 
>>>> have
>>>> some strange hacks in their drivers?
>>> I have no ideas how well it works under Windows, and I have no ideas
>>> if there are some strange hacks in the Windows nor in the Syanptics
>>> driver (I would assume so).
>>>
>
> We don't provide any drivers for touchscreens on Windows. So I don't 
> know how Microsoft is handling a situation like this.
Do you know what should be changed in firmware to make hid-touchscreen 
driver works correctly? Or maybe you know someone who is responsible for 
firmware for this device and whom I can call to gather this information?

Cheers,
Arek

  reply	other threads:[~2017-05-10  9:36 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-06 19:28 Missing release event for Synaptics touchscreen Arek Burdach
2017-05-09  8:35 ` Benjamin Tissoires
2017-05-09  9:20   ` Arek Burdach
2017-05-09 12:20     ` Benjamin Tissoires
2017-05-09 12:51       ` Arek Burdach
2017-05-09 14:02         ` Benjamin Tissoires
2017-05-09 23:17           ` Arek Burdach
2017-05-09 23:47             ` Andrew Duggan
2017-05-10  9:36               ` Arek Burdach [this message]
2017-05-11  9:48                 ` Martin Kepplinger
2017-05-11 10:12                   ` Arek Burdach
2017-05-11 11:22                     ` Martin Kepplinger
2017-05-11 11:28                       ` Benjamin Tissoires
2017-05-11 11:44                         ` Arek Burdach
2017-05-11 11:47                         ` Martin Kepplinger
2017-05-11 12:28                           ` Benjamin Tissoires
2017-05-11 12:50                             ` Martin Kepplinger
2017-05-11 14:30                               ` Arek Burdach
2017-05-11 14:45                                 ` Benjamin Tissoires
2017-05-11 15:38                                   ` Arek Burdach
2017-05-12  6:56                                     ` Martin Kepplinger
2017-05-12  7:25                                       ` Arek Burdach
2017-05-12  7:34                                         ` Martin Kepplinger
2017-05-12  7:39                                         ` Benjamin Tissoires
2017-05-12  7:57                                           ` Arek Burdach
2017-05-12 14:23                                             ` Benjamin Tissoires
2017-05-12 14:28                                               ` Benjamin Tissoires
2017-05-12 17:50                                                 ` Arek Burdach
2017-05-15 18:49                                                 ` Arek Burdach
     [not found]                                                 ` <c0ba39eb-c8d5-2473-36d9-ce7c605ef845@gmail.com>
2017-05-16  8:18                                                   ` Benjamin Tissoires
2017-05-16  9:34                                                     ` Benjamin Tissoires
2017-05-16  9:46                                                     ` Arek Burdach
2017-06-07  7:27                                                       ` Arek Burdach
2017-06-07 13:12                                                         ` Benjamin Tissoires
2017-06-07 17:58                                                           ` Arek Burdach
2017-05-11 11:36                       ` Arek Burdach
2017-05-11 11:36                       ` Martin Kepplinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=03d13b14-1f97-eee7-4131-60ef014cbf50@gmail.com \
    --to=arek.burdach@gmail.com \
    --cc=aduggan@synaptics.com \
    --cc=benjamin.tissoires@gmail.com \
    --cc=chatty@enac.fr \
    --cc=linux-input@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.