All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kukjin Kim <kgene.kim@samsung.com>
To: 'Sachin Kamat' <sachin.kamat@samsung.com>,
	linux-arm-kernel@lists.infradead.org,
	Russell King <rmk+kernel@arm.linux.org.uk>
Cc: linux-samsung-soc@vger.kernel.org, linux@arm.linux.org.uk,
	arnd@arndb.de, spk.linux@gmail.com
Subject: RE: [PATCH 1/1] ARM: Kconfig.debug: Update Samsung UART config options
Date: Wed, 25 Jun 2014 20:41:13 +0900	[thread overview]
Message-ID: <03dd01cf906a$5e22b620$1a682260$@samsung.com> (raw)
In-Reply-To: <1403605171-31805-1-git-send-email-sachin.kamat@samsung.com>

Sachin Kamat wrote:
> 
+ Russell

> In a multiplatform config, the low level debug option shows several
> UART port entries. Improve the user visible string so that it becomes
> clear to the user about Samsung UART ports.
> While at it also remove some lines from the help text that are no
> longer applicable across all Samsung platforms.
> 
Looks good to me and will apply into cleanup.

Thanks,
Kukjin

> Signed-off-by: Sachin Kamat <sachin.kamat@samsung.com>
> ---
>  arch/arm/Kconfig.debug |   20 ++++----------------
>  1 file changed, 4 insertions(+), 16 deletions(-)
> 
> diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug
> index 3548612b0bfe..b92993e59a12 100644
> --- a/arch/arm/Kconfig.debug
> +++ b/arch/arm/Kconfig.debug
> @@ -617,53 +617,41 @@ choice
>  		depends on PLAT_SAMSUNG
>  		select DEBUG_EXYNOS_UART if ARCH_EXYNOS
>  		select DEBUG_S3C24XX_UART if ARCH_S3C24XX
> -		bool "Use S3C UART 0 for low-level debug"
> +		bool "Use Samsung S3C UART 0 for low-level debug"
>  		help
>  		  Say Y here if you want the debug print routines to direct
>  		  their output to UART 0. The port must have been initialised
>  		  by the boot-loader before use.
> 
> -		  The uncompressor code port configuration is now handled
> -		  by CONFIG_S3C_LOWLEVEL_UART_PORT.
> -
>  	config DEBUG_S3C_UART1
>  		depends on PLAT_SAMSUNG
>  		select DEBUG_EXYNOS_UART if ARCH_EXYNOS
>  		select DEBUG_S3C24XX_UART if ARCH_S3C24XX
> -		bool "Use S3C UART 1 for low-level debug"
> +		bool "Use Samsung S3C UART 1 for low-level debug"
>  		help
>  		  Say Y here if you want the debug print routines to direct
>  		  their output to UART 1. The port must have been initialised
>  		  by the boot-loader before use.
> 
> -		  The uncompressor code port configuration is now handled
> -		  by CONFIG_S3C_LOWLEVEL_UART_PORT.
> -
>  	config DEBUG_S3C_UART2
>  		depends on PLAT_SAMSUNG
>  		select DEBUG_EXYNOS_UART if ARCH_EXYNOS
>  		select DEBUG_S3C24XX_UART if ARCH_S3C24XX
> -		bool "Use S3C UART 2 for low-level debug"
> +		bool "Use Samsung S3C UART 2 for low-level debug"
>  		help
>  		  Say Y here if you want the debug print routines to direct
>  		  their output to UART 2. The port must have been initialised
>  		  by the boot-loader before use.
> 
> -		  The uncompressor code port configuration is now handled
> -		  by CONFIG_S3C_LOWLEVEL_UART_PORT.
> -
>  	config DEBUG_S3C_UART3
>  		depends on PLAT_SAMSUNG && ARCH_EXYNOS
>  		select DEBUG_EXYNOS_UART
> -		bool "Use S3C UART 3 for low-level debug"
> +		bool "Use Samsung S3C UART 3 for low-level debug"
>  		help
>  		  Say Y here if you want the debug print routines to direct
>  		  their output to UART 3. The port must have been initialised
>  		  by the boot-loader before use.
> 
> -		  The uncompressor code port configuration is now handled
> -		  by CONFIG_S3C_LOWLEVEL_UART_PORT.
> -
>  	config DEBUG_S3C2410_UART0
>  		depends on ARCH_S3C24XX
>  		select DEBUG_S3C2410_UART
> --
> 1.7.9.5

WARNING: multiple messages have this Message-ID (diff)
From: kgene.kim@samsung.com (Kukjin Kim)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/1] ARM: Kconfig.debug: Update Samsung UART config options
Date: Wed, 25 Jun 2014 20:41:13 +0900	[thread overview]
Message-ID: <03dd01cf906a$5e22b620$1a682260$@samsung.com> (raw)
In-Reply-To: <1403605171-31805-1-git-send-email-sachin.kamat@samsung.com>

Sachin Kamat wrote:
> 
+ Russell

> In a multiplatform config, the low level debug option shows several
> UART port entries. Improve the user visible string so that it becomes
> clear to the user about Samsung UART ports.
> While at it also remove some lines from the help text that are no
> longer applicable across all Samsung platforms.
> 
Looks good to me and will apply into cleanup.

Thanks,
Kukjin

> Signed-off-by: Sachin Kamat <sachin.kamat@samsung.com>
> ---
>  arch/arm/Kconfig.debug |   20 ++++----------------
>  1 file changed, 4 insertions(+), 16 deletions(-)
> 
> diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug
> index 3548612b0bfe..b92993e59a12 100644
> --- a/arch/arm/Kconfig.debug
> +++ b/arch/arm/Kconfig.debug
> @@ -617,53 +617,41 @@ choice
>  		depends on PLAT_SAMSUNG
>  		select DEBUG_EXYNOS_UART if ARCH_EXYNOS
>  		select DEBUG_S3C24XX_UART if ARCH_S3C24XX
> -		bool "Use S3C UART 0 for low-level debug"
> +		bool "Use Samsung S3C UART 0 for low-level debug"
>  		help
>  		  Say Y here if you want the debug print routines to direct
>  		  their output to UART 0. The port must have been initialised
>  		  by the boot-loader before use.
> 
> -		  The uncompressor code port configuration is now handled
> -		  by CONFIG_S3C_LOWLEVEL_UART_PORT.
> -
>  	config DEBUG_S3C_UART1
>  		depends on PLAT_SAMSUNG
>  		select DEBUG_EXYNOS_UART if ARCH_EXYNOS
>  		select DEBUG_S3C24XX_UART if ARCH_S3C24XX
> -		bool "Use S3C UART 1 for low-level debug"
> +		bool "Use Samsung S3C UART 1 for low-level debug"
>  		help
>  		  Say Y here if you want the debug print routines to direct
>  		  their output to UART 1. The port must have been initialised
>  		  by the boot-loader before use.
> 
> -		  The uncompressor code port configuration is now handled
> -		  by CONFIG_S3C_LOWLEVEL_UART_PORT.
> -
>  	config DEBUG_S3C_UART2
>  		depends on PLAT_SAMSUNG
>  		select DEBUG_EXYNOS_UART if ARCH_EXYNOS
>  		select DEBUG_S3C24XX_UART if ARCH_S3C24XX
> -		bool "Use S3C UART 2 for low-level debug"
> +		bool "Use Samsung S3C UART 2 for low-level debug"
>  		help
>  		  Say Y here if you want the debug print routines to direct
>  		  their output to UART 2. The port must have been initialised
>  		  by the boot-loader before use.
> 
> -		  The uncompressor code port configuration is now handled
> -		  by CONFIG_S3C_LOWLEVEL_UART_PORT.
> -
>  	config DEBUG_S3C_UART3
>  		depends on PLAT_SAMSUNG && ARCH_EXYNOS
>  		select DEBUG_EXYNOS_UART
> -		bool "Use S3C UART 3 for low-level debug"
> +		bool "Use Samsung S3C UART 3 for low-level debug"
>  		help
>  		  Say Y here if you want the debug print routines to direct
>  		  their output to UART 3. The port must have been initialised
>  		  by the boot-loader before use.
> 
> -		  The uncompressor code port configuration is now handled
> -		  by CONFIG_S3C_LOWLEVEL_UART_PORT.
> -
>  	config DEBUG_S3C2410_UART0
>  		depends on ARCH_S3C24XX
>  		select DEBUG_S3C2410_UART
> --
> 1.7.9.5

  reply	other threads:[~2014-06-25 11:41 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-24 10:19 [PATCH 1/1] ARM: Kconfig.debug: Update Samsung UART config options Sachin Kamat
2014-06-24 10:19 ` Sachin Kamat
2014-06-25 11:41 ` Kukjin Kim [this message]
2014-06-25 11:41   ` Kukjin Kim
2014-06-25 12:51   ` Russell King - ARM Linux
2014-06-25 12:51     ` Russell King - ARM Linux

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='03dd01cf906a$5e22b620$1a682260$@samsung.com' \
    --to=kgene.kim@samsung.com \
    --cc=arnd@arndb.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=rmk+kernel@arm.linux.org.uk \
    --cc=sachin.kamat@samsung.com \
    --cc=spk.linux@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.