[Fuego] [PATCH] synctest: fix default specification so it works in docker

[Fuego] [PATCH] synctest: fix default specification so it works in docker

[Daniel Sangorrin]

Also added it to testplan_docker

Signed-off-by: Daniel Sangorrin <daniel.sangorrin@toshiba.co.jp>
---
 engine/overlays/testplans/testplan_docker.json            | 3 +++
 engine/tests/Functional.synctest/Functional.synctest.spec | 2 +-
 2 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/engine/overlays/testplans/testplan_docker.json b/engine/overlays/testplans/testplan_docker.json
index d018fa7..99dc018 100644
--- a/engine/overlays/testplans/testplan_docker.json
+++ b/engine/overlays/testplans/testplan_docker.json
@@ -59,6 +59,9 @@
             "testName": "Functional.expat"
         },
         {
+            "testName": "Functional.synctest"
+        },
+        {
             "testName": "Functional.aiostress"
         },
         {
diff --git a/engine/tests/Functional.synctest/Functional.synctest.spec b/engine/tests/Functional.synctest/Functional.synctest.spec
index d7056e1..9180801 100644
--- a/engine/tests/Functional.synctest/Functional.synctest.spec
+++ b/engine/tests/Functional.synctest/Functional.synctest.spec
@@ -24,7 +24,7 @@
         "default": {
             "MOUNT_BLOCKDEV":"ROOT",
             "MOUNT_POINT":"$BOARD_TESTDIR/work",
-            "LEN":"10",
+            "LEN":"30",
             "LOOP":"10"
         }
     }
-- 
2.7.4

Re: [Fuego] [PATCH] synctest: fix default specification so it works in docker

[Bird, Timothy]

I have no problem with these, but they wouldn't apply since I didn't 
apply your testspec refactoring patch.  I'll wait until I see that one, and
then these should add OK.  Let me know if there will be a delay in
re-sending that one.  I don't want to have too many patches outstanding.
It's much easier if we keep our next branches in sync.

FYI, Here are the patches I skipped in your next branch:
   - skipped: 1467795 specs: put links in the spec and don't use the name key
     - I don't want lots of declarations with the same strings
   - skipped: adc9167 LTP: support separate phases for build and run
     - depends on conversion of specs from list to dict.
   - skipped: d95c571 fix expat test and add it to testplan docker
     - depends on conversion of specs from list to dict.
   - skipped: 0409ed1 synctest: fix default specification so it works in docker
     - depends on conversion of specs from list to dict.
   - skipped: c1304fb phases: rework phases execution order after the test is run
    - I'll comment on this one in that patch's e-mail.

 -- Tim

> -----Original Message-----
> From Daniel Sangorrin on Monday, April 24, 2017 5:43 PM
> Also added it to testplan_docker
> 
> Signed-off-by: Daniel Sangorrin <daniel.sangorrin@toshiba.co.jp>
> ---
>  engine/overlays/testplans/testplan_docker.json            | 3 +++
>  engine/tests/Functional.synctest/Functional.synctest.spec | 2 +-
>  2 files changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/engine/overlays/testplans/testplan_docker.json
> b/engine/overlays/testplans/testplan_docker.json
> index d018fa7..99dc018 100644
> --- a/engine/overlays/testplans/testplan_docker.json
> +++ b/engine/overlays/testplans/testplan_docker.json
> @@ -59,6 +59,9 @@
>              "testName": "Functional.expat"
>          },
>          {
> +            "testName": "Functional.synctest"
> +        },
> +        {
>              "testName": "Functional.aiostress"
>          },
>          {
> diff --git a/engine/tests/Functional.synctest/Functional.synctest.spec
> b/engine/tests/Functional.synctest/Functional.synctest.spec
> index d7056e1..9180801 100644
> --- a/engine/tests/Functional.synctest/Functional.synctest.spec
> +++ b/engine/tests/Functional.synctest/Functional.synctest.spec
> @@ -24,7 +24,7 @@
>          "default": {
>              "MOUNT_BLOCKDEV":"ROOT",
>              "MOUNT_POINT":"$BOARD_TESTDIR/work",
> -            "LEN":"10",
> +            "LEN":"30",
>              "LOOP":"10"
>          }
>      }
> --
> 2.7.4
> 
> 
> _______________________________________________
> Fuego mailing list
> Fuego@lists.linuxfoundation.org
> https://lists.linuxfoundation.org/mailman/listinfo/fuego

Re: [Fuego] [PATCH] synctest: fix default specification so it works in docker

[Daniel Sangorrin]

Hi Tim,

> -----Original Message-----
> From: Bird, Timothy [mailto:Tim.Bird@sony.com]
> Sent: Thursday, April 27, 2017 9:20 AM
> To: Daniel Sangorrin; fuego@lists.linuxfoundation.org
> Subject: RE: [Fuego] [PATCH] synctest: fix default specification so it works in docker
> 
> I have no problem with these, but they wouldn't apply since I didn't
> apply your testspec refactoring patch.  I'll wait until I see that one, and
> then these should add OK.  Let me know if there will be a delay in
> re-sending that one.  I don't want to have too many patches outstanding.
> It's much easier if we keep our next branches in sync.

yeah, we need to sync so that synctest works.
# such a bad joke XD

I will resend them today and hopefully we will be in sync by tomorrow. 
By the way, next week it's my turn to take a 1-week vacation. I'll think of you
guys while I relax in Japanese springs ;)

Thanks,
Daniel


> 
> FYI, Here are the patches I skipped in your next branch:
>    - skipped: 1467795 specs: put links in the spec and don't use the name key
>      - I don't want lots of declarations with the same strings
>    - skipped: adc9167 LTP: support separate phases for build and run
>      - depends on conversion of specs from list to dict.
>    - skipped: d95c571 fix expat test and add it to testplan docker
>      - depends on conversion of specs from list to dict.
>    - skipped: 0409ed1 synctest: fix default specification so it works in docker
>      - depends on conversion of specs from list to dict.
>    - skipped: c1304fb phases: rework phases execution order after the test is run
>     - I'll comment on this one in that patch's e-mail.

> 
>  -- Tim
> 
> > -----Original Message-----
> > From Daniel Sangorrin on Monday, April 24, 2017 5:43 PM
> > Also added it to testplan_docker
> >
> > Signed-off-by: Daniel Sangorrin <daniel.sangorrin@toshiba.co.jp>
> > ---
> >  engine/overlays/testplans/testplan_docker.json            | 3 +++
> >  engine/tests/Functional.synctest/Functional.synctest.spec | 2 +-
> >  2 files changed, 4 insertions(+), 1 deletion(-)
> >
> > diff --git a/engine/overlays/testplans/testplan_docker.json
> > b/engine/overlays/testplans/testplan_docker.json
> > index d018fa7..99dc018 100644
> > --- a/engine/overlays/testplans/testplan_docker.json
> > +++ b/engine/overlays/testplans/testplan_docker.json
> > @@ -59,6 +59,9 @@
> >              "testName": "Functional.expat"
> >          },
> >          {
> > +            "testName": "Functional.synctest"
> > +        },
> > +        {
> >              "testName": "Functional.aiostress"
> >          },
> >          {
> > diff --git a/engine/tests/Functional.synctest/Functional.synctest.spec
> > b/engine/tests/Functional.synctest/Functional.synctest.spec
> > index d7056e1..9180801 100644
> > --- a/engine/tests/Functional.synctest/Functional.synctest.spec
> > +++ b/engine/tests/Functional.synctest/Functional.synctest.spec
> > @@ -24,7 +24,7 @@
> >          "default": {
> >              "MOUNT_BLOCKDEV":"ROOT",
> >              "MOUNT_POINT":"$BOARD_TESTDIR/work",
> > -            "LEN":"10",
> > +            "LEN":"30",
> >              "LOOP":"10"
> >          }
> >      }
> > --
> > 2.7.4
> >
> >
> > _______________________________________________
> > Fuego mailing list
> > Fuego@lists.linuxfoundation.org
> > https://lists.linuxfoundation.org/mailman/listinfo/fuego

Re: [Fuego] [PATCH] synctest: fix default specification so it works in docker

[Bird, Timothy]

> -----Original Message-----
> From: Daniel Sangorrin on Wednesday, April 26, 2017 6:12 PM
> Hi Tim,
> 
> > -----Original Message-----
> > From: Bird, Timothy [mailto:Tim.Bird@sony.com]
> > Sent: Thursday, April 27, 2017 9:20 AM
> > To: Daniel Sangorrin; fuego@lists.linuxfoundation.org
> > Subject: RE: [Fuego] [PATCH] synctest: fix default specification so it works
> in docker
> >
> > I have no problem with these, but they wouldn't apply since I didn't
> > apply your testspec refactoring patch.  I'll wait until I see that one, and
> > then these should add OK.  Let me know if there will be a delay in
> > re-sending that one.  I don't want to have too many patches outstanding.
> > It's much easier if we keep our next branches in sync.
> 
> yeah, we need to sync so that synctest works.
> # such a bad joke XD
> 
> I will resend them today and hopefully we will be in sync by tomorrow.

BTW - I've pushed my local repos to bitbucket, so what I've integrated should
be up there if you want to rebase on that.   If not that's fine.  I think most of these
don't have conflicts with the other patches submitted.

> By the way, next week it's my turn to take a 1-week vacation. I'll think of you
> guys while I relax in Japanese springs ;)
Sounds good!  Have fun.  That's Golden Week, right?
 -- Tim