From: Jens Axboe <axboe@kernel.dk>
To: Christoph Hellwig <hch@infradead.org>, Jaegeuk Kim <jaegeuk@kernel.org>
Cc: linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] f2fs: provide a way to attach HIPRI for Direct IO
Date: Tue, 9 Nov 2021 09:42:18 -0700 [thread overview]
Message-ID: <042997ce-8382-40fe-4840-25f40a84c4bf@kernel.dk> (raw)
In-Reply-To: <YYqkWWZZsMW49/xu@infradead.org>
On 11/9/21 9:39 AM, Christoph Hellwig wrote:
> On Mon, Nov 08, 2021 at 06:13:36PM -0800, Jaegeuk Kim wrote:
>> This patch adds a way to attach HIPRI by expanding the existing sysfs's
>> data_io_flag. User can measure IO performance by enabling it.
>
> NAK. This flag should only be used when explicitly specified by
> the submitter of the I/O.
Yes, this cannot be set in the middle for a multitude of reasons. I wonder
if we should add a comment to that effect near the definition of it.
--
Jens Axboe
WARNING: multiple messages have this Message-ID (diff)
From: Jens Axboe <axboe@kernel.dk>
To: Christoph Hellwig <hch@infradead.org>, Jaegeuk Kim <jaegeuk@kernel.org>
Cc: linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH] f2fs: provide a way to attach HIPRI for Direct IO
Date: Tue, 9 Nov 2021 09:42:18 -0700 [thread overview]
Message-ID: <042997ce-8382-40fe-4840-25f40a84c4bf@kernel.dk> (raw)
In-Reply-To: <YYqkWWZZsMW49/xu@infradead.org>
On 11/9/21 9:39 AM, Christoph Hellwig wrote:
> On Mon, Nov 08, 2021 at 06:13:36PM -0800, Jaegeuk Kim wrote:
>> This patch adds a way to attach HIPRI by expanding the existing sysfs's
>> data_io_flag. User can measure IO performance by enabling it.
>
> NAK. This flag should only be used when explicitly specified by
> the submitter of the I/O.
Yes, this cannot be set in the middle for a multitude of reasons. I wonder
if we should add a comment to that effect near the definition of it.
--
Jens Axboe
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2021-11-09 16:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-09 2:13 [PATCH] f2fs: provide a way to attach HIPRI for Direct IO Jaegeuk Kim
2021-11-09 2:13 ` [f2fs-dev] " Jaegeuk Kim
2021-11-09 14:13 ` Chao Yu
2021-11-09 14:13 ` Chao Yu
2021-11-09 16:39 ` Christoph Hellwig
2021-11-09 16:39 ` [f2fs-dev] " Christoph Hellwig
2021-11-09 16:42 ` Jens Axboe [this message]
2021-11-09 16:42 ` Jens Axboe
2021-11-10 19:08 ` Jaegeuk Kim
2021-11-10 19:08 ` [f2fs-dev] " Jaegeuk Kim
2021-11-11 0:26 ` Jens Axboe
2021-11-11 0:26 ` [f2fs-dev] " Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=042997ce-8382-40fe-4840-25f40a84c4bf@kernel.dk \
--to=axboe@kernel.dk \
--cc=hch@infradead.org \
--cc=jaegeuk@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.